From 46d1e72720fa3fdce0c0f080ca5dcba6a3611b9c Mon Sep 17 00:00:00 2001 From: Mauro Ronchi Date: Mon, 19 Aug 2019 18:14:44 +0200 Subject: [PATCH] extract long expression into local variable --- .../package/compile/events/websockets/lib/deployment.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/plugins/aws/package/compile/events/websockets/lib/deployment.js b/lib/plugins/aws/package/compile/events/websockets/lib/deployment.js index 9e93c30e7..4af927e2c 100644 --- a/lib/plugins/aws/package/compile/events/websockets/lib/deployment.js +++ b/lib/plugins/aws/package/compile/events/websockets/lib/deployment.js @@ -13,7 +13,8 @@ module.exports = { this.serverless.instanceId ); - _.merge(this.serverless.service.provider.compiledCloudFormationTemplate.Resources, { + const resources = this.serverless.service.provider.compiledCloudFormationTemplate.Resources; + _.merge(resources, { [this.websocketsDeploymentLogicalId]: { Type: 'AWS::ApiGatewayV2::Deployment', DependsOn: routeLogicalIds, @@ -26,9 +27,7 @@ module.exports = { }); const { apiGateway } = this.serverless.service.provider; if (apiGateway && apiGateway.websocketApiId) { - this.serverless.service.provider.compiledCloudFormationTemplate.Resources[ - this.websocketsDeploymentLogicalId - ].Properties.StageName = this.provider.getStage(); + resources[this.websocketsDeploymentLogicalId].Properties.StageName = this.provider.getStage(); } _.merge(this.serverless.service.provider.compiledCloudFormationTemplate.Outputs, {