archive-gh-me/serverless
1
0
Fork 0
mirror of https://github.com/serverless/serverless.git synced 2026-01-25 15:07:39 +00:00
Code Issues Projects Releases Wiki Activity

Do not double-reject errors

Browse Source 
Calling .then here creates a new promise.  One that is not returned and generating a rejection within that promise can lead to unhandledRejection events being inappropriately raised.
As such, don't declare unneeded variables.
This commit is contained in:
Erik Erikson 2018-02-06 16:35:16 -08:00
parent 8f69678a88
commit 3606589ff2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/classes/Variables.js
View File

@ -36,9 +36,9 @@ class PromiseTracker {
const promise = prms;
promise.waitList = `${variable} waited on by: ${specifier}`;
promise.state = 'pending';
promise.then(
(value) => { promise.state = 'resolved'; return Promise.resolve(value); },
(error) => { promise.state = 'rejected'; return Promise.reject(error); });
promise.then( // creates a promise with the following effects but that we otherwise ignore
() => { promise.state = 'resolved'; },
() => { promise.state = 'rejected'; });
this.promiseList.push(promise);
this.promiseMap[variable] = promise;
return promise;
@ -393,7 +393,7 @@ class Variables {
].join('');
ret = BbPromise.reject(new this.serverless.classes.Error(errorMessage));
}
this.tracker.add(variableString, ret, propertyString);
ret = this.tracker.add(variableString, ret, propertyString);
}
return ret;
}