archive-gh-me/serverless
1
0
Fork 0
mirror of https://github.com/serverless/serverless.git synced 2026-01-25 15:07:39 +00:00
Code Issues Projects Releases Wiki Activity

fix(AWS HTTP API): Properly handle authorizer function with alias

Browse Source
This commit is contained in:
Piotr Grzesik 2021-08-16 13:11:57 +02:00
parent bb0484e6b5
commit 0ca6aaae52
2 changed files with 77 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/plugins/aws/package/compile/events/httpApi.js
View File

@ -294,8 +294,7 @@ class HttpApiEvents {
};
if (functionObject && functionObject.targetAlias) {
permissionResource.Properties.DependsOn =
this.provider.naming.getLambdaLogicalId(functionName);
permissionResource.DependsOn = functionObject.targetAlias.logicalId;
}
this.cfTemplate.Resources[authorizerPermissionLogicalId] = permissionResource;
}

76
test/unit/lib/plugins/aws/package/compile/events/httpApi.test.js
View File

@ -550,6 +550,82 @@ describe('lib/plugins/aws/package/compile/events/httpApi.test.js', () => {
expect(cfResources[authorizerPermissionLogicalId]).to.be.undefined;
});
it('should correctly set `DependsOn` property on permission resource for functions with provisioned concurrency', async () => {
const { awsNaming, cfTemplate } = await runServerless({
fixture: 'httpApi',
configExt: {
provider: {
httpApi: {
authorizers: {
someAuthorizer: {
type: 'request',
identitySource: '$request.header.Authorization',
functionName: 'other',
resultTtlInSeconds: 300,
enableSimpleResponses: true,
payloadVersion: '2.0',
},
},
},
},
functions: {
other: {
provisionedConcurrency: 1,
},
foo: {
events: [
{
httpApi: {
authorizer: {
name: 'someAuthorizer',
},
},
},
],
},
},
},
command: 'package',
});
const authorizerPermissionLogicalId =
awsNaming.getLambdaAuthorizerHttpApiPermissionLogicalId('someAuthorizer');
expect(cfTemplate.Resources[authorizerPermissionLogicalId]).to.deep.equal({
Type: 'AWS::Lambda::Permission',
Properties: {
FunctionName: {
'Fn::Join': [
':',
[
{
'Fn::GetAtt': ['OtherLambdaFunction', 'Arn'],
},
'provisioned',
],
],
},
Action: 'lambda:InvokeFunction',
Principal: 'apigateway.amazonaws.com',
SourceArn: {
'Fn::Join': [
'',
[
'arn:',
{ Ref: 'AWS::Partition' },
':execute-api:',
{ Ref: 'AWS::Region' },
':',
{ Ref: 'AWS::AccountId' },
':',
{ Ref: naming.getHttpApiLogicalId() },
'/*',
],
],
},
},
DependsOn: 'OtherProvConcLambdaAlias',
});
});
it('should throw when request authorizer does not have "functionName" and "functionArn" defined', async () => {
await expect(
runServerless({