archive-gh-me/rollup-plugin-typescript2
1
0
Fork 0
mirror of https://github.com/ezolenko/rollup-plugin-typescript2.git synced 2025-12-08 19:06:16 +00:00
Code Issues Projects Releases Wiki Activity

clean: remove redundant allImportedFiles check in _onwrite (#346)

Browse Source 
- this checks if any of the files in `parsedConfig.fileNames` are _not_
  in `allImportedFiles`, but all the files in `parsedConfig.fileNames`
  are explicitly added in the `options` hook on line 98
  - so this is redundant / dead code; the check will never be true

- this can be considered a remnant of an old bug as an old commit fixed
  a bug with `allImportedFiles` after it was released:
  f24359e668
This commit is contained in:
Anton Gilgur 2022-06-06 20:17:31 -04:00 committed by GitHub
parent 671281f6de
commit c0fb53d3bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/index.ts
View File

@ -306,11 +306,6 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
const key = normalize(name);
if (key in declarations)
return;
if (!allImportedFiles.has(key))
{
context.debug(() => `skipping declarations for unused '${key}'`);
return;
}
context.debug(() => `generating missed declarations for '${key}'`);
const output = service.getEmitOutput(key, true);