From bbb4f4f161aa0f1d80f13384b065d6e9408a34ce Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Mon, 16 May 2022 16:46:31 -0400 Subject: [PATCH] ci: add a lint check to ensure all PRs pass lint too (#327) - rename the job a bit to match, and shrink the name a bit for conciseness as it didn't always fit on screen in the list of checks - this could be done in a different job as it's not necessarily required for linting to run through the entire matrix, but this is simpler for now as we don't have a further need for separate jobs - and no need to re-run install etc, and the tests are fast anyway currently, so no perf need there either --- .github/workflows/nodejs.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index b8db396..a624c92 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -10,8 +10,8 @@ on: branches: [ master ] jobs: - build-and-test: - name: Build & Test on Node ${{ matrix.node-version }} and ${{ matrix.os }} + lint-build-test: + name: Lint, Build, Test - Node ${{ matrix.node-version }}, ${{ matrix.os }} runs-on: ${{ matrix.os }} strategy: @@ -27,6 +27,7 @@ jobs: node-version: ${{ matrix.node-version }} cache: 'npm' - run: npm ci + - run: npm run lint - run: npm run build - run: npm run build-self - run: npm run build-self