archive-gh-me/react-use
1
0
Fork 0
mirror of https://github.com/streamich/react-use.git synced 2026-01-18 14:06:52 +00:00
Code Issues Projects Releases Wiki Activity

fix: 🐛 cancel animation frame on un-mount in useWindowScroll()

Browse Source
This commit is contained in:
streamich 2019-03-23 08:40:31 +01:00
parent 94bffc514d
commit bc021ce550
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/useWindowScroll.ts
View File

@ -16,7 +16,6 @@ const useWindowScroll = (): State => {
useEffect(() => {
const handler = () => {
cancelAnimationFrame(frame.current)
frame.current = requestAnimationFrame(() => {
setState({
x: window.scrollX,
@ -30,7 +29,10 @@ const useWindowScroll = (): State => {
passive: true
})
return () => window.removeEventListener('scroll', handler)
return () => {
cancelAnimationFrame(frame.current);
window.removeEventListener('scroll', handler);
};
}, [])
return state