archive-gh-me/react-use
1
0
Fork 0
mirror of https://github.com/streamich/react-use.git synced 2025-12-08 18:02:14 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #2536 from willnguyen1312/pr/update-use-media

Browse Source 
fix: update useMedia hook to use recommended approach of MDN
This commit is contained in:
Va Da 2024-01-13 15:13:53 +01:00 committed by GitHub
commit 3264d96fa2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/useMedia.ts
View File

@ -34,12 +34,12 @@ const useMedia = (query: string, defaultState?: boolean) => {
setState(!!mql.matches);
};
mql.addListener(onChange);
mql.addEventListener('change', onChange);
setState(mql.matches);
return () => {
mounted = false;
mql.removeListener(onChange);
mql.removeEventListener('change', onChange);
};
}, [query]);

4
tests/useMedia.test.ts
View File

@ -4,8 +4,8 @@ import { useMedia } from '../src';
const createMockMediaMatcher = (matches: Record<string, boolean>) => (qs: string) => ({
matches: matches[qs] ?? false,
addListener: () => {},
removeListener: () => {},
addEventListener: () => {},
removeEventListener: () => {},
});
describe('useMedia', () => {