From da4c7c6c3075a072ce7feac623d152ce242508da Mon Sep 17 00:00:00 2001 From: Victor Oliva Date: Wed, 30 Mar 2022 14:45:44 +0200 Subject: [PATCH] fix Subscribe running in react18 StrictMode (#249) --- packages/core/src/Subscribe.test.tsx | 12 ++++++++++-- packages/core/src/Subscribe.tsx | 1 + 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/packages/core/src/Subscribe.test.tsx b/packages/core/src/Subscribe.test.tsx index 2141c28..1fef0d0 100644 --- a/packages/core/src/Subscribe.test.tsx +++ b/packages/core/src/Subscribe.test.tsx @@ -1,7 +1,15 @@ import { render } from "@testing-library/react" -import React, { useState } from "react" +import React, { StrictMode, useState } from "react" import { defer, Observable, of } from "rxjs" -import { bind, Subscribe } from "./" +import { bind, Subscribe as OriginalSubscribe } from "./" + +const Subscribe = (props: any) => { + return ( + + + + ) +} describe("Subscribe", () => { describe("Subscribe with source$", () => { diff --git a/packages/core/src/Subscribe.tsx b/packages/core/src/Subscribe.tsx index e79bf56..95e9ddb 100644 --- a/packages/core/src/Subscribe.tsx +++ b/packages/core/src/Subscribe.tsx @@ -77,6 +77,7 @@ export const Subscribe: React.FC<{ useEffect(() => { return () => { subscriptionRef.current!.unsubscribe() + subscriptionRef.current = undefined } }, [])