From c3d72b010f20b21aff90bda8c0f63f509bdbc606 Mon Sep 17 00:00:00 2001 From: Md Balal Raza Date: Thu, 31 Oct 2019 19:36:37 +0530 Subject: [PATCH] Fix #215: strokeDasharray expects array of numbers PR #215 is a fix in the right direction. However, it doesn't solve issue #213 completely. strokeDasharray expects an array of numbers. Object.values() returns all strings, always. --- src/CircularProgress.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/CircularProgress.js b/src/CircularProgress.js index 6171ff3..ba7646d 100644 --- a/src/CircularProgress.js +++ b/src/CircularProgress.js @@ -88,6 +88,9 @@ export default class CircularProgress extends React.PureComponent { const dashedBackgroundStyle = dashedBackground.gap > 0 ? `${dashedBackground.width}, ${dashedBackground.gap}` : dashedBackground; + + const strokeDasharray = Object.values(dashedBackgroundStyle) + .map(value => parseInt(value)); return ( @@ -99,7 +102,7 @@ export default class CircularProgress extends React.PureComponent { stroke={backgroundColor} strokeWidth={backgroundWidth || width} strokeLinecap={lineCap} - strokeDasharray={Object.values(dashedBackgroundStyle)} + strokeDasharray={strokeDasharray} fill="transparent" /> )}