archive-gh-me/react-map-gl
1
0
Fork 0
mirror of https://github.com/visgl/react-map-gl.git synced 2026-01-25 16:02:50 +00:00
Code Issues Projects Releases Wiki Activity

Fix crash during Source component removal (#928)

Browse Source
This commit is contained in:
Xiaoji Chen 2019-10-29 16:14:09 -07:00 committed by GitHub
parent 734b1114be
commit d1cb92dffd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/components/source.js
View File

@ -48,7 +48,12 @@ export default class Source<Props: SourceProps> extends PureComponent<Props> {
}
componentWillUnmount() {
this._map.removeSource(this.id);
/* global requestAnimationFrame */
// Do not remove source immediately because the
// dependent <Layer>s' componentWillUnmount() might not have been called
// Removing source before dependent layers will throw error
// TODO - find a more robust solution
requestAnimationFrame(() => this._map.removeSource(this.id));
}
id: string;