archive-gh-me/react-map-gl
1
0
Fork 0
mirror of https://github.com/visgl/react-map-gl.git synced 2026-01-18 15:54:22 +00:00
Code Issues Projects Releases Wiki Activity

Fix stale onLoad and onError event handlers (#1505)

Browse Source
This commit is contained in:
Maxim 2021-09-06 21:26:05 +03:00 committed by GitHub
parent f96184e910
commit 376dc5cc08
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/mapbox/mapbox.js
View File

@ -204,6 +204,11 @@ export default class Mapbox {
});
};
_handleError = event => {
// @ts-ignore
this.props.onError(event);
};
_reuse(props) {
this._map = Mapbox.savedMap;
// When reusing the saved map, we need to reparent the map(canvas) and other child nodes
@ -272,8 +277,8 @@ export default class Mapbox {
this._map = new this.mapboxgl.Map(Object.assign({}, mapOptions, props.mapOptions));
// Attach optional onLoad function
this._map.once('load', props.onLoad);
this._map.on('error', props.onError);
this._map.once('load', this._fireLoadEvent);
this._map.on('error', this._handleError);
}
return this;
@ -288,8 +293,8 @@ export default class Mapbox {
Mapbox.savedMap = this._map;
// deregister the mapbox event listeners
this._map.off('load', this.props.onLoad);
this._map.off('error', this.props.onError);
this._map.off('load', this._fireLoadEvent);
this._map.off('error', this._handleError);
this._map.off('styledata', this._fireLoadEvent);
} else {
this._map.remove();