From 9243eeaaee4406e3f0cd83c313d96ef1c2b8a258 Mon Sep 17 00:00:00 2001 From: Sandro Santilli Date: Mon, 9 Feb 2015 19:56:37 +0100 Subject: [PATCH] Add a couple of return values check now that pcerror is not guaranteed to exit it is worth checking returns --- lib/pc_patch_dimensional.c | 1 + lib/pc_patch_uncompressed.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/pc_patch_dimensional.c b/lib/pc_patch_dimensional.c index 1e50cf3..f2bf82a 100644 --- a/lib/pc_patch_dimensional.c +++ b/lib/pc_patch_dimensional.c @@ -293,6 +293,7 @@ PCPATCH_DIMENSIONAL * pc_patch_dimensional_from_pointlist(const PCPOINTLIST *pdl) { PCPATCH_UNCOMPRESSED *patch = pc_patch_uncompressed_from_pointlist(pdl); + if ( ! patch ) return NULL; PCPATCH_DIMENSIONAL *dimpatch = pc_patch_dimensional_from_uncompressed(patch); pc_patch_uncompressed_free(patch); return dimpatch; diff --git a/lib/pc_patch_uncompressed.c b/lib/pc_patch_uncompressed.c index 1949ab4..4c3d533 100644 --- a/lib/pc_patch_uncompressed.c +++ b/lib/pc_patch_uncompressed.c @@ -39,6 +39,7 @@ pc_patch_uncompressed_to_string(const PCPATCH_UNCOMPRESSED *patch) if ( ! pc_point_get_double_by_index(pt, j, &d)) { pcerror("%s: unable to read double at index %d", __func__, j); + return NULL; } if ( j ) {