From 53b4fa1dcbf9c322479abfb2fbf4840b180d3a8a Mon Sep 17 00:00:00 2001
From: Sandro Santilli <strk@keybit.net>
Date: Thu, 9 Apr 2015 12:19:22 +0200
Subject: [PATCH] Add test for pc_schema_clone and plug memory leaks in the
 test

See #65
---
 lib/cunit/cu_pc_schema.c | 47 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/lib/cunit/cu_pc_schema.c b/lib/cunit/cu_pc_schema.c
index 4396cf6..ecb7f06 100644
--- a/lib/cunit/cu_pc_schema.c
+++ b/lib/cunit/cu_pc_schema.c
@@ -131,6 +131,8 @@ test_schema_is_valid()
   cu_error_msg_reset();
   rv = pc_schema_is_valid(myschema);
 	CU_ASSERT_EQUAL(rv, PC_FAILURE);
+
+  pc_schema_free(myschema);
 }
 
 
@@ -141,6 +143,50 @@ test_schema_compression(void)
     CU_ASSERT_EQUAL(compression, PC_DIMENSIONAL);
 }
 
+static void
+test_schema_clone(void)
+{
+    int i;
+    PCSCHEMA *clone = pc_schema_clone(schema);
+    hashtable *hash, *chash;
+    CU_ASSERT_EQUAL(clone->pcid, schema->pcid);
+    CU_ASSERT_EQUAL(clone->ndims, schema->ndims);
+    CU_ASSERT_EQUAL(clone->size, schema->size);
+    CU_ASSERT_EQUAL(clone->srid, schema->srid);
+    CU_ASSERT_EQUAL(clone->x_position, schema->x_position);
+    CU_ASSERT_EQUAL(clone->y_position, schema->y_position);
+    CU_ASSERT_EQUAL(clone->compression, schema->compression);
+    CU_ASSERT(clone->dims != schema->dims); /* deep clone */
+    CU_ASSERT(clone->namehash != schema->namehash); /* deep clone */
+    hash = schema->namehash;
+    chash = clone->namehash;
+    CU_ASSERT_EQUAL(chash->tablelength, hash->tablelength);
+    CU_ASSERT_EQUAL(chash->entrycount, hash->entrycount);
+    CU_ASSERT_EQUAL(chash->loadlimit, hash->loadlimit);
+    CU_ASSERT_EQUAL(chash->primeindex, hash->primeindex);
+    CU_ASSERT_EQUAL(chash->hashfn, hash->hashfn);
+    CU_ASSERT_EQUAL(chash->eqfn, hash->eqfn);
+    CU_ASSERT(chash->table != hash->table); /* deep clone */
+    for (i=0; i<schema->ndims; ++i) {
+      PCDIMENSION *dim = schema->dims[i];
+      PCDIMENSION *cdim = clone->dims[i];
+      CU_ASSERT(dim != cdim); /* deep clone */
+      CU_ASSERT_STRING_EQUAL(cdim->name, dim->name);
+      CU_ASSERT_STRING_EQUAL(cdim->description, dim->description);
+      CU_ASSERT_EQUAL(cdim->position, dim->position);
+      CU_ASSERT_EQUAL(cdim->size, dim->size);
+      CU_ASSERT_EQUAL(cdim->byteoffset, dim->byteoffset);
+      CU_ASSERT_EQUAL(cdim->interpretation, dim->interpretation);
+      CU_ASSERT_EQUAL(cdim->scale, dim->scale);
+      CU_ASSERT_EQUAL(cdim->offset, dim->offset);
+      CU_ASSERT_EQUAL(cdim->active, dim->active);
+      /* hash table is correctly setup */
+      CU_ASSERT_EQUAL(cdim, hashtable_search(clone->namehash, dim->name) );
+    }
+
+    pc_schema_free(clone);
+}
+
 /* REGISTER ***********************************************************/
 
 CU_TestInfo schema_tests[] = {
@@ -150,6 +196,7 @@ CU_TestInfo schema_tests[] = {
 	PC_TEST(test_dimension_byteoffsets),
 	PC_TEST(test_schema_compression),
 	PC_TEST(test_schema_is_valid),
+	PC_TEST(test_schema_clone),
 	CU_TEST_INFO_NULL
 };