archive-gh-me/openmaptiles
1
0
Fork 0
mirror of https://github.com/openmaptiles/openmaptiles.git synced 2025-12-08 18:02:18 +00:00
Code Issues Projects Releases Wiki Activity

Add test failure targets (#1761)

Browse Source 
This PR adds a new Makefile target `show-test-failures` to display test failure details and updates the existing `test-sql` target to automatically show failures when tests fail. This avoids forcing the developer to log into the SQL database to review test failures

### New Features

- **Added `show-test-failures` target**: A new Makefile target that displays test failures from the `omt_test_failures` table in a user-friendly format
- **update `test-sql` target**: Modified to automatically call `show-test-failures` when tests fail
This commit is contained in:
Brian Sperlongano 2025-10-06 02:25:11 -04:00 committed by GitHub
parent 9fd6f078c2
commit 94676c3816
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Makefile
View File

@ -200,6 +200,7 @@ Hints for developers:
make generate-tiles # generate vector tiles based on .env settings using Mapnik (obsolete)
make generate-changed-tiles # Generate tiles changed by import-diff
make test-sql # run unit tests on the OpenMapTiles SQL schema
make show-test-failures # show any test failures from the last test run
cat .env # list PG database and MIN_ZOOM and MAX_ZOOM information
cat quickstart.log # transcript of the last ./quickstart.sh run
make help # help about available commands
@ -686,7 +687,7 @@ test-sql: clean refresh-docker-images destroy-db start-db-nowait build/import-te
@echo "Test SQL output for Import Test Data"
$(DOCKER_COMPOSE) $(DC_CONFIG_CACHE) run $(DC_OPTS_CACHE) openmaptiles-tools sh -c 'pgwait && psql.sh < tests/test-post-import.sql' 2>&1 | \
awk -v s="ERROR:" '1{print; fflush()} $$0~s{print "*** ERROR detected, aborting"; exit(1)}'
awk -v s="ERROR:" '1{print; fflush()} $$0~s{print "*** ERROR detected, aborting"; exit(1)}' || (echo ""; echo "=== IMPORT TEST FAILURES ==="; $(MAKE) show-test-failures; exit 1)
@echo "Run UPDATE process on test data..."
sed -ir "s/^[#]*\s*DIFF_MODE=.*/DIFF_MODE=true/" .env
@ -694,4 +695,12 @@ test-sql: clean refresh-docker-images destroy-db start-db-nowait build/import-te
@echo "Test SQL output for Update Test Data"
$(DOCKER_COMPOSE) $(DC_CONFIG_CACHE) run $(DC_OPTS_CACHE) openmaptiles-tools sh -c 'pgwait && psql.sh < tests/test-post-update.sql' 2>&1 | \
awk -v s="ERROR:" '1{print; fflush()} $$0~s{print "*** ERROR detected, aborting"; exit(1)}'
awk -v s="ERROR:" '1{print; fflush()} $$0~s{print "*** ERROR detected, aborting"; exit(1)}' || (echo ""; echo "=== UPDATE TEST FAILURES ==="; $(MAKE) show-test-failures; exit 1)
.PHONY: show-test-failures
show-test-failures: start-db-nowait
@echo "=============================================="
@echo "OpenMapTiles Test Failures"
@echo "=============================================="
$(DOCKER_COMPOSE) run $(DC_OPTS) openmaptiles-tools psql.sh -v ON_ERROR_STOP=1 -P pager=off -c \
"SELECT CASE WHEN COUNT(*) = 0 THEN 'No test failures found.' ELSE 'Found ' || COUNT(*) || ' test failure(s):' END FROM omt_test_failures; SELECT * FROM omt_test_failures ORDER BY test_id;"