diff --git a/server-core/src/main/java/io/onedev/server/attachment/DefaultAttachmentManager.java b/server-core/src/main/java/io/onedev/server/attachment/DefaultAttachmentManager.java index a8b5d827ea..48e8920bf3 100644 --- a/server-core/src/main/java/io/onedev/server/attachment/DefaultAttachmentManager.java +++ b/server-core/src/main/java/io/onedev/server/attachment/DefaultAttachmentManager.java @@ -1,5 +1,43 @@ package io.onedev.server.attachment; +import static io.onedev.commons.utils.LockUtils.read; +import static io.onedev.commons.utils.LockUtils.write; +import static io.onedev.k8shelper.KubernetesHelper.BEARER; +import static io.onedev.server.model.Project.ATTACHMENT_DIR; +import static io.onedev.server.util.DirectoryVersionUtils.isVersionFile; +import static io.onedev.server.util.IOUtils.BUFFER_SIZE; +import static javax.ws.rs.core.HttpHeaders.AUTHORIZATION; + +import java.io.BufferedOutputStream; +import java.io.File; +import java.io.FileOutputStream; +import java.io.IOException; +import java.io.InputStream; +import java.io.ObjectStreamException; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashSet; +import java.util.List; +import java.util.UUID; + +import javax.inject.Inject; +import javax.inject.Singleton; +import javax.ws.rs.client.Client; +import javax.ws.rs.client.ClientBuilder; +import javax.ws.rs.client.Entity; +import javax.ws.rs.client.Invocation; +import javax.ws.rs.client.WebTarget; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import javax.ws.rs.core.StreamingOutput; + +import org.glassfish.jersey.client.ClientProperties; +import org.quartz.CronScheduleBuilder; +import org.quartz.ScheduleBuilder; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import io.onedev.commons.loader.ManagedSerializedForm; import io.onedev.commons.utils.ExceptionUtils; import io.onedev.commons.utils.FileUtils; @@ -19,7 +57,13 @@ import io.onedev.server.event.project.codecomment.CodeCommentCreated; import io.onedev.server.event.project.codecomment.CodeCommentEdited; import io.onedev.server.event.project.codecomment.CodeCommentReplyCreated; import io.onedev.server.event.project.codecomment.CodeCommentReplyEdited; -import io.onedev.server.event.project.issue.*; +import io.onedev.server.event.project.issue.IssueChanged; +import io.onedev.server.event.project.issue.IssueCommentCreated; +import io.onedev.server.event.project.issue.IssueCommentEdited; +import io.onedev.server.event.project.issue.IssueOpened; +import io.onedev.server.event.project.issue.IssuesCopied; +import io.onedev.server.event.project.issue.IssuesImported; +import io.onedev.server.event.project.issue.IssuesMoved; import io.onedev.server.event.project.pullrequest.PullRequestChanged; import io.onedev.server.event.project.pullrequest.PullRequestCommentCreated; import io.onedev.server.event.project.pullrequest.PullRequestCommentEdited; @@ -35,30 +79,8 @@ import io.onedev.server.persistence.annotation.Transactional; import io.onedev.server.persistence.dao.Dao; import io.onedev.server.taskschedule.SchedulableTask; import io.onedev.server.taskschedule.TaskScheduler; +import io.onedev.server.util.IOUtils; import io.onedev.server.util.artifact.FileInfo; -import org.apache.commons.compress.utils.IOUtils; -import org.glassfish.jersey.client.ClientProperties; -import org.quartz.CronScheduleBuilder; -import org.quartz.ScheduleBuilder; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -import javax.inject.Inject; -import javax.inject.Singleton; -import javax.ws.rs.client.*; -import javax.ws.rs.core.MediaType; -import javax.ws.rs.core.Response; -import javax.ws.rs.core.StreamingOutput; -import java.io.*; -import java.util.*; - -import static io.onedev.commons.utils.LockUtils.read; -import static io.onedev.commons.utils.LockUtils.write; -import static io.onedev.k8shelper.KubernetesHelper.BEARER; -import static io.onedev.server.model.Project.ATTACHMENT_DIR; -import static io.onedev.server.util.DirectoryVersionUtils.isVersionFile; -import static io.onedev.server.util.IOUtils.BUFFER_SIZE; -import static javax.ws.rs.core.HttpHeaders.AUTHORIZATION; @Singleton public class DefaultAttachmentManager implements AttachmentManager, SchedulableTask, Serializable { diff --git a/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.java b/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.java index d8d7fb83d9..6409c89aee 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.java @@ -1490,6 +1490,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate19(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specObjectKey = ((ScalarNode)specTuple.getKeyNode()).getValue(); @@ -1517,6 +1518,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate20(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specTupleKey = ((ScalarNode)specTuple.getKeyNode()).getValue(); @@ -1550,6 +1552,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate21(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specObjectKey = ((ScalarNode)specTuple.getKeyNode()).getValue(); @@ -1590,6 +1593,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate22(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specObjectKey = ((ScalarNode)specTuple.getKeyNode()).getValue(); @@ -1627,6 +1631,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate23(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specObjectKey = ((ScalarNode)specTuple.getKeyNode()).getValue(); @@ -1667,6 +1672,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate24(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specObjectKey = ((ScalarNode)specTuple.getKeyNode()).getValue(); @@ -1704,6 +1710,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate25(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specObjectKey = ((ScalarNode)specTuple.getKeyNode()).getValue(); @@ -1753,6 +1760,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate26(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specObjectKey = ((ScalarNode)specTuple.getKeyNode()).getValue(); @@ -1804,6 +1812,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate27(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specObjectKey = ((ScalarNode) specTuple.getKeyNode()).getValue(); @@ -1821,6 +1830,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate28(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specObjectKey = ((ScalarNode) specTuple.getKeyNode()).getValue(); @@ -1882,6 +1892,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate29(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specObjectKey = ((ScalarNode)specTuple.getKeyNode()).getValue(); @@ -1937,6 +1948,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate30(VersionedYamlDoc doc, Stack versions) { migrateSteps(doc, versions, stepsNode -> { for (var itStepNode = stepsNode.getValue().iterator(); itStepNode.hasNext();) { @@ -1964,6 +1976,7 @@ public class BuildSpec implements Serializable, Validatable { }); } + @SuppressWarnings("unused") private void migrate31(VersionedYamlDoc doc, Stack versions) { migrateSteps(doc, versions, stepsNode -> { for (var itStepNode = stepsNode.getValue().iterator(); itStepNode.hasNext();) { @@ -2000,6 +2013,7 @@ public class BuildSpec implements Serializable, Validatable { }); } + @SuppressWarnings("unused") private void migrate32(VersionedYamlDoc doc, Stack versions) { migrateSteps(doc, versions, stepsNode -> { for (var itStepNode = stepsNode.getValue().iterator(); itStepNode.hasNext();) { @@ -2056,6 +2070,7 @@ public class BuildSpec implements Serializable, Validatable { }); } + @SuppressWarnings("unused") private void migrate33(VersionedYamlDoc doc, Stack versions) { migrateSteps(doc, versions, stepsNode -> { for (var itStepNode = stepsNode.getValue().iterator(); itStepNode.hasNext();) { @@ -2105,6 +2120,7 @@ public class BuildSpec implements Serializable, Validatable { } } + @SuppressWarnings("unused") private void migrate34(VersionedYamlDoc doc, Stack versions) { migrateSteps(doc, versions, stepsNode -> { for (var itStepNode = stepsNode.getValue().iterator(); itStepNode.hasNext();) { @@ -2124,6 +2140,7 @@ public class BuildSpec implements Serializable, Validatable { }); } + @SuppressWarnings("unused") private void migrate35(VersionedYamlDoc doc, Stack versions) { migrateSteps(doc, versions, stepsNode -> { for (var itStepNode = stepsNode.getValue().iterator(); itStepNode.hasNext();) { @@ -2149,6 +2166,7 @@ public class BuildSpec implements Serializable, Validatable { }); } + @SuppressWarnings("unused") private void migrate36(VersionedYamlDoc doc, Stack versions) { migrateSteps(doc, versions, stepsNode -> { for (var itStepNode = stepsNode.getValue().iterator(); itStepNode.hasNext();) { @@ -2162,7 +2180,7 @@ public class BuildSpec implements Serializable, Validatable { } }); } - + private void migrate37_registryLogins(MappingNode node) { String accessTokenSecret = null; for (var itTuple = node.getValue().iterator(); itTuple.hasNext();) { @@ -2190,7 +2208,8 @@ public class BuildSpec implements Serializable, Validatable { node.getValue().add(new NodeTuple(new ScalarNode(Tag.STR, "registryLogins"), logins)); } } - + + @SuppressWarnings("unused") private void migrate37(VersionedYamlDoc doc, Stack versions) { for (NodeTuple specTuple: doc.getValue()) { String specObjectKey = ((ScalarNode)specTuple.getKeyNode()).getValue(); @@ -2207,6 +2226,7 @@ public class BuildSpec implements Serializable, Validatable { }); } + @SuppressWarnings("unused") private void migrate38(VersionedYamlDoc doc, Stack versions) { migrateSteps(doc, versions, stepsNode -> { for (var stepNode: stepsNode.getValue()) { diff --git a/server-core/src/main/java/io/onedev/server/buildspec/Import.java b/server-core/src/main/java/io/onedev/server/buildspec/Import.java index 0cf6f0cf45..5684ecd3b4 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/Import.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/Import.java @@ -1,6 +1,24 @@ package io.onedev.server.buildspec; -import com.google.common.base.Throwables; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; +import java.util.Stack; +import java.util.stream.Collectors; + +import javax.annotation.Nullable; +import javax.validation.ConstraintValidatorContext; +import javax.validation.ConstraintViolation; +import javax.validation.ValidationException; +import javax.validation.Validator; +import javax.validation.constraints.NotEmpty; + +import org.apache.shiro.subject.Subject; +import org.eclipse.jgit.revwalk.RevCommit; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import edu.emory.mathcs.backport.java.util.Collections; import io.onedev.commons.codeassist.InputSuggestion; import io.onedev.commons.utils.ExplicitException; @@ -22,23 +40,6 @@ import io.onedev.server.validation.Validatable; import io.onedev.server.web.page.project.ProjectPage; import io.onedev.server.web.util.SuggestionUtils; import io.onedev.server.web.util.WicketUtils; -import org.apache.shiro.subject.Subject; -import org.eclipse.jgit.revwalk.RevCommit; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -import javax.annotation.Nullable; -import javax.validation.ConstraintValidatorContext; -import javax.validation.ConstraintViolation; -import javax.validation.ValidationException; -import javax.validation.Validator; -import javax.validation.constraints.NotEmpty; -import java.io.Serializable; -import java.util.ArrayList; -import java.util.Collection; -import java.util.List; -import java.util.Stack; -import java.util.stream.Collectors; @Editable @ClassValidating diff --git a/server-core/src/main/java/io/onedev/server/buildspec/Service.java b/server-core/src/main/java/io/onedev/server/buildspec/Service.java index d5ebc1f699..2c1463b05a 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/Service.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/Service.java @@ -1,25 +1,28 @@ package io.onedev.server.buildspec; +import static java.util.stream.Collectors.toList; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; + +import javax.validation.constraints.NotEmpty; + import io.onedev.commons.codeassist.InputCompletion; import io.onedev.commons.codeassist.InputStatus; import io.onedev.commons.codeassist.InputSuggestion; import io.onedev.k8shelper.ServiceFacade; -import io.onedev.server.annotation.*; +import io.onedev.server.annotation.DnsName; +import io.onedev.server.annotation.Editable; +import io.onedev.server.annotation.Interpolative; +import io.onedev.server.annotation.RegEx; +import io.onedev.server.annotation.SuggestionProvider; import io.onedev.server.buildspec.job.EnvVar; import io.onedev.server.buildspec.step.RegistryLogin; import io.onedev.server.model.Build; -import javax.validation.constraints.NotEmpty; -import java.io.Serializable; -import java.util.ArrayList; -import java.util.HashMap; -import java.util.List; -import java.util.stream.Collectors; - -import static java.util.stream.Collectors.toList; - @Editable -public class Service implements NamedElement, Serializable { +public class Service implements NamedElement { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/buildspec/job/Job.java b/server-core/src/main/java/io/onedev/server/buildspec/job/Job.java index 4c7bf1c41a..65309737b2 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/job/Job.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/job/Job.java @@ -1,10 +1,40 @@ package io.onedev.server.buildspec.job; +import static io.onedev.server.model.Build.NAME_BRANCH; +import static io.onedev.server.model.Build.NAME_COMMIT; +import static io.onedev.server.model.Build.NAME_JOB; +import static io.onedev.server.model.Build.NAME_PULL_REQUEST; +import static io.onedev.server.model.Build.NAME_TAG; +import static io.onedev.server.search.entity.build.BuildQuery.getRuleName; +import static io.onedev.server.search.entity.build.BuildQueryLexer.And; +import static io.onedev.server.search.entity.build.BuildQueryLexer.Is; + +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.stream.Collectors; + +import javax.annotation.Nullable; +import javax.validation.ConstraintValidatorContext; +import javax.validation.Valid; +import javax.validation.constraints.Min; +import javax.validation.constraints.NotEmpty; + +import org.apache.wicket.Component; +import org.eclipse.jgit.lib.ObjectId; + import io.onedev.commons.codeassist.InputCompletion; import io.onedev.commons.codeassist.InputStatus; import io.onedev.commons.codeassist.InputSuggestion; import io.onedev.server.OneDev; -import io.onedev.server.annotation.*; +import io.onedev.server.annotation.ChoiceProvider; +import io.onedev.server.annotation.ClassValidating; +import io.onedev.server.annotation.Editable; +import io.onedev.server.annotation.Interpolative; +import io.onedev.server.annotation.RetryCondition; +import io.onedev.server.annotation.SuggestionProvider; import io.onedev.server.buildspec.BuildSpec; import io.onedev.server.buildspec.BuildSpecAware; import io.onedev.server.buildspec.NamedElement; @@ -29,25 +59,10 @@ import io.onedev.server.validation.Validatable; import io.onedev.server.web.page.project.blob.ProjectBlobPage; import io.onedev.server.web.util.SuggestionUtils; import io.onedev.server.web.util.WicketUtils; -import org.apache.wicket.Component; -import org.eclipse.jgit.lib.ObjectId; - -import javax.annotation.Nullable; -import javax.validation.ConstraintValidatorContext; -import javax.validation.Valid; -import javax.validation.constraints.Min; -import javax.validation.constraints.NotEmpty; -import java.io.Serializable; -import java.util.*; -import java.util.stream.Collectors; - -import static io.onedev.server.model.Build.*; -import static io.onedev.server.search.entity.build.BuildQuery.getRuleName; -import static io.onedev.server.search.entity.build.BuildQueryLexer.*; @Editable @ClassValidating -public class Job implements NamedElement, Serializable, Validatable { +public class Job implements NamedElement, Validatable { private static final long serialVersionUID = 1L; @@ -132,6 +147,7 @@ public class Job implements NamedElement, Serializable, Validatable { this.jobExecutor = jobExecutor; } + @SuppressWarnings("unused") private static String getJobExecutorPlaceholder() { if (OneDev.getInstance(SettingManager.class).getJobExecutors().isEmpty()) return "Auto-discovered executor"; @@ -323,9 +339,6 @@ public class Job implements NamedElement, Serializable, Validatable { public boolean isValid(ConstraintValidatorContext context) { boolean isValid = true; - Set keys = new HashSet<>(); - Set paths = new HashSet<>(); - Set dependencyJobNames = new HashSet<>(); for (JobDependency dependency: jobDependencies) { if (!dependencyJobNames.add(dependency.getJobName())) { diff --git a/server-core/src/main/java/io/onedev/server/buildspec/job/JobDependency.java b/server-core/src/main/java/io/onedev/server/buildspec/job/JobDependency.java index 7cfdcbb7d3..63ca5b65c3 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/job/JobDependency.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/job/JobDependency.java @@ -1,7 +1,21 @@ package io.onedev.server.buildspec.job; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +import javax.validation.Valid; +import javax.validation.constraints.NotEmpty; + import io.onedev.commons.codeassist.InputSuggestion; -import io.onedev.server.annotation.*; +import io.onedev.server.annotation.ChoiceProvider; +import io.onedev.server.annotation.Editable; +import io.onedev.server.annotation.Interpolative; +import io.onedev.server.annotation.OmitName; +import io.onedev.server.annotation.ParamSpecProvider; +import io.onedev.server.annotation.Patterns; +import io.onedev.server.annotation.ShowCondition; +import io.onedev.server.annotation.VariableOption; import io.onedev.server.buildspec.BuildSpec; import io.onedev.server.buildspec.param.instance.ParamInstances; import io.onedev.server.buildspec.param.instance.ParamMap; @@ -9,13 +23,6 @@ import io.onedev.server.buildspec.param.spec.ParamSpec; import io.onedev.server.util.ComponentContext; import io.onedev.server.util.EditContext; import io.onedev.server.web.editable.BeanEditor; -import io.onedev.server.web.util.WicketUtils; - -import javax.validation.Valid; -import javax.validation.constraints.NotEmpty; -import java.io.Serializable; -import java.util.ArrayList; -import java.util.List; @Editable public class JobDependency implements Serializable { @@ -78,6 +85,7 @@ public class JobDependency implements Serializable { this.excludeParamMaps = excludeParamMaps; } + @SuppressWarnings({ "unused", "unchecked" }) private static boolean isExcludeParamMapsVisible() { var componentContext = ComponentContext.get(); if (componentContext != null && componentContext.getComponent().findParent(BeanEditor.class) != null) { diff --git a/server-core/src/main/java/io/onedev/server/buildspec/job/action/CreateIssueAction.java b/server-core/src/main/java/io/onedev/server/buildspec/job/action/CreateIssueAction.java index 0afab73bb2..63ea1b1ca6 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/job/action/CreateIssueAction.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/job/action/CreateIssueAction.java @@ -90,6 +90,7 @@ public class CreateIssueAction extends PostBuildAction { this.accessTokenSecret = accessTokenSecret; } + @SuppressWarnings("unused") private static boolean isProjectSpecified() { return EditContext.get().getInputValue("projectPath") != null; } diff --git a/server-core/src/main/java/io/onedev/server/buildspec/job/action/RunJobAction.java b/server-core/src/main/java/io/onedev/server/buildspec/job/action/RunJobAction.java index 4991644d3b..4df2ff7853 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/job/action/RunJobAction.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/job/action/RunJobAction.java @@ -75,6 +75,7 @@ public class RunJobAction extends PostBuildAction { this.excludeParamMaps = excludeParamMaps; } + @SuppressWarnings({ "unused", "unchecked" }) private static boolean isExcludeParamMapsVisible() { var componentContext = ComponentContext.get(); if (componentContext != null && componentContext.getComponent().findParent(BeanEditor.class) != null) { diff --git a/server-core/src/main/java/io/onedev/server/buildspec/job/gitcredential/GitCredential.java b/server-core/src/main/java/io/onedev/server/buildspec/job/gitcredential/GitCredential.java index 153c8e3af8..1ea75d816b 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/job/gitcredential/GitCredential.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/job/gitcredential/GitCredential.java @@ -17,6 +17,7 @@ public interface GitCredential extends Serializable { CloneInfo newCloneInfo(Build build, String jobToken); + @SuppressWarnings("unused") private static Collection> getImplementations() { var implementations = Lists.newArrayList(DefaultCredential.class, HttpCredential.class); if (OneDev.getInstance(ServerConfig.class).getSshPort() != 0) diff --git a/server-core/src/main/java/io/onedev/server/buildspec/job/trigger/IssueInStateTrigger.java b/server-core/src/main/java/io/onedev/server/buildspec/job/trigger/IssueInStateTrigger.java index 832a8456b7..92ea2e97e6 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/job/trigger/IssueInStateTrigger.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/job/trigger/IssueInStateTrigger.java @@ -40,6 +40,7 @@ public class IssueInStateTrigger extends JobTrigger { this.state = state; } + @SuppressWarnings("unused") private static List getStateChoices() { return OneDev.getInstance(SettingManager.class).getIssueSetting() .getStateSpecs().stream().map(StateSpec::getName).collect(toList()); diff --git a/server-core/src/main/java/io/onedev/server/buildspec/job/trigger/JobTrigger.java b/server-core/src/main/java/io/onedev/server/buildspec/job/trigger/JobTrigger.java index 36b5cb42a3..b74172a6a2 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/job/trigger/JobTrigger.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/job/trigger/JobTrigger.java @@ -85,6 +85,7 @@ public abstract class JobTrigger implements Serializable { this.excludeParamMaps = excludeParamMaps; } + @SuppressWarnings({ "unused", "unchecked" }) private static boolean isExcludeParamMapsVisible() { var componentContext = ComponentContext.get(); if (componentContext != null && componentContext.getComponent().findParent(BeanEditor.class) != null) { @@ -106,7 +107,6 @@ public abstract class JobTrigger implements Serializable { return new ArrayList<>(); } - @SuppressWarnings("unused") @Nullable public TriggerMatch matches(ProjectEvent event, Job job) { String projectPath = event.getProject().getPath(); diff --git a/server-core/src/main/java/io/onedev/server/buildspec/param/instance/ParamMap.java b/server-core/src/main/java/io/onedev/server/buildspec/param/instance/ParamMap.java index fc82b72ac2..0c2ae41fdf 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/param/instance/ParamMap.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/param/instance/ParamMap.java @@ -41,6 +41,7 @@ public class ParamMap implements Serializable { this.params = params; } + @SuppressWarnings("unused") private static List getParamSpecs() { Component component = ComponentContext.get().getComponent(); if (WicketUtils.findInnermost(component, JobTriggerEditPanel.class) != null) diff --git a/server-core/src/main/java/io/onedev/server/buildspec/param/instance/ScriptingValue.java b/server-core/src/main/java/io/onedev/server/buildspec/param/instance/ScriptingValue.java index a3fccb3ec8..512d492c9d 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/param/instance/ScriptingValue.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/param/instance/ScriptingValue.java @@ -52,7 +52,6 @@ public class ScriptingValue implements ValueProvider { .toHashCode(); } - @SuppressWarnings("unchecked") @Override public List getValue(Build build, ParamCombination paramCombination) { Map variables = new HashMap<>(); diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java index 99663859e6..0092277cb2 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/CommandStep.java @@ -1,5 +1,14 @@ package io.onedev.server.buildspec.step; +import static java.util.stream.Collectors.toList; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; + +import javax.validation.constraints.NotEmpty; +import javax.validation.constraints.NotNull; + import io.onedev.commons.codeassist.InputSuggestion; import io.onedev.k8shelper.StepFacade; import io.onedev.server.annotation.Editable; @@ -12,19 +21,9 @@ import io.onedev.server.buildspec.param.ParamCombination; import io.onedev.server.buildspec.step.commandinterpreter.DefaultInterpreter; import io.onedev.server.buildspec.step.commandinterpreter.Interpreter; import io.onedev.server.model.Build; -import io.onedev.server.model.Project; import io.onedev.server.model.support.administration.jobexecutor.JobExecutor; import io.onedev.server.util.EditContext; -import javax.validation.constraints.NotEmpty; -import javax.validation.constraints.NotNull; -import java.util.ArrayList; -import java.util.HashMap; -import java.util.List; -import java.util.stream.Collectors; - -import static java.util.stream.Collectors.toList; - @Editable(order=100, name="Execute Commands") public class CommandStep extends Step { diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/CreateBranchStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/CreateBranchStep.java index cc2f597e1a..aaf9f0515e 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/CreateBranchStep.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/CreateBranchStep.java @@ -65,6 +65,7 @@ public class CreateBranchStep extends ServerSideStep { return BuildSpec.suggestVariables(matchWith, true, true, false); } + @SuppressWarnings("unused") private static List suggestRevisions(String matchWith) { Project project = Project.get(); if (project != null) diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/RegistryLogin.java b/server-core/src/main/java/io/onedev/server/buildspec/step/RegistryLogin.java index cd7184cf0f..cf75edc9e5 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/RegistryLogin.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/RegistryLogin.java @@ -60,6 +60,7 @@ public class RegistryLogin implements Serializable { .stream().map(it->it.getName()).collect(Collectors.toList()); } + @SuppressWarnings("unused") private static List suggestVariables(String matchWith) { return BuildSpec.suggestVariables(matchWith, false, false, false); } diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/RunContainerStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/RunContainerStep.java index 1acd6b6b48..e900645e12 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/RunContainerStep.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/RunContainerStep.java @@ -1,5 +1,15 @@ package io.onedev.server.buildspec.step; +import static java.util.stream.Collectors.toList; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import javax.annotation.Nullable; +import javax.validation.constraints.NotEmpty; + import io.onedev.commons.codeassist.InputSuggestion; import io.onedev.k8shelper.RunContainerFacade; import io.onedev.k8shelper.StepFacade; @@ -12,16 +22,6 @@ import io.onedev.server.buildspec.param.ParamCombination; import io.onedev.server.model.Build; import io.onedev.server.model.support.administration.jobexecutor.JobExecutor; -import javax.annotation.Nullable; -import javax.validation.constraints.NotEmpty; -import java.util.ArrayList; -import java.util.HashMap; -import java.util.List; -import java.util.Map; -import java.util.stream.Collectors; - -import static java.util.stream.Collectors.toList; - @Editable(order=150, name="Run Docker Container", description="Run specified docker container. Job workspace " + "is mounted into the container and its path is placed in environment variable ONEDEV_WORKSPACE. " + "Note: this step can only be executed by server docker executor or remote " + diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/SCPCommandStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/SCPCommandStep.java index 82839e0f71..5703121697 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/SCPCommandStep.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/SCPCommandStep.java @@ -42,6 +42,7 @@ public class SCPCommandStep extends CommandStep { this.privateKeySecret = privateKeySecret; } + @SuppressWarnings("unused") private static List getPrivateKeySecretChoices() { return Project.get().getHierarchyJobSecrets() .stream().map(it->it.getName()).collect(Collectors.toList()); diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/SSHCommandStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/SSHCommandStep.java index ad74457133..c30a9db280 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/SSHCommandStep.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/SSHCommandStep.java @@ -67,6 +67,7 @@ public class SSHCommandStep extends CommandStep { this.privateKeySecret = privateKeySecret; } + @SuppressWarnings("unused") private static List getPrivateKeySecretChoices() { return Project.get().getHierarchyJobSecrets() .stream().map(it->it.getName()).collect(Collectors.toList()); diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/ServerSideStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/ServerSideStep.java index 10d2ed1b8c..81ef0efdfb 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/ServerSideStep.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/ServerSideStep.java @@ -3,22 +3,20 @@ package io.onedev.server.buildspec.step; import java.io.File; import java.util.Collection; import java.util.HashSet; -import java.util.Map; -import java.util.function.Consumer; import javax.annotation.Nullable; import io.onedev.commons.utils.TaskLogger; -import io.onedev.k8shelper.ServerStepResult; -import io.onedev.k8shelper.StepFacade; import io.onedev.k8shelper.KubernetesHelper; import io.onedev.k8shelper.ServerSideFacade; +import io.onedev.k8shelper.ServerStepResult; +import io.onedev.k8shelper.StepFacade; +import io.onedev.server.annotation.Interpolative; import io.onedev.server.buildspec.param.ParamCombination; import io.onedev.server.model.Build; import io.onedev.server.model.support.administration.jobexecutor.JobExecutor; import io.onedev.server.util.patternset.PatternSet; import io.onedev.server.web.editable.EditableStringVisitor; -import io.onedev.server.annotation.Interpolative; public abstract class ServerSideStep extends Step { diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/SetupCacheStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/SetupCacheStep.java index 8cabaca0f1..6818fba61f 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/SetupCacheStep.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/SetupCacheStep.java @@ -68,6 +68,7 @@ public class SetupCacheStep extends Step { this.loadKeys = loadKeys; } + @SuppressWarnings("unused") private static List suggestVariables(String matchWith) { return BuildSpec.suggestVariables(matchWith, true, true, false); } @@ -111,6 +112,7 @@ public class SetupCacheStep extends Step { this.changeDetectionExcludes = changeDetectionExcludes; } + @SuppressWarnings("unused") private static boolean isUploadIfChanged() { return UPLOAD_IF_CHANGED == EditContext.get().getInputValue("uploadStrategy"); } @@ -126,6 +128,7 @@ public class SetupCacheStep extends Step { this.uploadProjectPath = uploadProjectPath; } + @SuppressWarnings("unused") private static List suggestStaticVariables(String matchWith) { return BuildSpec.suggestVariables(matchWith, true, false, false); } @@ -142,6 +145,7 @@ public class SetupCacheStep extends Step { this.uploadAccessTokenSecret = uploadAccessTokenSecret; } + @SuppressWarnings("unused") private static List getAccessTokenSecretChoices() { return Project.get().getHierarchyJobSecrets() .stream().map(it->it.getName()).distinct().collect(toList()); diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/StepTemplate.java b/server-core/src/main/java/io/onedev/server/buildspec/step/StepTemplate.java index cf357949a8..f132fcafba 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/StepTemplate.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/StepTemplate.java @@ -1,5 +1,11 @@ package io.onedev.server.buildspec.step; +import java.util.ArrayList; +import java.util.List; + +import javax.validation.Valid; +import javax.validation.constraints.NotEmpty; + import io.onedev.commons.codeassist.InputCompletion; import io.onedev.commons.codeassist.InputStatus; import io.onedev.server.annotation.Editable; @@ -8,14 +14,8 @@ import io.onedev.server.buildspec.BuildSpec; import io.onedev.server.buildspec.NamedElement; import io.onedev.server.buildspec.param.spec.ParamSpec; -import javax.validation.Valid; -import javax.validation.constraints.NotEmpty; -import java.io.Serializable; -import java.util.ArrayList; -import java.util.List; - @Editable -public class StepTemplate implements NamedElement, Serializable { +public class StepTemplate implements NamedElement { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/SyncRepository.java b/server-core/src/main/java/io/onedev/server/buildspec/step/SyncRepository.java index 57625fc9cd..f577180d54 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/SyncRepository.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/SyncRepository.java @@ -74,7 +74,6 @@ public abstract class SyncRepository extends ServerSideStep { this.passwordSecret = passwordSecret; } - @SuppressWarnings("unused") static List getSecretChoices() { return Project.get().getHierarchyJobSecrets() .stream().map(it->it.getName()).collect(Collectors.toList()); diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/UseTemplateStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/UseTemplateStep.java index 1abf95418a..c1df2d2a32 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/UseTemplateStep.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/UseTemplateStep.java @@ -76,6 +76,7 @@ public class UseTemplateStep extends CompositeStep { this.excludeParamMaps = excludeParamMaps; } + @SuppressWarnings({ "unused", "unchecked" }) private static boolean isExcludeParamMapsVisible() { var componentContext = ComponentContext.get(); if (componentContext != null && componentContext.getComponent().findParent(BeanEditor.class) != null) { @@ -86,7 +87,6 @@ public class UseTemplateStep extends CompositeStep { } } - @SuppressWarnings("unused") public static List getParamSpecs() { String templateName = (String) EditContext.get().getInputValue(PROP_TEMPLATE_NAME); if (templateName != null) { diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/commandinterpreter/DefaultInterpreter.java b/server-core/src/main/java/io/onedev/server/buildspec/step/commandinterpreter/DefaultInterpreter.java index 104e24fad8..06ed45a849 100644 --- a/server-core/src/main/java/io/onedev/server/buildspec/step/commandinterpreter/DefaultInterpreter.java +++ b/server-core/src/main/java/io/onedev/server/buildspec/step/commandinterpreter/DefaultInterpreter.java @@ -1,5 +1,10 @@ package io.onedev.server.buildspec.step.commandinterpreter; +import java.util.List; +import java.util.Map; + +import javax.validation.constraints.NotEmpty; + import io.onedev.k8shelper.CommandFacade; import io.onedev.k8shelper.RegistryLoginFacade; import io.onedev.server.annotation.Code; @@ -7,11 +12,6 @@ import io.onedev.server.annotation.Editable; import io.onedev.server.annotation.Interpolative; import io.onedev.server.model.support.administration.jobexecutor.JobExecutor; -import javax.validation.constraints.NotEmpty; -import java.util.HashMap; -import java.util.List; -import java.util.Map; - @Editable(order=100, name="Default (Shell on Linux, Batch on Windows)") public class DefaultInterpreter extends Interpreter { diff --git a/server-core/src/main/java/io/onedev/server/cluster/ClusterResource.java b/server-core/src/main/java/io/onedev/server/cluster/ClusterResource.java index 21a903f7c6..6f0d8b6a89 100644 --- a/server-core/src/main/java/io/onedev/server/cluster/ClusterResource.java +++ b/server-core/src/main/java/io/onedev/server/cluster/ClusterResource.java @@ -1,7 +1,43 @@ package io.onedev.server.cluster; +import static io.onedev.commons.utils.LockUtils.read; +import static io.onedev.commons.utils.LockUtils.write; +import static io.onedev.server.model.Build.getArtifactsLockName; +import static io.onedev.server.model.Project.SHARE_TEST_DIR; +import static io.onedev.server.util.IOUtils.BUFFER_SIZE; +import static javax.ws.rs.core.Response.ok; +import static javax.ws.rs.core.Response.status; +import static javax.ws.rs.core.Response.Status.NO_CONTENT; + +import java.io.BufferedOutputStream; +import java.io.File; +import java.io.FileInputStream; +import java.io.FileOutputStream; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.util.Map; +import java.util.concurrent.ExecutionException; + +import javax.inject.Inject; +import javax.inject.Singleton; +import javax.ws.rs.Consumes; +import javax.ws.rs.GET; +import javax.ws.rs.POST; +import javax.ws.rs.Path; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import javax.ws.rs.core.StreamingOutput; + +import org.apache.shiro.authz.UnauthorizedException; +import org.eclipse.jgit.lib.ObjectId; +import org.eclipse.jgit.lib.Repository; + import com.google.common.base.Splitter; import com.google.common.collect.Sets; + import io.onedev.commons.utils.FileUtils; import io.onedev.commons.utils.TarUtils; import io.onedev.server.OneDev; @@ -22,34 +58,12 @@ import io.onedev.server.model.PackBlob; import io.onedev.server.model.Project; import io.onedev.server.rest.annotation.Api; import io.onedev.server.security.SecurityUtils; +import io.onedev.server.util.IOUtils; import io.onedev.server.util.concurrent.PrioritizedRunnable; import io.onedev.server.util.concurrent.WorkExecutor; import io.onedev.server.util.patternset.PatternSet; import io.onedev.server.xodus.CommitInfoManager; import io.onedev.server.xodus.VisitInfoManager; -import org.apache.commons.compress.utils.IOUtils; -import org.apache.shiro.authz.UnauthorizedException; -import org.eclipse.jgit.lib.ObjectId; -import org.eclipse.jgit.lib.Repository; - -import javax.inject.Inject; -import javax.inject.Singleton; -import javax.ws.rs.*; -import javax.ws.rs.core.MediaType; -import javax.ws.rs.core.Response; -import javax.ws.rs.core.StreamingOutput; -import java.io.*; -import java.util.Map; -import java.util.concurrent.ExecutionException; - -import static io.onedev.commons.utils.LockUtils.read; -import static io.onedev.commons.utils.LockUtils.write; -import static io.onedev.server.model.Build.getArtifactsLockName; -import static io.onedev.server.model.Project.SHARE_TEST_DIR; -import static io.onedev.server.util.IOUtils.BUFFER_SIZE; -import static javax.ws.rs.core.Response.Status.NO_CONTENT; -import static javax.ws.rs.core.Response.ok; -import static javax.ws.rs.core.Response.status; @Api(internal=true) @Path("/cluster") diff --git a/server-core/src/main/java/io/onedev/server/codequality/ProblemTarget.java b/server-core/src/main/java/io/onedev/server/codequality/ProblemTarget.java index 6d1669fa88..b05966d74d 100644 --- a/server-core/src/main/java/io/onedev/server/codequality/ProblemTarget.java +++ b/server-core/src/main/java/io/onedev/server/codequality/ProblemTarget.java @@ -1,10 +1,9 @@ package io.onedev.server.codequality; -import io.onedev.server.model.Group; -import org.apache.wicket.Component; - import java.io.Serializable; +import org.apache.wicket.Component; + public abstract class ProblemTarget implements Serializable { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/commandhandler/BackupDatabase.java b/server-core/src/main/java/io/onedev/server/commandhandler/BackupDatabase.java index 4991db5baf..394a7e7b19 100644 --- a/server-core/src/main/java/io/onedev/server/commandhandler/BackupDatabase.java +++ b/server-core/src/main/java/io/onedev/server/commandhandler/BackupDatabase.java @@ -29,9 +29,7 @@ public class BackupDatabase extends CommandHandler { private final DataManager dataManager; private final SessionFactoryManager sessionFactoryManager; - - private final HibernateConfig hibernateConfig; - + private File backupFile; @Inject @@ -40,7 +38,6 @@ public class BackupDatabase extends CommandHandler { super(hibernateConfig); this.dataManager = dataManager; this.sessionFactoryManager = sessionFactoryManager; - this.hibernateConfig = hibernateConfig; } @Override diff --git a/server-core/src/main/java/io/onedev/server/commandhandler/CheckDataVersion.java b/server-core/src/main/java/io/onedev/server/commandhandler/CheckDataVersion.java index 9df44ce97d..891b5a891f 100644 --- a/server-core/src/main/java/io/onedev/server/commandhandler/CheckDataVersion.java +++ b/server-core/src/main/java/io/onedev/server/commandhandler/CheckDataVersion.java @@ -1,18 +1,20 @@ package io.onedev.server.commandhandler; -import io.onedev.commons.utils.ExplicitException; -import io.onedev.server.persistence.HibernateConfig; -import io.onedev.server.data.DataManager; -import io.onedev.server.persistence.SessionFactoryManager; -import io.onedev.server.security.SecurityUtils; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; +import static io.onedev.server.persistence.PersistenceUtils.callWithTransaction; + +import java.sql.SQLException; import javax.inject.Inject; import javax.inject.Singleton; -import java.sql.SQLException; -import static io.onedev.server.persistence.PersistenceUtils.callWithTransaction; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import io.onedev.commons.utils.ExplicitException; +import io.onedev.server.data.DataManager; +import io.onedev.server.persistence.HibernateConfig; +import io.onedev.server.persistence.SessionFactoryManager; +import io.onedev.server.security.SecurityUtils; @Singleton public class CheckDataVersion extends CommandHandler { @@ -24,16 +26,13 @@ public class CheckDataVersion extends CommandHandler { private final SessionFactoryManager sessionFactoryManager; private final DataManager dataManager; - - private final HibernateConfig hibernateConfig; - + @Inject public CheckDataVersion(SessionFactoryManager sessionFactoryManager, DataManager dataManager, HibernateConfig hibernateConfig) { super(hibernateConfig); this.sessionFactoryManager = sessionFactoryManager; this.dataManager = dataManager; - this.hibernateConfig = hibernateConfig; } @Override diff --git a/server-core/src/main/java/io/onedev/server/data/DefaultDataManager.java b/server-core/src/main/java/io/onedev/server/data/DefaultDataManager.java index c39a09bbc2..764991e387 100644 --- a/server-core/src/main/java/io/onedev/server/data/DefaultDataManager.java +++ b/server-core/src/main/java/io/onedev/server/data/DefaultDataManager.java @@ -1,42 +1,46 @@ package io.onedev.server.data; -import com.google.common.base.Preconditions; -import com.google.common.collect.Lists; -import com.google.common.collect.Sets; -import io.onedev.commons.bootstrap.Bootstrap; -import io.onedev.commons.loader.ManagedSerializedForm; -import io.onedev.commons.utils.*; -import io.onedev.server.OneDev; -import io.onedev.server.cluster.ClusterManager; -import io.onedev.server.cluster.ClusterRunnable; -import io.onedev.server.cluster.ClusterTask; -import io.onedev.server.commandhandler.Upgrade; -import io.onedev.server.data.migration.DataMigrator; -import io.onedev.server.data.migration.MigrationHelper; -import io.onedev.server.data.migration.VersionedXmlDoc; -import io.onedev.server.entitymanager.*; -import io.onedev.server.event.Listen; -import io.onedev.server.event.entity.EntityPersisted; -import io.onedev.server.event.system.SystemStarted; -import io.onedev.server.mail.MailManager; -import io.onedev.server.model.*; -import io.onedev.server.model.Setting.Key; -import io.onedev.server.model.support.administration.*; -import io.onedev.server.model.support.administration.emailtemplates.EmailTemplates; -import io.onedev.server.model.support.issue.LinkSpecOpposite; -import io.onedev.server.persistence.HibernateConfig; -import io.onedev.server.persistence.PersistenceUtils; -import io.onedev.server.persistence.SessionFactoryManager; -import io.onedev.server.persistence.TransactionManager; -import io.onedev.server.persistence.annotation.Sessional; -import io.onedev.server.persistence.annotation.Transactional; -import io.onedev.server.persistence.dao.Dao; -import io.onedev.server.ssh.SshKeyUtils; -import io.onedev.server.taskschedule.SchedulableTask; -import io.onedev.server.taskschedule.TaskScheduler; -import io.onedev.server.util.BeanUtils; -import io.onedev.server.util.init.ManualConfig; -import io.onedev.server.web.util.editbean.NewUserBean; +import static com.google.common.base.Throwables.getStackTraceAsString; +import static io.onedev.server.model.User.PROP_DISABLE_WATCH_NOTIFICATIONS; +import static io.onedev.server.model.User.PROP_NOTIFY_OWN_EVENTS; +import static io.onedev.server.model.support.administration.SystemSetting.PROP_CURL_LOCATION; +import static io.onedev.server.model.support.administration.SystemSetting.PROP_DISABLE_AUTO_UPDATE_CHECK; +import static io.onedev.server.model.support.administration.SystemSetting.PROP_GIT_LOCATION; +import static io.onedev.server.model.support.administration.SystemSetting.PROP_SSH_ROOT_URL; +import static io.onedev.server.model.support.administration.SystemSetting.PROP_USE_AVATAR_SERVICE; +import static io.onedev.server.persistence.PersistenceUtils.tableExists; +import static org.unbescape.html.HtmlEscape.escapeHtml5; + +import java.io.File; +import java.io.IOException; +import java.io.ObjectStreamException; +import java.io.Serializable; +import java.lang.reflect.Field; +import java.nio.charset.Charset; +import java.nio.charset.StandardCharsets; +import java.sql.Connection; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.Statement; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.EnumSet; +import java.util.HashSet; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.UUID; +import java.util.stream.Collectors; + +import javax.inject.Inject; +import javax.inject.Singleton; +import javax.persistence.JoinColumn; +import javax.persistence.ManyToOne; +import javax.persistence.criteria.CriteriaBuilder; +import javax.persistence.criteria.CriteriaQuery; +import javax.persistence.criteria.Root; +import javax.validation.Validator; + import org.apache.shiro.authc.credential.PasswordService; import org.dom4j.DocumentHelper; import org.dom4j.Element; @@ -57,35 +61,73 @@ import org.quartz.ScheduleBuilder; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import javax.inject.Inject; -import javax.inject.Singleton; -import javax.persistence.JoinColumn; -import javax.persistence.ManyToOne; -import javax.persistence.criteria.CriteriaBuilder; -import javax.persistence.criteria.CriteriaQuery; -import javax.persistence.criteria.Root; -import javax.validation.ConstraintViolation; -import javax.validation.Validator; -import java.io.File; -import java.io.IOException; -import java.io.ObjectStreamException; -import java.io.Serializable; -import java.lang.reflect.Field; -import java.nio.charset.Charset; -import java.nio.charset.StandardCharsets; -import java.sql.Connection; -import java.sql.ResultSet; -import java.sql.SQLException; -import java.sql.Statement; -import java.util.*; -import java.util.stream.Collectors; +import com.google.common.base.Preconditions; +import com.google.common.collect.Lists; +import com.google.common.collect.Sets; -import static com.google.common.base.Throwables.getStackTraceAsString; -import static io.onedev.server.model.User.PROP_DISABLE_WATCH_NOTIFICATIONS; -import static io.onedev.server.model.User.PROP_NOTIFY_OWN_EVENTS; -import static io.onedev.server.model.support.administration.SystemSetting.*; -import static io.onedev.server.persistence.PersistenceUtils.tableExists; -import static org.unbescape.html.HtmlEscape.escapeHtml5; +import io.onedev.commons.bootstrap.Bootstrap; +import io.onedev.commons.loader.ManagedSerializedForm; +import io.onedev.commons.utils.ExceptionUtils; +import io.onedev.commons.utils.ExplicitException; +import io.onedev.commons.utils.FileUtils; +import io.onedev.commons.utils.StringUtils; +import io.onedev.commons.utils.ZipUtils; +import io.onedev.server.OneDev; +import io.onedev.server.cluster.ClusterManager; +import io.onedev.server.cluster.ClusterRunnable; +import io.onedev.server.cluster.ClusterTask; +import io.onedev.server.commandhandler.Upgrade; +import io.onedev.server.data.migration.DataMigrator; +import io.onedev.server.data.migration.MigrationHelper; +import io.onedev.server.data.migration.VersionedXmlDoc; +import io.onedev.server.entitymanager.AlertManager; +import io.onedev.server.entitymanager.EmailAddressManager; +import io.onedev.server.entitymanager.LinkSpecManager; +import io.onedev.server.entitymanager.RoleManager; +import io.onedev.server.entitymanager.SettingManager; +import io.onedev.server.entitymanager.UserManager; +import io.onedev.server.event.Listen; +import io.onedev.server.event.entity.EntityPersisted; +import io.onedev.server.event.system.SystemStarted; +import io.onedev.server.model.AbstractEntity; +import io.onedev.server.model.EmailAddress; +import io.onedev.server.model.LinkSpec; +import io.onedev.server.model.ModelVersion; +import io.onedev.server.model.Role; +import io.onedev.server.model.Setting; +import io.onedev.server.model.Setting.Key; +import io.onedev.server.model.User; +import io.onedev.server.model.support.administration.AgentSetting; +import io.onedev.server.model.support.administration.AlertSetting; +import io.onedev.server.model.support.administration.BackupSetting; +import io.onedev.server.model.support.administration.BrandingSetting; +import io.onedev.server.model.support.administration.ClusterSetting; +import io.onedev.server.model.support.administration.GlobalBuildSetting; +import io.onedev.server.model.support.administration.GlobalIssueSetting; +import io.onedev.server.model.support.administration.GlobalPackSetting; +import io.onedev.server.model.support.administration.GlobalProjectSetting; +import io.onedev.server.model.support.administration.GlobalPullRequestSetting; +import io.onedev.server.model.support.administration.GpgSetting; +import io.onedev.server.model.support.administration.PerformanceSetting; +import io.onedev.server.model.support.administration.SecuritySetting; +import io.onedev.server.model.support.administration.ServiceDeskSetting; +import io.onedev.server.model.support.administration.SshSetting; +import io.onedev.server.model.support.administration.SystemSetting; +import io.onedev.server.model.support.administration.emailtemplates.EmailTemplates; +import io.onedev.server.model.support.issue.LinkSpecOpposite; +import io.onedev.server.persistence.HibernateConfig; +import io.onedev.server.persistence.PersistenceUtils; +import io.onedev.server.persistence.SessionFactoryManager; +import io.onedev.server.persistence.TransactionManager; +import io.onedev.server.persistence.annotation.Sessional; +import io.onedev.server.persistence.annotation.Transactional; +import io.onedev.server.persistence.dao.Dao; +import io.onedev.server.ssh.SshKeyUtils; +import io.onedev.server.taskschedule.SchedulableTask; +import io.onedev.server.taskschedule.TaskScheduler; +import io.onedev.server.util.BeanUtils; +import io.onedev.server.util.init.ManualConfig; +import io.onedev.server.web.util.editbean.NewUserBean; @Singleton public class DefaultDataManager implements DataManager, Serializable { @@ -119,9 +161,7 @@ public class DefaultDataManager implements DataManager, Serializable { private final UserManager userManager; private final SettingManager settingManager; - - private final MailManager mailManager; - + private final PasswordService passwordService; private final TaskScheduler taskScheduler; @@ -143,7 +183,7 @@ public class DefaultDataManager implements DataManager, Serializable { @Inject public DefaultDataManager(PhysicalNamingStrategy physicalNamingStrategy, HibernateConfig hibernateConfig, Validator validator, Dao dao, SessionFactoryManager sessionFactoryManager, - SettingManager settingManager, MailManager mailManager, TaskScheduler taskScheduler, + SettingManager settingManager, TaskScheduler taskScheduler, PasswordService passwordService, RoleManager roleManager, LinkSpecManager linkSpecManager, EmailAddressManager emailAddressManager, UserManager userManager, ClusterManager clusterManager, TransactionManager transactionManager, AlertManager alertManager) { @@ -156,7 +196,6 @@ public class DefaultDataManager implements DataManager, Serializable { this.userManager = userManager; this.settingManager = settingManager; this.taskScheduler = taskScheduler; - this.mailManager = mailManager; this.passwordService = passwordService; this.roleManager = roleManager; this.linkSpecManager = linkSpecManager; @@ -468,13 +507,7 @@ public class DefaultDataManager implements DataManager, Serializable { } } } - - private void reportError(AbstractEntity entity, ConstraintViolation violation) { - String errorInfo = String.format("Error validating entity (entity class: %s, entity id: %d, entity property: %s, error message: %s)", - entity.getClass(), entity.getId(), violation.getPropertyPath().toString(), violation.getMessage()); - throw new RuntimeException(errorInfo); - } - + @Override public void applyConstraints(Connection conn) { File tempFile = null; @@ -606,7 +639,6 @@ public class DefaultDataManager implements DataManager, Serializable { emailAddressManager.update(primaryEmailAddress); } - @SuppressWarnings({"serial"}) @Transactional @Override public List checkData() { diff --git a/server-core/src/main/java/io/onedev/server/data/migration/DataMigrator.java b/server-core/src/main/java/io/onedev/server/data/migration/DataMigrator.java index 8686068361..05da04f142 100644 --- a/server-core/src/main/java/io/onedev/server/data/migration/DataMigrator.java +++ b/server-core/src/main/java/io/onedev/server/data/migration/DataMigrator.java @@ -6754,7 +6754,7 @@ public class DataMigrator { submitTimeGroupsElement.addElement("week").setText(String.valueOf(DateUtils.toLocalDate(submitDate).with(TemporalAdjusters.previousOrSame(DayOfWeek.MONDAY)).toEpochDay())); submitTimeGroupsElement.addElement("month").setText(String.valueOf(DateUtils.toLocalDate(submitDate).with(TemporalAdjusters.firstDayOfMonth()).toEpochDay())); - if (!element.element("status").equals("OPEN")) { + if (!element.elementTextTrim("status").equals("OPEN")) { var closeDate = parseDate(element.element("lastActivity").elementText("date").trim()); element.addElement("closeDate").addAttribute("class", "sql-timestamp").setText(formatDate(closeDate)); element.addElement("duration").setText(String.valueOf(closeDate.getTime() - submitDate.getTime())); diff --git a/server-core/src/main/java/io/onedev/server/data/migration/VersionedXmlDoc.java b/server-core/src/main/java/io/onedev/server/data/migration/VersionedXmlDoc.java index 9e507ee490..7439a7aeb7 100644 --- a/server-core/src/main/java/io/onedev/server/data/migration/VersionedXmlDoc.java +++ b/server-core/src/main/java/io/onedev/server/data/migration/VersionedXmlDoc.java @@ -577,6 +577,7 @@ public final class VersionedXmlDoc implements Document, Externalizable { } } + @SuppressWarnings("unchecked") public static T cloneBean(T bean) { return (T) VersionedXmlDoc.fromBean(bean).toBean(); } diff --git a/server-core/src/main/java/io/onedev/server/entitymanager/IssueScheduleManager.java b/server-core/src/main/java/io/onedev/server/entitymanager/IssueScheduleManager.java index 35ab498908..794925d5f6 100644 --- a/server-core/src/main/java/io/onedev/server/entitymanager/IssueScheduleManager.java +++ b/server-core/src/main/java/io/onedev/server/entitymanager/IssueScheduleManager.java @@ -1,7 +1,6 @@ package io.onedev.server.entitymanager; import java.util.Collection; -import java.util.List; import io.onedev.server.model.Issue; import io.onedev.server.model.IssueSchedule; diff --git a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultAgentManager.java b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultAgentManager.java index d0bc0eb2de..a035e88b42 100644 --- a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultAgentManager.java +++ b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultAgentManager.java @@ -133,6 +133,7 @@ public class DefaultAgentManager extends BaseEntityManager implements Age var cacheInited = hazelcastInstance.getCPSubsystem().getAtomicLong("agentCacheInited"); clusterManager.init(cacheInited, () -> { + @SuppressWarnings("unchecked") Query query = dao.getSession().createQuery(String.format("select %s, %s from Agent", Agent.PROP_OS_NAME, Agent.PROP_OS_ARCH)); for (Object[] row: query.list()) { diff --git a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultAgentTokenManager.java b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultAgentTokenManager.java index e4c893eebc..b25f987090 100644 --- a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultAgentTokenManager.java +++ b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultAgentTokenManager.java @@ -1,6 +1,14 @@ package io.onedev.server.entitymanager.impl; -import com.google.common.base.Preconditions; +import static java.util.stream.Collectors.toSet; + +import java.util.List; + +import javax.inject.Inject; +import javax.inject.Singleton; + +import org.hibernate.criterion.Restrictions; + import io.onedev.server.entitymanager.AgentManager; import io.onedev.server.entitymanager.AgentTokenManager; import io.onedev.server.model.Agent; @@ -10,13 +18,6 @@ import io.onedev.server.persistence.annotation.Transactional; import io.onedev.server.persistence.dao.BaseEntityManager; import io.onedev.server.persistence.dao.Dao; import io.onedev.server.persistence.dao.EntityCriteria; -import org.hibernate.criterion.Restrictions; - -import javax.inject.Inject; -import javax.inject.Singleton; -import java.util.List; - -import static java.util.stream.Collectors.toSet; @Singleton public class DefaultAgentTokenManager extends BaseEntityManager implements AgentTokenManager { @@ -43,7 +44,6 @@ public class DefaultAgentTokenManager extends BaseEntityManager impl return find(criteria); } - @SuppressWarnings("unchecked") @Sessional @Override public List queryUnused() { @@ -53,7 +53,6 @@ public class DefaultAgentTokenManager extends BaseEntityManager impl return tokens; } - @SuppressWarnings("unchecked") @Transactional @Override public void deleteUnused() { diff --git a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultBuildMetricManager.java b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultBuildMetricManager.java index 15d7d84c30..9c146e43c3 100644 --- a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultBuildMetricManager.java +++ b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultBuildMetricManager.java @@ -74,7 +74,6 @@ public class DefaultBuildMetricManager implements BuildMetricManager { return dao.find(criteria); } - @SuppressWarnings("resource") @Sessional @Override public Map queryStats(Project project, Class metricClass, BuildMetricQuery query) { diff --git a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultIssueQueryPersonalizationManager.java b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultIssueQueryPersonalizationManager.java index e623a80def..03c940a432 100644 --- a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultIssueQueryPersonalizationManager.java +++ b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultIssueQueryPersonalizationManager.java @@ -1,6 +1,18 @@ package io.onedev.server.entitymanager.impl; -import com.google.common.base.Preconditions; +import static io.onedev.server.model.AbstractEntity.PROP_ID; +import static io.onedev.server.model.IssueQueryPersonalization.PROP_PROJECT; + +import java.util.Collection; +import java.util.HashSet; +import java.util.stream.Collectors; + +import javax.inject.Inject; +import javax.inject.Singleton; +import javax.persistence.criteria.CriteriaBuilder; + +import org.hibernate.criterion.Restrictions; + import io.onedev.server.entitymanager.IssueQueryPersonalizationManager; import io.onedev.server.entitymanager.ProjectManager; import io.onedev.server.model.IssueQueryPersonalization; @@ -13,17 +25,6 @@ import io.onedev.server.persistence.dao.BaseEntityManager; import io.onedev.server.persistence.dao.Dao; import io.onedev.server.persistence.dao.EntityCriteria; import io.onedev.server.util.ProjectScope; -import org.hibernate.criterion.Restrictions; - -import javax.inject.Inject; -import javax.inject.Singleton; -import javax.persistence.criteria.CriteriaBuilder; -import java.util.Collection; -import java.util.HashSet; -import java.util.stream.Collectors; - -import static io.onedev.server.model.AbstractEntity.PROP_ID; -import static io.onedev.server.model.IssueQueryPersonalization.PROP_PROJECT; @Singleton public class DefaultIssueQueryPersonalizationManager extends BaseEntityManager diff --git a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultIssueWorkManager.java b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultIssueWorkManager.java index b66de009d7..c278bb5064 100644 --- a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultIssueWorkManager.java +++ b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultIssueWorkManager.java @@ -52,6 +52,7 @@ public class DefaultIssueWorkManager extends BaseEntityManager implem dao.persist(work); } + @SuppressWarnings("unchecked") @Sessional @Override public List query(ProjectScope projectScope, EntityQuery issueQuery, long fromDay, long toDay) { diff --git a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultJobCacheManager.java b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultJobCacheManager.java index bd8e2ba12c..30fedef8bd 100644 --- a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultJobCacheManager.java +++ b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultJobCacheManager.java @@ -167,6 +167,7 @@ public class DefaultJobCacheManager extends BaseEntityManager }); } + @SuppressWarnings("resource") @Nullable private InputStream openCacheInputStream(Long projectId, Long cacheId, List cachePaths) { var cacheHome = projectManager.getCacheDir(projectId); diff --git a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultPackBlobReferenceManager.java b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultPackBlobReferenceManager.java index 0d7d8bf5d3..c01b6b62bd 100644 --- a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultPackBlobReferenceManager.java +++ b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultPackBlobReferenceManager.java @@ -1,6 +1,20 @@ package io.onedev.server.entitymanager.impl; +import static io.onedev.server.model.Pack.PROP_PROJECT; +import static io.onedev.server.model.PackBlobReference.PROP_PACK; +import static io.onedev.server.model.PackBlobReference.PROP_PACK_BLOB; +import static io.onedev.server.model.Project.PROP_PENDING_DELETE; + +import java.io.ObjectStreamException; +import java.io.Serializable; + +import javax.inject.Inject; +import javax.inject.Singleton; + +import org.hibernate.criterion.Restrictions; + import com.google.common.base.Preconditions; + import io.onedev.commons.loader.ManagedSerializedForm; import io.onedev.server.entitymanager.PackBlobReferenceManager; import io.onedev.server.model.Pack; @@ -9,20 +23,6 @@ import io.onedev.server.model.PackBlobReference; import io.onedev.server.persistence.annotation.Transactional; import io.onedev.server.persistence.dao.BaseEntityManager; import io.onedev.server.persistence.dao.Dao; -import org.hibernate.criterion.Restrictions; - -import javax.inject.Inject; -import javax.inject.Singleton; -import javax.persistence.criteria.CriteriaBuilder; -import javax.persistence.criteria.CriteriaDelete; -import javax.persistence.criteria.Root; -import java.io.ObjectStreamException; -import java.io.Serializable; - -import static io.onedev.server.model.Pack.PROP_PROJECT; -import static io.onedev.server.model.PackBlobReference.PROP_PACK; -import static io.onedev.server.model.PackBlobReference.PROP_PACK_BLOB; -import static io.onedev.server.model.Project.PROP_PENDING_DELETE; @Singleton public class DefaultPackBlobReferenceManager extends BaseEntityManager diff --git a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultPackManager.java b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultPackManager.java index 24c45e43ae..9c37a7190d 100644 --- a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultPackManager.java +++ b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultPackManager.java @@ -322,6 +322,7 @@ public class DefaultPackManager extends BaseEntityManager return query(criteria); } + @SuppressWarnings("unchecked") @Sessional @Override public List queryLatests(Project project, String type, String nameQuery, diff --git a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultUserManager.java b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultUserManager.java index 5c101c497c..5c231dad62 100644 --- a/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultUserManager.java +++ b/server-core/src/main/java/io/onedev/server/entitymanager/impl/DefaultUserManager.java @@ -1,9 +1,29 @@ package io.onedev.server.entitymanager.impl; +import java.util.Collection; +import java.util.List; + +import javax.inject.Inject; +import javax.inject.Singleton; +import javax.persistence.criteria.CriteriaBuilder; +import javax.persistence.criteria.CriteriaQuery; +import javax.persistence.criteria.Predicate; +import javax.persistence.criteria.Root; +import javax.persistence.criteria.Subquery; + +import org.hibernate.ReplicationMode; +import org.hibernate.criterion.Restrictions; +import org.hibernate.query.Query; + import com.google.common.base.Preconditions; import com.hazelcast.core.HazelcastInstance; + import io.onedev.server.cluster.ClusterManager; -import io.onedev.server.entitymanager.*; +import io.onedev.server.entitymanager.EmailAddressManager; +import io.onedev.server.entitymanager.IssueFieldManager; +import io.onedev.server.entitymanager.ProjectManager; +import io.onedev.server.entitymanager.SettingManager; +import io.onedev.server.entitymanager.UserManager; import io.onedev.server.event.Listen; import io.onedev.server.event.entity.EntityPersisted; import io.onedev.server.event.entity.EntityRemoved; @@ -24,16 +44,6 @@ import io.onedev.server.persistence.dao.EntityCriteria; import io.onedev.server.util.facade.UserCache; import io.onedev.server.util.facade.UserFacade; import io.onedev.server.util.usage.Usage; -import org.apache.shiro.authc.credential.PasswordService; -import org.hibernate.ReplicationMode; -import org.hibernate.criterion.Restrictions; -import org.hibernate.query.Query; - -import javax.inject.Inject; -import javax.inject.Singleton; -import javax.persistence.criteria.*; -import java.util.Collection; -import java.util.List; @Singleton public class DefaultUserManager extends BaseEntityManager implements UserManager { @@ -47,23 +57,18 @@ public class DefaultUserManager extends BaseEntityManager implements UserM private final IdManager idManager; private final EmailAddressManager emailAddressManager; - - private final GroupManager groupManager; - + private final TransactionManager transactionManager; private final ClusterManager clusterManager; - - private final PasswordService passwordService; - + private volatile UserCache cache; @Inject public DefaultUserManager(Dao dao, ProjectManager projectManager, SettingManager settingManager, IssueFieldManager issueFieldManager, IdManager idManager, - GroupManager groupManager, EmailAddressManager emailAddressManager, - TransactionManager transactionManager, ClusterManager clusterManager, - PasswordService passwordService) { + EmailAddressManager emailAddressManager, TransactionManager transactionManager, + ClusterManager clusterManager) { super(dao); this.projectManager = projectManager; @@ -72,9 +77,7 @@ public class DefaultUserManager extends BaseEntityManager implements UserM this.idManager = idManager; this.emailAddressManager = emailAddressManager; this.transactionManager = transactionManager; - this.groupManager = groupManager; this.clusterManager = clusterManager; - this.passwordService = passwordService; } @Transactional diff --git a/server-core/src/main/java/io/onedev/server/entityreference/ReferenceUtils.java b/server-core/src/main/java/io/onedev/server/entityreference/ReferenceUtils.java index 100ea7b75e..baf9305727 100644 --- a/server-core/src/main/java/io/onedev/server/entityreference/ReferenceUtils.java +++ b/server-core/src/main/java/io/onedev/server/entityreference/ReferenceUtils.java @@ -1,6 +1,24 @@ package io.onedev.server.entityreference; +import static java.lang.String.format; +import static java.util.regex.Pattern.CASE_INSENSITIVE; +import static java.util.regex.Pattern.compile; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Set; +import java.util.function.BiFunction; +import java.util.regex.Pattern; + +import javax.annotation.Nullable; + +import org.jsoup.nodes.Document; +import org.jsoup.select.NodeTraversor; + import com.google.common.collect.ImmutableSet; + import io.onedev.commons.utils.StringUtils; import io.onedev.server.OneDev; import io.onedev.server.entitymanager.ProjectManager; @@ -9,18 +27,6 @@ import io.onedev.server.util.HtmlUtils; import io.onedev.server.util.TextNodeVisitor; import io.onedev.server.validation.validator.ProjectKeyValidator; import io.onedev.server.validation.validator.ProjectPathValidator; -import org.jsoup.nodes.Document; -import org.jsoup.nodes.TextNode; -import org.jsoup.select.NodeTraversor; - -import javax.annotation.Nullable; -import java.util.*; -import java.util.function.BiFunction; -import java.util.regex.Pattern; - -import static java.lang.String.format; -import static java.util.regex.Pattern.CASE_INSENSITIVE; -import static java.util.regex.Pattern.compile; public class ReferenceUtils { diff --git a/server-core/src/main/java/io/onedev/server/event/project/pack/PackEvent.java b/server-core/src/main/java/io/onedev/server/event/project/pack/PackEvent.java index 6d1d578c88..e4e71a206d 100644 --- a/server-core/src/main/java/io/onedev/server/event/project/pack/PackEvent.java +++ b/server-core/src/main/java/io/onedev/server/event/project/pack/PackEvent.java @@ -1,16 +1,13 @@ package io.onedev.server.event.project.pack; +import java.util.Date; + import io.onedev.server.OneDev; -import io.onedev.server.entitymanager.CodeCommentManager; import io.onedev.server.entitymanager.PackManager; import io.onedev.server.event.project.ProjectEvent; -import io.onedev.server.model.CodeComment; import io.onedev.server.model.Pack; -import io.onedev.server.model.User; import io.onedev.server.web.UrlManager; -import java.util.Date; - public abstract class PackEvent extends ProjectEvent { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/exception/HttpResponseAwareException.java b/server-core/src/main/java/io/onedev/server/exception/HttpResponseAwareException.java index 8fed2534aa..c6a2d3cc6f 100644 --- a/server-core/src/main/java/io/onedev/server/exception/HttpResponseAwareException.java +++ b/server-core/src/main/java/io/onedev/server/exception/HttpResponseAwareException.java @@ -1,10 +1,10 @@ package io.onedev.server.exception; -import io.onedev.commons.utils.ExplicitException; +import java.util.Map; + import org.eclipse.jetty.http.HttpStatus; -import javax.annotation.Nullable; -import java.util.Map; +import io.onedev.commons.utils.ExplicitException; public class HttpResponseAwareException extends ExplicitException { diff --git a/server-core/src/main/java/io/onedev/server/exception/handler/ServerNotReadyExceptionHandler.java b/server-core/src/main/java/io/onedev/server/exception/handler/ServerNotReadyExceptionHandler.java index 1ab33b790a..5e27bc6f97 100644 --- a/server-core/src/main/java/io/onedev/server/exception/handler/ServerNotReadyExceptionHandler.java +++ b/server-core/src/main/java/io/onedev/server/exception/handler/ServerNotReadyExceptionHandler.java @@ -1,11 +1,9 @@ package io.onedev.server.exception.handler; -import io.onedev.server.exception.HttpResponse; -import io.onedev.server.exception.ServerNotReadyException; - import javax.servlet.http.HttpServletResponse; -import static javax.ws.rs.core.MediaType.TEXT_PLAIN; +import io.onedev.server.exception.HttpResponse; +import io.onedev.server.exception.ServerNotReadyException; public class ServerNotReadyExceptionHandler extends AbstractExceptionHandler { diff --git a/server-core/src/main/java/io/onedev/server/exception/handler/UnauthenticatedExceptionHandler.java b/server-core/src/main/java/io/onedev/server/exception/handler/UnauthenticatedExceptionHandler.java index fcb71028f1..d38e3fe841 100644 --- a/server-core/src/main/java/io/onedev/server/exception/handler/UnauthenticatedExceptionHandler.java +++ b/server-core/src/main/java/io/onedev/server/exception/handler/UnauthenticatedExceptionHandler.java @@ -1,17 +1,14 @@ package io.onedev.server.exception.handler; -import io.onedev.server.exception.HttpResponse; -import io.onedev.server.exception.HttpResponseBody; -import org.apache.shiro.authz.UnauthenticatedException; - import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import javax.ws.rs.core.MultivaluedHashMap; import javax.ws.rs.core.MultivaluedMap; -import java.util.HashMap; -import java.util.Map; -import static javax.ws.rs.core.MediaType.TEXT_PLAIN; +import org.apache.shiro.authz.UnauthenticatedException; + +import io.onedev.server.exception.HttpResponse; +import io.onedev.server.exception.HttpResponseBody; public class UnauthenticatedExceptionHandler extends AbstractExceptionHandler { diff --git a/server-core/src/main/java/io/onedev/server/git/BlobChange.java b/server-core/src/main/java/io/onedev/server/git/BlobChange.java index 0bbcad2735..9224b75b2e 100644 --- a/server-core/src/main/java/io/onedev/server/git/BlobChange.java +++ b/server-core/src/main/java/io/onedev/server/git/BlobChange.java @@ -20,7 +20,6 @@ import java.util.Collection; import java.util.HashSet; import java.util.List; -@SuppressWarnings("serial") public abstract class BlobChange implements Serializable { protected final ChangeType type; diff --git a/server-core/src/main/java/io/onedev/server/git/GitFilter.java b/server-core/src/main/java/io/onedev/server/git/GitFilter.java index be8f2ac453..1ccfb6db3c 100644 --- a/server-core/src/main/java/io/onedev/server/git/GitFilter.java +++ b/server-core/src/main/java/io/onedev/server/git/GitFilter.java @@ -1,5 +1,44 @@ package io.onedev.server.git; +import static io.onedev.server.model.Project.decodeFullRepoNameAsPath; +import static io.onedev.server.util.IOUtils.BUFFER_SIZE; +import static org.apache.commons.lang3.StringUtils.strip; + +import java.io.File; +import java.io.FilterInputStream; +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.util.Set; +import java.util.concurrent.ExecutionException; + +import javax.inject.Inject; +import javax.inject.Singleton; +import javax.servlet.Filter; +import javax.servlet.FilterChain; +import javax.servlet.FilterConfig; +import javax.servlet.ServletException; +import javax.servlet.ServletRequest; +import javax.servlet.ServletResponse; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; +import javax.ws.rs.client.Client; +import javax.ws.rs.client.ClientBuilder; +import javax.ws.rs.client.Entity; +import javax.ws.rs.client.Invocation; +import javax.ws.rs.client.WebTarget; +import javax.ws.rs.core.HttpHeaders; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import javax.ws.rs.core.StreamingOutput; + +import org.apache.commons.lang3.StringUtils; +import org.apache.shiro.authz.UnauthorizedException; +import org.eclipse.jgit.http.server.GitSmartHttpTools; +import org.eclipse.jgit.http.server.ServletUtils; +import org.eclipse.jgit.transport.PacketLineOut; +import org.glassfish.jersey.client.ClientProperties; + import io.onedev.commons.utils.ExplicitException; import io.onedev.k8shelper.KubernetesHelper; import io.onedev.server.OneDev; @@ -13,34 +52,10 @@ import io.onedev.server.model.Project; import io.onedev.server.persistence.SessionManager; import io.onedev.server.security.CodePullAuthorizationSource; import io.onedev.server.security.SecurityUtils; +import io.onedev.server.util.IOUtils; import io.onedev.server.util.OutputStreamWrapper; import io.onedev.server.util.concurrent.PrioritizedRunnable; import io.onedev.server.util.concurrent.WorkExecutor; -import org.apache.commons.compress.utils.IOUtils; -import org.apache.commons.lang3.StringUtils; -import org.apache.shiro.authz.UnauthorizedException; -import org.eclipse.jgit.http.server.GitSmartHttpTools; -import org.eclipse.jgit.http.server.ServletUtils; -import org.eclipse.jgit.transport.PacketLineOut; -import org.glassfish.jersey.client.ClientProperties; - -import javax.inject.Inject; -import javax.inject.Singleton; -import javax.servlet.*; -import javax.servlet.http.HttpServletRequest; -import javax.servlet.http.HttpServletResponse; -import javax.ws.rs.client.*; -import javax.ws.rs.core.HttpHeaders; -import javax.ws.rs.core.MediaType; -import javax.ws.rs.core.Response; -import javax.ws.rs.core.StreamingOutput; -import java.io.*; -import java.util.Set; -import java.util.concurrent.ExecutionException; - -import static io.onedev.server.model.Project.decodeFullRepoNameAsPath; -import static io.onedev.server.util.IOUtils.BUFFER_SIZE; -import static org.apache.commons.lang3.StringUtils.strip; @Singleton public class GitFilter implements Filter { diff --git a/server-core/src/main/java/io/onedev/server/git/GitLfsFilter.java b/server-core/src/main/java/io/onedev/server/git/GitLfsFilter.java index 810c230fbb..74343acb38 100644 --- a/server-core/src/main/java/io/onedev/server/git/GitLfsFilter.java +++ b/server-core/src/main/java/io/onedev/server/git/GitLfsFilter.java @@ -1,8 +1,65 @@ package io.onedev.server.git; +import static com.google.common.hash.Hashing.sha256; +import static io.onedev.k8shelper.KubernetesHelper.BEARER; +import static io.onedev.server.model.Project.decodeFullRepoNameAsPath; +import static io.onedev.server.util.CollectionUtils.newHashMap; +import static io.onedev.server.util.IOUtils.BUFFER_SIZE; +import static javax.servlet.http.HttpServletResponse.SC_CONFLICT; +import static javax.servlet.http.HttpServletResponse.SC_CREATED; +import static javax.servlet.http.HttpServletResponse.SC_FORBIDDEN; +import static javax.servlet.http.HttpServletResponse.SC_INTERNAL_SERVER_ERROR; +import static javax.servlet.http.HttpServletResponse.SC_NOT_ACCEPTABLE; +import static javax.servlet.http.HttpServletResponse.SC_NOT_FOUND; +import static javax.servlet.http.HttpServletResponse.SC_NOT_IMPLEMENTED; +import static javax.servlet.http.HttpServletResponse.SC_UNAUTHORIZED; +import static javax.ws.rs.core.HttpHeaders.AUTHORIZATION; +import static javax.ws.rs.core.MediaType.APPLICATION_OCTET_STREAM; +import static org.apache.commons.lang3.StringUtils.substringBeforeLast; +import static org.apache.tika.mime.MimeTypes.OCTET_STREAM; +import static org.glassfish.jersey.client.ClientProperties.REQUEST_ENTITY_PROCESSING; + +import java.io.IOException; +import java.io.InputStream; +import java.io.OutputStream; +import java.text.SimpleDateFormat; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.atomic.AtomicReference; +import java.util.function.BooleanSupplier; + +import javax.annotation.Nullable; +import javax.inject.Inject; +import javax.inject.Singleton; +import javax.servlet.Filter; +import javax.servlet.FilterChain; +import javax.servlet.FilterConfig; +import javax.servlet.ServletException; +import javax.servlet.ServletRequest; +import javax.servlet.ServletResponse; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; +import javax.ws.rs.client.Client; +import javax.ws.rs.client.ClientBuilder; +import javax.ws.rs.client.Entity; +import javax.ws.rs.client.Invocation; +import javax.ws.rs.client.WebTarget; +import javax.ws.rs.core.Response; +import javax.ws.rs.core.StreamingOutput; + +import org.apache.commons.codec.binary.Hex; +import org.apache.commons.lang3.StringUtils; +import org.hibernate.criterion.Restrictions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import com.fasterxml.jackson.databind.JsonNode; import com.fasterxml.jackson.databind.ObjectMapper; import com.google.common.hash.HashingInputStream; + import io.onedev.commons.utils.ExplicitException; import io.onedev.k8shelper.KubernetesHelper; import io.onedev.server.cluster.ClusterManager; @@ -15,42 +72,8 @@ import io.onedev.server.persistence.SessionManager; import io.onedev.server.persistence.dao.EntityCriteria; import io.onedev.server.security.CodePullAuthorizationSource; import io.onedev.server.security.SecurityUtils; +import io.onedev.server.util.IOUtils; import io.onedev.server.util.facade.ProjectFacade; -import org.apache.commons.codec.binary.Hex; -import org.apache.commons.compress.utils.IOUtils; -import org.apache.commons.lang3.StringUtils; -import org.hibernate.criterion.Restrictions; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -import javax.annotation.Nullable; -import javax.inject.Inject; -import javax.inject.Singleton; -import javax.servlet.*; -import javax.servlet.http.HttpServletRequest; -import javax.servlet.http.HttpServletResponse; -import javax.ws.rs.client.*; -import javax.ws.rs.core.Response; -import javax.ws.rs.core.StreamingOutput; -import java.io.IOException; -import java.io.InputStream; -import java.io.OutputStream; -import java.text.SimpleDateFormat; -import java.util.*; -import java.util.concurrent.atomic.AtomicReference; -import java.util.function.BooleanSupplier; - -import static com.google.common.hash.Hashing.sha256; -import static io.onedev.k8shelper.KubernetesHelper.BEARER; -import static io.onedev.server.model.Project.decodeFullRepoNameAsPath; -import static io.onedev.server.util.CollectionUtils.newHashMap; -import static io.onedev.server.util.IOUtils.BUFFER_SIZE; -import static javax.servlet.http.HttpServletResponse.*; -import static javax.ws.rs.core.HttpHeaders.AUTHORIZATION; -import static javax.ws.rs.core.MediaType.APPLICATION_OCTET_STREAM; -import static org.apache.commons.lang3.StringUtils.substringBeforeLast; -import static org.apache.tika.mime.MimeTypes.OCTET_STREAM; -import static org.glassfish.jersey.client.ClientProperties.REQUEST_ENTITY_PROCESSING; @Singleton public class GitLfsFilter implements Filter { diff --git a/server-core/src/main/java/io/onedev/server/git/command/FileChange.java b/server-core/src/main/java/io/onedev/server/git/command/FileChange.java index 5079872757..92adf612de 100644 --- a/server-core/src/main/java/io/onedev/server/git/command/FileChange.java +++ b/server-core/src/main/java/io/onedev/server/git/command/FileChange.java @@ -12,7 +12,6 @@ import io.onedev.commons.utils.match.Matcher; import io.onedev.commons.utils.match.PathMatcher; import io.onedev.server.util.patternset.PatternSet; -@SuppressWarnings("serial") public class FileChange implements Serializable { private final String oldPath; diff --git a/server-core/src/main/java/io/onedev/server/git/command/LogCommand.java b/server-core/src/main/java/io/onedev/server/git/command/LogCommand.java index 9b7cf2f73f..ac9abc663b 100644 --- a/server-core/src/main/java/io/onedev/server/git/command/LogCommand.java +++ b/server-core/src/main/java/io/onedev/server/git/command/LogCommand.java @@ -1,7 +1,11 @@ package io.onedev.server.git.command; import java.io.File; -import java.util.*; +import java.util.ArrayList; +import java.util.EnumSet; +import java.util.HashMap; +import java.util.Map; +import java.util.StringTokenizer; import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicReference; @@ -9,7 +13,6 @@ import org.eclipse.jgit.util.QuotedString; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import com.google.common.base.Preconditions; import com.google.common.base.Splitter; import io.onedev.commons.utils.command.Commandline; @@ -17,8 +20,6 @@ import io.onedev.commons.utils.command.LineConsumer; import io.onedev.server.git.CommandUtils; import io.onedev.server.git.GitUtils; -import javax.annotation.Nullable; - public abstract class LogCommand { private static final Logger logger = LoggerFactory.getLogger(LogCommand.class); diff --git a/server-core/src/main/java/io/onedev/server/git/hook/GitPostReceiveCallback.java b/server-core/src/main/java/io/onedev/server/git/hook/GitPostReceiveCallback.java index d40c6e6966..d5e896a836 100644 --- a/server-core/src/main/java/io/onedev/server/git/hook/GitPostReceiveCallback.java +++ b/server-core/src/main/java/io/onedev/server/git/hook/GitPostReceiveCallback.java @@ -35,7 +35,6 @@ import java.util.List; import static io.onedev.server.security.SecurityUtils.asPrincipals; import static io.onedev.server.security.SecurityUtils.asSubject; -@SuppressWarnings("serial") @Singleton public class GitPostReceiveCallback extends HttpServlet { diff --git a/server-core/src/main/java/io/onedev/server/git/hook/GitPreReceiveCallback.java b/server-core/src/main/java/io/onedev/server/git/hook/GitPreReceiveCallback.java index 620f7045f0..3aa07eb4b8 100644 --- a/server-core/src/main/java/io/onedev/server/git/hook/GitPreReceiveCallback.java +++ b/server-core/src/main/java/io/onedev/server/git/hook/GitPreReceiveCallback.java @@ -30,7 +30,6 @@ import java.util.*; import static io.onedev.server.security.SecurityUtils.*; -@SuppressWarnings("serial") @Singleton public class GitPreReceiveCallback extends HttpServlet { diff --git a/server-core/src/main/java/io/onedev/server/git/service/AheadBehind.java b/server-core/src/main/java/io/onedev/server/git/service/AheadBehind.java index 123cdd133d..04f5bd61e8 100644 --- a/server-core/src/main/java/io/onedev/server/git/service/AheadBehind.java +++ b/server-core/src/main/java/io/onedev/server/git/service/AheadBehind.java @@ -2,7 +2,6 @@ package io.onedev.server.git.service; import java.io.Serializable; -@SuppressWarnings("serial") public class AheadBehind implements Serializable { private final int ahead; diff --git a/server-core/src/main/java/io/onedev/server/git/service/CommitMessageError.java b/server-core/src/main/java/io/onedev/server/git/service/CommitMessageError.java index ea6ac86e6f..a2ea59ce0e 100644 --- a/server-core/src/main/java/io/onedev/server/git/service/CommitMessageError.java +++ b/server-core/src/main/java/io/onedev/server/git/service/CommitMessageError.java @@ -1,12 +1,12 @@ package io.onedev.server.git.service; -import io.onedev.server.git.GitUtils; -import org.eclipse.jgit.lib.ObjectId; +import static io.onedev.server.git.GitUtils.abbreviateSHA; -import javax.annotation.Nullable; import java.io.Serializable; -import static io.onedev.server.git.GitUtils.abbreviateSHA; +import javax.annotation.Nullable; + +import org.eclipse.jgit.lib.ObjectId; public class CommitMessageError implements Serializable { diff --git a/server-core/src/main/java/io/onedev/server/git/service/DefaultGitService.java b/server-core/src/main/java/io/onedev/server/git/service/DefaultGitService.java index ac63409be2..61f00cd068 100644 --- a/server-core/src/main/java/io/onedev/server/git/service/DefaultGitService.java +++ b/server-core/src/main/java/io/onedev/server/git/service/DefaultGitService.java @@ -1,10 +1,78 @@ package io.onedev.server.git.service; +import static io.onedev.server.git.command.LogCommand.Field.BODY; +import static io.onedev.server.git.command.LogCommand.Field.PARENTS; +import static io.onedev.server.git.command.LogCommand.Field.SUBJECT; + +import java.io.ByteArrayInputStream; +import java.io.File; +import java.io.IOException; +import java.io.ObjectStreamException; +import java.io.Serializable; +import java.nio.charset.StandardCharsets; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.Comparator; +import java.util.EnumSet; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Iterator; +import java.util.LinkedHashMap; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.atomic.AtomicReference; +import java.util.concurrent.locks.ReadWriteLock; + +import javax.annotation.Nullable; +import javax.inject.Inject; +import javax.inject.Singleton; + +import org.apache.commons.lang3.SerializationUtils; +import org.bouncycastle.openpgp.PGPSecretKeyRing; +import org.eclipse.jgit.api.CreateBranchCommand; +import org.eclipse.jgit.api.Git; +import org.eclipse.jgit.api.errors.GitAPIException; +import org.eclipse.jgit.diff.DiffEntry; +import org.eclipse.jgit.errors.MissingObjectException; +import org.eclipse.jgit.errors.RevisionSyntaxException; +import org.eclipse.jgit.lib.AnyObjectId; +import org.eclipse.jgit.lib.CommitBuilder; +import org.eclipse.jgit.lib.Constants; +import org.eclipse.jgit.lib.FileMode; +import org.eclipse.jgit.lib.ObjectDatabase; +import org.eclipse.jgit.lib.ObjectId; +import org.eclipse.jgit.lib.ObjectInserter; +import org.eclipse.jgit.lib.PersonIdent; +import org.eclipse.jgit.lib.Ref; +import org.eclipse.jgit.lib.RefUpdate; +import org.eclipse.jgit.lib.Repository; +import org.eclipse.jgit.lib.TagBuilder; +import org.eclipse.jgit.lib.TreeFormatter; +import org.eclipse.jgit.revwalk.LastCommitsOfChildren; +import org.eclipse.jgit.revwalk.LastCommitsOfChildren.Value; +import org.eclipse.jgit.revwalk.RevCommit; +import org.eclipse.jgit.revwalk.RevTree; +import org.eclipse.jgit.revwalk.RevWalk; +import org.eclipse.jgit.revwalk.RevWalkUtils; +import org.eclipse.jgit.revwalk.filter.RevFilter; +import org.eclipse.jgit.treewalk.TreeWalk; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import com.google.common.base.Preconditions; import com.google.common.collect.Lists; import com.google.common.collect.Sets; + import io.onedev.commons.loader.ManagedSerializedForm; -import io.onedev.commons.utils.*; +import io.onedev.commons.utils.ExceptionUtils; +import io.onedev.commons.utils.ExplicitException; +import io.onedev.commons.utils.FileUtils; +import io.onedev.commons.utils.LinearRange; +import io.onedev.commons.utils.LockUtils; +import io.onedev.commons.utils.StringUtils; import io.onedev.commons.utils.command.Commandline; import io.onedev.commons.utils.command.LineConsumer; import io.onedev.server.cluster.ClusterManager; @@ -14,43 +82,32 @@ import io.onedev.server.entitymanager.SettingManager; import io.onedev.server.event.ListenerRegistry; import io.onedev.server.event.project.DefaultBranchChanged; import io.onedev.server.event.project.RefUpdated; -import io.onedev.server.git.*; -import io.onedev.server.git.command.*; +import io.onedev.server.git.BlameBlock; +import io.onedev.server.git.Blob; +import io.onedev.server.git.BlobContent; +import io.onedev.server.git.BlobEdits; +import io.onedev.server.git.BlobIdent; +import io.onedev.server.git.BlobIdentFilter; +import io.onedev.server.git.CommandUtils; +import io.onedev.server.git.GitTask; +import io.onedev.server.git.GitUtils; +import io.onedev.server.git.Submodule; +import io.onedev.server.git.command.BlameCommand; +import io.onedev.server.git.command.GetRawCommitCommand; +import io.onedev.server.git.command.GetRawTagCommand; +import io.onedev.server.git.command.ListChangedFilesCommand; +import io.onedev.server.git.command.LogCommand; +import io.onedev.server.git.command.LogCommit; +import io.onedev.server.git.command.RevListCommand; +import io.onedev.server.git.command.RevListOptions; import io.onedev.server.git.exception.NotFileException; import io.onedev.server.git.exception.NotTreeException; import io.onedev.server.git.exception.ObjectAlreadyExistsException; import io.onedev.server.git.exception.ObjectNotFoundException; import io.onedev.server.model.Project; -import io.onedev.server.model.User; import io.onedev.server.model.support.code.BranchProtection; import io.onedev.server.persistence.SessionManager; import io.onedev.server.persistence.annotation.Sessional; -import org.apache.commons.lang3.SerializationUtils; -import org.bouncycastle.openpgp.PGPSecretKeyRing; -import org.eclipse.jgit.api.CreateBranchCommand; -import org.eclipse.jgit.api.Git; -import org.eclipse.jgit.api.errors.GitAPIException; -import org.eclipse.jgit.diff.DiffEntry; -import org.eclipse.jgit.errors.MissingObjectException; -import org.eclipse.jgit.errors.RevisionSyntaxException; -import org.eclipse.jgit.lib.*; -import org.eclipse.jgit.revwalk.*; -import org.eclipse.jgit.revwalk.LastCommitsOfChildren.Value; -import org.eclipse.jgit.revwalk.filter.RevFilter; -import org.eclipse.jgit.treewalk.TreeWalk; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -import javax.annotation.Nullable; -import javax.inject.Inject; -import javax.inject.Singleton; -import java.io.*; -import java.nio.charset.StandardCharsets; -import java.util.*; -import java.util.concurrent.atomic.AtomicReference; -import java.util.concurrent.locks.ReadWriteLock; - -import static io.onedev.server.git.command.LogCommand.Field.*; @Singleton public class DefaultGitService implements GitService, Serializable { @@ -1166,6 +1223,7 @@ public class DefaultGitService implements GitService, Serializable { }); } + @SuppressWarnings("unchecked") @Override public LastCommitsOfChildren getLastCommitsOfChildren(Project project, ObjectId revId, String path) { Long projectId = project.getId(); diff --git a/server-core/src/main/java/io/onedev/server/imports/IssueImporter.java b/server-core/src/main/java/io/onedev/server/imports/IssueImporter.java index c6fd862ead..84186b5b7a 100644 --- a/server-core/src/main/java/io/onedev/server/imports/IssueImporter.java +++ b/server-core/src/main/java/io/onedev/server/imports/IssueImporter.java @@ -1,13 +1,12 @@ package io.onedev.server.imports; -import io.onedev.commons.utils.TaskLogger; -import io.onedev.server.model.Project; -import io.onedev.server.web.component.taskbutton.TaskResult; -import io.onedev.server.web.util.ImportStep; - import java.io.Serializable; import java.util.List; +import io.onedev.commons.utils.TaskLogger; +import io.onedev.server.web.component.taskbutton.TaskResult; +import io.onedev.server.web.util.ImportStep; + public interface IssueImporter extends Serializable { String getName(); diff --git a/server-core/src/main/java/io/onedev/server/jetty/DefaultJettyLauncher.java b/server-core/src/main/java/io/onedev/server/jetty/DefaultJettyLauncher.java index c3f21b8649..4f697307f7 100644 --- a/server-core/src/main/java/io/onedev/server/jetty/DefaultJettyLauncher.java +++ b/server-core/src/main/java/io/onedev/server/jetty/DefaultJettyLauncher.java @@ -1,9 +1,17 @@ package io.onedev.server.jetty; -import com.google.inject.servlet.GuiceFilter; -import io.onedev.commons.bootstrap.Bootstrap; -import io.onedev.commons.utils.ExceptionUtils; -import io.onedev.server.cluster.ClusterManager; +import java.util.ArrayList; +import java.util.Collections; +import java.util.EnumSet; +import java.util.List; +import java.util.Set; + +import javax.inject.Inject; +import javax.inject.Provider; +import javax.inject.Singleton; +import javax.servlet.DispatcherType; +import javax.servlet.http.HttpServletResponse; + import org.apache.tika.mime.MimeTypes; import org.eclipse.jetty.http.HttpCookie.SameSite; import org.eclipse.jetty.http.HttpMethod; @@ -13,12 +21,10 @@ import org.eclipse.jetty.server.session.SessionDataStoreFactory; import org.eclipse.jetty.servlet.ErrorPageErrorHandler; import org.eclipse.jetty.servlet.ServletContextHandler; -import javax.inject.Inject; -import javax.inject.Provider; -import javax.inject.Singleton; -import javax.servlet.DispatcherType; -import javax.servlet.http.HttpServletResponse; -import java.util.*; +import com.google.inject.servlet.GuiceFilter; + +import io.onedev.commons.bootstrap.Bootstrap; +import io.onedev.commons.utils.ExceptionUtils; @Singleton public class DefaultJettyLauncher implements JettyLauncher, Provider { diff --git a/server-core/src/main/java/io/onedev/server/jetty/DefaultSessionDataStoreFactory.java b/server-core/src/main/java/io/onedev/server/jetty/DefaultSessionDataStoreFactory.java index fc7108c8ca..91554d0e10 100644 --- a/server-core/src/main/java/io/onedev/server/jetty/DefaultSessionDataStoreFactory.java +++ b/server-core/src/main/java/io/onedev/server/jetty/DefaultSessionDataStoreFactory.java @@ -18,18 +18,17 @@ package io.onedev.server.jetty; -import io.onedev.server.cluster.ClusterManager; -import org.eclipse.jetty.server.session.AbstractSessionDataStoreFactory; -import org.eclipse.jetty.server.session.SessionDataStore; -import org.eclipse.jetty.server.session.SessionDataStoreFactory; -import org.eclipse.jetty.server.session.SessionHandler; - import javax.inject.Inject; import javax.inject.Singleton; +import org.eclipse.jetty.server.session.AbstractSessionDataStoreFactory; +import org.eclipse.jetty.server.session.SessionDataStore; +import org.eclipse.jetty.server.session.SessionHandler; + +import io.onedev.server.cluster.ClusterManager; + @Singleton -public class DefaultSessionDataStoreFactory extends AbstractSessionDataStoreFactory - implements SessionDataStoreFactory { +public class DefaultSessionDataStoreFactory extends AbstractSessionDataStoreFactory { private final ClusterManager clusterManager; diff --git a/server-core/src/main/java/io/onedev/server/job/JobAuthorizationContext.java b/server-core/src/main/java/io/onedev/server/job/JobAuthorizationContext.java index f4b4262c6f..0b65ef164b 100644 --- a/server-core/src/main/java/io/onedev/server/job/JobAuthorizationContext.java +++ b/server-core/src/main/java/io/onedev/server/job/JobAuthorizationContext.java @@ -1,12 +1,17 @@ package io.onedev.server.job; +import java.util.Stack; + +import org.apache.shiro.subject.Subject; +import org.eclipse.jgit.lib.ObjectId; +import org.jetbrains.annotations.Nullable; + import io.onedev.commons.utils.ExplicitException; import io.onedev.server.OneDev; import io.onedev.server.buildspecmodel.inputspec.SecretInput; import io.onedev.server.entitymanager.AccessTokenManager; import io.onedev.server.job.match.JobMatch; import io.onedev.server.job.match.JobMatchContext; -import io.onedev.server.job.match.OnBranchCriteria; import io.onedev.server.model.Project; import io.onedev.server.model.PullRequest; import io.onedev.server.model.User; @@ -15,11 +20,6 @@ import io.onedev.server.model.support.build.JobSecret; import io.onedev.server.security.SecurityUtils; import io.onedev.server.util.ComponentContext; import io.onedev.server.web.util.WicketUtils; -import org.apache.shiro.subject.Subject; -import org.eclipse.jgit.lib.ObjectId; -import org.jetbrains.annotations.Nullable; - -import java.util.Stack; public class JobAuthorizationContext { diff --git a/server-core/src/main/java/io/onedev/server/mail/MailManager.java b/server-core/src/main/java/io/onedev/server/mail/MailManager.java index 30266c6e73..d24610d690 100644 --- a/server-core/src/main/java/io/onedev/server/mail/MailManager.java +++ b/server-core/src/main/java/io/onedev/server/mail/MailManager.java @@ -1,14 +1,14 @@ package io.onedev.server.mail; -import io.onedev.server.model.Issue; -import io.onedev.server.model.PullRequest; +import java.util.Collection; +import java.util.concurrent.Future; +import java.util.function.Consumer; import javax.annotation.Nullable; import javax.mail.Message; -import java.util.Collection; -import java.util.List; -import java.util.concurrent.Future; -import java.util.function.Consumer; + +import io.onedev.server.model.Issue; +import io.onedev.server.model.PullRequest; public interface MailManager { diff --git a/server-core/src/main/java/io/onedev/server/model/Agent.java b/server-core/src/main/java/io/onedev/server/model/Agent.java index 7623d5e469..c91624d557 100644 --- a/server-core/src/main/java/io/onedev/server/model/Agent.java +++ b/server-core/src/main/java/io/onedev/server/model/Agent.java @@ -1,26 +1,46 @@ package io.onedev.server.model; +import static io.onedev.server.model.Agent.PROP_IP_ADDRESS; +import static io.onedev.server.model.Agent.PROP_NAME; +import static io.onedev.server.model.Agent.PROP_OS_ARCH; +import static io.onedev.server.model.Agent.PROP_OS_NAME; +import static io.onedev.server.model.Agent.PROP_OS_VERSION; +import static io.onedev.server.model.Agent.PROP_PAUSED; +import static io.onedev.server.model.AgentLastUsedDate.PROP_VALUE; +import static io.onedev.server.search.entity.EntitySort.Direction.DESCENDING; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashMap; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; + +import javax.persistence.CascadeType; +import javax.persistence.Column; +import javax.persistence.Entity; +import javax.persistence.FetchType; +import javax.persistence.Index; +import javax.persistence.JoinColumn; +import javax.persistence.OneToMany; +import javax.persistence.OneToOne; +import javax.persistence.Table; + +import org.hibernate.annotations.Cache; +import org.hibernate.annotations.CacheConcurrencyStrategy; + import com.fasterxml.jackson.annotation.JsonIgnore; import com.fasterxml.jackson.annotation.JsonProperty; import com.google.common.collect.Lists; import com.google.common.collect.Sets; + import io.onedev.agent.AgentData; import io.onedev.k8shelper.OsInfo; import io.onedev.server.OneDev; import io.onedev.server.cluster.ClusterManager; import io.onedev.server.entitymanager.AgentManager; -import io.onedev.server.search.entity.EntitySort; import io.onedev.server.search.entity.SortField; -import io.onedev.server.util.CollectionUtils; -import org.hibernate.annotations.Cache; -import org.hibernate.annotations.CacheConcurrencyStrategy; - -import javax.persistence.*; -import java.util.*; - -import static io.onedev.server.model.Agent.*; -import static io.onedev.server.model.AgentLastUsedDate.PROP_VALUE; -import static io.onedev.server.search.entity.EntitySort.Direction.DESCENDING; @Entity @Table(indexes={ diff --git a/server-core/src/main/java/io/onedev/server/model/Build.java b/server-core/src/main/java/io/onedev/server/model/Build.java index cbc2f8dced..610bf76e98 100644 --- a/server-core/src/main/java/io/onedev/server/model/Build.java +++ b/server-core/src/main/java/io/onedev/server/model/Build.java @@ -1,9 +1,70 @@ package io.onedev.server.model; +import static io.onedev.server.model.AbstractEntity.PROP_NUMBER; +import static io.onedev.server.model.Build.PROP_COMMIT_HASH; +import static io.onedev.server.model.Build.PROP_FINISH_DATE; +import static io.onedev.server.model.Build.PROP_FINISH_DAY; +import static io.onedev.server.model.Build.PROP_FINISH_MONTH; +import static io.onedev.server.model.Build.PROP_FINISH_WEEK; +import static io.onedev.server.model.Build.PROP_JOB_NAME; +import static io.onedev.server.model.Build.PROP_PENDING_DATE; +import static io.onedev.server.model.Build.PROP_REF_NAME; +import static io.onedev.server.model.Build.PROP_RUNNING_DATE; +import static io.onedev.server.model.Build.PROP_STATUS; +import static io.onedev.server.model.Build.PROP_SUBMIT_DATE; +import static io.onedev.server.model.Build.PROP_VERSION; +import static io.onedev.server.model.Project.BUILDS_DIR; +import static io.onedev.server.model.support.TimeGroups.PROP_DAY; +import static io.onedev.server.model.support.TimeGroups.PROP_MONTH; +import static io.onedev.server.model.support.TimeGroups.PROP_WEEK; +import static io.onedev.server.search.entity.EntitySort.Direction.DESCENDING; + +import java.io.File; +import java.io.Serializable; +import java.lang.reflect.InvocationTargetException; +import java.nio.file.Paths; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.Date; +import java.util.HashMap; +import java.util.HashSet; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.Stack; +import java.util.UUID; + +import javax.annotation.Nullable; +import javax.persistence.AttributeOverride; +import javax.persistence.AttributeOverrides; +import javax.persistence.CascadeType; +import javax.persistence.Column; +import javax.persistence.Embedded; +import javax.persistence.Entity; +import javax.persistence.FetchType; +import javax.persistence.Index; +import javax.persistence.JoinColumn; +import javax.persistence.Lob; +import javax.persistence.ManyToOne; +import javax.persistence.OneToMany; +import javax.persistence.Table; +import javax.persistence.UniqueConstraint; + +import org.apache.commons.lang3.StringUtils; +import org.eclipse.jgit.lib.ObjectId; +import org.eclipse.jgit.revwalk.RevCommit; +import org.hibernate.annotations.DynamicUpdate; +import org.hibernate.criterion.Criterion; +import org.hibernate.criterion.Restrictions; + import com.fasterxml.jackson.annotation.JsonIgnore; import com.google.common.base.Preconditions; import com.google.common.collect.Lists; import com.google.common.collect.Sets; + import io.onedev.commons.utils.ExplicitException; import io.onedev.commons.utils.WordUtils; import io.onedev.server.OneDev; @@ -28,10 +89,8 @@ import io.onedev.server.model.support.LabelSupport; import io.onedev.server.model.support.ProjectBelonging; import io.onedev.server.model.support.TimeGroups; import io.onedev.server.model.support.build.JobSecret; -import io.onedev.server.search.entity.EntitySort; import io.onedev.server.search.entity.SortField; import io.onedev.server.security.SecurityUtils; -import io.onedev.server.util.CollectionUtils; import io.onedev.server.util.ComponentContext; import io.onedev.server.util.FilenameUtils; import io.onedev.server.util.Input; @@ -43,26 +102,6 @@ import io.onedev.server.web.editable.BeanDescriptor; import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.util.BuildAware; import io.onedev.server.web.util.WicketUtils; -import org.apache.commons.lang3.StringUtils; -import org.eclipse.jgit.lib.ObjectId; -import org.eclipse.jgit.revwalk.RevCommit; -import org.hibernate.annotations.DynamicUpdate; -import org.hibernate.criterion.Criterion; -import org.hibernate.criterion.Restrictions; - -import javax.annotation.Nullable; -import javax.persistence.*; -import java.io.File; -import java.io.Serializable; -import java.lang.reflect.InvocationTargetException; -import java.nio.file.Paths; -import java.util.*; - -import static io.onedev.server.model.AbstractEntity.PROP_NUMBER; -import static io.onedev.server.model.Build.*; -import static io.onedev.server.model.Project.BUILDS_DIR; -import static io.onedev.server.model.support.TimeGroups.*; -import static io.onedev.server.search.entity.EntitySort.Direction.DESCENDING; @Entity @Table( diff --git a/server-core/src/main/java/io/onedev/server/model/CodeComment.java b/server-core/src/main/java/io/onedev/server/model/CodeComment.java index dc9457a0e6..da6fd8d55a 100644 --- a/server-core/src/main/java/io/onedev/server/model/CodeComment.java +++ b/server-core/src/main/java/io/onedev/server/model/CodeComment.java @@ -1,7 +1,36 @@ package io.onedev.server.model; +import static io.onedev.server.model.CodeComment.PROP_CREATE_DATE; +import static io.onedev.server.search.entity.EntitySort.Direction.DESCENDING; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Date; +import java.util.LinkedHashMap; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; + +import javax.annotation.Nullable; +import javax.persistence.CascadeType; +import javax.persistence.Column; +import javax.persistence.Embedded; +import javax.persistence.Entity; +import javax.persistence.FetchType; +import javax.persistence.Index; +import javax.persistence.JoinColumn; +import javax.persistence.ManyToOne; +import javax.persistence.OneToMany; +import javax.persistence.Table; + +import org.apache.commons.lang3.StringUtils; +import org.eclipse.jgit.lib.ObjectId; + import com.google.common.collect.Lists; import com.google.common.collect.Sets; + import io.onedev.server.OneDev; import io.onedev.server.attachment.AttachmentStorageSupport; import io.onedev.server.entitymanager.UserManager; @@ -10,20 +39,9 @@ import io.onedev.server.model.support.CompareContext; import io.onedev.server.model.support.LastActivity; import io.onedev.server.model.support.Mark; import io.onedev.server.model.support.ProjectBelonging; -import io.onedev.server.search.entity.EntitySort; import io.onedev.server.search.entity.SortField; import io.onedev.server.security.SecurityUtils; -import io.onedev.server.util.CollectionUtils; import io.onedev.server.xodus.VisitInfoManager; -import org.apache.commons.lang3.StringUtils; -import org.eclipse.jgit.lib.ObjectId; - -import javax.annotation.Nullable; -import javax.persistence.*; -import java.util.*; - -import static io.onedev.server.model.CodeComment.PROP_CREATE_DATE; -import static io.onedev.server.search.entity.EntitySort.Direction.DESCENDING; @Entity @Table(indexes={ diff --git a/server-core/src/main/java/io/onedev/server/model/Project.java b/server-core/src/main/java/io/onedev/server/model/Project.java index a1f5a8866f..c6c4dcd4c2 100644 --- a/server-core/src/main/java/io/onedev/server/model/Project.java +++ b/server-core/src/main/java/io/onedev/server/model/Project.java @@ -1065,6 +1065,7 @@ public class Project extends AbstractEntity implements LabelSupportNOTE: Time tracking is an enterprise feature. " + @@ -1075,6 +1076,7 @@ public class Project extends AbstractEntity implements LabelSupportpackage management for this project"; } diff --git a/server-core/src/main/java/io/onedev/server/model/Role.java b/server-core/src/main/java/io/onedev/server/model/Role.java index 80a0b5589a..1415adf544 100644 --- a/server-core/src/main/java/io/onedev/server/model/Role.java +++ b/server-core/src/main/java/io/onedev/server/model/Role.java @@ -380,6 +380,7 @@ public class Role extends AbstractEntity implements BasePermission { return permissions; } + @SuppressWarnings("unused") private static boolean isSubscriptionActive() { return WicketUtils.isSubscriptionActive(); } diff --git a/server-core/src/main/java/io/onedev/server/model/support/administration/AgentSetting.java b/server-core/src/main/java/io/onedev/server/model/support/administration/AgentSetting.java index 498ca89a2c..e209cfa6dd 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/administration/AgentSetting.java +++ b/server-core/src/main/java/io/onedev/server/model/support/administration/AgentSetting.java @@ -1,5 +1,7 @@ package io.onedev.server.model.support.administration; +import static io.onedev.server.search.entity.agent.AgentQueryLexer.Is; + import java.io.Serializable; import java.util.ArrayList; import java.util.List; @@ -8,12 +10,9 @@ import javax.annotation.Nullable; import io.onedev.server.model.support.NamedAgentQuery; import io.onedev.server.search.entity.agent.AgentQuery; -import io.onedev.server.search.entity.agent.AgentQueryLexer; import io.onedev.server.search.entity.agent.NotUsedSinceCriteria; import io.onedev.server.search.entity.agent.OsCriteria; -import static io.onedev.server.search.entity.agent.AgentQueryLexer.Is; - public class AgentSetting implements Serializable { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/model/support/administration/GlobalPullRequestSetting.java b/server-core/src/main/java/io/onedev/server/model/support/administration/GlobalPullRequestSetting.java index eaa6b0cdd9..3d4ff075fa 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/administration/GlobalPullRequestSetting.java +++ b/server-core/src/main/java/io/onedev/server/model/support/administration/GlobalPullRequestSetting.java @@ -6,7 +6,6 @@ import java.util.List; import javax.annotation.Nullable; -import io.onedev.server.model.support.issue.NamedIssueQuery; import io.onedev.server.model.support.pullrequest.NamedPullRequestQuery; public class GlobalPullRequestSetting implements Serializable { diff --git a/server-core/src/main/java/io/onedev/server/model/support/administration/SecuritySetting.java b/server-core/src/main/java/io/onedev/server/model/support/administration/SecuritySetting.java index ab7e049357..25d08e6c7c 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/administration/SecuritySetting.java +++ b/server-core/src/main/java/io/onedev/server/model/support/administration/SecuritySetting.java @@ -67,6 +67,7 @@ public class SecuritySetting implements Serializable { this.allowedSelfRegisterEmailDomain = allowedSelfRegisterEmailDomain; } + @SuppressWarnings("unused") private static boolean isEnableSelfRegisterEnabled() { return (boolean) EditContext.get().getInputValue("enableSelfRegister"); } diff --git a/server-core/src/main/java/io/onedev/server/model/support/administration/SystemSetting.java b/server-core/src/main/java/io/onedev/server/model/support/administration/SystemSetting.java index 25ae847c92..1b9df6f117 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/administration/SystemSetting.java +++ b/server-core/src/main/java/io/onedev/server/model/support/administration/SystemSetting.java @@ -149,6 +149,7 @@ public class SystemSetting implements Serializable, Validatable { this.disableDashboard = disableDashboard; } + @SuppressWarnings("unused") private static boolean isDisableDashboardEnabled() { return WicketUtils.isSubscriptionActive(); } @@ -173,6 +174,7 @@ public class SystemSetting implements Serializable, Validatable { this.avatarServiceUrl = avatarServiceUrl; } + @SuppressWarnings("unused") private static boolean isUseAvatarServiceEnabled() { return (boolean) EditContext.get().getInputValue(PROP_USE_AVATAR_SERVICE); } diff --git a/server-core/src/main/java/io/onedev/server/model/support/administration/jobexecutor/RegistryLogin.java b/server-core/src/main/java/io/onedev/server/model/support/administration/jobexecutor/RegistryLogin.java index 0a7156eeb2..ed61f84a6f 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/administration/jobexecutor/RegistryLogin.java +++ b/server-core/src/main/java/io/onedev/server/model/support/administration/jobexecutor/RegistryLogin.java @@ -38,6 +38,7 @@ public class RegistryLogin implements Serializable { this.registryUrl = registryUrl; } + @SuppressWarnings("unused") private static List suggestRegistryUrlVariables(String matchWith) { return SuggestionUtils.suggest(Lists.newArrayList(JobVariable.SERVER_URL.name().toLowerCase()), matchWith); } @@ -53,6 +54,7 @@ public class RegistryLogin implements Serializable { this.userName = userName; } + @SuppressWarnings("unused") private static List suggestUserNameVariables(String matchWith) { return SuggestionUtils.suggest(Lists.newArrayList(JobVariable.JOB_TOKEN.name().toLowerCase()), matchWith); } diff --git a/server-core/src/main/java/io/onedev/server/model/support/administration/mailservice/MailService.java b/server-core/src/main/java/io/onedev/server/model/support/administration/mailservice/MailService.java index 3a051a5ee0..828d85e5ea 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/administration/mailservice/MailService.java +++ b/server-core/src/main/java/io/onedev/server/model/support/administration/mailservice/MailService.java @@ -1,13 +1,13 @@ package io.onedev.server.model.support.administration.mailservice; +import java.io.Serializable; +import java.util.Collection; + +import javax.annotation.Nullable; + import io.onedev.server.annotation.Editable; import io.onedev.server.mail.InboxMonitor; -import javax.annotation.Nullable; -import java.io.Serializable; -import java.util.Collection; -import java.util.concurrent.Future; - @Editable public interface MailService extends Serializable { diff --git a/server-core/src/main/java/io/onedev/server/model/support/administration/sso/SsoAuthenticated.java b/server-core/src/main/java/io/onedev/server/model/support/administration/sso/SsoAuthenticated.java index 24c51504ba..220fe45019 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/administration/sso/SsoAuthenticated.java +++ b/server-core/src/main/java/io/onedev/server/model/support/administration/sso/SsoAuthenticated.java @@ -1,11 +1,12 @@ package io.onedev.server.model.support.administration.sso; -import io.onedev.server.model.User; -import io.onedev.server.model.support.administration.authenticator.Authenticated; -import org.apache.shiro.authc.AuthenticationToken; +import java.util.Collection; import javax.annotation.Nullable; -import java.util.Collection; + +import org.apache.shiro.authc.AuthenticationToken; + +import io.onedev.server.model.support.administration.authenticator.Authenticated; public class SsoAuthenticated extends Authenticated implements AuthenticationToken { diff --git a/server-core/src/main/java/io/onedev/server/model/support/build/JobProperty.java b/server-core/src/main/java/io/onedev/server/model/support/build/JobProperty.java index 0639c5d4dd..56b854c7f4 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/build/JobProperty.java +++ b/server-core/src/main/java/io/onedev/server/model/support/build/JobProperty.java @@ -1,20 +1,20 @@ package io.onedev.server.model.support.build; -import io.onedev.commons.codeassist.InputCompletion; -import io.onedev.commons.codeassist.InputStatus; -import io.onedev.server.annotation.RegEx; -import io.onedev.server.buildspec.BuildSpec; -import io.onedev.server.buildspec.NamedElement; -import io.onedev.server.annotation.Editable; -import io.onedev.server.annotation.SuggestionProvider; - -import javax.validation.constraints.NotEmpty; -import java.io.Serializable; import java.util.ArrayList; import java.util.List; +import javax.validation.constraints.NotEmpty; + +import io.onedev.commons.codeassist.InputCompletion; +import io.onedev.commons.codeassist.InputStatus; +import io.onedev.server.annotation.Editable; +import io.onedev.server.annotation.RegEx; +import io.onedev.server.annotation.SuggestionProvider; +import io.onedev.server.buildspec.BuildSpec; +import io.onedev.server.buildspec.NamedElement; + @Editable -public class JobProperty implements NamedElement, Serializable { +public class JobProperty implements NamedElement { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/model/support/channelnotification/ChannelNotification.java b/server-core/src/main/java/io/onedev/server/model/support/channelnotification/ChannelNotification.java index 6cc9961073..c2864cef7f 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/channelnotification/ChannelNotification.java +++ b/server-core/src/main/java/io/onedev/server/model/support/channelnotification/ChannelNotification.java @@ -1,6 +1,17 @@ package io.onedev.server.model.support.channelnotification; -import io.onedev.server.annotation.*; +import java.io.Serializable; + +import javax.validation.constraints.NotEmpty; +import javax.validation.constraints.Pattern; + +import io.onedev.server.annotation.BuildQuery; +import io.onedev.server.annotation.CodeCommentQuery; +import io.onedev.server.annotation.CommitQuery; +import io.onedev.server.annotation.Editable; +import io.onedev.server.annotation.IssueQuery; +import io.onedev.server.annotation.PullRequestQuery; +import io.onedev.server.annotation.ShowCondition; import io.onedev.server.event.project.ProjectEvent; import io.onedev.server.event.project.RefUpdated; import io.onedev.server.event.project.build.BuildEvent; @@ -9,11 +20,6 @@ import io.onedev.server.event.project.issue.IssueEvent; import io.onedev.server.event.project.pullrequest.PullRequestEvent; import io.onedev.server.search.entity.issue.IssueQueryParseOption; import io.onedev.server.util.EditContext; -import org.hibernate.validator.constraints.URL; - -import javax.validation.constraints.NotEmpty; -import javax.validation.constraints.Pattern; -import java.io.Serializable; @Editable public class ChannelNotification implements Serializable { diff --git a/server-core/src/main/java/io/onedev/server/model/support/code/BranchProtection.java b/server-core/src/main/java/io/onedev/server/model/support/code/BranchProtection.java index 79f7eeae86..63aad15000 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/code/BranchProtection.java +++ b/server-core/src/main/java/io/onedev/server/model/support/code/BranchProtection.java @@ -166,6 +166,7 @@ public class BranchProtection implements Serializable { this.enforceConventionalCommits = enforceConventionalCommits; } + @SuppressWarnings("unused") private static boolean isEnforceConventionalCommitsEnabled() { return (boolean) EditContext.get().getInputValue("enforceConventionalCommits"); } @@ -202,6 +203,7 @@ public class BranchProtection implements Serializable { this.checkCommitMessageFooter = checkCommitMessageFooter; } + @SuppressWarnings("unused") private static boolean isCheckCommitMessageFooterEnabled() { return (boolean) EditContext.get().getInputValue("checkCommitMessageFooter"); } diff --git a/server-core/src/main/java/io/onedev/server/model/support/issue/TimeTrackingSetting.java b/server-core/src/main/java/io/onedev/server/model/support/issue/TimeTrackingSetting.java index 23aa66988c..15c15101f3 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/issue/TimeTrackingSetting.java +++ b/server-core/src/main/java/io/onedev/server/model/support/issue/TimeTrackingSetting.java @@ -1,17 +1,5 @@ package io.onedev.server.model.support.issue; -import io.onedev.server.OneDev; -import io.onedev.server.annotation.ChoiceProvider; -import io.onedev.server.annotation.Editable; -import io.onedev.server.entitymanager.LinkSpecManager; -import io.onedev.server.entitymanager.SettingManager; -import io.onedev.server.model.support.administration.GlobalIssueSetting; -import io.onedev.server.util.usage.Usage; -import org.apache.commons.lang3.StringUtils; - -import javax.validation.ValidationException; -import javax.validation.constraints.Max; -import javax.validation.constraints.Min; import java.io.Serializable; import java.util.ArrayList; import java.util.LinkedHashSet; @@ -19,6 +7,18 @@ import java.util.List; import java.util.regex.Matcher; import java.util.regex.Pattern; +import javax.validation.ValidationException; +import javax.validation.constraints.Max; +import javax.validation.constraints.Min; + +import org.apache.commons.lang3.StringUtils; + +import io.onedev.server.OneDev; +import io.onedev.server.annotation.ChoiceProvider; +import io.onedev.server.annotation.Editable; +import io.onedev.server.entitymanager.LinkSpecManager; +import io.onedev.server.util.usage.Usage; + @Editable public class TimeTrackingSetting implements Serializable { @@ -69,6 +69,7 @@ public class TimeTrackingSetting implements Serializable { this.aggregationLink = aggregationLink; } + @SuppressWarnings("unused") private static List getLinkChoices() { var choices = new LinkedHashSet(); for (var linkSpec: OneDev.getInstance(LinkSpecManager.class).query()) { @@ -80,10 +81,6 @@ public class TimeTrackingSetting implements Serializable { return new ArrayList<>(choices); } - private static GlobalIssueSetting getIssueSetting() { - return OneDev.getInstance(SettingManager.class).getIssueSetting(); - } - public Usage onDeleteLink(String linkName) { Usage usage = new Usage(); if (linkName.equals(aggregationLink)) diff --git a/server-core/src/main/java/io/onedev/server/model/support/issue/TimesheetSetting.java b/server-core/src/main/java/io/onedev/server/model/support/issue/TimesheetSetting.java index 9f0aed1a48..e33e5d413b 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/issue/TimesheetSetting.java +++ b/server-core/src/main/java/io/onedev/server/model/support/issue/TimesheetSetting.java @@ -75,6 +75,7 @@ public class TimesheetSetting implements Serializable { this.groupBy = groupBy; } + @SuppressWarnings("unused") private static List getGroupByChoices() { var choices = Lists.newArrayList(NAME_PROJECT); for (var fieldSpec: OneDev.getInstance(SettingManager.class).getIssueSetting().getFieldSpecs()) { diff --git a/server-core/src/main/java/io/onedev/server/model/support/issue/field/spec/GroupChoiceField.java b/server-core/src/main/java/io/onedev/server/model/support/issue/field/spec/GroupChoiceField.java index 2f0a0d8509..79484647a1 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/issue/field/spec/GroupChoiceField.java +++ b/server-core/src/main/java/io/onedev/server/model/support/issue/field/spec/GroupChoiceField.java @@ -65,6 +65,7 @@ public class GroupChoiceField extends FieldSpec { this.editEstimatedTime = editEstimatedTime; } + @SuppressWarnings("unused") private static boolean isSubscriptionActive() { return OneDev.getInstance(SubscriptionManager.class).isSubscriptionActive(); } diff --git a/server-core/src/main/java/io/onedev/server/model/support/issue/field/spec/userchoicefield/UserChoiceField.java b/server-core/src/main/java/io/onedev/server/model/support/issue/field/spec/userchoicefield/UserChoiceField.java index 4ae9937e2a..fc20ee7d45 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/issue/field/spec/userchoicefield/UserChoiceField.java +++ b/server-core/src/main/java/io/onedev/server/model/support/issue/field/spec/userchoicefield/UserChoiceField.java @@ -74,6 +74,7 @@ public class UserChoiceField extends FieldSpec { return EditContext.get().getInputValue("allowMultiple").equals(true); } + @SuppressWarnings("unused") private static boolean isSubscriptionActive() { return OneDev.getInstance(SubscriptionManager.class).isSubscriptionActive(); } diff --git a/server-core/src/main/java/io/onedev/server/model/support/issue/transitionspec/AutoSpec.java b/server-core/src/main/java/io/onedev/server/model/support/issue/transitionspec/AutoSpec.java index 660dc8d7d6..787faf2891 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/issue/transitionspec/AutoSpec.java +++ b/server-core/src/main/java/io/onedev/server/model/support/issue/transitionspec/AutoSpec.java @@ -1,17 +1,17 @@ package io.onedev.server.model.support.issue.transitionspec; -import com.google.common.collect.Lists; -import io.onedev.commons.utils.StringUtils; -import io.onedev.server.annotation.ChoiceProvider; -import io.onedev.server.annotation.Editable; -import io.onedev.server.web.component.issue.workflowreconcile.ReconcileUtils; -import io.onedev.server.web.component.issue.workflowreconcile.UndefinedStateResolution; - -import javax.validation.constraints.NotEmpty; import java.util.Collection; import java.util.List; import java.util.Map; +import javax.validation.constraints.NotEmpty; + +import com.google.common.collect.Lists; + +import io.onedev.server.annotation.ChoiceProvider; +import io.onedev.server.annotation.Editable; +import io.onedev.server.web.component.issue.workflowreconcile.UndefinedStateResolution; + @Editable public abstract class AutoSpec extends TransitionSpec { diff --git a/server-core/src/main/java/io/onedev/server/model/support/issue/transitionspec/TransitionSpec.java b/server-core/src/main/java/io/onedev/server/model/support/issue/transitionspec/TransitionSpec.java index 12f8b49b20..5cf9c56ccd 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/issue/transitionspec/TransitionSpec.java +++ b/server-core/src/main/java/io/onedev/server/model/support/issue/transitionspec/TransitionSpec.java @@ -1,5 +1,12 @@ package io.onedev.server.model.support.issue.transitionspec; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashSet; +import java.util.List; +import java.util.Map; + import io.onedev.commons.utils.StringUtils; import io.onedev.server.OneDev; import io.onedev.server.annotation.ChoiceProvider; @@ -10,12 +17,12 @@ import io.onedev.server.model.support.issue.StateSpec; import io.onedev.server.model.support.issue.field.spec.FieldSpec; import io.onedev.server.search.entity.issue.IssueQueryUpdater; import io.onedev.server.util.usage.Usage; -import io.onedev.server.web.component.issue.workflowreconcile.*; +import io.onedev.server.web.component.issue.workflowreconcile.ReconcileUtils; +import io.onedev.server.web.component.issue.workflowreconcile.UndefinedFieldResolution; import io.onedev.server.web.component.issue.workflowreconcile.UndefinedFieldResolution.FixType; - -import javax.validation.constraints.Size; -import java.io.Serializable; -import java.util.*; +import io.onedev.server.web.component.issue.workflowreconcile.UndefinedFieldValue; +import io.onedev.server.web.component.issue.workflowreconcile.UndefinedFieldValuesResolution; +import io.onedev.server.web.component.issue.workflowreconcile.UndefinedStateResolution; @Editable public abstract class TransitionSpec implements Serializable { @@ -60,7 +67,6 @@ public abstract class TransitionSpec implements Serializable { this.removeFields = removeFields; } - @SuppressWarnings("unused") protected static List getFieldChoices() { List fields = new ArrayList<>(); for (FieldSpec field: getIssueSetting().getFieldSpecs()) @@ -95,7 +101,6 @@ public abstract class TransitionSpec implements Serializable { return getQueryUpdater().onDeleteProject(projectPath); } - @SuppressWarnings("unused") protected static List getStateChoices() { List stateNames = new ArrayList<>(); for (StateSpec state: getIssueSetting().getStateSpecs()) diff --git a/server-core/src/main/java/io/onedev/server/model/support/pullrequest/MergePreview.java b/server-core/src/main/java/io/onedev/server/model/support/pullrequest/MergePreview.java index 546dd891ad..d399fb728b 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/pullrequest/MergePreview.java +++ b/server-core/src/main/java/io/onedev/server/model/support/pullrequest/MergePreview.java @@ -7,7 +7,6 @@ import javax.persistence.Column; import javax.persistence.Embeddable; import java.io.Serializable; -@SuppressWarnings("serial") @Embeddable public class MergePreview implements Serializable { diff --git a/server-core/src/main/java/io/onedev/server/model/support/pullrequest/ProjectPullRequestSetting.java b/server-core/src/main/java/io/onedev/server/model/support/pullrequest/ProjectPullRequestSetting.java index 870fd3c4f2..208db24b90 100644 --- a/server-core/src/main/java/io/onedev/server/model/support/pullrequest/ProjectPullRequestSetting.java +++ b/server-core/src/main/java/io/onedev/server/model/support/pullrequest/ProjectPullRequestSetting.java @@ -38,6 +38,7 @@ public class ProjectPullRequestSetting implements Serializable { this.namedQueries = namedQueries; } + @SuppressWarnings("unused") private static String getLfsDescription() { if (!Bootstrap.isInDocker()) { return "Whether or not to fetch LFS objects if pull request is opened from a different project. " + @@ -69,6 +70,7 @@ public class ProjectPullRequestSetting implements Serializable { this.defaultAssignees = defaultAssignees; } + @SuppressWarnings("unused") private static List getAssigneeChoices() { var choices = new ArrayList<>(SecurityUtils.getAuthorizedUsers(Project.get(), new WriteCode())); Collections.sort(choices, Comparator.comparing(User::getDisplayName)); diff --git a/server-core/src/main/java/io/onedev/server/notification/ChannelNotificationManager.java b/server-core/src/main/java/io/onedev/server/notification/ChannelNotificationManager.java index fcb87356bd..f42a70da15 100644 --- a/server-core/src/main/java/io/onedev/server/notification/ChannelNotificationManager.java +++ b/server-core/src/main/java/io/onedev/server/notification/ChannelNotificationManager.java @@ -41,6 +41,7 @@ public abstract class ChannelNotificationManager settingClass; + @SuppressWarnings("unchecked") public ChannelNotificationManager() { List> typeArguments = ReflectionUtils.getTypeArguments(ChannelNotificationManager.class, getClass()); if (typeArguments.size() == 1 && ChannelNotificationSetting.class.isAssignableFrom(typeArguments.get(0))) { diff --git a/server-core/src/main/java/io/onedev/server/notification/WebHookManager.java b/server-core/src/main/java/io/onedev/server/notification/WebHookManager.java index 0b3c52b6e3..1cfa9ed400 100644 --- a/server-core/src/main/java/io/onedev/server/notification/WebHookManager.java +++ b/server-core/src/main/java/io/onedev/server/notification/WebHookManager.java @@ -1,20 +1,19 @@ package io.onedev.server.notification; +import static java.nio.charset.StandardCharsets.UTF_8; +import static javax.ws.rs.core.MediaType.APPLICATION_JSON; + import java.io.IOException; -import java.nio.charset.StandardCharsets; import java.util.concurrent.ExecutorService; import javax.inject.Inject; import javax.inject.Singleton; import javax.ws.rs.core.HttpHeaders; -import javax.ws.rs.core.MediaType; import org.apache.http.HttpEntity; import org.apache.http.HttpStatus; -import org.apache.http.client.methods.CloseableHttpResponse; import org.apache.http.client.methods.HttpPost; import org.apache.http.entity.StringEntity; -import org.apache.http.impl.client.CloseableHttpClient; import org.apache.http.impl.client.HttpClients; import org.apache.http.util.EntityUtils; import org.slf4j.Logger; @@ -28,9 +27,6 @@ import io.onedev.server.event.project.ProjectEvent; import io.onedev.server.model.support.WebHook; import io.onedev.server.persistence.annotation.Sessional; -import static java.nio.charset.StandardCharsets.UTF_8; -import static javax.ws.rs.core.MediaType.APPLICATION_JSON; - @Singleton public class WebHookManager { diff --git a/server-core/src/main/java/io/onedev/server/persistence/DefaultSessionFactoryManager.java b/server-core/src/main/java/io/onedev/server/persistence/DefaultSessionFactoryManager.java index 69bcc1f581..20fc8aafba 100644 --- a/server-core/src/main/java/io/onedev/server/persistence/DefaultSessionFactoryManager.java +++ b/server-core/src/main/java/io/onedev/server/persistence/DefaultSessionFactoryManager.java @@ -1,7 +1,6 @@ package io.onedev.server.persistence; import java.util.Properties; -import java.util.concurrent.ExecutorService; import org.hibernate.Interceptor; import org.hibernate.SessionFactory; diff --git a/server-core/src/main/java/io/onedev/server/persistence/dao/BaseEntityManager.java b/server-core/src/main/java/io/onedev/server/persistence/dao/BaseEntityManager.java index f28326a940..a938daa4ee 100644 --- a/server-core/src/main/java/io/onedev/server/persistence/dao/BaseEntityManager.java +++ b/server-core/src/main/java/io/onedev/server/persistence/dao/BaseEntityManager.java @@ -98,6 +98,7 @@ public abstract class BaseEntityManager implements Ent return entityClass; } + @SuppressWarnings("rawtypes") protected void addOrderByIdIfNecessary(CriteriaBuilder builder, From from, List orders) { boolean orderByIdFound = false; for (var order: orders) { diff --git a/server-core/src/main/java/io/onedev/server/persistence/dao/EntityCriteria.java b/server-core/src/main/java/io/onedev/server/persistence/dao/EntityCriteria.java index cec58c3c92..513ac5e81c 100644 --- a/server-core/src/main/java/io/onedev/server/persistence/dao/EntityCriteria.java +++ b/server-core/src/main/java/io/onedev/server/persistence/dao/EntityCriteria.java @@ -20,7 +20,6 @@ import org.hibernate.transform.ResultTransformer; import io.onedev.server.model.AbstractEntity; -@SuppressWarnings("serial") public class EntityCriteria implements CriteriaSpecification, Serializable { private final CriteriaImpl impl; diff --git a/server-core/src/main/java/io/onedev/server/rest/DefaultServletContainer.java b/server-core/src/main/java/io/onedev/server/rest/DefaultServletContainer.java index 77950ec703..f517dec05f 100644 --- a/server-core/src/main/java/io/onedev/server/rest/DefaultServletContainer.java +++ b/server-core/src/main/java/io/onedev/server/rest/DefaultServletContainer.java @@ -13,7 +13,6 @@ import org.glassfish.jersey.servlet.ServletContainer; import io.onedev.server.persistence.annotation.Sessional; -@SuppressWarnings("serial") @Singleton public class DefaultServletContainer extends ServletContainer { diff --git a/server-core/src/main/java/io/onedev/server/rest/resource/ArtifactResource.java b/server-core/src/main/java/io/onedev/server/rest/resource/ArtifactResource.java index 2798080a15..8314765ba5 100644 --- a/server-core/src/main/java/io/onedev/server/rest/resource/ArtifactResource.java +++ b/server-core/src/main/java/io/onedev/server/rest/resource/ArtifactResource.java @@ -32,7 +32,7 @@ import static javax.ws.rs.client.Entity.entity; import static javax.ws.rs.core.HttpHeaders.AUTHORIZATION; import static javax.ws.rs.core.MediaType.APPLICATION_OCTET_STREAM; import static javax.ws.rs.core.Response.ok; -import static org.apache.commons.compress.utils.IOUtils.copy; +import static io.onedev.server.util.IOUtils.copy; @Api(order=4100, description="In most cases, artifact resource is operated with build id, which is different from build number. " + "To get build id of a particular build number, use the Query Basic Info operation with query for " diff --git a/server-core/src/main/java/io/onedev/server/rest/resource/GroupAuthorizationResource.java b/server-core/src/main/java/io/onedev/server/rest/resource/GroupAuthorizationResource.java index 07b65deb43..bbabb81128 100644 --- a/server-core/src/main/java/io/onedev/server/rest/resource/GroupAuthorizationResource.java +++ b/server-core/src/main/java/io/onedev/server/rest/resource/GroupAuthorizationResource.java @@ -13,7 +13,6 @@ import javax.ws.rs.Produces; import javax.ws.rs.core.MediaType; import javax.ws.rs.core.Response; -import io.onedev.server.model.UserAuthorization; import org.apache.shiro.authz.UnauthorizedException; import io.onedev.server.entitymanager.GroupAuthorizationManager; diff --git a/server-core/src/main/java/io/onedev/server/rest/resource/IssueCommentResource.java b/server-core/src/main/java/io/onedev/server/rest/resource/IssueCommentResource.java index b7807b6e35..b7b8d9417e 100644 --- a/server-core/src/main/java/io/onedev/server/rest/resource/IssueCommentResource.java +++ b/server-core/src/main/java/io/onedev/server/rest/resource/IssueCommentResource.java @@ -1,20 +1,29 @@ package io.onedev.server.rest.resource; +import static io.onedev.server.security.SecurityUtils.canAccessIssue; +import static io.onedev.server.security.SecurityUtils.canModifyOrDelete; +import static io.onedev.server.security.SecurityUtils.getUser; +import static io.onedev.server.security.SecurityUtils.isAdministrator; + +import javax.inject.Inject; +import javax.inject.Singleton; +import javax.validation.constraints.NotNull; +import javax.ws.rs.Consumes; +import javax.ws.rs.DELETE; +import javax.ws.rs.GET; +import javax.ws.rs.POST; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; + +import org.apache.shiro.authz.UnauthorizedException; + import io.onedev.server.entitymanager.IssueCommentManager; import io.onedev.server.model.IssueComment; import io.onedev.server.rest.annotation.Api; import io.onedev.server.security.SecurityUtils; -import org.apache.shiro.authz.UnauthorizedException; - -import javax.inject.Inject; -import javax.inject.Singleton; -import javax.validation.constraints.NotNull; -import javax.ws.rs.*; -import javax.ws.rs.core.MediaType; -import javax.ws.rs.core.Response; -import java.util.ArrayList; - -import static io.onedev.server.security.SecurityUtils.*; @Api(order=2300) @Path("/issue-comments") diff --git a/server-core/src/main/java/io/onedev/server/rest/resource/IssueResource.java b/server-core/src/main/java/io/onedev/server/rest/resource/IssueResource.java index 45b6350c17..98d2f84412 100644 --- a/server-core/src/main/java/io/onedev/server/rest/resource/IssueResource.java +++ b/server-core/src/main/java/io/onedev/server/rest/resource/IssueResource.java @@ -225,6 +225,7 @@ public class IssueResource { return issues; } + @SuppressWarnings("unused") private static List> getIssuesExample() { var issues = new ArrayList>(); var issue = ApiHelpUtils.getExampleValue(Issue.class, ValueInfo.Origin.READ_BODY); @@ -391,6 +392,7 @@ public class IssueResource { return Response.ok().build(); } + @SuppressWarnings("unchecked") private Map getFieldObjs(Issue issue, Map fields) { var issueSetting = settingManager.getIssueSetting(); Map fieldObjs = new HashMap<>(); @@ -498,6 +500,7 @@ public class IssueResource { this.fields = fields; } + @SuppressWarnings("unused") private static Map getFieldsExample() { return IssueResource.getFieldsExample(); } @@ -554,6 +557,7 @@ public class IssueResource { this.comment = comment; } + @SuppressWarnings("unused") private static Map getFieldsExample() { return IssueResource.getFieldsExample(); } diff --git a/server-core/src/main/java/io/onedev/server/rest/resource/RepositoryResource.java b/server-core/src/main/java/io/onedev/server/rest/resource/RepositoryResource.java index 3fd6dfe889..2be5e6c4e4 100644 --- a/server-core/src/main/java/io/onedev/server/rest/resource/RepositoryResource.java +++ b/server-core/src/main/java/io/onedev/server/rest/resource/RepositoryResource.java @@ -292,6 +292,7 @@ public class RepositoryResource { throw new ObjectNotFoundException("Commit not found"); } + @SuppressWarnings("unused") private static List getFieldsExample() { return EnumSet.allOf(LogCommand.Field.class).stream().map(Enum::name).collect(toList()); } diff --git a/server-core/src/main/java/io/onedev/server/rest/resource/VersionResource.java b/server-core/src/main/java/io/onedev/server/rest/resource/VersionResource.java index b507724460..7c8e072828 100644 --- a/server-core/src/main/java/io/onedev/server/rest/resource/VersionResource.java +++ b/server-core/src/main/java/io/onedev/server/rest/resource/VersionResource.java @@ -1,13 +1,16 @@ package io.onedev.server.rest.resource; +import java.io.Serializable; + +import javax.inject.Singleton; +import javax.ws.rs.GET; +import javax.ws.rs.Path; +import javax.ws.rs.Produces; +import javax.ws.rs.core.MediaType; + import io.onedev.server.OneDev; import io.onedev.server.rest.annotation.Api; -import javax.inject.Singleton; -import javax.ws.rs.*; -import javax.ws.rs.core.MediaType; -import java.io.Serializable; - @Api(order=100000, description = "Version info for server and various tools") @Path("/version") @Produces(MediaType.APPLICATION_JSON) @@ -38,21 +41,6 @@ public class VersionResource { @Api(example = "2.0.0", description = "Maximum version. Null means no upper bound") String maxVersion; - public String getMinVersion() { - return minVersion; - } - - public void setMinVersion(String minVersion) { - this.minVersion = minVersion; - } - - public String getMaxVersion() { - return maxVersion; - } - - public void setMaxVersion(String maxVersion) { - this.maxVersion = maxVersion; - } } } diff --git a/server-core/src/main/java/io/onedev/server/search/code/DefaultCodeSearchManager.java b/server-core/src/main/java/io/onedev/server/search/code/DefaultCodeSearchManager.java index a1c07aea14..b63569ffd6 100644 --- a/server-core/src/main/java/io/onedev/server/search/code/DefaultCodeSearchManager.java +++ b/server-core/src/main/java/io/onedev/server/search/code/DefaultCodeSearchManager.java @@ -235,7 +235,6 @@ public class DefaultCodeSearchManager implements CodeSearchManager, Serializable private LeafReaderContext context; - @SuppressWarnings("unchecked") @Override public void collect(int doc) throws IOException { Document document = searcher.doc(context.docBase+doc); diff --git a/server-core/src/main/java/io/onedev/server/search/commit/CommitQuery.java b/server-core/src/main/java/io/onedev/server/search/commit/CommitQuery.java index 4174e4554c..4ea6d2773b 100644 --- a/server-core/src/main/java/io/onedev/server/search/commit/CommitQuery.java +++ b/server-core/src/main/java/io/onedev/server/search/commit/CommitQuery.java @@ -1,28 +1,34 @@ package io.onedev.server.search.commit; +import static io.onedev.commons.codeassist.FenceAware.unfence; +import static io.onedev.commons.utils.StringUtils.unescape; +import static org.apache.commons.lang3.StringUtils.join; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +import javax.annotation.Nullable; + +import org.antlr.v4.runtime.BailErrorStrategy; +import org.antlr.v4.runtime.BaseErrorListener; +import org.antlr.v4.runtime.CharStream; +import org.antlr.v4.runtime.CharStreams; +import org.antlr.v4.runtime.CommonTokenStream; +import org.antlr.v4.runtime.RecognitionException; +import org.antlr.v4.runtime.Recognizer; +import org.antlr.v4.runtime.tree.TerminalNode; +import org.eclipse.jgit.lib.ObjectId; + import io.onedev.commons.utils.ExplicitException; import io.onedev.server.OneDev; import io.onedev.server.entitymanager.BuildManager; import io.onedev.server.entityreference.BuildReference; -import io.onedev.server.entityreference.IssueReference; import io.onedev.server.event.project.RefUpdated; import io.onedev.server.git.command.RevListOptions; import io.onedev.server.model.Build; import io.onedev.server.model.Project; import io.onedev.server.search.commit.CommitQueryParser.CriteriaContext; -import org.antlr.v4.runtime.*; -import org.antlr.v4.runtime.tree.TerminalNode; -import org.apache.commons.lang.math.NumberUtils; -import org.eclipse.jgit.lib.ObjectId; - -import javax.annotation.Nullable; -import java.io.Serializable; -import java.util.ArrayList; -import java.util.List; - -import static io.onedev.commons.codeassist.FenceAware.unfence; -import static io.onedev.commons.utils.StringUtils.join; -import static io.onedev.commons.utils.StringUtils.unescape; public class CommitQuery implements Serializable { diff --git a/server-core/src/main/java/io/onedev/server/search/commit/FuzzyCriteria.java b/server-core/src/main/java/io/onedev/server/search/commit/FuzzyCriteria.java index 80976ee004..8c904895ad 100644 --- a/server-core/src/main/java/io/onedev/server/search/commit/FuzzyCriteria.java +++ b/server-core/src/main/java/io/onedev/server/search/commit/FuzzyCriteria.java @@ -1,19 +1,18 @@ package io.onedev.server.search.commit; -import com.google.common.base.Preconditions; -import com.google.common.collect.Lists; -import io.onedev.commons.utils.StringUtils; -import io.onedev.server.event.project.RefUpdated; -import io.onedev.server.git.command.RevListOptions; -import io.onedev.server.git.service.RefFacade; -import io.onedev.server.model.Project; -import org.eclipse.jgit.revwalk.RevCommit; +import static io.onedev.commons.utils.match.WildcardUtils.matchString; import java.util.ArrayList; import java.util.List; -import java.util.stream.Collectors; -import static io.onedev.commons.utils.match.WildcardUtils.matchString; +import org.eclipse.jgit.revwalk.RevCommit; + +import com.google.common.base.Preconditions; + +import io.onedev.commons.utils.StringUtils; +import io.onedev.server.event.project.RefUpdated; +import io.onedev.server.git.command.RevListOptions; +import io.onedev.server.model.Project; public class FuzzyCriteria extends CommitCriteria { diff --git a/server-core/src/main/java/io/onedev/server/search/entity/IssueSortField.java b/server-core/src/main/java/io/onedev/server/search/entity/IssueSortField.java index 36691fdce9..3c799ea4db 100644 --- a/server-core/src/main/java/io/onedev/server/search/entity/IssueSortField.java +++ b/server-core/src/main/java/io/onedev/server/search/entity/IssueSortField.java @@ -1,13 +1,12 @@ package io.onedev.server.search.entity; +import static io.onedev.server.search.entity.EntitySort.Direction.ASCENDING; + import java.util.Comparator; -import io.onedev.server.model.AbstractEntity; import io.onedev.server.model.Issue; import io.onedev.server.search.entity.EntitySort.Direction; -import static io.onedev.server.search.entity.EntitySort.Direction.ASCENDING; - public class IssueSortField extends SortField { private final Comparator comparator; diff --git a/server-core/src/main/java/io/onedev/server/search/entity/agent/FuzzyCriteria.java b/server-core/src/main/java/io/onedev/server/search/entity/agent/FuzzyCriteria.java index 5fce3e8eda..5912ff4fee 100644 --- a/server-core/src/main/java/io/onedev/server/search/entity/agent/FuzzyCriteria.java +++ b/server-core/src/main/java/io/onedev/server/search/entity/agent/FuzzyCriteria.java @@ -34,6 +34,7 @@ public class FuzzyCriteria extends Criteria { return parse(value).matches(agent); } + @SuppressWarnings("unchecked") private Criteria parse(String value) { return new OrCriteria<>( new NameCriteria("*" + value + "*", Is), diff --git a/server-core/src/main/java/io/onedev/server/search/entity/build/FuzzyCriteria.java b/server-core/src/main/java/io/onedev/server/search/entity/build/FuzzyCriteria.java index 34bcc2222a..f2382c5893 100644 --- a/server-core/src/main/java/io/onedev/server/search/entity/build/FuzzyCriteria.java +++ b/server-core/src/main/java/io/onedev/server/search/entity/build/FuzzyCriteria.java @@ -32,6 +32,7 @@ public class FuzzyCriteria extends Criteria { return parse(value).matches(build); } + @SuppressWarnings("unchecked") private Criteria parse(String value) { return new OrCriteria<>( new VersionCriteria("*" + value + "*", BuildQueryLexer.Is), diff --git a/server-core/src/main/java/io/onedev/server/search/entity/issue/FieldOperatorCriteria.java b/server-core/src/main/java/io/onedev/server/search/entity/issue/FieldOperatorCriteria.java index 2e19c2d4c9..4cd646b817 100644 --- a/server-core/src/main/java/io/onedev/server/search/entity/issue/FieldOperatorCriteria.java +++ b/server-core/src/main/java/io/onedev/server/search/entity/issue/FieldOperatorCriteria.java @@ -107,6 +107,7 @@ public class FieldOperatorCriteria extends FieldCriteria { } } + @SuppressWarnings("rawtypes") @Override public boolean matches(Issue issue) { Object fieldValue = issue.getFieldValue(getFieldName()); diff --git a/server-core/src/main/java/io/onedev/server/search/entity/issue/IterationFieldCriteria.java b/server-core/src/main/java/io/onedev/server/search/entity/issue/IterationFieldCriteria.java index d07bf9a5ea..939bdbead2 100644 --- a/server-core/src/main/java/io/onedev/server/search/entity/issue/IterationFieldCriteria.java +++ b/server-core/src/main/java/io/onedev/server/search/entity/issue/IterationFieldCriteria.java @@ -35,6 +35,7 @@ public class IterationFieldCriteria extends FieldCriteria { return predicate; } + @SuppressWarnings("unchecked") @Override public boolean matches(Issue issue) { List fieldValue = (List) issue.getFieldValue(getFieldName()); diff --git a/server-core/src/main/java/io/onedev/server/search/entity/pack/FuzzyCriteria.java b/server-core/src/main/java/io/onedev/server/search/entity/pack/FuzzyCriteria.java index ee7002294e..647adb1716 100644 --- a/server-core/src/main/java/io/onedev/server/search/entity/pack/FuzzyCriteria.java +++ b/server-core/src/main/java/io/onedev/server/search/entity/pack/FuzzyCriteria.java @@ -32,6 +32,7 @@ public class FuzzyCriteria extends Criteria { return parse(value).matches(build); } + @SuppressWarnings("unchecked") private Criteria parse(String value) { return new OrCriteria<>( new NameCriteria("*" + value + "*", PackQueryLexer.Is), diff --git a/server-core/src/main/java/io/onedev/server/search/entity/pack/PackQuery.java b/server-core/src/main/java/io/onedev/server/search/entity/pack/PackQuery.java index d1acdc1a47..fbfb87e5b9 100644 --- a/server-core/src/main/java/io/onedev/server/search/entity/pack/PackQuery.java +++ b/server-core/src/main/java/io/onedev/server/search/entity/pack/PackQuery.java @@ -1,26 +1,53 @@ package io.onedev.server.search.entity.pack; +import static io.onedev.server.model.Pack.NAME_LABEL; +import static io.onedev.server.model.Pack.NAME_NAME; +import static io.onedev.server.model.Pack.NAME_PROJECT; +import static io.onedev.server.model.Pack.NAME_PUBLISH_DATE; +import static io.onedev.server.model.Pack.NAME_TYPE; +import static io.onedev.server.model.Pack.NAME_VERSION; +import static io.onedev.server.model.Pack.QUERY_FIELDS; +import static io.onedev.server.model.Pack.SORT_FIELDS; +import static io.onedev.server.search.entity.EntitySort.Direction.ASCENDING; +import static io.onedev.server.search.entity.EntitySort.Direction.DESCENDING; +import static io.onedev.server.search.entity.pack.PackQueryParser.Is; +import static io.onedev.server.search.entity.pack.PackQueryParser.IsNot; +import static io.onedev.server.search.entity.pack.PackQueryParser.IsSince; +import static io.onedev.server.search.entity.pack.PackQueryParser.IsUntil; +import static io.onedev.server.search.entity.pack.PackQueryParser.PublishedByMe; + +import java.util.ArrayList; +import java.util.List; + +import javax.annotation.Nullable; + +import org.antlr.v4.runtime.BailErrorStrategy; +import org.antlr.v4.runtime.BaseErrorListener; +import org.antlr.v4.runtime.CharStream; +import org.antlr.v4.runtime.CharStreams; +import org.antlr.v4.runtime.CommonTokenStream; +import org.antlr.v4.runtime.RecognitionException; +import org.antlr.v4.runtime.Recognizer; + import io.onedev.commons.codeassist.AntlrUtils; import io.onedev.commons.utils.ExplicitException; import io.onedev.server.model.Pack; import io.onedev.server.model.Project; import io.onedev.server.search.entity.EntityQuery; import io.onedev.server.search.entity.EntitySort; -import io.onedev.server.search.entity.EntitySort.Direction; +import io.onedev.server.search.entity.pack.PackQueryParser.AndCriteriaContext; +import io.onedev.server.search.entity.pack.PackQueryParser.CriteriaContext; +import io.onedev.server.search.entity.pack.PackQueryParser.FieldOperatorValueCriteriaContext; +import io.onedev.server.search.entity.pack.PackQueryParser.FuzzyCriteriaContext; +import io.onedev.server.search.entity.pack.PackQueryParser.NotCriteriaContext; +import io.onedev.server.search.entity.pack.PackQueryParser.OrCriteriaContext; +import io.onedev.server.search.entity.pack.PackQueryParser.OrderContext; +import io.onedev.server.search.entity.pack.PackQueryParser.ParensCriteriaContext; +import io.onedev.server.search.entity.pack.PackQueryParser.QueryContext; import io.onedev.server.util.criteria.AndCriteria; import io.onedev.server.util.criteria.Criteria; import io.onedev.server.util.criteria.NotCriteria; import io.onedev.server.util.criteria.OrCriteria; -import org.antlr.v4.runtime.*; - -import javax.annotation.Nullable; -import java.util.ArrayList; -import java.util.List; - -import static io.onedev.server.model.Pack.*; -import static io.onedev.server.search.entity.EntitySort.Direction.ASCENDING; -import static io.onedev.server.search.entity.EntitySort.Direction.DESCENDING; -import static io.onedev.server.search.entity.pack.PackQueryParser.*; public class PackQuery extends EntityQuery { diff --git a/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/NeedActionOfCriteria.java b/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/NeedActionOfCriteria.java index 29356142e2..7e85f0573e 100644 --- a/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/NeedActionOfCriteria.java +++ b/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/NeedActionOfCriteria.java @@ -33,6 +33,7 @@ public class NeedActionOfCriteria extends Criteria { return getCriteria().matches(request); } + @SuppressWarnings("unchecked") private Criteria getCriteria() { return new OrCriteria<>( new ToBeReviewedByCriteria(user), diff --git a/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ReadyToMergeCriteria.java b/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ReadyToMergeCriteria.java index edf7ee0ff1..05f61dd1e9 100644 --- a/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ReadyToMergeCriteria.java +++ b/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ReadyToMergeCriteria.java @@ -27,6 +27,7 @@ public class ReadyToMergeCriteria extends Criteria { return getCriteria().matches(request); } + @SuppressWarnings("unchecked") private Criteria getCriteria() { return new AndCriteria<>( new OpenCriteria(), diff --git a/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ToBeChangedByCriteria.java b/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ToBeChangedByCriteria.java index 88cdee2031..6b5c0b4a18 100644 --- a/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ToBeChangedByCriteria.java +++ b/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ToBeChangedByCriteria.java @@ -32,6 +32,7 @@ public class ToBeChangedByCriteria extends Criteria { return getCriteria(user).matches(request); } + @SuppressWarnings("unchecked") private Criteria getCriteria(User user) { return new AndCriteria<>( new OpenCriteria(), diff --git a/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ToBeMergedByCriteria.java b/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ToBeMergedByCriteria.java index fc76edff03..fd8b6be3da 100644 --- a/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ToBeMergedByCriteria.java +++ b/server-core/src/main/java/io/onedev/server/search/entity/pullrequest/ToBeMergedByCriteria.java @@ -32,6 +32,7 @@ public class ToBeMergedByCriteria extends Criteria { return getCriteria(user).matches(request); } + @SuppressWarnings("unchecked") private Criteria getCriteria(User user) { return new AndCriteria<>(new ReadyToMergeCriteria(), new AssignedToCriteria(user)); } diff --git a/server-core/src/main/java/io/onedev/server/search/entitytext/DefaultCodeCommentTextManager.java b/server-core/src/main/java/io/onedev/server/search/entitytext/DefaultCodeCommentTextManager.java index 4d76d6a847..c835173773 100644 --- a/server-core/src/main/java/io/onedev/server/search/entitytext/DefaultCodeCommentTextManager.java +++ b/server-core/src/main/java/io/onedev/server/search/entitytext/DefaultCodeCommentTextManager.java @@ -20,7 +20,6 @@ import javax.inject.Singleton; import org.apache.lucene.analysis.Analyzer; import org.apache.lucene.document.Document; import org.apache.lucene.document.LongPoint; -import org.apache.lucene.document.StringField; import org.apache.lucene.document.TextField; import org.apache.lucene.index.Term; import org.apache.lucene.queryparser.classic.MultiFieldQueryParser; diff --git a/server-core/src/main/java/io/onedev/server/security/DefaultWebEnvironment.java b/server-core/src/main/java/io/onedev/server/security/DefaultWebEnvironment.java index c1be9eb5dc..c1bce8586f 100644 --- a/server-core/src/main/java/io/onedev/server/security/DefaultWebEnvironment.java +++ b/server-core/src/main/java/io/onedev/server/security/DefaultWebEnvironment.java @@ -1,7 +1,6 @@ package io.onedev.server.security; import org.apache.shiro.ShiroException; -import org.apache.shiro.util.Destroyable; import org.apache.shiro.util.Initializable; import org.apache.shiro.web.config.ShiroFilterConfiguration; import org.apache.shiro.web.filter.mgt.FilterChainResolver; @@ -9,7 +8,7 @@ import org.apache.shiro.web.mgt.WebSecurityManager; import io.onedev.server.OneDev; -public class DefaultWebEnvironment extends org.apache.shiro.web.env.DefaultWebEnvironment implements Initializable, Destroyable { +public class DefaultWebEnvironment extends org.apache.shiro.web.env.DefaultWebEnvironment implements Initializable { @Override public void init() throws ShiroException { diff --git a/server-core/src/main/java/io/onedev/server/security/realm/GeneralAuthorizingRealm.java b/server-core/src/main/java/io/onedev/server/security/realm/GeneralAuthorizingRealm.java index 8d3cade9fc..68b9e95f68 100644 --- a/server-core/src/main/java/io/onedev/server/security/realm/GeneralAuthorizingRealm.java +++ b/server-core/src/main/java/io/onedev/server/security/realm/GeneralAuthorizingRealm.java @@ -41,7 +41,6 @@ public class GeneralAuthorizingRealm extends AuthorizingRealm { protected final SettingManager settingManager; - @SuppressWarnings("serial") private static final MetaDataKey> AUTHORIZATION_INFOS = new MetaDataKey<>() {}; @Inject diff --git a/server-core/src/main/java/io/onedev/server/ssh/DefaultSshManager.java b/server-core/src/main/java/io/onedev/server/ssh/DefaultSshManager.java index c8647e44db..d39c6c4660 100644 --- a/server-core/src/main/java/io/onedev/server/ssh/DefaultSshManager.java +++ b/server-core/src/main/java/io/onedev/server/ssh/DefaultSshManager.java @@ -1,6 +1,29 @@ package io.onedev.server.ssh; -import com.google.crypto.tink.subtle.EngineWrapper; +import static com.google.common.collect.Lists.newArrayList; + +import java.io.IOException; +import java.io.ObjectStreamException; +import java.io.Serializable; +import java.security.GeneralSecurityException; +import java.security.KeyPair; +import java.security.PrivateKey; +import java.security.PublicKey; +import java.util.Set; + +import javax.inject.Inject; +import javax.inject.Singleton; + +import org.apache.sshd.client.SshClient; +import org.apache.sshd.client.keyverifier.RequiredServerKeyVerifier; +import org.apache.sshd.client.session.ClientSession; +import org.apache.sshd.common.config.keys.KeyUtils; +import org.apache.sshd.common.keyprovider.KeyIdentityProvider; +import org.apache.sshd.server.SshServer; +import org.apache.sshd.server.auth.pubkey.CachingPublicKeyAuthenticator; +import org.apache.sshd.server.command.Command; +import org.apache.sshd.server.shell.UnknownCommand; + import io.onedev.commons.loader.ManagedSerializedForm; import io.onedev.server.ServerConfig; import io.onedev.server.cluster.ClusterManager; @@ -12,32 +35,6 @@ import io.onedev.server.event.system.SystemStopping; import io.onedev.server.model.Setting; import io.onedev.server.model.User; import io.onedev.server.persistence.TransactionManager; -import org.apache.sshd.client.SshClient; -import org.apache.sshd.client.keyverifier.RequiredServerKeyVerifier; -import org.apache.sshd.client.session.ClientSession; -import org.apache.sshd.common.PropertyResolver; -import org.apache.sshd.common.PropertyResolverUtils; -import org.apache.sshd.common.config.keys.KeyUtils; -import org.apache.sshd.common.keyprovider.KeyIdentityProvider; -import org.apache.sshd.server.ServerBuilder; -import org.apache.sshd.server.SshServer; -import org.apache.sshd.server.auth.pubkey.CachingPublicKeyAuthenticator; -import org.apache.sshd.server.command.Command; -import org.apache.sshd.server.config.SshServerConfigFileReader; -import org.apache.sshd.server.shell.UnknownCommand; - -import javax.inject.Inject; -import javax.inject.Singleton; -import java.io.*; -import java.security.GeneralSecurityException; -import java.security.KeyPair; -import java.security.PrivateKey; -import java.security.PublicKey; -import java.util.Map; -import java.util.Properties; -import java.util.Set; - -import static com.google.common.collect.Lists.newArrayList; @Singleton public class DefaultSshManager implements SshManager, Serializable { diff --git a/server-core/src/main/java/io/onedev/server/ssh/SshKeyUtils.java b/server-core/src/main/java/io/onedev/server/ssh/SshKeyUtils.java index a56350463a..7633e4f20a 100644 --- a/server-core/src/main/java/io/onedev/server/ssh/SshKeyUtils.java +++ b/server-core/src/main/java/io/onedev/server/ssh/SshKeyUtils.java @@ -9,7 +9,6 @@ import java.security.KeyPair; import java.security.PrivateKey; import java.security.PublicKey; import java.security.spec.PKCS8EncodedKeySpec; -import java.security.spec.X509EncodedKeySpec; import java.util.List; import org.apache.sshd.common.config.keys.AuthorizedKeyEntry; diff --git a/server-core/src/main/java/io/onedev/server/ssh/SshManager.java b/server-core/src/main/java/io/onedev/server/ssh/SshManager.java index 5e4126b2a8..e6e80ded69 100644 --- a/server-core/src/main/java/io/onedev/server/ssh/SshManager.java +++ b/server-core/src/main/java/io/onedev/server/ssh/SshManager.java @@ -2,8 +2,6 @@ package io.onedev.server.ssh; import org.apache.sshd.client.session.ClientSession; -import java.util.UUID; - public interface SshManager { ClientSession ssh(String server); diff --git a/server-core/src/main/java/io/onedev/server/util/BeanEditContext.java b/server-core/src/main/java/io/onedev/server/util/BeanEditContext.java index 724f47414a..b793e2dfa8 100644 --- a/server-core/src/main/java/io/onedev/server/util/BeanEditContext.java +++ b/server-core/src/main/java/io/onedev/server/util/BeanEditContext.java @@ -1,14 +1,6 @@ package io.onedev.server.util; import io.onedev.server.web.editable.BeanDescriptor; -import io.onedev.server.web.editable.PropertyDescriptor; -import io.onedev.server.web.util.WicketUtils; - -import javax.annotation.Nullable; -import java.util.ArrayList; -import java.util.Collections; -import java.util.List; -import java.util.Stack; public class BeanEditContext implements EditContext { diff --git a/server-core/src/main/java/io/onedev/server/util/EditContext.java b/server-core/src/main/java/io/onedev/server/util/EditContext.java index 8f58c9186f..59658fd43f 100644 --- a/server-core/src/main/java/io/onedev/server/util/EditContext.java +++ b/server-core/src/main/java/io/onedev/server/util/EditContext.java @@ -7,7 +7,6 @@ import java.util.Stack; import javax.annotation.Nullable; -import io.onedev.server.model.Project; import io.onedev.server.web.util.WicketUtils; public interface EditContext { diff --git a/server-core/src/main/java/io/onedev/server/util/IOUtils.java b/server-core/src/main/java/io/onedev/server/util/IOUtils.java index 0f1a943b48..1f291c1a07 100644 --- a/server-core/src/main/java/io/onedev/server/util/IOUtils.java +++ b/server-core/src/main/java/io/onedev/server/util/IOUtils.java @@ -1,11 +1,12 @@ package io.onedev.server.util; -import io.onedev.server.exception.DataTooLargeException; - import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; +import io.onedev.server.exception.DataTooLargeException; + +@SuppressWarnings("deprecation") public class IOUtils extends org.apache.commons.io.IOUtils { public static final int BUFFER_SIZE = 64*1024; diff --git a/server-core/src/main/java/io/onedev/server/util/ManualConfigStep.java b/server-core/src/main/java/io/onedev/server/util/ManualConfigStep.java index 3ac5916886..4dc89f85ed 100644 --- a/server-core/src/main/java/io/onedev/server/util/ManualConfigStep.java +++ b/server-core/src/main/java/io/onedev/server/util/ManualConfigStep.java @@ -12,7 +12,6 @@ import io.onedev.server.web.component.wizard.WizardStep; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") public class ManualConfigStep implements WizardStep { private ManualConfig config; diff --git a/server-core/src/main/java/io/onedev/server/util/Path.java b/server-core/src/main/java/io/onedev/server/util/Path.java index 36987f4de6..b346a2d773 100644 --- a/server-core/src/main/java/io/onedev/server/util/Path.java +++ b/server-core/src/main/java/io/onedev/server/util/Path.java @@ -9,7 +9,6 @@ import javax.annotation.Nullable; import com.google.common.collect.Lists; -@SuppressWarnings("serial") public class Path implements Serializable { private List nodes = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/util/PathNode.java b/server-core/src/main/java/io/onedev/server/util/PathNode.java index 21b988d88f..02346fc9fa 100644 --- a/server-core/src/main/java/io/onedev/server/util/PathNode.java +++ b/server-core/src/main/java/io/onedev/server/util/PathNode.java @@ -9,7 +9,6 @@ import com.google.common.base.Preconditions; public interface PathNode extends Serializable { - @SuppressWarnings("serial") class Named implements PathNode { private final String name; @@ -48,7 +47,6 @@ public interface PathNode extends Serializable { } - @SuppressWarnings("serial") class Indexed implements PathNode { private final int index; diff --git a/server-core/src/main/java/io/onedev/server/util/artifact/ArtifactInfo.java b/server-core/src/main/java/io/onedev/server/util/artifact/ArtifactInfo.java index 2a8cdef269..5a1ebc2b1a 100644 --- a/server-core/src/main/java/io/onedev/server/util/artifact/ArtifactInfo.java +++ b/server-core/src/main/java/io/onedev/server/util/artifact/ArtifactInfo.java @@ -23,6 +23,7 @@ public abstract class ArtifactInfo implements Serializable { this.lastModified = lastModified; } + @SuppressWarnings("unused") private static ArtifactInfo getExample() { List children = new ArrayList<>(); children.add(new DirectoryInfo("directory/sub-directory", 1, null)); diff --git a/server-core/src/main/java/io/onedev/server/util/concurrent/BatchWorker.java b/server-core/src/main/java/io/onedev/server/util/concurrent/BatchWorker.java index e37b9beea6..41d84c742f 100644 --- a/server-core/src/main/java/io/onedev/server/util/concurrent/BatchWorker.java +++ b/server-core/src/main/java/io/onedev/server/util/concurrent/BatchWorker.java @@ -1,7 +1,6 @@ package io.onedev.server.util.concurrent; import java.io.Serializable; -import java.util.Collection; import java.util.List; import org.apache.commons.lang3.builder.EqualsBuilder; diff --git a/server-core/src/main/java/io/onedev/server/util/concurrent/PrioritizedFutureTask.java b/server-core/src/main/java/io/onedev/server/util/concurrent/PrioritizedFutureTask.java index 383acf5742..e0f7e9894b 100644 --- a/server-core/src/main/java/io/onedev/server/util/concurrent/PrioritizedFutureTask.java +++ b/server-core/src/main/java/io/onedev/server/util/concurrent/PrioritizedFutureTask.java @@ -2,8 +2,7 @@ package io.onedev.server.util.concurrent; import java.util.concurrent.FutureTask; -public class PrioritizedFutureTask extends FutureTask - implements PriorityAware, Comparable { +public class PrioritizedFutureTask extends FutureTask implements PriorityAware { private final int priority; diff --git a/server-core/src/main/java/io/onedev/server/util/criteria/AndCriteria.java b/server-core/src/main/java/io/onedev/server/util/criteria/AndCriteria.java index f8242317eb..573f0e226a 100644 --- a/server-core/src/main/java/io/onedev/server/util/criteria/AndCriteria.java +++ b/server-core/src/main/java/io/onedev/server/util/criteria/AndCriteria.java @@ -29,7 +29,7 @@ public class AndCriteria extends Criteria { protected final List> criterias; - public AndCriteria(Criteria...criterias) { + public AndCriteria(@SuppressWarnings("unchecked") Criteria...criterias) { this(Arrays.asList(criterias)); } diff --git a/server-core/src/main/java/io/onedev/server/util/criteria/OrCriteria.java b/server-core/src/main/java/io/onedev/server/util/criteria/OrCriteria.java index 369b17a0ab..8593faedec 100644 --- a/server-core/src/main/java/io/onedev/server/util/criteria/OrCriteria.java +++ b/server-core/src/main/java/io/onedev/server/util/criteria/OrCriteria.java @@ -29,7 +29,7 @@ public class OrCriteria extends Criteria { protected final List> criterias; - public OrCriteria(Criteria...criterias) { + public OrCriteria(@SuppressWarnings("unchecked") Criteria...criterias) { this(Arrays.asList(criterias)); } diff --git a/server-core/src/main/java/io/onedev/server/util/facade/AccessTokenCache.java b/server-core/src/main/java/io/onedev/server/util/facade/AccessTokenCache.java index 24cebb18c8..ff2649920c 100644 --- a/server-core/src/main/java/io/onedev/server/util/facade/AccessTokenCache.java +++ b/server-core/src/main/java/io/onedev/server/util/facade/AccessTokenCache.java @@ -1,13 +1,12 @@ package io.onedev.server.util.facade; -import io.onedev.server.model.User; -import io.onedev.server.util.MapProxy; - -import javax.annotation.Nullable; -import java.io.Serializable; import java.util.Map; -public class AccessTokenCache extends MapProxy implements Serializable { +import javax.annotation.Nullable; + +import io.onedev.server.util.MapProxy; + +public class AccessTokenCache extends MapProxy { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/util/facade/EmailAddressCache.java b/server-core/src/main/java/io/onedev/server/util/facade/EmailAddressCache.java index 9ba8d334c6..d941b8de6c 100644 --- a/server-core/src/main/java/io/onedev/server/util/facade/EmailAddressCache.java +++ b/server-core/src/main/java/io/onedev/server/util/facade/EmailAddressCache.java @@ -1,6 +1,5 @@ package io.onedev.server.util.facade; -import java.io.Serializable; import java.util.HashMap; import java.util.Map; @@ -12,7 +11,7 @@ import org.eclipse.jgit.lib.PersonIdent; import io.onedev.server.model.User; import io.onedev.server.util.MapProxy; -public class EmailAddressCache extends MapProxy implements Serializable { +public class EmailAddressCache extends MapProxy { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/util/facade/GroupCache.java b/server-core/src/main/java/io/onedev/server/util/facade/GroupCache.java index 70184914a8..da6f301ae3 100644 --- a/server-core/src/main/java/io/onedev/server/util/facade/GroupCache.java +++ b/server-core/src/main/java/io/onedev/server/util/facade/GroupCache.java @@ -1,6 +1,5 @@ package io.onedev.server.util.facade; -import java.io.Serializable; import java.util.HashMap; import java.util.Map; @@ -8,7 +7,7 @@ import javax.annotation.Nullable; import io.onedev.server.util.MapProxy; -public class GroupCache extends MapProxy implements Serializable { +public class GroupCache extends MapProxy { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/util/facade/LinkSpecFacade.java b/server-core/src/main/java/io/onedev/server/util/facade/LinkSpecFacade.java index a745d7a237..fa989eefb5 100644 --- a/server-core/src/main/java/io/onedev/server/util/facade/LinkSpecFacade.java +++ b/server-core/src/main/java/io/onedev/server/util/facade/LinkSpecFacade.java @@ -2,8 +2,6 @@ package io.onedev.server.util.facade; import javax.annotation.Nullable; -import io.onedev.server.model.LinkSpec; - public class LinkSpecFacade extends EntityFacade { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/util/facade/ProjectCache.java b/server-core/src/main/java/io/onedev/server/util/facade/ProjectCache.java index 67bcb74abd..3d425e78ed 100644 --- a/server-core/src/main/java/io/onedev/server/util/facade/ProjectCache.java +++ b/server-core/src/main/java/io/onedev/server/util/facade/ProjectCache.java @@ -1,6 +1,22 @@ package io.onedev.server.util.facade; +import static io.onedev.commons.utils.match.WildcardUtils.matchPath; +import static java.util.Comparator.comparing; +import static java.util.stream.Collectors.toSet; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.Comparator; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; + +import javax.annotation.Nullable; + import com.google.common.collect.Sets; + import io.onedev.commons.utils.match.PathMatcher; import io.onedev.server.OneDev; import io.onedev.server.entitymanager.ProjectManager; @@ -9,15 +25,7 @@ import io.onedev.server.util.MapProxy; import io.onedev.server.util.Similarities; import io.onedev.server.util.patternset.PatternSet; -import javax.annotation.Nullable; -import java.io.Serializable; -import java.util.*; - -import static io.onedev.commons.utils.match.WildcardUtils.matchPath; -import static java.util.Comparator.comparing; -import static java.util.stream.Collectors.toSet; - -public class ProjectCache extends MapProxy implements Serializable { +public class ProjectCache extends MapProxy { public ProjectCache(Map delegate) { super(delegate); diff --git a/server-core/src/main/java/io/onedev/server/util/facade/RoleCache.java b/server-core/src/main/java/io/onedev/server/util/facade/RoleCache.java index a071b7c43f..15d828795a 100644 --- a/server-core/src/main/java/io/onedev/server/util/facade/RoleCache.java +++ b/server-core/src/main/java/io/onedev/server/util/facade/RoleCache.java @@ -1,13 +1,13 @@ package io.onedev.server.util.facade; -import io.onedev.server.util.MapProxy; - -import javax.annotation.Nullable; -import java.io.Serializable; import java.util.HashMap; import java.util.Map; -public class RoleCache extends MapProxy implements Serializable { +import javax.annotation.Nullable; + +import io.onedev.server.util.MapProxy; + +public class RoleCache extends MapProxy { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/util/facade/UserCache.java b/server-core/src/main/java/io/onedev/server/util/facade/UserCache.java index 15ef37500d..ceb382927e 100644 --- a/server-core/src/main/java/io/onedev/server/util/facade/UserCache.java +++ b/server-core/src/main/java/io/onedev/server/util/facade/UserCache.java @@ -1,20 +1,20 @@ package io.onedev.server.util.facade; +import java.util.Collection; +import java.util.Comparator; +import java.util.HashMap; +import java.util.Map; +import java.util.stream.Collectors; + +import javax.annotation.Nullable; + import io.onedev.server.OneDev; import io.onedev.server.entitymanager.UserManager; import io.onedev.server.model.User; import io.onedev.server.util.MapProxy; import io.onedev.server.util.Similarities; -import javax.annotation.Nullable; -import java.io.Serializable; -import java.util.Collection; -import java.util.Comparator; -import java.util.HashMap; -import java.util.Map; -import java.util.stream.Collectors; - -public class UserCache extends MapProxy implements Serializable { +public class UserCache extends MapProxy { private static final long serialVersionUID = 1L; diff --git a/server-core/src/main/java/io/onedev/server/util/init/InitStage.java b/server-core/src/main/java/io/onedev/server/util/init/InitStage.java index 75d041d499..6527bd7941 100644 --- a/server-core/src/main/java/io/onedev/server/util/init/InitStage.java +++ b/server-core/src/main/java/io/onedev/server/util/init/InitStage.java @@ -4,7 +4,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class InitStage implements Serializable, Cloneable { private final String message; diff --git a/server-core/src/main/java/io/onedev/server/util/init/ManualConfig.java b/server-core/src/main/java/io/onedev/server/util/init/ManualConfig.java index 6707dda616..813cf94465 100644 --- a/server-core/src/main/java/io/onedev/server/util/init/ManualConfig.java +++ b/server-core/src/main/java/io/onedev/server/util/init/ManualConfig.java @@ -6,7 +6,6 @@ import java.util.HashSet; import javax.annotation.Nullable; -@SuppressWarnings("serial") public abstract class ManualConfig implements Serializable { private final String title; diff --git a/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/EntityDeserializer.java b/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/EntityDeserializer.java index 46e0ed4504..2f9e11d2ff 100644 --- a/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/EntityDeserializer.java +++ b/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/EntityDeserializer.java @@ -16,7 +16,6 @@ import org.hibernate.proxy.HibernateProxy; import java.io.IOException; import java.util.Stack; -@SuppressWarnings("serial") public class EntityDeserializer extends BeanDeserializer { private static ThreadLocal> paramsStack = ThreadLocal.withInitial(() -> new Stack()); diff --git a/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/ForeignKeyDeserializer.java b/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/ForeignKeyDeserializer.java index 4e82f2c282..3c6aa3dec4 100644 --- a/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/ForeignKeyDeserializer.java +++ b/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/ForeignKeyDeserializer.java @@ -10,7 +10,6 @@ import io.onedev.server.persistence.dao.Dao; import java.io.IOException; -@SuppressWarnings("serial") public final class ForeignKeyDeserializer extends StdDeserializer { public ForeignKeyDeserializer(Class entityClass) { diff --git a/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/HibernateAnnotationIntrospector.java b/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/HibernateAnnotationIntrospector.java index 9e42aa20dd..12d544fc84 100644 --- a/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/HibernateAnnotationIntrospector.java +++ b/server-core/src/main/java/io/onedev/server/util/jackson/hibernate/HibernateAnnotationIntrospector.java @@ -16,7 +16,6 @@ import com.fasterxml.jackson.databind.introspect.AnnotatedMember; import io.onedev.server.model.AbstractEntity; -@SuppressWarnings("serial") public class HibernateAnnotationIntrospector extends AnnotationIntrospector { @Override diff --git a/server-core/src/main/java/io/onedev/server/validation/validator/BranchNameValidator.java b/server-core/src/main/java/io/onedev/server/validation/validator/BranchNameValidator.java index 0bf6912217..96c60678b0 100644 --- a/server-core/src/main/java/io/onedev/server/validation/validator/BranchNameValidator.java +++ b/server-core/src/main/java/io/onedev/server/validation/validator/BranchNameValidator.java @@ -1,13 +1,13 @@ package io.onedev.server.validation.validator; -import io.onedev.server.annotation.BranchName; -import io.onedev.server.annotation.TagName; -import io.onedev.server.git.GitUtils; -import org.eclipse.jgit.lib.Repository; - import javax.validation.ConstraintValidator; import javax.validation.ConstraintValidatorContext; +import org.eclipse.jgit.lib.Repository; + +import io.onedev.server.annotation.BranchName; +import io.onedev.server.git.GitUtils; + public class BranchNameValidator implements ConstraintValidator { private String message; diff --git a/server-core/src/main/java/io/onedev/server/validation/validator/CodeValidator.java b/server-core/src/main/java/io/onedev/server/validation/validator/CodeValidator.java index 0122e6b95c..ea62ab1eb0 100644 --- a/server-core/src/main/java/io/onedev/server/validation/validator/CodeValidator.java +++ b/server-core/src/main/java/io/onedev/server/validation/validator/CodeValidator.java @@ -23,6 +23,7 @@ public class CodeValidator implements ConstraintValidator { message = constaintAnnotation.message(); } + @SuppressWarnings("unchecked") @Override public boolean isValid(Object value, ConstraintValidatorContext constraintContext) { if (value instanceof String && StringUtils.isNotBlank((String)value) diff --git a/server-core/src/main/java/io/onedev/server/validation/validator/DataDirectoryValidator.java b/server-core/src/main/java/io/onedev/server/validation/validator/DataDirectoryValidator.java index fe93671ee4..e1a284c05d 100644 --- a/server-core/src/main/java/io/onedev/server/validation/validator/DataDirectoryValidator.java +++ b/server-core/src/main/java/io/onedev/server/validation/validator/DataDirectoryValidator.java @@ -6,7 +6,6 @@ import javax.validation.ConstraintValidator; import javax.validation.ConstraintValidatorContext; import io.onedev.commons.bootstrap.Bootstrap; -import io.onedev.commons.utils.FileUtils; import io.onedev.server.annotation.DataDirectory; public class DataDirectoryValidator implements ConstraintValidator { diff --git a/server-core/src/main/java/io/onedev/server/validation/validator/NoSpaceValidator.java b/server-core/src/main/java/io/onedev/server/validation/validator/NoSpaceValidator.java index 7c2637495a..d89a08acc9 100644 --- a/server-core/src/main/java/io/onedev/server/validation/validator/NoSpaceValidator.java +++ b/server-core/src/main/java/io/onedev/server/validation/validator/NoSpaceValidator.java @@ -1,12 +1,10 @@ package io.onedev.server.validation.validator; -import io.onedev.server.annotation.NoSpace; -import io.onedev.server.annotation.SubPath; -import org.apache.commons.io.FilenameUtils; - import javax.validation.ConstraintValidator; import javax.validation.ConstraintValidatorContext; +import io.onedev.server.annotation.NoSpace; + public class NoSpaceValidator implements ConstraintValidator { private String message; diff --git a/server-core/src/main/java/io/onedev/server/validation/validator/PackQueryValidator.java b/server-core/src/main/java/io/onedev/server/validation/validator/PackQueryValidator.java index aa827abfa2..cb1598107e 100644 --- a/server-core/src/main/java/io/onedev/server/validation/validator/PackQueryValidator.java +++ b/server-core/src/main/java/io/onedev/server/validation/validator/PackQueryValidator.java @@ -16,7 +16,7 @@ public class PackQueryValidator implements ConstraintValidator projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/BuildQueryBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/BuildQueryBehavior.java index c577aaf489..0e7007c2f1 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/BuildQueryBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/BuildQueryBehavior.java @@ -30,7 +30,6 @@ import javax.annotation.Nullable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class BuildQueryBehavior extends ANTLRAssistBehavior { private static final String FUZZY_SUGGESTION_DESCRIPTION_PREFIX = "enclose with ~"; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/CodeCommentQueryBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/CodeCommentQueryBehavior.java index 1eeca35391..483f4160e3 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/CodeCommentQueryBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/CodeCommentQueryBehavior.java @@ -28,7 +28,6 @@ import java.util.List; import static io.onedev.server.search.entity.codecomment.CodeCommentQuery.getRuleName; import static io.onedev.server.search.entity.codecomment.CodeCommentQueryLexer.*; -@SuppressWarnings("serial") public class CodeCommentQueryBehavior extends ANTLRAssistBehavior { private static final String FUZZY_SUGGESTION_DESCRIPTION_PREFIX = "enclose with ~"; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/CommitQueryBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/CommitQueryBehavior.java index ebce35e691..efc9a98cd2 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/CommitQueryBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/CommitQueryBehavior.java @@ -29,7 +29,6 @@ import java.util.LinkedHashMap; import java.util.List; import java.util.Map; -@SuppressWarnings("serial") public class CommitQueryBehavior extends ANTLRAssistBehavior { private static final String FUZZY_SUGGESTION_DESCRIPTION_PREFIX = "enclose with ~"; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/CtrlClickBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/CtrlClickBehavior.java index 713cdc1510..b64375d506 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/CtrlClickBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/CtrlClickBehavior.java @@ -6,7 +6,6 @@ import org.apache.wicket.behavior.Behavior; import org.apache.wicket.markup.head.IHeaderResponse; import org.apache.wicket.markup.head.OnDomReadyHeaderItem; -@SuppressWarnings("serial") public class CtrlClickBehavior extends Behavior { private Component delegate; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/DisplayNoneBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/DisplayNoneBehavior.java index f06b8e86f1..ab31068bf5 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/DisplayNoneBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/DisplayNoneBehavior.java @@ -4,7 +4,6 @@ import org.apache.wicket.Component; import org.apache.wicket.behavior.AttributeAppender; import org.apache.wicket.model.Model; -@SuppressWarnings("serial") public class DisplayNoneBehavior extends AttributeAppender { public DisplayNoneBehavior() { diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/InputChangeBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/InputChangeBehavior.java index 905b61473a..9c29231973 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/InputChangeBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/InputChangeBehavior.java @@ -6,7 +6,6 @@ import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior; import org.apache.wicket.markup.html.form.FormComponent; -@SuppressWarnings("serial") public abstract class InputChangeBehavior extends AjaxFormComponentUpdatingBehavior{ private String input; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/InterpolativeAssistBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/InterpolativeAssistBehavior.java index b35bf0b82f..7b30f6ab19 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/InterpolativeAssistBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/InterpolativeAssistBehavior.java @@ -13,11 +13,9 @@ import io.onedev.commons.codeassist.grammar.LexerRuleRefElementSpec; import io.onedev.commons.codeassist.parser.ParseExpect; import io.onedev.commons.codeassist.parser.TerminalExpect; import io.onedev.commons.utils.StringUtils; -import io.onedev.server.util.Input; import io.onedev.server.util.interpolative.InterpolativeParser; import io.onedev.server.web.behavior.inputassist.ANTLRAssistBehavior; -@SuppressWarnings("serial") public abstract class InterpolativeAssistBehavior extends ANTLRAssistBehavior { public InterpolativeAssistBehavior() { diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/InterpolativePatternSetAssistBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/InterpolativePatternSetAssistBehavior.java index d91e873704..f9d79272d2 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/InterpolativePatternSetAssistBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/InterpolativePatternSetAssistBehavior.java @@ -22,7 +22,6 @@ import io.onedev.server.util.patternset.InterpolativePatternSetLexer; import io.onedev.server.util.patternset.InterpolativePatternSetParser; import io.onedev.server.web.behavior.inputassist.ANTLRAssistBehavior; -@SuppressWarnings("serial") public abstract class InterpolativePatternSetAssistBehavior extends ANTLRAssistBehavior { public InterpolativePatternSetAssistBehavior() { diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/JobMatchBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/JobMatchBehavior.java index 2f7e071818..6a20a7eb03 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/JobMatchBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/JobMatchBehavior.java @@ -26,7 +26,6 @@ import static io.onedev.commons.codeassist.AntlrUtils.getLexerRule; import static io.onedev.commons.codeassist.AntlrUtils.getLexerRuleName; import static io.onedev.server.job.match.JobMatchLexer.*; -@SuppressWarnings("serial") public class JobMatchBehavior extends ANTLRAssistBehavior { private final boolean withProjectCriteria; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/NotificationReceiverBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/NotificationReceiverBehavior.java index d71ab33163..12eb837c22 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/NotificationReceiverBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/NotificationReceiverBehavior.java @@ -17,7 +17,6 @@ import io.onedev.server.model.Project; import io.onedev.server.web.behavior.inputassist.ANTLRAssistBehavior; import io.onedev.server.web.util.SuggestionUtils; -@SuppressWarnings("serial") public class NotificationReceiverBehavior extends ANTLRAssistBehavior { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/OnTypingDoneBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/OnTypingDoneBehavior.java index a9f440b45a..14b1722b76 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/OnTypingDoneBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/OnTypingDoneBehavior.java @@ -9,7 +9,6 @@ import org.apache.wicket.markup.head.OnDomReadyHeaderItem; import io.onedev.server.web.asset.doneevents.DoneEventsResourceReference; -@SuppressWarnings("serial") public abstract class OnTypingDoneBehavior extends AjaxFormComponentUpdatingBehavior { private int timeout; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/PackQueryBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/PackQueryBehavior.java index 782b8628fd..fd2ea7023c 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/PackQueryBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/PackQueryBehavior.java @@ -30,7 +30,6 @@ import java.util.List; import static io.onedev.server.model.Pack.*; -@SuppressWarnings("serial") public class PackQueryBehavior extends ANTLRAssistBehavior { private static final String FUZZY_SUGGESTION_DESCRIPTION_PREFIX = "enclose with ~"; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/PatternSetAssistBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/PatternSetAssistBehavior.java index 598e395d60..8c712882bd 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/PatternSetAssistBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/PatternSetAssistBehavior.java @@ -20,7 +20,6 @@ import io.onedev.server.util.patternset.PatternSetLexer; import io.onedev.server.util.patternset.PatternSetParser; import io.onedev.server.web.behavior.inputassist.ANTLRAssistBehavior; -@SuppressWarnings("serial") public abstract class PatternSetAssistBehavior extends ANTLRAssistBehavior { public PatternSetAssistBehavior() { diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/ProjectQueryBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/ProjectQueryBehavior.java index 608690929a..bacf08bdef 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/ProjectQueryBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/ProjectQueryBehavior.java @@ -34,7 +34,6 @@ import java.util.stream.Collectors; import static io.onedev.server.search.entity.project.ProjectQuery.getRuleName; import static io.onedev.server.search.entity.project.ProjectQueryParser.*; -@SuppressWarnings("serial") public class ProjectQueryBehavior extends ANTLRAssistBehavior { private static final String FUZZY_SUGGESTION_DESCRIPTION_PREFIX = "enclose with ~"; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/ReferenceInputBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/ReferenceInputBehavior.java index d677e61ef2..7bd2e693e5 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/ReferenceInputBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/ReferenceInputBehavior.java @@ -1,24 +1,22 @@ package io.onedev.server.web.behavior; -import io.onedev.commons.codeassist.InputCompletion; -import io.onedev.commons.codeassist.InputStatus; -import io.onedev.commons.codeassist.InputSuggestion; -import io.onedev.commons.utils.LinearRange; -import io.onedev.server.OneDev; -import io.onedev.server.entitymanager.ProjectManager; -import io.onedev.server.model.Project; -import io.onedev.server.validation.validator.ProjectKeyValidator; -import io.onedev.server.validation.validator.ProjectPathValidator; -import io.onedev.server.web.behavior.inputassist.InputAssistBehavior; -import io.onedev.server.web.util.SuggestionUtils; +import static java.lang.String.format; +import static org.apache.commons.lang3.StringUtils.deleteWhitespace; import java.util.ArrayList; import java.util.List; import java.util.regex.Matcher; import java.util.regex.Pattern; -import static java.lang.String.format; -import static org.apache.commons.lang3.StringUtils.deleteWhitespace; +import io.onedev.commons.codeassist.InputCompletion; +import io.onedev.commons.codeassist.InputStatus; +import io.onedev.commons.codeassist.InputSuggestion; +import io.onedev.commons.utils.LinearRange; +import io.onedev.server.model.Project; +import io.onedev.server.validation.validator.ProjectKeyValidator; +import io.onedev.server.validation.validator.ProjectPathValidator; +import io.onedev.server.web.behavior.inputassist.InputAssistBehavior; +import io.onedev.server.web.util.SuggestionUtils; public abstract class ReferenceInputBehavior extends InputAssistBehavior { diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/RetryConditionBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/RetryConditionBehavior.java index eaeec702e9..97a2cdf062 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/RetryConditionBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/RetryConditionBehavior.java @@ -27,7 +27,6 @@ import io.onedev.server.model.Build; import io.onedev.server.web.behavior.inputassist.ANTLRAssistBehavior; import io.onedev.server.web.util.SuggestionUtils; -@SuppressWarnings("serial") public class RetryConditionBehavior extends ANTLRAssistBehavior { public RetryConditionBehavior() { diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/RunTaskBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/RunTaskBehavior.java index fdde18f78f..a1be4c4d11 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/RunTaskBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/RunTaskBehavior.java @@ -2,7 +2,6 @@ package io.onedev.server.web.behavior; import org.apache.wicket.ajax.AjaxRequestTarget; -@SuppressWarnings("serial") public abstract class RunTaskBehavior extends AbstractPostAjaxBehavior { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/SelectByTypingBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/SelectByTypingBehavior.java index 32b82cca24..05973c3a70 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/SelectByTypingBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/SelectByTypingBehavior.java @@ -8,7 +8,6 @@ import org.apache.wicket.markup.head.OnDomReadyHeaderItem; import io.onedev.server.web.asset.selectbytyping.SelectByTypingResourceReference; -@SuppressWarnings("serial") public class SelectByTypingBehavior extends Behavior { private final Component container; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/UserMatchBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/UserMatchBehavior.java index f90208f90c..cfeae4efdd 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/UserMatchBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/UserMatchBehavior.java @@ -13,7 +13,6 @@ import java.util.List; import static io.onedev.server.util.usermatch.UserMatchLexer.GROUP; import static io.onedev.server.util.usermatch.UserMatchLexer.USER; -@SuppressWarnings("serial") public class UserMatchBehavior extends ANTLRAssistBehavior { public UserMatchBehavior() { diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/bootstrapswitch/BootstrapSwitchBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/bootstrapswitch/BootstrapSwitchBehavior.java index e751ca5d12..77f86d3302 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/bootstrapswitch/BootstrapSwitchBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/bootstrapswitch/BootstrapSwitchBehavior.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.head.IHeaderResponse; import org.apache.wicket.markup.head.JavaScriptHeaderItem; import org.apache.wicket.markup.head.OnDomReadyHeaderItem; -@SuppressWarnings("serial") public class BootstrapSwitchBehavior extends Behavior { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/dropdown/DropdownHoverBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/dropdown/DropdownHoverBehavior.java index de2629bb48..671db22315 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/dropdown/DropdownHoverBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/dropdown/DropdownHoverBehavior.java @@ -15,7 +15,6 @@ import io.onedev.server.web.component.floating.Alignment; import io.onedev.server.web.component.floating.ComponentTarget; import io.onedev.server.web.component.floating.FloatingPanel; -@SuppressWarnings("serial") public abstract class DropdownHoverBehavior extends AbstractPostAjaxBehavior { private static final int DEFAULT_HOVER_DELAY = 350; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/infinitescroll/InfiniteScrollBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/infinitescroll/InfiniteScrollBehavior.java index a894c3d90d..3be9fe71b3 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/infinitescroll/InfiniteScrollBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/infinitescroll/InfiniteScrollBehavior.java @@ -15,7 +15,6 @@ import org.apache.wicket.markup.html.WebMarkupContainer; import org.apache.wicket.markup.repeater.RepeatingView; import org.apache.wicket.request.IRequestParameters; import org.apache.wicket.request.cycle.RequestCycle; -import org.apache.wicket.util.visit.IVisit; import org.apache.wicket.util.visit.IVisitor; import org.unbescape.javascript.JavaScriptEscape; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/ANTLRAssistBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/ANTLRAssistBehavior.java index 106a55aab3..ba4db26422 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/ANTLRAssistBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/ANTLRAssistBehavior.java @@ -15,7 +15,6 @@ import java.lang.reflect.Method; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public abstract class ANTLRAssistBehavior extends InputAssistBehavior { protected final Class lexerClass; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.java b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.java index a3c618e48e..c5baee951d 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.java @@ -14,7 +14,6 @@ import org.unbescape.html.HtmlEscape; import java.util.List; -@SuppressWarnings("serial") abstract class AssistPanel extends Panel { private static final int PAGE_SIZE = 25; diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/InputAssistBehavior.java b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/InputAssistBehavior.java index c415819233..28c3f60ca4 100644 --- a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/InputAssistBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/InputAssistBehavior.java @@ -29,7 +29,6 @@ import java.util.List; import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; -@SuppressWarnings("serial") public abstract class InputAssistBehavior extends AbstractPostAjaxBehavior { public static final int MAX_SUGGESTIONS = 1000; diff --git a/server-core/src/main/java/io/onedev/server/web/component/AgentStatusBadge.java b/server-core/src/main/java/io/onedev/server/web/component/AgentStatusBadge.java index bfc8c35818..1b3eb18b3d 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/AgentStatusBadge.java +++ b/server-core/src/main/java/io/onedev/server/web/component/AgentStatusBadge.java @@ -7,7 +7,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import io.onedev.server.model.Agent; -@SuppressWarnings("serial") public class AgentStatusBadge extends Label { private final IModel agentModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/EmailAddressVerificationStatusBadge.java b/server-core/src/main/java/io/onedev/server/web/component/EmailAddressVerificationStatusBadge.java index 2bdcf65ba6..17f0709677 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/EmailAddressVerificationStatusBadge.java +++ b/server-core/src/main/java/io/onedev/server/web/component/EmailAddressVerificationStatusBadge.java @@ -7,7 +7,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import io.onedev.server.model.EmailAddress; -@SuppressWarnings("serial") public class EmailAddressVerificationStatusBadge extends Label { private final IModel emailAddressModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/LabelBadge.java b/server-core/src/main/java/io/onedev/server/web/component/LabelBadge.java index 69600b6cb5..113bb9739d 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/LabelBadge.java +++ b/server-core/src/main/java/io/onedev/server/web/component/LabelBadge.java @@ -9,7 +9,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.model.LabelSpec; import io.onedev.server.util.ColorUtils; -@SuppressWarnings("serial") public class LabelBadge extends WebComponent { public LabelBadge(String id, IModel model) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/MultilineLabel.java b/server-core/src/main/java/io/onedev/server/web/component/MultilineLabel.java index cf1d1696ec..f1e4d80360 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/MultilineLabel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/MultilineLabel.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.html.basic.MultiLineLabel; import org.apache.wicket.model.IModel; import org.apache.wicket.util.string.AppendingStringBuffer; -@SuppressWarnings("serial") public class MultilineLabel extends MultiLineLabel { public MultilineLabel(String id) { super(id); diff --git a/server-core/src/main/java/io/onedev/server/web/component/NoRecordsPlaceholder.java b/server-core/src/main/java/io/onedev/server/web/component/NoRecordsPlaceholder.java index 59170bdf6c..709792511f 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/NoRecordsPlaceholder.java +++ b/server-core/src/main/java/io/onedev/server/web/component/NoRecordsPlaceholder.java @@ -4,7 +4,6 @@ import org.apache.wicket.behavior.AttributeAppender; import org.apache.wicket.markup.html.WebMarkupContainer; import org.apache.wicket.markup.html.navigation.paging.IPageableItems; -@SuppressWarnings("serial") public class NoRecordsPlaceholder extends WebMarkupContainer { private final IPageableItems pageable; diff --git a/server-core/src/main/java/io/onedev/server/web/component/avatarupload/AvatarUploadField.java b/server-core/src/main/java/io/onedev/server/web/component/avatarupload/AvatarUploadField.java index aac5914594..9b62ce99dc 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/avatarupload/AvatarUploadField.java +++ b/server-core/src/main/java/io/onedev/server/web/component/avatarupload/AvatarUploadField.java @@ -26,7 +26,6 @@ import io.onedev.commons.utils.FileUtils; import io.onedev.commons.utils.StringUtils; import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; -@SuppressWarnings("serial") public class AvatarUploadField extends FormComponentPanel { private TextField dataField; diff --git a/server-core/src/main/java/io/onedev/server/web/component/beaneditmodal/BeanEditContentPanel.java b/server-core/src/main/java/io/onedev/server/web/component/beaneditmodal/BeanEditContentPanel.java index 8f2b9612e5..e249b443be 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/beaneditmodal/BeanEditContentPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/beaneditmodal/BeanEditContentPanel.java @@ -21,7 +21,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.Collection; -@SuppressWarnings("serial") abstract class BeanEditContentPanel extends Panel { public BeanEditContentPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/beaneditmodal/BeanEditModalPanel.java b/server-core/src/main/java/io/onedev/server/web/component/beaneditmodal/BeanEditModalPanel.java index 09fc61c5cd..53c3ee33d9 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/beaneditmodal/BeanEditModalPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/beaneditmodal/BeanEditModalPanel.java @@ -1,17 +1,17 @@ package io.onedev.server.web.component.beaneditmodal; -import io.onedev.server.web.component.modal.ModalPanel; -import io.onedev.server.web.editable.BeanEditor; -import org.apache.wicket.Component; -import org.apache.wicket.ajax.AjaxRequestTarget; -import org.apache.wicket.core.request.handler.IPartialPageRequestHandler; - -import javax.annotation.Nullable; import java.io.Serializable; import java.util.Collection; import java.util.HashSet; -@SuppressWarnings("serial") +import javax.annotation.Nullable; + +import org.apache.wicket.Component; +import org.apache.wicket.ajax.AjaxRequestTarget; +import org.apache.wicket.core.request.handler.IPartialPageRequestHandler; + +import io.onedev.server.web.component.modal.ModalPanel; + public abstract class BeanEditModalPanel extends ModalPanel { private final T bean; diff --git a/server-core/src/main/java/io/onedev/server/web/component/blob/BlobFolderSelector.java b/server-core/src/main/java/io/onedev/server/web/component/blob/BlobFolderSelector.java index a610170616..c021b27968 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/blob/BlobFolderSelector.java +++ b/server-core/src/main/java/io/onedev/server/web/component/blob/BlobFolderSelector.java @@ -29,7 +29,6 @@ import io.onedev.server.git.BlobIdentFilter; import io.onedev.server.model.Project; import io.onedev.server.web.component.link.ViewStateAwareAjaxLink; -@SuppressWarnings("serial") public abstract class BlobFolderSelector extends Panel { private final ObjectId commitId; diff --git a/server-core/src/main/java/io/onedev/server/web/component/blob/BlobIcon.java b/server-core/src/main/java/io/onedev/server/web/component/blob/BlobIcon.java index 60e98f5082..6d6471c3c1 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/blob/BlobIcon.java +++ b/server-core/src/main/java/io/onedev/server/web/component/blob/BlobIcon.java @@ -10,7 +10,6 @@ import io.onedev.server.git.BlobIdent; import io.onedev.server.web.asset.icon.IconScope; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") public class BlobIcon extends WebComponent { public BlobIcon(String id, IModel model) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/blob/BlobPicker.java b/server-core/src/main/java/io/onedev/server/web/component/blob/BlobPicker.java index 6b5926b6cd..a33c36e430 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/blob/BlobPicker.java +++ b/server-core/src/main/java/io/onedev/server/web/component/blob/BlobPicker.java @@ -23,7 +23,6 @@ import io.onedev.server.web.component.floating.FloatingPanel; import io.onedev.server.web.component.link.DropdownLink; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") public abstract class BlobPicker extends DropdownLink { private final IModel commitModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/blob/BlobResourceReference.java b/server-core/src/main/java/io/onedev/server/web/component/blob/BlobResourceReference.java index 7ba6fd6f57..69e7856314 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/blob/BlobResourceReference.java +++ b/server-core/src/main/java/io/onedev/server/web/component/blob/BlobResourceReference.java @@ -2,7 +2,6 @@ package io.onedev.server.web.component.blob; import io.onedev.server.web.page.base.BaseDependentCssResourceReference; -@SuppressWarnings("serial") public class BlobResourceReference extends BaseDependentCssResourceReference { public BlobResourceReference() { diff --git a/server-core/src/main/java/io/onedev/server/web/component/blob/BlobSelector.java b/server-core/src/main/java/io/onedev/server/web/component/blob/BlobSelector.java index 9bd134f3a7..aad65152eb 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/blob/BlobSelector.java +++ b/server-core/src/main/java/io/onedev/server/web/component/blob/BlobSelector.java @@ -30,7 +30,6 @@ import java.util.Iterator; import java.util.List; import java.util.Set; -@SuppressWarnings("serial") public abstract class BlobSelector extends Panel { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/branch/BranchLink.java b/server-core/src/main/java/io/onedev/server/web/component/branch/BranchLink.java index 05b9c8dc6e..91672eb7b4 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/branch/BranchLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/branch/BranchLink.java @@ -13,7 +13,6 @@ import io.onedev.server.web.component.link.ViewStateAwarePageLink; import io.onedev.server.web.page.project.ProjectPage; import io.onedev.server.web.page.project.blob.ProjectBlobPage; -@SuppressWarnings("serial") public class BranchLink extends ViewStateAwarePageLink { private final ProjectAndBranch projectAndBranch; diff --git a/server-core/src/main/java/io/onedev/server/web/component/branch/choice/BranchMultiChoice.java b/server-core/src/main/java/io/onedev/server/web/component/branch/choice/BranchMultiChoice.java index d6cf2f8300..ac0bc9182b 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/branch/choice/BranchMultiChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/branch/choice/BranchMultiChoice.java @@ -10,7 +10,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.web.component.select2.Select2MultiChoice; import io.onedev.server.web.component.stringchoice.StringChoiceProvider; -@SuppressWarnings("serial") public class BranchMultiChoice extends Select2MultiChoice { public BranchMultiChoice(String id, IModel> model, diff --git a/server-core/src/main/java/io/onedev/server/web/component/branch/choice/BranchSingleChoice.java b/server-core/src/main/java/io/onedev/server/web/component/branch/choice/BranchSingleChoice.java index 1412d4e74e..aaad9a4b2d 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/branch/choice/BranchSingleChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/branch/choice/BranchSingleChoice.java @@ -9,7 +9,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.web.component.select2.Select2Choice; import io.onedev.server.web.component.stringchoice.StringChoiceProvider; -@SuppressWarnings("serial") public class BranchSingleChoice extends Select2Choice { public BranchSingleChoice(String id, IModel model, diff --git a/server-core/src/main/java/io/onedev/server/web/component/branch/create/CreateBranchPanel.java b/server-core/src/main/java/io/onedev/server/web/component/branch/create/CreateBranchPanel.java index bc5365f459..421456214b 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/branch/create/CreateBranchPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/branch/create/CreateBranchPanel.java @@ -19,7 +19,6 @@ import io.onedev.server.util.PathNode; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") public abstract class CreateBranchPanel extends Panel { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/branch/picker/AffinalBranchPicker.java b/server-core/src/main/java/io/onedev/server/web/component/branch/picker/AffinalBranchPicker.java index 93ca8d6eb3..56f28d961d 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/branch/picker/AffinalBranchPicker.java +++ b/server-core/src/main/java/io/onedev/server/web/component/branch/picker/AffinalBranchPicker.java @@ -14,7 +14,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import javax.annotation.Nullable; import java.util.List; -@SuppressWarnings("serial") public abstract class AffinalBranchPicker extends Panel { private Long projectId; diff --git a/server-core/src/main/java/io/onedev/server/web/component/branch/picker/BranchPicker.java b/server-core/src/main/java/io/onedev/server/web/component/branch/picker/BranchPicker.java index 965b99035f..2b0906aa86 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/branch/picker/BranchPicker.java +++ b/server-core/src/main/java/io/onedev/server/web/component/branch/picker/BranchPicker.java @@ -12,7 +12,6 @@ import io.onedev.server.web.component.floating.FloatingPanel; import io.onedev.server.web.component.link.DropdownLink; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") public abstract class BranchPicker extends DropdownLink { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/branch/picker/BranchSelector.java b/server-core/src/main/java/io/onedev/server/web/component/branch/picker/BranchSelector.java index 925a8c5c80..a1853c4333 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/branch/picker/BranchSelector.java +++ b/server-core/src/main/java/io/onedev/server/web/component/branch/picker/BranchSelector.java @@ -31,7 +31,6 @@ import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; import io.onedev.server.web.behavior.InputChangeBehavior; -@SuppressWarnings("serial") public abstract class BranchSelector extends Panel { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/brandlogo/BrandLogoPanel.java b/server-core/src/main/java/io/onedev/server/web/component/brandlogo/BrandLogoPanel.java index 7694d8822d..583b0fe451 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/brandlogo/BrandLogoPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/brandlogo/BrandLogoPanel.java @@ -13,7 +13,6 @@ import javax.annotation.Nullable; import java.io.File; import java.io.Serializable; -@SuppressWarnings("serial") public class BrandLogoPanel extends Panel { private final Boolean darkMode; diff --git a/server-core/src/main/java/io/onedev/server/web/component/build/ParamValuesLabel.java b/server-core/src/main/java/io/onedev/server/web/component/build/ParamValuesLabel.java index 7b0b85a541..166b27d0a4 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/build/ParamValuesLabel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/build/ParamValuesLabel.java @@ -8,7 +8,6 @@ import io.onedev.server.buildspec.param.spec.ParamSpec; import io.onedev.server.buildspecmodel.inputspec.SecretInput; import io.onedev.server.util.Input; -@SuppressWarnings("serial") public class ParamValuesLabel extends Label { public ParamValuesLabel(String id, Input param) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/build/choice/BuildMultiChoice.java b/server-core/src/main/java/io/onedev/server/web/component/build/choice/BuildMultiChoice.java index 2d1817fe7e..9fce76bba6 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/build/choice/BuildMultiChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/build/choice/BuildMultiChoice.java @@ -9,7 +9,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.model.Build; import io.onedev.server.web.component.select2.Select2MultiChoice; -@SuppressWarnings("serial") public class BuildMultiChoice extends Select2MultiChoice { public BuildMultiChoice(String id, IModel> model, BuildChoiceProvider choiceProvider) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/build/choice/BuildSingleChoice.java b/server-core/src/main/java/io/onedev/server/web/component/build/choice/BuildSingleChoice.java index 51154bd1dc..f4fdaf4474 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/build/choice/BuildSingleChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/build/choice/BuildSingleChoice.java @@ -7,7 +7,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.model.Build; import io.onedev.server.web.component.select2.Select2Choice; -@SuppressWarnings("serial") public class BuildSingleChoice extends Select2Choice { public BuildSingleChoice(String id, IModel model, BuildChoiceProvider choiceProvider) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.java index 7707d13173..f122d5204d 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.java @@ -100,7 +100,6 @@ import java.util.*; import static io.onedev.server.model.Build.SORT_FIELDS; -@SuppressWarnings("serial") public abstract class BuildListPanel extends Panel { public static final String REF_TOD = "refs/onedev/tod"; diff --git a/server-core/src/main/java/io/onedev/server/web/component/build/log/BuildLogPanel.java b/server-core/src/main/java/io/onedev/server/web/component/build/log/BuildLogPanel.java index e7937d3810..c63259cf91 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/build/log/BuildLogPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/build/log/BuildLogPanel.java @@ -28,7 +28,6 @@ import java.util.List; import static io.onedev.server.model.Build.getDetailChangeObservable; import static java.util.stream.Collectors.toList; -@SuppressWarnings("serial") public class BuildLogPanel extends GenericPanel { private static final int MAX_LOG_ENTRIES = 1000; diff --git a/server-core/src/main/java/io/onedev/server/web/component/build/minilist/MiniBuildListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/build/minilist/MiniBuildListPanel.java index bac63b2477..b87d3960b6 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/build/minilist/MiniBuildListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/build/minilist/MiniBuildListPanel.java @@ -26,7 +26,6 @@ import io.onedev.server.model.Build.Status; import io.onedev.server.web.component.build.status.BuildStatusIcon; import io.onedev.server.web.page.project.builds.detail.dashboard.BuildDashboardPage; -@SuppressWarnings("serial") public class MiniBuildListPanel extends GenericPanel> { public MiniBuildListPanel(String id, IModel> model) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/build/side/BuildSidePanel.java b/server-core/src/main/java/io/onedev/server/web/component/build/side/BuildSidePanel.java index 2e9a02ab8c..20ff7f5576 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/build/side/BuildSidePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/build/side/BuildSidePanel.java @@ -60,7 +60,6 @@ import java.util.Collection; import java.util.List; import java.util.Map; -@SuppressWarnings("serial") public abstract class BuildSidePanel extends Panel { public BuildSidePanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/build/status/BuildStatusIcon.java b/server-core/src/main/java/io/onedev/server/web/component/build/status/BuildStatusIcon.java index 28781b2de8..cee6703f99 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/build/status/BuildStatusIcon.java +++ b/server-core/src/main/java/io/onedev/server/web/component/build/status/BuildStatusIcon.java @@ -15,7 +15,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import javax.annotation.Nullable; import java.util.Collection; -@SuppressWarnings("serial") public class BuildStatusIcon extends SpriteImage { private final IModel model; diff --git a/server-core/src/main/java/io/onedev/server/web/component/chart/line/LineChartPanel.java b/server-core/src/main/java/io/onedev/server/web/component/chart/line/LineChartPanel.java index f38deb4894..75dfdbccdb 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/chart/line/LineChartPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/chart/line/LineChartPanel.java @@ -14,7 +14,6 @@ import com.fasterxml.jackson.databind.ObjectMapper; import io.onedev.server.OneDev; import io.onedev.server.web.page.base.BasePage; -@SuppressWarnings("serial") public class LineChartPanel extends GenericPanel { public LineChartPanel(String id, IModel model) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/chart/pie/PieChartPanel.java b/server-core/src/main/java/io/onedev/server/web/component/chart/pie/PieChartPanel.java index dfe7db7b62..329f5de7a0 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/chart/pie/PieChartPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/chart/pie/PieChartPanel.java @@ -20,7 +20,6 @@ import io.onedev.server.OneDev; import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; import io.onedev.server.web.page.base.BasePage; -@SuppressWarnings("serial") public abstract class PieChartPanel extends GenericPanel> { private AbstractPostAjaxBehavior selectionBehavior; diff --git a/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentListPanel.java index 4d5cf45be1..2684d979d4 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentListPanel.java @@ -77,7 +77,6 @@ import java.util.stream.Collectors; import static io.onedev.server.model.CodeComment.SORT_FIELDS; -@SuppressWarnings("serial") public abstract class CodeCommentListPanel extends Panel { private static final int MAX_DESCRIPTION_LEN = 200; @@ -419,7 +418,8 @@ public abstract class CodeCommentListPanel extends Panel { changeStatus(target, (Provider>) () -> { Collection comments = new ArrayList<>(); - for (Iterator it = (Iterator) dataProvider.iterator(0, commentsTable.getItemCount()); it.hasNext();) + for (@SuppressWarnings("unchecked") + Iterator it = (Iterator) dataProvider.iterator(0, commentsTable.getItemCount()); it.hasNext();) comments.add(it.next()); return comments; }, true); @@ -463,7 +463,8 @@ public abstract class CodeCommentListPanel extends Panel { changeStatus(target, (Provider>) () -> { Collection comments = new ArrayList<>(); - for (Iterator it = (Iterator) dataProvider.iterator(0, commentsTable.getItemCount()); it.hasNext();) + for (@SuppressWarnings("unchecked") + Iterator it = (Iterator) dataProvider.iterator(0, commentsTable.getItemCount()); it.hasNext();) comments.add(it.next()); return comments; }, false); @@ -587,7 +588,8 @@ public abstract class CodeCommentListPanel extends Panel { public void onClick(AjaxRequestTarget target) { dropdown.close(); var visitInfoManager = OneDev.getInstance(VisitInfoManager.class); - for (Iterator it = (Iterator) dataProvider.iterator(0, commentsTable.getItemCount()); it.hasNext(); ) + for (@SuppressWarnings("unchecked") + Iterator it = (Iterator) dataProvider.iterator(0, commentsTable.getItemCount()); it.hasNext(); ) visitInfoManager.visitCodeComment(SecurityUtils.getAuthUser(), it.next()); target.add(body); } diff --git a/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentPanel.java b/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentPanel.java index 162a7caabb..90badb368f 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentPanel.java @@ -64,7 +64,6 @@ import java.util.Collection; import java.util.Date; import java.util.List; -@SuppressWarnings("serial") public abstract class CodeCommentPanel extends Panel { private final Long commentId; diff --git a/server-core/src/main/java/io/onedev/server/web/component/codecomment/referencedfrom/ReferencedFromCodeCommentPanel.java b/server-core/src/main/java/io/onedev/server/web/component/codecomment/referencedfrom/ReferencedFromCodeCommentPanel.java index 595fe7742d..b47b71f596 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/codecomment/referencedfrom/ReferencedFromCodeCommentPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/codecomment/referencedfrom/ReferencedFromCodeCommentPanel.java @@ -11,7 +11,6 @@ import org.apache.wicket.markup.html.panel.GenericPanel; import org.apache.wicket.model.LoadableDetachableModel; import org.unbescape.html.HtmlEscape; -@SuppressWarnings("serial") public class ReferencedFromCodeCommentPanel extends GenericPanel { public ReferencedFromCodeCommentPanel(String id, Long commentId) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/colorpicker/ColorPicker.java b/server-core/src/main/java/io/onedev/server/web/component/colorpicker/ColorPicker.java index c11c077ba4..d95cac739c 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/colorpicker/ColorPicker.java +++ b/server-core/src/main/java/io/onedev/server/web/component/colorpicker/ColorPicker.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.head.OnDomReadyHeaderItem; import org.apache.wicket.markup.html.form.HiddenField; import org.apache.wicket.model.IModel; -@SuppressWarnings("serial") public class ColorPicker extends HiddenField { private final boolean allowEmpty; diff --git a/server-core/src/main/java/io/onedev/server/web/component/commandpalette/CommandPalettePanel.java b/server-core/src/main/java/io/onedev/server/web/component/commandpalette/CommandPalettePanel.java index b95a65507b..3f656cd186 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/commandpalette/CommandPalettePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/commandpalette/CommandPalettePanel.java @@ -48,7 +48,7 @@ import org.unbescape.javascript.JavaScriptEscape; import java.lang.reflect.Field; import java.util.*; -@SuppressWarnings("serial") +@SuppressWarnings("unchecked") public abstract class CommandPalettePanel extends Panel { private static final int PAGE_SIZE = 100; diff --git a/server-core/src/main/java/io/onedev/server/web/component/comment/CommentPanel.java b/server-core/src/main/java/io/onedev/server/web/component/comment/CommentPanel.java index 44665fffe2..5af8f18bd1 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/comment/CommentPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/comment/CommentPanel.java @@ -38,7 +38,6 @@ import io.onedev.server.web.component.markdown.MarkdownViewer; import io.onedev.server.web.component.reaction.ReactionListPanel; import io.onedev.server.web.util.DeleteCallback; -@SuppressWarnings("serial") public abstract class CommentPanel extends Panel { private static final String COMMENT_ID = "comment"; diff --git a/server-core/src/main/java/io/onedev/server/web/component/commit/list/CommitListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/commit/list/CommitListPanel.java index 10d7c0c9a7..d9bf590c2c 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/commit/list/CommitListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/commit/list/CommitListPanel.java @@ -74,7 +74,6 @@ import javax.annotation.Nullable; import java.util.*; import java.util.regex.Pattern; -@SuppressWarnings("serial") public abstract class CommitListPanel extends Panel { private static final Logger logger = LoggerFactory.getLogger(CommitListPanel.class); diff --git a/server-core/src/main/java/io/onedev/server/web/component/commit/message/CommitMessagePanel.java b/server-core/src/main/java/io/onedev/server/web/component/commit/message/CommitMessagePanel.java index 0bfa7f53a4..45a7a7cf5e 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/commit/message/CommitMessagePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/commit/message/CommitMessagePanel.java @@ -26,7 +26,6 @@ import java.util.regex.Pattern; import static io.onedev.server.entityreference.ReferenceUtils.transformReferences; -@SuppressWarnings("serial") public abstract class CommitMessagePanel extends Panel { private final IModel commitModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/commit/status/CommitStatusLink.java b/server-core/src/main/java/io/onedev/server/web/component/commit/status/CommitStatusLink.java index 08a606fbc4..84adf32ece 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/commit/status/CommitStatusLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/commit/status/CommitStatusLink.java @@ -33,7 +33,6 @@ import java.util.Collection; import java.util.HashSet; import java.util.List; -@SuppressWarnings("serial") public abstract class CommitStatusLink extends DropdownLink { private static final Logger logger = LoggerFactory.getLogger(CommitStatusLink.class); diff --git a/server-core/src/main/java/io/onedev/server/web/component/contributorpanel/ContributorPanel.java b/server-core/src/main/java/io/onedev/server/web/component/contributorpanel/ContributorPanel.java index 94dd942313..67751e0c10 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/contributorpanel/ContributorPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/contributorpanel/ContributorPanel.java @@ -10,7 +10,6 @@ import io.onedev.server.util.DateUtils; import io.onedev.server.web.component.user.ident.Mode; import io.onedev.server.web.component.user.ident.PersonIdentPanel; -@SuppressWarnings("serial") public class ContributorPanel extends Panel { private final PersonIdent author; diff --git a/server-core/src/main/java/io/onedev/server/web/component/createtag/CreateTagPanel.java b/server-core/src/main/java/io/onedev/server/web/component/createtag/CreateTagPanel.java index 72c122966d..f4c4c5e2de 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/createtag/CreateTagPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/createtag/CreateTagPanel.java @@ -23,7 +23,6 @@ import io.onedev.server.util.PathNode; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") public abstract class CreateTagPanel extends Panel { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/datatable/DefaultDataTable.java b/server-core/src/main/java/io/onedev/server/web/component/datatable/DefaultDataTable.java index 784cc467f2..112fc6ac06 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/datatable/DefaultDataTable.java +++ b/server-core/src/main/java/io/onedev/server/web/component/datatable/DefaultDataTable.java @@ -20,7 +20,6 @@ import io.onedev.server.web.behavior.NoRecordsBehavior; import io.onedev.server.web.component.pagenavigator.OnePagingNavigator; import io.onedev.server.web.util.paginghistory.PagingHistorySupport; -@SuppressWarnings("serial") public class DefaultDataTable extends DataTable { public DefaultDataTable(final String id, final List> columns, diff --git a/server-core/src/main/java/io/onedev/server/web/component/datatable/EntityDataProvider.java b/server-core/src/main/java/io/onedev/server/web/component/datatable/EntityDataProvider.java index b5adc55c59..4cd7cb5f7e 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/datatable/EntityDataProvider.java +++ b/server-core/src/main/java/io/onedev/server/web/component/datatable/EntityDataProvider.java @@ -13,7 +13,6 @@ import io.onedev.server.persistence.dao.Dao; import io.onedev.server.persistence.dao.EntityCriteria; import io.onedev.server.web.util.LoadableDetachableDataProvider; -@SuppressWarnings("serial") public class EntityDataProvider extends LoadableDetachableDataProvider { private final Class entityType; diff --git a/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/HeaderSelector.java b/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/HeaderSelector.java index eb7be877a0..67858dbc9a 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/HeaderSelector.java +++ b/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/HeaderSelector.java @@ -20,7 +20,6 @@ import org.apache.wicket.util.visit.IVisitor; import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; -@SuppressWarnings("serial") abstract class HeaderSelector extends Panel { public HeaderSelector(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/RowSelector.java b/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/RowSelector.java index 178502564e..a428c670bf 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/RowSelector.java +++ b/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/RowSelector.java @@ -21,7 +21,6 @@ import org.apache.wicket.util.visit.IVisitor; import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; -@SuppressWarnings("serial") abstract class RowSelector extends Panel { public RowSelector(String id, IModel model) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/SelectionColumn.java b/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/SelectionColumn.java index 4f38c9b211..14c45b49d3 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/SelectionColumn.java +++ b/server-core/src/main/java/io/onedev/server/web/component/datatable/selectioncolumn/SelectionColumn.java @@ -21,7 +21,6 @@ import org.apache.wicket.model.IModel; * @param * @param */ -@SuppressWarnings("serial") public class SelectionColumn implements IStyledColumn { private Set> selections = new HashSet>(); diff --git a/server-core/src/main/java/io/onedev/server/web/component/diff/blob/BlobDiffPanel.java b/server-core/src/main/java/io/onedev/server/web/component/diff/blob/BlobDiffPanel.java index 33933fa630..bc16afc1a3 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/diff/blob/BlobDiffPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/diff/blob/BlobDiffPanel.java @@ -40,7 +40,6 @@ import javax.annotation.Nullable; import static io.onedev.server.util.diff.DiffUtils.MAX_LINE_LEN; -@SuppressWarnings("serial") public class BlobDiffPanel extends Panel { private static final String BODY_ID = "body"; diff --git a/server-core/src/main/java/io/onedev/server/web/component/diff/blob/image/BlobImageDiffPanel.java b/server-core/src/main/java/io/onedev/server/web/component/diff/blob/image/BlobImageDiffPanel.java index e36571be3d..971d9f19a0 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/diff/blob/image/BlobImageDiffPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/diff/blob/image/BlobImageDiffPanel.java @@ -12,7 +12,6 @@ import org.apache.wicket.markup.html.image.Image; import org.apache.wicket.markup.html.panel.Panel; import org.apache.wicket.request.resource.PackageResourceReference; -@SuppressWarnings("serial") public class BlobImageDiffPanel extends Panel { private final BlobChange change; diff --git a/server-core/src/main/java/io/onedev/server/web/component/diff/blob/text/BlobTextDiffPanel.java b/server-core/src/main/java/io/onedev/server/web/component/diff/blob/text/BlobTextDiffPanel.java index b3d32991ae..fd7721b886 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/diff/blob/text/BlobTextDiffPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/diff/blob/text/BlobTextDiffPanel.java @@ -1,8 +1,41 @@ package io.onedev.server.web.component.diff.blob.text; +import static io.onedev.server.codequality.BlobTarget.groupByLine; +import static io.onedev.server.util.diff.DiffRenderer.toHtml; +import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; +import static org.unbescape.javascript.JavaScriptEscape.escapeJavaScript; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; + +import javax.annotation.Nullable; + +import org.apache.wicket.Component; +import org.apache.wicket.ajax.AjaxRequestTarget; +import org.apache.wicket.behavior.AttributeAppender; +import org.apache.wicket.markup.head.IHeaderResponse; +import org.apache.wicket.markup.head.JavaScriptHeaderItem; +import org.apache.wicket.markup.head.OnDomReadyHeaderItem; +import org.apache.wicket.markup.head.OnLoadHeaderItem; +import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.markup.html.panel.Panel; +import org.apache.wicket.model.AbstractReadOnlyModel; +import org.apache.wicket.model.IModel; +import org.apache.wicket.model.LoadableDetachableModel; +import org.apache.wicket.request.IRequestParameters; +import org.apache.wicket.request.cycle.RequestCycle; +import org.apache.wicket.request.mapper.parameter.PageParameters; +import org.eclipse.jgit.diff.DiffEntry.ChangeType; +import org.unbescape.html.HtmlEscape; + import com.fasterxml.jackson.core.JsonProcessingException; import com.fasterxml.jackson.databind.ObjectMapper; import com.google.common.base.Preconditions; + import io.onedev.commons.utils.LinearRange; import io.onedev.commons.utils.StringUtils; import io.onedev.server.OneDev; @@ -28,7 +61,6 @@ import io.onedev.server.web.asset.icon.IconScope; import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; import io.onedev.server.web.behavior.blamemessage.BlameMessageBehavior; import io.onedev.server.web.component.diff.blob.BlobAnnotationSupport; -import io.onedev.server.web.component.diff.blob.BlobDiffPanel; import io.onedev.server.web.component.diff.revision.DiffViewMode; import io.onedev.server.web.component.svg.SpriteImage; import io.onedev.server.web.component.symboltooltip.SymbolTooltipPanel; @@ -38,35 +70,7 @@ import io.onedev.server.web.page.project.commits.CommitDetailPage; import io.onedev.server.web.util.AnnotationInfo; import io.onedev.server.web.util.CodeCommentInfo; import io.onedev.server.web.util.DiffPlanarRange; -import org.apache.wicket.Component; -import org.apache.wicket.ajax.AjaxRequestTarget; -import org.apache.wicket.behavior.AttributeAppender; -import org.apache.wicket.markup.head.IHeaderResponse; -import org.apache.wicket.markup.head.JavaScriptHeaderItem; -import org.apache.wicket.markup.head.OnDomReadyHeaderItem; -import org.apache.wicket.markup.head.OnLoadHeaderItem; -import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.markup.html.panel.Panel; -import org.apache.wicket.model.AbstractReadOnlyModel; -import org.apache.wicket.model.IModel; -import org.apache.wicket.model.LoadableDetachableModel; -import org.apache.wicket.request.IRequestParameters; -import org.apache.wicket.request.cycle.RequestCycle; -import org.apache.wicket.request.mapper.parameter.PageParameters; -import org.eclipse.jgit.diff.DiffEntry.ChangeType; -import org.unbescape.html.HtmlEscape; -import org.unbescape.javascript.JavaScriptEscape; -import javax.annotation.Nullable; -import java.io.Serializable; -import java.util.*; - -import static io.onedev.server.codequality.BlobTarget.groupByLine; -import static io.onedev.server.util.diff.DiffRenderer.toHtml; -import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; -import static org.unbescape.javascript.JavaScriptEscape.escapeJavaScript; - -@SuppressWarnings("serial") public class BlobTextDiffPanel extends Panel { private final BlobChange change; diff --git a/server-core/src/main/java/io/onedev/server/web/component/diff/diffstat/DiffStatBar.java b/server-core/src/main/java/io/onedev/server/web/component/diff/diffstat/DiffStatBar.java index 96fc02d099..4247cb7510 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/diff/diffstat/DiffStatBar.java +++ b/server-core/src/main/java/io/onedev/server/web/component/diff/diffstat/DiffStatBar.java @@ -7,7 +7,6 @@ import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.panel.Panel; import org.apache.wicket.model.AbstractReadOnlyModel; -@SuppressWarnings("serial") public class DiffStatBar extends Panel { private static final int MAX_BLOCKS = 6; diff --git a/server-core/src/main/java/io/onedev/server/web/component/diff/difftitle/BlobDiffTitle.java b/server-core/src/main/java/io/onedev/server/web/component/diff/difftitle/BlobDiffTitle.java index aeb6407e82..417993568e 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/diff/difftitle/BlobDiffTitle.java +++ b/server-core/src/main/java/io/onedev/server/web/component/diff/difftitle/BlobDiffTitle.java @@ -11,7 +11,6 @@ import io.onedev.server.git.BlobChange; import io.onedev.server.web.asset.icon.IconScope; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") public class BlobDiffTitle extends Panel { private final BlobChange change; diff --git a/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java b/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java index 519e47ed8b..3264304d7a 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java @@ -115,7 +115,6 @@ import static java.util.stream.Collectors.toList; * @author robin * */ -@SuppressWarnings("serial") public abstract class RevisionDiffPanel extends Panel { private static final String COOKIE_VIEW_MODE = "onedev.server.diff.viewmode"; @@ -1379,7 +1378,7 @@ public abstract class RevisionDiffPanel extends Panel { @Override public Iterator getRoots() { - return RevisionDiffPanel.this.getChildren(changes.keySet(), "").iterator(); + return RevisionDiffPanel.getChildren(changes.keySet(), "").iterator(); } @Override @@ -1389,7 +1388,7 @@ public abstract class RevisionDiffPanel extends Panel { @Override public Iterator getChildren(String node) { - return RevisionDiffPanel.this.getChildren(changes.keySet(), node).iterator(); + return RevisionDiffPanel.getChildren(changes.keySet(), node).iterator(); } @Override diff --git a/server-core/src/main/java/io/onedev/server/web/component/dropzonefield/DropzoneField.java b/server-core/src/main/java/io/onedev/server/web/component/dropzonefield/DropzoneField.java index 25a7a0293f..de4f65db3c 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/dropzonefield/DropzoneField.java +++ b/server-core/src/main/java/io/onedev/server/web/component/dropzonefield/DropzoneField.java @@ -23,7 +23,6 @@ import javax.annotation.Nullable; import java.util.ArrayList; import java.util.UUID; -@SuppressWarnings("serial") public class DropzoneField extends FormComponentPanel { private final int maxFiles; diff --git a/server-core/src/main/java/io/onedev/server/web/component/dropzonefield/DropzoneFieldResourceReference.java b/server-core/src/main/java/io/onedev/server/web/component/dropzonefield/DropzoneFieldResourceReference.java index adc1ebd363..1ce446f7fa 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/dropzonefield/DropzoneFieldResourceReference.java +++ b/server-core/src/main/java/io/onedev/server/web/component/dropzonefield/DropzoneFieldResourceReference.java @@ -10,7 +10,6 @@ import io.onedev.server.web.asset.dropzone.DropzoneResourceReference; import io.onedev.server.web.page.base.BaseDependentCssResourceReference; import io.onedev.server.web.page.base.BaseDependentResourceReference; -@SuppressWarnings("serial") public class DropzoneFieldResourceReference extends BaseDependentResourceReference { public DropzoneFieldResourceReference() { diff --git a/server-core/src/main/java/io/onedev/server/web/component/entity/labels/EntityLabelsPanel.java b/server-core/src/main/java/io/onedev/server/web/component/entity/labels/EntityLabelsPanel.java index 75ce3c752b..b17f9ab217 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/entity/labels/EntityLabelsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/entity/labels/EntityLabelsPanel.java @@ -16,7 +16,6 @@ import io.onedev.server.model.support.EntityLabel; import io.onedev.server.model.support.LabelSupport; import io.onedev.server.web.component.LabelBadge; -@SuppressWarnings("serial") public class EntityLabelsPanel extends Panel { private final IModel> model; diff --git a/server-core/src/main/java/io/onedev/server/web/component/entity/nav/EntityNavPanel.java b/server-core/src/main/java/io/onedev/server/web/component/entity/nav/EntityNavPanel.java index 7f10d4d670..78dd32d631 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/entity/nav/EntityNavPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/entity/nav/EntityNavPanel.java @@ -21,7 +21,6 @@ import io.onedev.server.util.ReflectionUtils; import io.onedev.server.web.util.Cursor; import io.onedev.server.web.util.CursorSupport; -@SuppressWarnings("serial") public abstract class EntityNavPanel extends Panel { private final String entityName; diff --git a/server-core/src/main/java/io/onedev/server/web/component/entity/reference/EntityReferencePanel.java b/server-core/src/main/java/io/onedev/server/web/component/entity/reference/EntityReferencePanel.java index e05eb494a3..e945a94fb4 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/entity/reference/EntityReferencePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/entity/reference/EntityReferencePanel.java @@ -9,7 +9,6 @@ import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.panel.Panel; import org.apache.wicket.model.Model; -@SuppressWarnings("serial") public abstract class EntityReferencePanel extends Panel { public EntityReferencePanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/entity/watches/EntityWatchesPanel.java b/server-core/src/main/java/io/onedev/server/web/component/entity/watches/EntityWatchesPanel.java index 1167ffff2a..bd6ea6f7d4 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/entity/watches/EntityWatchesPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/entity/watches/EntityWatchesPanel.java @@ -23,7 +23,6 @@ import io.onedev.server.web.component.user.ident.UserIdentPanel; import io.onedev.server.web.component.user.list.SimpleUserListLink; import io.onedev.server.web.component.watchstatus.WatchStatusLink; -@SuppressWarnings("serial") public abstract class EntityWatchesPanel extends Panel { private static final int MAX_DISPLAY_AVATARS = 20; diff --git a/server-core/src/main/java/io/onedev/server/web/component/fileupload/FileUploadField.java b/server-core/src/main/java/io/onedev/server/web/component/fileupload/FileUploadField.java index f58a9d6979..1851318108 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/fileupload/FileUploadField.java +++ b/server-core/src/main/java/io/onedev/server/web/component/fileupload/FileUploadField.java @@ -11,7 +11,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") public class FileUploadField extends org.apache.wicket.markup.html.form.upload.FileUploadField { public FileUploadField(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/floating/FloatingPanel.java b/server-core/src/main/java/io/onedev/server/web/component/floating/FloatingPanel.java index 71916a76a6..3bc26ea70d 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/floating/FloatingPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/floating/FloatingPanel.java @@ -16,7 +16,6 @@ import io.onedev.server.web.behavior.DisplayNoneBehavior; import io.onedev.server.web.page.base.BasePage; import io.onedev.server.web.util.Animation; -@SuppressWarnings("serial") public abstract class FloatingPanel extends Panel { private static final String CONTENT_ID = "content"; diff --git a/server-core/src/main/java/io/onedev/server/web/component/gitsignature/GpgVerificationDetailPanel.java b/server-core/src/main/java/io/onedev/server/web/component/gitsignature/GpgVerificationDetailPanel.java index 7b674a5cb2..ced40fa08a 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/gitsignature/GpgVerificationDetailPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/gitsignature/GpgVerificationDetailPanel.java @@ -9,7 +9,6 @@ import org.apache.wicket.markup.html.panel.Panel; import java.util.List; -@SuppressWarnings("serial") public class GpgVerificationDetailPanel extends Panel { private final boolean successful; diff --git a/server-core/src/main/java/io/onedev/server/web/component/gitsignature/SignatureStatusPanel.java b/server-core/src/main/java/io/onedev/server/web/component/gitsignature/SignatureStatusPanel.java index 44a922e614..c76fc28f6c 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/gitsignature/SignatureStatusPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/gitsignature/SignatureStatusPanel.java @@ -14,7 +14,6 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.LoadableDetachableModel; import org.eclipse.jgit.revwalk.RevObject; -@SuppressWarnings("serial") public abstract class SignatureStatusPanel extends DropdownLink { private IModel model = new LoadableDetachableModel<>() { diff --git a/server-core/src/main/java/io/onedev/server/web/component/gitsignature/SshVerificationDetailPanel.java b/server-core/src/main/java/io/onedev/server/web/component/gitsignature/SshVerificationDetailPanel.java index c02c05fa3d..603ca68035 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/gitsignature/SshVerificationDetailPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/gitsignature/SshVerificationDetailPanel.java @@ -5,7 +5,6 @@ import org.apache.wicket.behavior.AttributeAppender; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.panel.Panel; -@SuppressWarnings("serial") public class SshVerificationDetailPanel extends Panel { private final boolean successful; diff --git a/server-core/src/main/java/io/onedev/server/web/component/groupchoice/GroupMultiChoice.java b/server-core/src/main/java/io/onedev/server/web/component/groupchoice/GroupMultiChoice.java index 2d89da292c..7c7ba75dea 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/groupchoice/GroupMultiChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/groupchoice/GroupMultiChoice.java @@ -9,7 +9,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.model.Group; import io.onedev.server.web.component.select2.Select2MultiChoice; -@SuppressWarnings("serial") public class GroupMultiChoice extends Select2MultiChoice { public GroupMultiChoice(String id, IModel> selectionsModel, IModel> choicesModel) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/groupchoice/GroupSingleChoice.java b/server-core/src/main/java/io/onedev/server/web/component/groupchoice/GroupSingleChoice.java index 1ef1cd786b..c35b78e770 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/groupchoice/GroupSingleChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/groupchoice/GroupSingleChoice.java @@ -9,7 +9,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.model.Group; import io.onedev.server.web.component.select2.Select2Choice; -@SuppressWarnings("serial") public class GroupSingleChoice extends Select2Choice { public GroupSingleChoice(String id, IModel selectionModel, IModel> choicesModel) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/imagedata/upload/ImageUploadField.java b/server-core/src/main/java/io/onedev/server/web/component/imagedata/upload/ImageUploadField.java index 889a0d6878..2a362b1a01 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/imagedata/upload/ImageUploadField.java +++ b/server-core/src/main/java/io/onedev/server/web/component/imagedata/upload/ImageUploadField.java @@ -14,7 +14,6 @@ import org.apache.wicket.markup.html.form.TextField; import org.apache.wicket.model.IModel; import org.apache.wicket.model.Model; -@SuppressWarnings("serial") public class ImageUploadField extends FormComponentPanel { private final String accept; diff --git a/server-core/src/main/java/io/onedev/server/web/component/imagedata/viewer/ImageViewer.java b/server-core/src/main/java/io/onedev/server/web/component/imagedata/viewer/ImageViewer.java index 5890527f8a..a26c1ea187 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/imagedata/viewer/ImageViewer.java +++ b/server-core/src/main/java/io/onedev/server/web/component/imagedata/viewer/ImageViewer.java @@ -5,7 +5,6 @@ import org.apache.wicket.markup.html.WebMarkupContainer; import org.apache.wicket.markup.html.panel.GenericPanel; import org.apache.wicket.model.IModel; -@SuppressWarnings("serial") public class ImageViewer extends GenericPanel { private final int width; diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/IssueStateBadge.java b/server-core/src/main/java/io/onedev/server/web/component/issue/IssueStateBadge.java index 5bd8401a32..fbdfde50b5 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/IssueStateBadge.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/IssueStateBadge.java @@ -17,7 +17,6 @@ import org.unbescape.html.HtmlEscape; import java.util.Collection; -@SuppressWarnings("serial") public class IssueStateBadge extends Label { private final IModel issueModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/IssueActivitiesCssResourceReference.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/IssueActivitiesCssResourceReference.java index 610dc7b28b..c898dedfb5 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/IssueActivitiesCssResourceReference.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/IssueActivitiesCssResourceReference.java @@ -2,7 +2,6 @@ package io.onedev.server.web.component.issue.activities; import io.onedev.server.web.page.base.BaseDependentCssResourceReference; -@SuppressWarnings("serial") public class IssueActivitiesCssResourceReference extends BaseDependentCssResourceReference { public IssueActivitiesCssResourceReference() { diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueChangeActivity.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueChangeActivity.java index 32b7f937c2..f576a10e0d 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueChangeActivity.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueChangeActivity.java @@ -11,7 +11,6 @@ import io.onedev.server.model.IssueChange; import io.onedev.server.model.User; import io.onedev.server.web.util.DeleteCallback; -@SuppressWarnings("serial") public class IssueChangeActivity implements IssueActivity { private final Long changeId; diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueChangePanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueChangePanel.java index c4d9ac92a0..cf4a5455f8 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueChangePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueChangePanel.java @@ -11,7 +11,6 @@ import io.onedev.server.model.IssueChange; import io.onedev.server.notification.ActivityDetail; import io.onedev.server.util.DateUtils; -@SuppressWarnings("serial") class IssueChangePanel extends GenericPanel { public IssueChangePanel(String id, IModel model) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedActivity.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedActivity.java index 73bc771dbc..1c5fc00a50 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedActivity.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedActivity.java @@ -10,7 +10,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import java.util.Date; -@SuppressWarnings("serial") public class IssueCommentedActivity implements IssueActivity { private final Long commentId; diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedPanel.java index 6074fd8f38..2e742deec1 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedPanel.java @@ -33,7 +33,6 @@ import io.onedev.server.web.component.markdown.ContentVersionSupport; import io.onedev.server.web.page.base.BasePage; import io.onedev.server.web.util.DeleteCallback; -@SuppressWarnings("serial") class IssueCommentedPanel extends GenericPanel { private final DeleteCallback deleteCallback; diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedActivity.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedActivity.java index f1ca5fdf17..a6bbf11965 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedActivity.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedActivity.java @@ -11,7 +11,6 @@ import io.onedev.server.model.Issue; import io.onedev.server.model.User; import io.onedev.server.web.util.DeleteCallback; -@SuppressWarnings("serial") public class IssueOpenedActivity implements IssueActivity { private final Long issueId; diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedPanel.java index 9b235603a0..4fdb4115ca 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedPanel.java @@ -31,7 +31,6 @@ import io.onedev.server.web.component.markdown.ContentVersionSupport; import io.onedev.server.web.page.base.BasePage; import io.onedev.server.web.util.DeleteCallback; -@SuppressWarnings("serial") class IssueOpenedPanel extends GenericPanel { public IssueOpenedPanel(String id, IModel model) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueWorkActivity.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueWorkActivity.java index 47a7ac6051..fba469ab70 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueWorkActivity.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueWorkActivity.java @@ -10,7 +10,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import java.util.Date; -@SuppressWarnings("serial") public class IssueWorkActivity implements IssueActivity { private final Long workId; diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueWorkPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueWorkPanel.java index 10bda55b8a..8156e0eb42 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueWorkPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueWorkPanel.java @@ -28,7 +28,6 @@ import org.apache.wicket.model.Model; import static io.onedev.server.util.DateUtils.formatDateTime; -@SuppressWarnings("serial") class IssueWorkPanel extends GenericPanel { private final DeleteCallback deleteCallback; diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueCssResourceReference.java b/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueCssResourceReference.java index cf5a0964c5..f4f0f830c9 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueCssResourceReference.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueCssResourceReference.java @@ -2,7 +2,6 @@ package io.onedev.server.web.component.issue.create; import io.onedev.server.web.page.base.BaseDependentCssResourceReference; -@SuppressWarnings("serial") public class NewIssueCssResourceReference extends BaseDependentCssResourceReference { public NewIssueCssResourceReference() { diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.java index 50b048c367..c73f0e63a2 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/editabletitle/IssueEditableTitlePanel.java @@ -28,7 +28,6 @@ import org.apache.wicket.model.Model; import static io.onedev.server.entityreference.ReferenceUtils.transformReferences; -@SuppressWarnings("serial") public abstract class IssueEditableTitlePanel extends Panel { private static final String CONTENT_ID = "content"; diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/fieldvalues/FieldValuesPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/fieldvalues/FieldValuesPanel.java index d40f3d445b..5689270a0e 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/fieldvalues/FieldValuesPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/fieldvalues/FieldValuesPanel.java @@ -63,7 +63,6 @@ import java.util.HashMap; import java.util.List; import java.util.Map; -@SuppressWarnings("serial") public abstract class FieldValuesPanel extends Panel implements EditContext, ProjectAware { private final Mode userFieldDisplayMode; diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/list/BatchEditPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/list/BatchEditPanel.java index 0e0567e9cb..a62beb9329 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/list/BatchEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/list/BatchEditPanel.java @@ -1,5 +1,12 @@ package io.onedev.server.web.component.issue.list; +import static io.onedev.server.web.component.issue.list.BuiltInFieldsBean.NAME_CONFIDENTIAL; +import static io.onedev.server.web.component.issue.list.BuiltInFieldsBean.NAME_ITERATION; +import static io.onedev.server.web.component.issue.list.BuiltInFieldsBean.NAME_STATE; +import static io.onedev.server.web.component.issue.list.BuiltInFieldsBean.PROP_CONFIDENTIAL; +import static io.onedev.server.web.component.issue.list.BuiltInFieldsBean.PROP_ITERATIONS; +import static io.onedev.server.web.component.issue.list.BuiltInFieldsBean.PROP_STATE; + import java.io.Serializable; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; @@ -28,20 +35,19 @@ import org.apache.wicket.markup.html.list.ListItem; import org.apache.wicket.markup.html.list.ListView; import org.apache.wicket.markup.html.panel.Panel; import org.apache.wicket.model.IModel; -import org.apache.wicket.model.Model; import org.apache.wicket.model.PropertyModel; import com.google.common.collect.Lists; import io.onedev.server.OneDev; +import io.onedev.server.buildspecmodel.inputspec.InputContext; +import io.onedev.server.buildspecmodel.inputspec.InputSpec; import io.onedev.server.entitymanager.IssueChangeManager; import io.onedev.server.entitymanager.SettingManager; import io.onedev.server.model.Issue; import io.onedev.server.model.Iteration; import io.onedev.server.model.Project; import io.onedev.server.model.support.administration.GlobalIssueSetting; -import io.onedev.server.buildspecmodel.inputspec.InputContext; -import io.onedev.server.buildspecmodel.inputspec.InputSpec; import io.onedev.server.model.support.issue.field.FieldUtils; import io.onedev.server.model.support.issue.field.spec.FieldSpec; import io.onedev.server.search.entity.issue.IssueQuery; @@ -53,9 +59,7 @@ import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanDescriptor; import io.onedev.server.web.editable.BeanEditor; import io.onedev.server.web.editable.PropertyDescriptor; -import static io.onedev.server.web.component.issue.list.BuiltInFieldsBean.*; -@SuppressWarnings("serial") abstract class BatchEditPanel extends Panel implements InputContext { private Set selectedFields = new HashSet<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.java index da8f34f35f..71cf4ad654 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/list/IssueListPanel.java @@ -998,7 +998,8 @@ public abstract class IssueListPanel extends Panel { public void onClick(AjaxRequestTarget target) { dropdown.close(); Collection issueIds = new ArrayList<>(); - for (Iterator it = (Iterator) dataProvider.iterator(0, issuesTable.getItemCount()); it.hasNext(); ) + for (@SuppressWarnings("unchecked") + Iterator it = (Iterator) dataProvider.iterator(0, issuesTable.getItemCount()); it.hasNext(); ) issueIds.add(it.next().getId()); getTimeTrackingManager().requestToSyncTimes(issueIds); Session.get().success("Requested to sync estimated/spent time"); @@ -1365,7 +1366,7 @@ public abstract class IssueListPanel extends Panel { dropdown2.close(); Collection issues = new ArrayList<>(); - for (Iterator it = (Iterator) dataProvider.iterator(0, issuesTable.getItemCount()); it.hasNext(); ) + for (@SuppressWarnings("unchecked") var it = (Iterator) dataProvider.iterator(0, issuesTable.getItemCount()); it.hasNext(); ) issues.add(it.next()); getWatchManager().setWatchStatus(SecurityUtils.getAuthUser(), issues, watchStatus); Session.get().success("Watch status changed"); @@ -1425,7 +1426,7 @@ public abstract class IssueListPanel extends Panel { public void onClick(AjaxRequestTarget target) { dropdown.close(); var visitInfoManager = OneDev.getInstance(VisitInfoManager.class); - for (Iterator it = (Iterator) dataProvider.iterator(0, issuesTable.getItemCount()); it.hasNext(); ) + for (@SuppressWarnings("unchecked") var it = (Iterator) dataProvider.iterator(0, issuesTable.getItemCount()); it.hasNext(); ) visitInfoManager.visitIssue(SecurityUtils.getAuthUser(), it.next()); target.add(body); } diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/operation/IssueOperationsPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/operation/IssueOperationsPanel.java index 650349216e..4322fa8d7b 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/operation/IssueOperationsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/operation/IssueOperationsPanel.java @@ -13,7 +13,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import java.util.Collection; -@SuppressWarnings("serial") public abstract class IssueOperationsPanel extends Panel { public IssueOperationsPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/operation/TransitionMenuLink.java b/server-core/src/main/java/io/onedev/server/web/component/issue/operation/TransitionMenuLink.java index 6bd66069aa..5f512427d4 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/operation/TransitionMenuLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/operation/TransitionMenuLink.java @@ -21,7 +21,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import java.util.*; -@SuppressWarnings("serial") public abstract class TransitionMenuLink extends MenuLink { private final IModel> manualTransitionsModel = diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/progress/EstimatedTimeEditBean.java b/server-core/src/main/java/io/onedev/server/web/component/issue/progress/EstimatedTimeEditBean.java index 23428e66e6..bb40b9b535 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/progress/EstimatedTimeEditBean.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/progress/EstimatedTimeEditBean.java @@ -28,6 +28,7 @@ public class EstimatedTimeEditBean implements Serializable { this.estimatedTime = estimatedTime; } + @SuppressWarnings("unused") private static String getEstimatedTimeDescription() { var aggregationLink = OneDev.getInstance(SettingManager.class).getIssueSetting().getTimeTrackingSetting().getAggregationLink(); if (aggregationLink != null) diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/pullrequests/IssuePullRequestsPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/pullrequests/IssuePullRequestsPanel.java index 9b5226ebc4..7c44a0ae2d 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/pullrequests/IssuePullRequestsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/pullrequests/IssuePullRequestsPanel.java @@ -12,7 +12,6 @@ import io.onedev.server.search.entity.pullrequest.IncludesIssueCriteria; import io.onedev.server.search.entity.pullrequest.PullRequestQuery; import io.onedev.server.web.component.pullrequest.list.PullRequestListPanel; -@SuppressWarnings("serial") public class IssuePullRequestsPanel extends GenericPanel { public IssuePullRequestsPanel(String id, IModel model) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/referencedfrom/ReferencedFromIssuePanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/referencedfrom/ReferencedFromIssuePanel.java index 40640fc16f..cc8cc6c6d7 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/referencedfrom/ReferencedFromIssuePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/referencedfrom/ReferencedFromIssuePanel.java @@ -15,7 +15,6 @@ import org.apache.wicket.request.cycle.RequestCycle; import static org.unbescape.html.HtmlEscape.escapeHtml5; -@SuppressWarnings("serial") public class ReferencedFromIssuePanel extends GenericPanel { public ReferencedFromIssuePanel(String id, Long issueId) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/side/IssueSidePanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/side/IssueSidePanel.java index 20ed886f64..92ca753f9e 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/side/IssueSidePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/side/IssueSidePanel.java @@ -86,7 +86,6 @@ import static io.onedev.server.search.entity.issue.IssueQuery.parse; import static io.onedev.server.security.SecurityUtils.*; import static io.onedev.server.util.EmailAddressUtils.describe; -@SuppressWarnings("serial") public abstract class IssueSidePanel extends Panel { private static final int MAX_DISPLAY_AVATARS = 20; @@ -152,7 +151,6 @@ public abstract class IssueSidePanel extends Panel { }); - String initialState = OneDev.getInstance(SettingManager.class).getIssueSetting().getInitialStateSpec().getName(); if (SecurityUtils.canManageIssues(getProject())) addOrReplace(newDeleteLink("delete")); else diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/statestats/StateStatsBar.java b/server-core/src/main/java/io/onedev/server/web/component/issue/statestats/StateStatsBar.java index 9c63d03d5c..c30749c8c5 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/statestats/StateStatsBar.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/statestats/StateStatsBar.java @@ -17,7 +17,6 @@ import io.onedev.server.OneDev; import io.onedev.server.entitymanager.SettingManager; import io.onedev.server.model.support.issue.StateSpec; -@SuppressWarnings("serial") public abstract class StateStatsBar extends GenericPanel> { public StateStatsBar(String id, IModel> model) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/title/IssueTitlePanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/title/IssueTitlePanel.java index adef9878ca..a907e3cd7a 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/title/IssueTitlePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/title/IssueTitlePanel.java @@ -22,7 +22,6 @@ import javax.annotation.Nullable; import static io.onedev.server.entityreference.ReferenceUtils.transformReferences; -@SuppressWarnings("serial") public abstract class IssueTitlePanel extends Panel { public IssueTitlePanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/transitionoption/TransitionOptionPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/transitionoption/TransitionOptionPanel.java index c05fde589b..5feee66e92 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/transitionoption/TransitionOptionPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/transitionoption/TransitionOptionPanel.java @@ -35,7 +35,6 @@ import java.util.Collection; import java.util.List; import java.util.Map; -@SuppressWarnings("serial") public abstract class TransitionOptionPanel extends Panel implements InputContext { private String comment; diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowChangeAlertPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowChangeAlertPanel.java index bae28287b2..721abf0ccf 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowChangeAlertPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowChangeAlertPanel.java @@ -13,7 +13,6 @@ import io.onedev.server.security.SecurityUtils; import io.onedev.server.web.component.modal.ModalLink; import io.onedev.server.web.component.modal.ModalPanel; -@SuppressWarnings("serial") public abstract class WorkflowChangeAlertPanel extends Panel { public WorkflowChangeAlertPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowReconcilePanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowReconcilePanel.java index ae9db0fae8..bd280c0374 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowReconcilePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowReconcilePanel.java @@ -36,7 +36,6 @@ import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; import io.onedev.server.web.component.issue.workflowreconcile.UndefinedFieldValueResolution.FixType; import io.onedev.server.web.editable.BeanContext; -@SuppressWarnings("serial") public abstract class WorkflowReconcilePanel extends Panel { private String CONTENT_ID = "content"; diff --git a/server-core/src/main/java/io/onedev/server/web/component/iteration/IterationDateLabel.java b/server-core/src/main/java/io/onedev/server/web/component/iteration/IterationDateLabel.java index ba827543c4..fc3928e6c7 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/iteration/IterationDateLabel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/iteration/IterationDateLabel.java @@ -11,7 +11,6 @@ import io.onedev.server.model.Iteration; import io.onedev.server.util.DateUtils; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") public class IterationDateLabel extends Label { private final IModel iterationIModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/iteration/IterationStatusLabel.java b/server-core/src/main/java/io/onedev/server/web/component/iteration/IterationStatusLabel.java index 3410d989e9..198b17dc57 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/iteration/IterationStatusLabel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/iteration/IterationStatusLabel.java @@ -8,7 +8,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import io.onedev.server.model.Iteration; -@SuppressWarnings("serial") public class IterationStatusLabel extends Label { private final IModel iterationModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/iteration/actions/IterationActionsPanel.java b/server-core/src/main/java/io/onedev/server/web/component/iteration/actions/IterationActionsPanel.java index 02fff7d705..15056a7e9c 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/iteration/actions/IterationActionsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/iteration/actions/IterationActionsPanel.java @@ -13,7 +13,6 @@ import io.onedev.server.model.Iteration; import io.onedev.server.web.ajaxlistener.ConfirmClickListener; import io.onedev.server.web.page.project.issues.iteration.IterationEditPage; -@SuppressWarnings("serial") public abstract class IterationActionsPanel extends GenericPanel { public IterationActionsPanel(String id, IModel model) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/iteration/choice/IterationSingleChoice.java b/server-core/src/main/java/io/onedev/server/web/component/iteration/choice/IterationSingleChoice.java index 9eb0e6d0c3..5ea51e945a 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/iteration/choice/IterationSingleChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/iteration/choice/IterationSingleChoice.java @@ -9,7 +9,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.model.Iteration; import io.onedev.server.web.component.select2.Select2Choice; -@SuppressWarnings("serial") public class IterationSingleChoice extends Select2Choice { public IterationSingleChoice(String id, IModel selectionModel, IModel> iterationsModel) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/iteration/list/IterationListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/iteration/list/IterationListPanel.java index fe2bbf7b0b..419e22d815 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/iteration/list/IterationListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/iteration/list/IterationListPanel.java @@ -55,7 +55,6 @@ import org.hibernate.criterion.Restrictions; import javax.annotation.Nullable; import java.util.*; -@SuppressWarnings("serial") public class IterationListPanel extends GenericPanel { private boolean closed; diff --git a/server-core/src/main/java/io/onedev/server/web/component/job/BuildOptionContentPanel.java b/server-core/src/main/java/io/onedev/server/web/component/job/BuildOptionContentPanel.java index 695d3e42e8..3a3e1b9286 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/job/BuildOptionContentPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/job/BuildOptionContentPanel.java @@ -22,7 +22,6 @@ import org.apache.wicket.request.cycle.RequestCycle; import io.onedev.server.git.GitUtils; import io.onedev.server.web.editable.BeanContext; -@SuppressWarnings("serial") abstract class BuildOptionContentPanel extends Panel { private final List refNames; diff --git a/server-core/src/main/java/io/onedev/server/web/component/job/BuildOptionModalPanel.java b/server-core/src/main/java/io/onedev/server/web/component/job/BuildOptionModalPanel.java index d2eeb5d008..de36f5a2e0 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/job/BuildOptionModalPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/job/BuildOptionModalPanel.java @@ -10,7 +10,6 @@ import java.io.Serializable; import java.util.Collection; import java.util.List; -@SuppressWarnings("serial") public abstract class BuildOptionModalPanel extends ModalPanel implements InputContext { private final List refNames; diff --git a/server-core/src/main/java/io/onedev/server/web/component/job/JobDefLink.java b/server-core/src/main/java/io/onedev/server/web/component/job/JobDefLink.java index ddb71f835e..b34eba0a8b 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/job/JobDefLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/job/JobDefLink.java @@ -17,7 +17,6 @@ import io.onedev.server.security.SecurityUtils; import io.onedev.server.web.page.project.blob.ProjectBlobPage; import io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer; -@SuppressWarnings("serial") public abstract class JobDefLink extends BookmarkablePageLink { private final ObjectId commitId; diff --git a/server-core/src/main/java/io/onedev/server/web/component/job/RunJobLink.java b/server-core/src/main/java/io/onedev/server/web/component/job/RunJobLink.java index 6501814067..1b8551956f 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/job/RunJobLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/job/RunJobLink.java @@ -32,7 +32,6 @@ import java.lang.reflect.InvocationTargetException; import java.util.*; import java.util.stream.Collectors; -@SuppressWarnings("serial") public abstract class RunJobLink extends AjaxLink implements JobAuthorizationContextAware { private final String refName; diff --git a/server-core/src/main/java/io/onedev/server/web/component/job/jobinfo/JobInfoButton.java b/server-core/src/main/java/io/onedev/server/web/component/job/jobinfo/JobInfoButton.java index 063b96841c..5e2d88dc97 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/job/jobinfo/JobInfoButton.java +++ b/server-core/src/main/java/io/onedev/server/web/component/job/jobinfo/JobInfoButton.java @@ -35,7 +35,6 @@ import java.util.Collection; import java.util.Comparator; import java.util.List; -@SuppressWarnings("serial") public abstract class JobInfoButton extends Panel { public JobInfoButton(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/job/joblist/JobListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/job/joblist/JobListPanel.java index dc8f01e6f4..d95c8e20c9 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/job/joblist/JobListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/job/joblist/JobListPanel.java @@ -30,7 +30,6 @@ import org.eclipse.jgit.lib.ObjectId; import javax.annotation.Nullable; import java.util.*; -@SuppressWarnings("serial") public abstract class JobListPanel extends Panel { private final ObjectId commitId; diff --git a/server-core/src/main/java/io/onedev/server/web/component/link/ActionablePageLink.java b/server-core/src/main/java/io/onedev/server/web/component/link/ActionablePageLink.java index 5833019020..af7230a9fa 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/link/ActionablePageLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/link/ActionablePageLink.java @@ -9,7 +9,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.web.behavior.CtrlAwareOnClickAjaxBehavior; -@SuppressWarnings("serial") public abstract class ActionablePageLink extends AbstractLink { private final Class pageClass; diff --git a/server-core/src/main/java/io/onedev/server/web/component/link/ArchiveMenuLink.java b/server-core/src/main/java/io/onedev/server/web/component/link/ArchiveMenuLink.java index ef0de1e954..be79b28322 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/link/ArchiveMenuLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/link/ArchiveMenuLink.java @@ -14,7 +14,6 @@ import io.onedev.server.web.component.menu.MenuLink; import io.onedev.server.web.resource.ArchiveResource; import io.onedev.server.web.resource.ArchiveResourceReference; -@SuppressWarnings("serial") public abstract class ArchiveMenuLink extends MenuLink { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/link/BuildSpecLink.java b/server-core/src/main/java/io/onedev/server/web/component/link/BuildSpecLink.java index 9cb315998a..7e85d83a5b 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/link/BuildSpecLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/link/BuildSpecLink.java @@ -15,7 +15,6 @@ import io.onedev.server.model.PullRequest; import io.onedev.server.security.SecurityUtils; import io.onedev.server.web.page.project.blob.ProjectBlobPage; -@SuppressWarnings("serial") public abstract class BuildSpecLink extends BookmarkablePageLink { private final ObjectId commitId; diff --git a/server-core/src/main/java/io/onedev/server/web/component/link/ClientUriAwareLink.java b/server-core/src/main/java/io/onedev/server/web/component/link/ClientUriAwareLink.java index f6afcf2709..d38eaf556c 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/link/ClientUriAwareLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/link/ClientUriAwareLink.java @@ -19,7 +19,6 @@ import org.apache.wicket.request.cycle.RequestCycle; * * @param */ -@SuppressWarnings("serial") public abstract class ClientUriAwareLink extends AjaxLink { public ClientUriAwareLink(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/link/DropdownLink.java b/server-core/src/main/java/io/onedev/server/web/component/link/DropdownLink.java index 4bae8368eb..a1248eca93 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/link/DropdownLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/link/DropdownLink.java @@ -16,7 +16,6 @@ import org.apache.wicket.request.cycle.RequestCycle; import javax.annotation.Nullable; -@SuppressWarnings("serial") public abstract class DropdownLink extends AjaxLink { private final Component alignTarget; diff --git a/server-core/src/main/java/io/onedev/server/web/component/link/EmailLink.java b/server-core/src/main/java/io/onedev/server/web/component/link/EmailLink.java index accc8cd6a8..93e2fb534a 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/link/EmailLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/link/EmailLink.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.MarkupStream; import org.apache.wicket.markup.html.WebMarkupContainer; import org.apache.wicket.model.IModel; -@SuppressWarnings("serial") public class EmailLink extends WebMarkupContainer { private final IModel emailModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/link/ViewStateAwareAjaxLink.java b/server-core/src/main/java/io/onedev/server/web/component/link/ViewStateAwareAjaxLink.java index 487fffc74d..adcaa292d6 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/link/ViewStateAwareAjaxLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/link/ViewStateAwareAjaxLink.java @@ -5,7 +5,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.web.ajaxlistener.TrackViewStateListener; -@SuppressWarnings("serial") public abstract class ViewStateAwareAjaxLink extends PreventDefaultAjaxLink { private final boolean carryOver; diff --git a/server-core/src/main/java/io/onedev/server/web/component/link/ViewStateAwarePageLink.java b/server-core/src/main/java/io/onedev/server/web/component/link/ViewStateAwarePageLink.java index 7cd35eaf83..b384110b6d 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/link/ViewStateAwarePageLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/link/ViewStateAwarePageLink.java @@ -12,7 +12,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; * * @param */ -@SuppressWarnings("serial") public class ViewStateAwarePageLink extends BookmarkablePageLink { public ViewStateAwarePageLink(String id, final Class pageClass) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/markdown/InsertUrlPanel.java b/server-core/src/main/java/io/onedev/server/web/component/markdown/InsertUrlPanel.java index e3b50e41aa..d0e90641e7 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/markdown/InsertUrlPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/markdown/InsertUrlPanel.java @@ -65,7 +65,6 @@ import java.util.*; import static org.unbescape.html.HtmlEscape.escapeHtml5; -@SuppressWarnings("serial") abstract class InsertUrlPanel extends Panel { private static final MimetypesFileTypeMap MIME_TYPES = new MimetypesFileTypeMap(); diff --git a/server-core/src/main/java/io/onedev/server/web/component/markdown/LazyResourceLoader.java b/server-core/src/main/java/io/onedev/server/web/component/markdown/LazyResourceLoader.java index 4b9c39cdda..84450095e1 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/markdown/LazyResourceLoader.java +++ b/server-core/src/main/java/io/onedev/server/web/component/markdown/LazyResourceLoader.java @@ -8,7 +8,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.web.asset.katex.KatexResourceReference; import io.onedev.server.web.asset.mermaid.MermaidResourceReference; -@SuppressWarnings("serial") class LazyResourceLoader extends WebMarkupContainer { private final IModel renderedModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownEditor.java b/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownEditor.java index d4b0b5f335..208787d296 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownEditor.java @@ -76,7 +76,6 @@ import io.onedev.server.web.page.project.ProjectPage; import io.onedev.server.web.page.project.blob.render.BlobRenderContext; import org.unbescape.javascript.JavaScriptEscape; -@SuppressWarnings("serial") public class MarkdownEditor extends FormComponentPanel { protected static final int ATWHO_LIMIT = 10; diff --git a/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownResourceReference.java b/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownResourceReference.java index 45ffa38500..9d6fc5974f 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownResourceReference.java +++ b/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownResourceReference.java @@ -20,7 +20,6 @@ import io.onedev.server.web.component.commit.status.CommitStatusCssResourceRefer import io.onedev.server.web.page.base.BaseDependentCssResourceReference; import io.onedev.server.web.page.base.BaseDependentResourceReference; -@SuppressWarnings("serial") public class MarkdownResourceReference extends BaseDependentResourceReference { public MarkdownResourceReference() { diff --git a/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownViewer.java b/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownViewer.java index ef6a24d42e..9ece4b9ac7 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownViewer.java +++ b/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownViewer.java @@ -46,7 +46,6 @@ import java.util.List; import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; -@SuppressWarnings("serial") public class MarkdownViewer extends GenericPanel { private static final String TASK_CHECKED = "taskchecked"; diff --git a/server-core/src/main/java/io/onedev/server/web/component/menu/MenuLink.java b/server-core/src/main/java/io/onedev/server/web/component/menu/MenuLink.java index ce3e82b7ea..1b998532cb 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/menu/MenuLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/menu/MenuLink.java @@ -11,7 +11,6 @@ import org.apache.wicket.markup.head.IHeaderResponse; import javax.annotation.Nullable; import java.util.List; -@SuppressWarnings("serial") public abstract class MenuLink extends DropdownLink { public MenuLink(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/menu/MenuPanel.java b/server-core/src/main/java/io/onedev/server/web/component/menu/MenuPanel.java index f559291e6e..8adf62e99b 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/menu/MenuPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/menu/MenuPanel.java @@ -16,7 +16,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") abstract class MenuPanel extends Panel { public MenuPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/modal/ModalLink.java b/server-core/src/main/java/io/onedev/server/web/component/modal/ModalLink.java index 812c72793a..ea9e1701b7 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/modal/ModalLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/modal/ModalLink.java @@ -4,7 +4,6 @@ import org.apache.wicket.Component; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.markup.html.AjaxLink; -@SuppressWarnings("serial") public abstract class ModalLink extends AjaxLink { private ModalPanel modal; diff --git a/server-core/src/main/java/io/onedev/server/web/component/modal/ModalPanel.java b/server-core/src/main/java/io/onedev/server/web/component/modal/ModalPanel.java index 3332ced656..d5b503ca33 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/modal/ModalPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/modal/ModalPanel.java @@ -15,7 +15,6 @@ import org.apache.wicket.request.cycle.RequestCycle; import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; import io.onedev.server.web.page.base.BasePage; -@SuppressWarnings("serial") public abstract class ModalPanel extends Panel { private static final String CONTENT_ID = "content"; diff --git a/server-core/src/main/java/io/onedev/server/web/component/modal/confirm/ConfirmModalPanel.java b/server-core/src/main/java/io/onedev/server/web/component/modal/confirm/ConfirmModalPanel.java index b1058b5e79..0371d7c6ab 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/modal/confirm/ConfirmModalPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/modal/confirm/ConfirmModalPanel.java @@ -8,7 +8,6 @@ import org.apache.wicket.core.request.handler.IPartialPageRequestHandler; import io.onedev.server.web.component.modal.ModalPanel; -@SuppressWarnings("serial") public abstract class ConfirmModalPanel extends ModalPanel { public ConfirmModalPanel(IPartialPageRequestHandler handler) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/modal/confirm/ContentPanel.java b/server-core/src/main/java/io/onedev/server/web/component/modal/confirm/ContentPanel.java index c6553c364c..f56c3d93c2 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/modal/confirm/ContentPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/modal/confirm/ContentPanel.java @@ -16,7 +16,6 @@ import org.unbescape.javascript.JavaScriptEscape; import io.onedev.server.web.component.link.PreventDefaultAjaxLink; -@SuppressWarnings("serial") abstract class ContentPanel extends Panel { public ContentPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/modal/message/MessageModal.java b/server-core/src/main/java/io/onedev/server/web/component/modal/message/MessageModal.java index 8dcc33942a..179cdcd7c4 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/modal/message/MessageModal.java +++ b/server-core/src/main/java/io/onedev/server/web/component/modal/message/MessageModal.java @@ -5,7 +5,6 @@ import org.apache.wicket.ajax.AjaxRequestTarget; import io.onedev.server.web.component.modal.ModalPanel; -@SuppressWarnings("serial") public abstract class MessageModal extends ModalPanel { public MessageModal(AjaxRequestTarget target) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/modal/message/MessagePanel.java b/server-core/src/main/java/io/onedev/server/web/component/modal/message/MessagePanel.java index 9090092581..167faf3984 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/modal/message/MessagePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/modal/message/MessagePanel.java @@ -9,7 +9,6 @@ import org.apache.wicket.markup.html.panel.Panel; import io.onedev.server.web.component.link.PreventDefaultAjaxLink; -@SuppressWarnings("serial") abstract class MessagePanel extends Panel { public MessagePanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasCardPanel.java b/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasCardPanel.java index 8569409140..65c36e7f3b 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasCardPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasCardPanel.java @@ -6,7 +6,6 @@ import org.apache.wicket.Component; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.behavior.AttributeAppender; -@SuppressWarnings("serial") public abstract class OffCanvasCardPanel extends OffCanvasPanel { public OffCanvasCardPanel(AjaxRequestTarget target, Placement placement, @Nullable String width) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasCardSupportPanel.java b/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasCardSupportPanel.java index 245faf66bb..7266672089 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasCardSupportPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasCardSupportPanel.java @@ -8,7 +8,6 @@ import org.apache.wicket.ajax.markup.html.AjaxLink; import org.apache.wicket.markup.html.WebMarkupContainer; import org.apache.wicket.markup.html.panel.Panel; -@SuppressWarnings("serial") abstract class OffCanvasCardSupportPanel extends Panel { public OffCanvasCardSupportPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasPanel.java b/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasPanel.java index cd472b7be9..81385e86d3 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/offcanvas/OffCanvasPanel.java @@ -10,7 +10,6 @@ import org.apache.wicket.markup.head.IHeaderResponse; import io.onedev.server.web.component.floating.FloatingPanel; import io.onedev.server.web.util.Animation; -@SuppressWarnings("serial") public abstract class OffCanvasPanel extends FloatingPanel { public enum Placement {LEFT, RIGHT} diff --git a/server-core/src/main/java/io/onedev/server/web/component/orderedit/SortEditPanel.java b/server-core/src/main/java/io/onedev/server/web/component/orderedit/SortEditPanel.java index 829c5df3b2..2f821d347c 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/orderedit/SortEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/orderedit/SortEditPanel.java @@ -29,7 +29,6 @@ import java.util.stream.Collectors; import static io.onedev.server.search.entity.EntitySort.Direction.ASCENDING; -@SuppressWarnings("serial") public class SortEditPanel extends GenericPanel> { private final Map available; diff --git a/server-core/src/main/java/io/onedev/server/web/component/pack/choice/SelectPackToActChoice.java b/server-core/src/main/java/io/onedev/server/web/component/pack/choice/SelectPackToActChoice.java index 44b4f417f8..056851a6f6 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pack/choice/SelectPackToActChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pack/choice/SelectPackToActChoice.java @@ -5,7 +5,6 @@ import io.onedev.server.web.component.select2.SelectToActChoice; import org.apache.wicket.markup.head.IHeaderResponse; import org.apache.wicket.markup.head.JavaScriptHeaderItem; -@SuppressWarnings("serial") public abstract class SelectPackToActChoice extends SelectToActChoice { public SelectPackToActChoice(String id, PackChoiceProvider choiceProvider) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/pack/list/PackListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/pack/list/PackListPanel.java index 69e7492639..170cf67d8a 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pack/list/PackListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pack/list/PackListPanel.java @@ -74,7 +74,6 @@ import org.apache.wicket.request.cycle.RequestCycle; import javax.annotation.Nullable; import java.util.*; -@SuppressWarnings("serial") public abstract class PackListPanel extends Panel { private final IModel queryStringModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/pack/side/PackSidePanel.java b/server-core/src/main/java/io/onedev/server/web/component/pack/side/PackSidePanel.java index 3e88116c4f..773e140965 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pack/side/PackSidePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pack/side/PackSidePanel.java @@ -50,7 +50,6 @@ import java.util.List; import static io.onedev.server.search.entity.issue.IssueQuery.merge; -@SuppressWarnings("serial") public abstract class PackSidePanel extends Panel { public PackSidePanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/pagenavigator/OnePagingNavigator.java b/server-core/src/main/java/io/onedev/server/web/component/pagenavigator/OnePagingNavigator.java index 4fe0b332b1..60edbbfc56 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pagenavigator/OnePagingNavigator.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pagenavigator/OnePagingNavigator.java @@ -24,7 +24,6 @@ import org.apache.wicket.markup.html.navigation.paging.PagingNavigation; import javax.annotation.Nullable; -@SuppressWarnings("serial") public class OnePagingNavigator extends AjaxPagingNavigator { private final PagingHistorySupport pagingHistorySupport; diff --git a/server-core/src/main/java/io/onedev/server/web/component/pipeline/PipelinePanel.java b/server-core/src/main/java/io/onedev/server/web/component/pipeline/PipelinePanel.java index 1c75356d01..f6eaf88f36 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pipeline/PipelinePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pipeline/PipelinePanel.java @@ -32,7 +32,6 @@ import io.onedev.server.buildspec.job.JobDependency; import io.onedev.server.web.behavior.sortable.SortBehavior; import io.onedev.server.web.behavior.sortable.SortPosition; -@SuppressWarnings("serial") public abstract class PipelinePanel extends Panel { private final IModel>> pipelineModel = new LoadableDetachableModel>>() { diff --git a/server-core/src/main/java/io/onedev/server/web/component/polymorphiceditor/PolymorphicEditor.java b/server-core/src/main/java/io/onedev/server/web/component/polymorphiceditor/PolymorphicEditor.java index 67fe0f49ab..beb6a57e7e 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/polymorphiceditor/PolymorphicEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/component/polymorphiceditor/PolymorphicEditor.java @@ -1,15 +1,15 @@ package io.onedev.server.web.component.polymorphiceditor; -import com.google.common.base.Preconditions; -import io.onedev.commons.loader.AppLoader; -import io.onedev.commons.loader.ImplementationRegistry; -import io.onedev.server.annotation.ChoiceProvider; -import io.onedev.server.annotation.ImplementationProvider; -import io.onedev.server.util.ComponentContext; -import io.onedev.server.util.Path; -import io.onedev.server.util.PathNode; -import io.onedev.server.util.ReflectionUtils; -import io.onedev.server.web.editable.*; +import java.io.Serializable; +import java.lang.reflect.InvocationTargetException; +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashSet; +import java.util.List; +import java.util.Set; + +import javax.annotation.Nullable; + import org.apache.wicket.Component; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior; @@ -23,10 +23,21 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.LoadableDetachableModel; import org.apache.wicket.util.convert.ConversionException; -import javax.annotation.Nullable; -import java.io.Serializable; -import java.lang.reflect.InvocationTargetException; -import java.util.*; +import com.google.common.base.Preconditions; + +import io.onedev.commons.loader.AppLoader; +import io.onedev.commons.loader.ImplementationRegistry; +import io.onedev.server.annotation.ImplementationProvider; +import io.onedev.server.util.ComponentContext; +import io.onedev.server.util.Path; +import io.onedev.server.util.PathNode; +import io.onedev.server.util.ReflectionUtils; +import io.onedev.server.web.editable.BeanContext; +import io.onedev.server.web.editable.BeanDescriptor; +import io.onedev.server.web.editable.BeanEditor; +import io.onedev.server.web.editable.BeanUpdating; +import io.onedev.server.web.editable.EditableUtils; +import io.onedev.server.web.editable.ValueEditor; public class PolymorphicEditor extends ValueEditor { @@ -34,6 +45,7 @@ public class PolymorphicEditor extends ValueEditor { private final List> implementations = new ArrayList<>(); + @SuppressWarnings("unchecked") public PolymorphicEditor(String id, Class baseClass, IModel model) { super(id, model); diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/ConfirmDeleteModal.java b/server-core/src/main/java/io/onedev/server/web/component/project/ConfirmDeleteModal.java index 88930be835..54671a34e6 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/ConfirmDeleteModal.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/ConfirmDeleteModal.java @@ -7,7 +7,6 @@ import io.onedev.server.model.Project; import io.onedev.server.web.component.modal.confirm.ConfirmModalPanel; import org.apache.wicket.ajax.AjaxRequestTarget; -@SuppressWarnings("serial") public abstract class ConfirmDeleteModal extends ConfirmModalPanel { public ConfirmDeleteModal(AjaxRequestTarget target) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/ProjectAvatar.java b/server-core/src/main/java/io/onedev/server/web/component/project/ProjectAvatar.java index 730492a059..296274de41 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/ProjectAvatar.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/ProjectAvatar.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.html.WebComponent; import io.onedev.server.OneDev; import io.onedev.server.web.avatar.AvatarManager; -@SuppressWarnings("serial") public class ProjectAvatar extends WebComponent { private String url; diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/ProjectPicker.java b/server-core/src/main/java/io/onedev/server/web/component/project/ProjectPicker.java index e41542978b..9e45982713 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/ProjectPicker.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/ProjectPicker.java @@ -15,7 +15,6 @@ import io.onedev.server.web.component.link.DropdownLink; import io.onedev.server.web.component.project.selector.ProjectSelector; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") public abstract class ProjectPicker extends DropdownLink { private final IModel> projectsModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/childrentree/ChildLinkPanel.java b/server-core/src/main/java/io/onedev/server/web/component/project/childrentree/ChildLinkPanel.java index 1a14e6e439..ce281951ba 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/childrentree/ChildLinkPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/childrentree/ChildLinkPanel.java @@ -7,7 +7,6 @@ import org.apache.wicket.markup.html.panel.Panel; import io.onedev.server.util.facade.ProjectFacade; import io.onedev.server.web.component.project.ProjectAvatar; -@SuppressWarnings("serial") abstract class ChildLinkPanel extends Panel { private final ProjectFacade child; diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/childrentree/ProjectChildrenTree.java b/server-core/src/main/java/io/onedev/server/web/component/project/childrentree/ProjectChildrenTree.java index c58706fc5f..5bc1aeccf6 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/childrentree/ProjectChildrenTree.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/childrentree/ProjectChildrenTree.java @@ -21,7 +21,6 @@ import io.onedev.server.util.facade.ProjectFacade; import io.onedev.server.web.component.link.ViewStateAwarePageLink; import io.onedev.server.web.page.project.dashboard.ProjectDashboardPage; -@SuppressWarnings("serial") public class ProjectChildrenTree extends NestedTree { private final Set expandedProjectIds = new HashSet<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/choice/ProjectSingleChoice.java b/server-core/src/main/java/io/onedev/server/web/component/project/choice/ProjectSingleChoice.java index 9a89c54900..fd2920f5f8 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/choice/ProjectSingleChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/choice/ProjectSingleChoice.java @@ -9,7 +9,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.model.Project; import io.onedev.server.web.component.select2.Select2Choice; -@SuppressWarnings("serial") public class ProjectSingleChoice extends Select2Choice { public ProjectSingleChoice(String id, IModel model, IModel> choicesModel) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/forkoption/ForkOptionPanel.java b/server-core/src/main/java/io/onedev/server/web/component/project/forkoption/ForkOptionPanel.java index 26721c5b59..1cf72e09cc 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/forkoption/ForkOptionPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/forkoption/ForkOptionPanel.java @@ -30,7 +30,6 @@ import io.onedev.server.web.util.editbean.LabelsBean; import static io.onedev.server.model.Project.*; -@SuppressWarnings("serial") public abstract class ForkOptionPanel extends Panel { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/gitprotocol/GitProtocolPanel.java b/server-core/src/main/java/io/onedev/server/web/component/project/gitprotocol/GitProtocolPanel.java index 89a9962e15..0ca94686e5 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/gitprotocol/GitProtocolPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/gitprotocol/GitProtocolPanel.java @@ -23,7 +23,6 @@ import io.onedev.server.model.support.administration.SshSetting; import io.onedev.server.security.SecurityUtils; import io.onedev.server.web.page.my.sshkeys.MySshKeysPage; -@SuppressWarnings("serial") public abstract class GitProtocolPanel extends Panel { private static final String COOKIE_USE_SSH = "git.useSsh"; diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/info/ProjectInfoPanel.java b/server-core/src/main/java/io/onedev/server/web/component/project/info/ProjectInfoPanel.java index f484c95836..e4b83ebc7c 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/info/ProjectInfoPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/info/ProjectInfoPanel.java @@ -49,7 +49,6 @@ import static io.onedev.server.replica.ProjectReplica.Type.REDUNDANT; import static java.util.Comparator.comparingInt; import static org.unbescape.html.HtmlEscape.escapeHtml5; -@SuppressWarnings("serial") public abstract class ProjectInfoPanel extends Panel { private static final Logger logger = LoggerFactory.getLogger(ProjectInfoPanel.class); diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/list/ProjectListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/project/list/ProjectListPanel.java index b9de82c707..437d3f7afb 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/list/ProjectListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/list/ProjectListPanel.java @@ -93,7 +93,6 @@ import java.util.*; import static io.onedev.server.model.Project.SORT_FIELDS; -@SuppressWarnings("serial") public class ProjectListPanel extends Panel { private static final int MAX_DESCRIPTION_LEN = 120; diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/selector/ProjectSelector.java b/server-core/src/main/java/io/onedev/server/web/component/project/selector/ProjectSelector.java index 930fb23038..e24376d40e 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/selector/ProjectSelector.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/selector/ProjectSelector.java @@ -35,7 +35,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import javax.annotation.Nullable; import java.util.List; -@SuppressWarnings("serial") public abstract class ProjectSelector extends Panel { private final IModel> projectsModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/stats/build/BuildStatsPanel.java b/server-core/src/main/java/io/onedev/server/web/component/project/stats/build/BuildStatsPanel.java index c7ec4617b3..44a2732ee2 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/stats/build/BuildStatsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/stats/build/BuildStatsPanel.java @@ -22,7 +22,6 @@ import io.onedev.server.model.Project; import io.onedev.server.search.entity.build.BuildQuery; import io.onedev.server.web.page.project.builds.ProjectBuildsPage; -@SuppressWarnings("serial") public class BuildStatsPanel extends Panel { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/stats/code/CodeStatsPanel.java b/server-core/src/main/java/io/onedev/server/web/component/project/stats/code/CodeStatsPanel.java index 95ea1aca70..848df63b53 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/stats/code/CodeStatsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/stats/code/CodeStatsPanel.java @@ -18,7 +18,6 @@ import io.onedev.server.web.page.project.branches.ProjectBranchesPage; import io.onedev.server.web.page.project.commits.ProjectCommitsPage; import io.onedev.server.web.page.project.tags.ProjectTagsPage; -@SuppressWarnings("serial") public class CodeStatsPanel extends GenericPanel { private final IModel commitCountModel = new LoadableDetachableModel() { diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/stats/issue/IssueStatsPanel.java b/server-core/src/main/java/io/onedev/server/web/component/project/stats/issue/IssueStatsPanel.java index df6d6335b6..39019895ae 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/stats/issue/IssueStatsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/stats/issue/IssueStatsPanel.java @@ -30,7 +30,6 @@ import io.onedev.server.search.entity.issue.IssueQueryLexer; import io.onedev.server.search.entity.issue.StateCriteria; import io.onedev.server.web.page.project.issues.list.ProjectIssueListPage; -@SuppressWarnings("serial") public class IssueStatsPanel extends Panel { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/stats/pack/PackStatsPanel.java b/server-core/src/main/java/io/onedev/server/web/component/project/stats/pack/PackStatsPanel.java index b8cb2b20fa..24f946154c 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/stats/pack/PackStatsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/stats/pack/PackStatsPanel.java @@ -19,7 +19,6 @@ import java.util.ArrayList; import java.util.List; import java.util.Map; -@SuppressWarnings("serial") public class PackStatsPanel extends Panel { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/project/stats/pullrequest/PullRequestStatsPanel.java b/server-core/src/main/java/io/onedev/server/web/component/project/stats/pullrequest/PullRequestStatsPanel.java index 3e77fe81d5..98ff3cb2a1 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/project/stats/pullrequest/PullRequestStatsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/project/stats/pullrequest/PullRequestStatsPanel.java @@ -3,9 +3,7 @@ package io.onedev.server.web.component.project.stats.pullrequest; import java.util.ArrayList; import java.util.List; import java.util.Map; -import java.util.stream.Collectors; -import io.onedev.server.search.entity.pullrequest.PullRequestQueryLexer; import org.apache.wicket.behavior.AttributeAppender; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.link.BookmarkablePageLink; @@ -20,9 +18,9 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.model.Project; import io.onedev.server.model.PullRequest.Status; import io.onedev.server.search.entity.pullrequest.PullRequestQuery; +import io.onedev.server.search.entity.pullrequest.PullRequestQueryLexer; import io.onedev.server.web.page.project.pullrequests.ProjectPullRequestsPage; -@SuppressWarnings("serial") public class PullRequestStatsPanel extends Panel { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/RequestStatusBadge.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/RequestStatusBadge.java index 706193eeaf..7bdaba2761 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/RequestStatusBadge.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/RequestStatusBadge.java @@ -8,7 +8,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import io.onedev.server.model.PullRequest; -@SuppressWarnings("serial") public class RequestStatusBadge extends Label { private final IModel requestModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/assignment/AssigneeChoice.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/assignment/AssigneeChoice.java index 7795705b37..83dfb5e94f 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/assignment/AssigneeChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/assignment/AssigneeChoice.java @@ -13,7 +13,6 @@ import io.onedev.server.model.User; import io.onedev.server.web.component.select2.SelectToActChoice; import io.onedev.server.web.component.user.choice.UserChoiceResourceReference; -@SuppressWarnings("serial") public abstract class AssigneeChoice extends SelectToActChoice { public AssigneeChoice(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/assignment/AssignmentListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/assignment/AssignmentListPanel.java index 310e659a1c..dcf0a7d8e9 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/assignment/AssignmentListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/assignment/AssignmentListPanel.java @@ -25,7 +25,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import java.util.*; -@SuppressWarnings("serial") public abstract class AssignmentListPanel extends Panel { private final IModel> assignmentsModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/build/PullRequestJobsPanel.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/build/PullRequestJobsPanel.java index de4beb38c3..37009ddd5a 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/build/PullRequestJobsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/build/PullRequestJobsPanel.java @@ -36,7 +36,6 @@ import static io.onedev.server.search.entity.build.BuildQueryLexer.Is; import static io.onedev.server.util.criteria.Criteria.quote; import static java.util.Comparator.*; -@SuppressWarnings("serial") public abstract class PullRequestJobsPanel extends GenericPanel> { public PullRequestJobsPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/choice/PullRequestSingleChoice.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/choice/PullRequestSingleChoice.java index 7af25f7472..bccbcacd42 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/choice/PullRequestSingleChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/choice/PullRequestSingleChoice.java @@ -7,7 +7,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.model.PullRequest; import io.onedev.server.web.component.select2.Select2Choice; -@SuppressWarnings("serial") public class PullRequestSingleChoice extends Select2Choice { public PullRequestSingleChoice(String id, IModel model, PullRequestChoiceProvider choiceProvider) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/list/PullRequestListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/list/PullRequestListPanel.java index db61f802ab..aca2d378d6 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/list/PullRequestListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/list/PullRequestListPanel.java @@ -95,7 +95,6 @@ import java.util.*; import static io.onedev.server.entityreference.ReferenceUtils.transformReferences; import static java.util.stream.Collectors.toList; -@SuppressWarnings("serial") public abstract class PullRequestListPanel extends Panel { private final IModel queryStringModel; @@ -469,7 +468,7 @@ public abstract class PullRequestListPanel extends Panel { dropdown2.close(); Collection requests = new ArrayList<>(); - for (Iterator it = (Iterator) dataProvider.iterator(0, requestsTable.getItemCount()); it.hasNext(); ) + for (@SuppressWarnings("unchecked") var it = (Iterator) dataProvider.iterator(0, requestsTable.getItemCount()); it.hasNext(); ) requests.add(it.next()); getWatchManager().setWatchStatus(SecurityUtils.getAuthUser(), requests, watchStatus); Session.get().success("Watch status changed"); @@ -672,7 +671,7 @@ public abstract class PullRequestListPanel extends Panel { public void onClick(AjaxRequestTarget target) { dropdown.close(); var visitInfoManager = OneDev.getInstance(VisitInfoManager.class); - for (Iterator it = (Iterator) dataProvider.iterator(0, requestsTable.getItemCount()); it.hasNext(); ) + for (@SuppressWarnings("unchecked") var it = (Iterator) dataProvider.iterator(0, requestsTable.getItemCount()); it.hasNext(); ) visitInfoManager.visitPullRequest(SecurityUtils.getAuthUser(), it.next()); target.add(body); } diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/referencedfrom/ReferencedFromPullRequestPanel.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/referencedfrom/ReferencedFromPullRequestPanel.java index 58b5f2f966..71e3c2cfd3 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/referencedfrom/ReferencedFromPullRequestPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/referencedfrom/ReferencedFromPullRequestPanel.java @@ -15,7 +15,6 @@ import org.apache.wicket.request.cycle.RequestCycle; import static org.unbescape.html.HtmlEscape.escapeHtml5; -@SuppressWarnings("serial") public class ReferencedFromPullRequestPanel extends GenericPanel { public ReferencedFromPullRequestPanel(String id, Long requestId) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewListPanel.java index 970e8bd19b..f8d77648e9 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewListPanel.java @@ -30,7 +30,6 @@ import java.util.Collection; import java.util.List; import java.util.stream.Collectors; -@SuppressWarnings("serial") public abstract class ReviewListPanel extends Panel { private final IModel> reviewsModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewRequirementBehavior.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewRequirementBehavior.java index 964ac8dbfc..06585504ef 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewRequirementBehavior.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewRequirementBehavior.java @@ -20,7 +20,6 @@ import io.onedev.server.util.reviewrequirement.ReviewRequirementParser; import io.onedev.server.web.behavior.inputassist.ANTLRAssistBehavior; import io.onedev.server.web.util.SuggestionUtils; -@SuppressWarnings("serial") public class ReviewRequirementBehavior extends ANTLRAssistBehavior { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewRequirementInput.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewRequirementInput.java index 73e635b28d..cf47adec8b 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewRequirementInput.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewRequirementInput.java @@ -5,7 +5,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.model.Project; -@SuppressWarnings("serial") public class ReviewRequirementInput extends TextField { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewStatusIcon.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewStatusIcon.java index 56ee1dbaf4..c5f744e58d 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewStatusIcon.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewStatusIcon.java @@ -12,7 +12,6 @@ import io.onedev.server.model.PullRequestReview.Status; import io.onedev.server.web.asset.icon.IconScope; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") public abstract class ReviewStatusIcon extends WebComponent { private final boolean opposite; diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewerAvatar.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewerAvatar.java index e172d00aec..6f1685e301 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewerAvatar.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewerAvatar.java @@ -9,7 +9,6 @@ import io.onedev.server.model.PullRequestReview.Status; import io.onedev.server.web.component.user.ident.Mode; import io.onedev.server.web.component.user.ident.UserIdentPanel; -@SuppressWarnings("serial") public abstract class ReviewerAvatar extends Panel { public ReviewerAvatar(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewerChoice.java b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewerChoice.java index 0f486c8759..2be52c4137 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewerChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/pullrequest/review/ReviewerChoice.java @@ -13,7 +13,6 @@ import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.markup.head.IHeaderResponse; import org.apache.wicket.markup.head.JavaScriptHeaderItem; -@SuppressWarnings("serial") public abstract class ReviewerChoice extends SelectToActChoice { public ReviewerChoice(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/revision/AffinalRevisionPicker.java b/server-core/src/main/java/io/onedev/server/web/component/revision/AffinalRevisionPicker.java index d111110d9d..c9391c4678 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/revision/AffinalRevisionPicker.java +++ b/server-core/src/main/java/io/onedev/server/web/component/revision/AffinalRevisionPicker.java @@ -14,7 +14,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import javax.annotation.Nullable; import java.util.List; -@SuppressWarnings("serial") public abstract class AffinalRevisionPicker extends Panel { private Long projectId; diff --git a/server-core/src/main/java/io/onedev/server/web/component/revision/RevisionPicker.java b/server-core/src/main/java/io/onedev/server/web/component/revision/RevisionPicker.java index e3e1d39837..b5b9f4306d 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/revision/RevisionPicker.java +++ b/server-core/src/main/java/io/onedev/server/web/component/revision/RevisionPicker.java @@ -20,7 +20,6 @@ import io.onedev.server.web.component.link.DropdownLink; import io.onedev.server.web.component.modal.ModalPanel; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") public abstract class RevisionPicker extends DropdownLink { private final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/revision/RevisionSelector.java b/server-core/src/main/java/io/onedev/server/web/component/revision/RevisionSelector.java index 61d9976539..fcaea62c46 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/revision/RevisionSelector.java +++ b/server-core/src/main/java/io/onedev/server/web/component/revision/RevisionSelector.java @@ -50,7 +50,6 @@ import static io.onedev.server.git.GitUtils.branch2ref; import static io.onedev.server.git.GitUtils.tag2ref; import static org.eclipse.jgit.lib.Constants.R_REFS; -@SuppressWarnings("serial") public abstract class RevisionSelector extends Panel { private static final int PAGE_SIZE = 25; diff --git a/server-core/src/main/java/io/onedev/server/web/component/savedquery/SaveQueryPanel.java b/server-core/src/main/java/io/onedev/server/web/component/savedquery/SaveQueryPanel.java index 4a7c116f90..69eeee46ae 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/savedquery/SaveQueryPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/savedquery/SaveQueryPanel.java @@ -15,7 +15,6 @@ import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; import io.onedev.server.web.page.project.ProjectPage; -@SuppressWarnings("serial") public abstract class SaveQueryPanel extends Panel { private final PersonalQuerySupport myQuerySupport; diff --git a/server-core/src/main/java/io/onedev/server/web/component/savedquery/SavedQueriesPanel.java b/server-core/src/main/java/io/onedev/server/web/component/savedquery/SavedQueriesPanel.java index fc5590d1c6..cb7db19cb5 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/savedquery/SavedQueriesPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/savedquery/SavedQueriesPanel.java @@ -47,7 +47,6 @@ import java.util.HashSet; import java.util.List; import java.util.Set; -@SuppressWarnings("serial") public abstract class SavedQueriesPanel extends Panel { private static final String COOKIE_PREFIX = "savedQueries.closed."; diff --git a/server-core/src/main/java/io/onedev/server/web/component/select2/SelectToActChoice.java b/server-core/src/main/java/io/onedev/server/web/component/select2/SelectToActChoice.java index 7f81326888..e4c95a0da9 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/select2/SelectToActChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/select2/SelectToActChoice.java @@ -4,7 +4,6 @@ import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior; import org.apache.wicket.model.IModel; -@SuppressWarnings("serial") public abstract class SelectToActChoice extends Select2Choice { private transient T selection; diff --git a/server-core/src/main/java/io/onedev/server/web/component/sideinfo/SideInfoLink.java b/server-core/src/main/java/io/onedev/server/web/component/sideinfo/SideInfoLink.java index 4dcd0cb41d..9d378ddb7e 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/sideinfo/SideInfoLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/sideinfo/SideInfoLink.java @@ -6,7 +6,6 @@ import org.apache.wicket.event.Broadcast; import org.apache.wicket.markup.head.CssHeaderItem; import org.apache.wicket.markup.head.IHeaderResponse; -@SuppressWarnings("serial") public class SideInfoLink extends AjaxLink { public SideInfoLink(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/sideinfo/SideInfoPanel.java b/server-core/src/main/java/io/onedev/server/web/component/sideinfo/SideInfoPanel.java index f7af91e4a6..f35ebf88d5 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/sideinfo/SideInfoPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/sideinfo/SideInfoPanel.java @@ -12,7 +12,6 @@ import org.apache.wicket.markup.html.panel.Panel; import io.onedev.server.web.asset.jqueryui.JQueryUIResourceReference; -@SuppressWarnings("serial") public abstract class SideInfoPanel extends Panel { public SideInfoPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/sourceformat/SourceFormatPanel.java b/server-core/src/main/java/io/onedev/server/web/component/sourceformat/SourceFormatPanel.java index e13b52ceb6..8040a8ef8f 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/sourceformat/SourceFormatPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/sourceformat/SourceFormatPanel.java @@ -17,7 +17,6 @@ import org.apache.wicket.request.http.WebResponse; import com.google.common.collect.Lists; -@SuppressWarnings("serial") public class SourceFormatPanel extends Panel { private static final String COOKIE_INDENT_TYPE = "sourceFormat.identType"; diff --git a/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringMultiChoice.java b/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringMultiChoice.java index bb1df20cb1..02791ff6d8 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringMultiChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringMultiChoice.java @@ -7,7 +7,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.web.component.select2.Select2MultiChoice; -@SuppressWarnings("serial") public class StringMultiChoice extends Select2MultiChoice { public StringMultiChoice(String id, IModel> selectionsModel, diff --git a/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringRadioChoice.java b/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringRadioChoice.java index 3019eda208..d431fe8464 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringRadioChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringRadioChoice.java @@ -15,7 +15,6 @@ import org.apache.wicket.model.Model; import java.util.*; -@SuppressWarnings("serial") public class StringRadioChoice extends FormComponentPanel { private final IModel> choicesModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringSingleChoice.java b/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringSingleChoice.java index 1f4ddb7e0a..b6e2d36153 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringSingleChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/stringchoice/StringSingleChoice.java @@ -6,7 +6,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.web.component.select2.Select2Choice; -@SuppressWarnings("serial") public class StringSingleChoice extends Select2Choice { public StringSingleChoice(String id, IModel selectionModel, diff --git a/server-core/src/main/java/io/onedev/server/web/component/subscriptionstatus/SubscriptionStatusLink.java b/server-core/src/main/java/io/onedev/server/web/component/subscriptionstatus/SubscriptionStatusLink.java index 27407fac25..2463e72dca 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/subscriptionstatus/SubscriptionStatusLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/subscriptionstatus/SubscriptionStatusLink.java @@ -10,7 +10,6 @@ import org.apache.wicket.model.Model; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") public abstract class SubscriptionStatusLink extends AjaxLink { public SubscriptionStatusLink(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/suggestionapply/SuggestionApplyModalPanel.java b/server-core/src/main/java/io/onedev/server/web/component/suggestionapply/SuggestionApplyModalPanel.java index c9fcd8236e..09d31a1829 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/suggestionapply/SuggestionApplyModalPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/suggestionapply/SuggestionApplyModalPanel.java @@ -29,7 +29,6 @@ import io.onedev.server.web.component.markdown.OutdatedSuggestionException; import io.onedev.server.web.page.project.compare.RevisionComparePage; import io.onedev.server.web.page.project.pullrequests.detail.changes.PullRequestChangesPage; -@SuppressWarnings("serial") public abstract class SuggestionApplyModalPanel extends BeanEditModalPanel { public SuggestionApplyModalPanel(IPartialPageRequestHandler handler, SuggestionApplyBean bean) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/svg/SpriteImage.java b/server-core/src/main/java/io/onedev/server/web/component/svg/SpriteImage.java index 30523d2ebb..f03ea7ef8c 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/svg/SpriteImage.java +++ b/server-core/src/main/java/io/onedev/server/web/component/svg/SpriteImage.java @@ -24,7 +24,6 @@ import io.onedev.server.web.asset.icon.IconScope; import io.onedev.server.web.mapper.BaseResourceMapper; import io.onedev.server.web.resource.SpriteResourceReference; -@SuppressWarnings("serial") public class SpriteImage extends WebComponent { private static final Map> spriteScopes = new ConcurrentHashMap<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/component/symboltooltip/SymbolTooltipPanel.java b/server-core/src/main/java/io/onedev/server/web/component/symboltooltip/SymbolTooltipPanel.java index e5f1db660a..2b98917cdb 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/symboltooltip/SymbolTooltipPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/symboltooltip/SymbolTooltipPanel.java @@ -45,7 +45,6 @@ import java.util.List; import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; -@SuppressWarnings("serial") public abstract class SymbolTooltipPanel extends Panel { private static final int QUERY_ENTRIES = 20; diff --git a/server-core/src/main/java/io/onedev/server/web/component/tabbable/ActionTabHead.java b/server-core/src/main/java/io/onedev/server/web/component/tabbable/ActionTabHead.java index 730d969275..bfa7d9a639 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/tabbable/ActionTabHead.java +++ b/server-core/src/main/java/io/onedev/server/web/component/tabbable/ActionTabHead.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.link.Link; import org.apache.wicket.markup.html.panel.Panel; -@SuppressWarnings("serial") public class ActionTabHead extends Panel { public ActionTabHead(String id, ActionTab tab) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/tabbable/AjaxActionTab.java b/server-core/src/main/java/io/onedev/server/web/component/tabbable/AjaxActionTab.java index dd9a1106a9..097ac64e3b 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/tabbable/AjaxActionTab.java +++ b/server-core/src/main/java/io/onedev/server/web/component/tabbable/AjaxActionTab.java @@ -11,7 +11,6 @@ import org.apache.wicket.request.cycle.RequestCycle; import javax.annotation.Nullable; -@SuppressWarnings("serial") public abstract class AjaxActionTab extends ActionTab { public AjaxActionTab(IModel titleModel, @Nullable IModel iconModel) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/tabbable/PageTab.java b/server-core/src/main/java/io/onedev/server/web/component/tabbable/PageTab.java index daa6d7d7aa..e966580a36 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/tabbable/PageTab.java +++ b/server-core/src/main/java/io/onedev/server/web/component/tabbable/PageTab.java @@ -1,14 +1,16 @@ package io.onedev.server.web.component.tabbable; -import io.onedev.server.web.util.WicketUtils; +import java.util.ArrayList; +import java.util.List; + +import javax.annotation.Nullable; + import org.apache.wicket.Component; import org.apache.wicket.Page; import org.apache.wicket.model.IModel; import org.apache.wicket.request.mapper.parameter.PageParameters; -import javax.annotation.Nullable; -import java.util.ArrayList; -import java.util.List; +import io.onedev.server.web.util.WicketUtils; public class PageTab extends Tab { @@ -104,30 +106,6 @@ public class PageTab extends Tab { pageClasses.add(pageClass3); return pageClasses; } - - private static List> asList( - Class pageClass1, Class pageClass2, - Class pageClass3, Class pageClass4) { - List> pageClasses = new ArrayList<>(); - pageClasses.add(pageClass1); - pageClasses.add(pageClass2); - pageClasses.add(pageClass3); - pageClasses.add(pageClass4); - return pageClasses; - } - - private static List> asList( - Class pageClass1, Class pageClass2, - Class pageClass3, Class pageClass4, - Class pageClass5) { - List> pageClasses = new ArrayList<>(); - pageClasses.add(pageClass1); - pageClasses.add(pageClass2); - pageClasses.add(pageClass3); - pageClasses.add(pageClass4); - pageClasses.add(pageClass5); - return pageClasses; - } public final IModel getTitleModel() { return titleModel; diff --git a/server-core/src/main/java/io/onedev/server/web/component/tabbable/Tab.java b/server-core/src/main/java/io/onedev/server/web/component/tabbable/Tab.java index 18368a115d..34db5e1722 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/tabbable/Tab.java +++ b/server-core/src/main/java/io/onedev/server/web/component/tabbable/Tab.java @@ -6,7 +6,6 @@ import javax.annotation.Nullable; import org.apache.wicket.Component; -@SuppressWarnings("serial") public abstract class Tab implements Serializable { protected abstract Component render(String componentId); diff --git a/server-core/src/main/java/io/onedev/server/web/component/tabbable/Tabbable.java b/server-core/src/main/java/io/onedev/server/web/component/tabbable/Tabbable.java index 6483eee362..f7fb329b5b 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/tabbable/Tabbable.java +++ b/server-core/src/main/java/io/onedev/server/web/component/tabbable/Tabbable.java @@ -17,7 +17,6 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.LoadableDetachableModel; import org.apache.wicket.model.Model; -@SuppressWarnings("serial") public class Tabbable extends GenericPanel> { private static final String OPTIONS_ID = "options"; diff --git a/server-core/src/main/java/io/onedev/server/web/component/taskbutton/TaskButton.java b/server-core/src/main/java/io/onedev/server/web/component/taskbutton/TaskButton.java index 018abb004f..36dd9567b9 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/taskbutton/TaskButton.java +++ b/server-core/src/main/java/io/onedev/server/web/component/taskbutton/TaskButton.java @@ -33,7 +33,6 @@ import javax.inject.Singleton; import java.util.*; import java.util.concurrent.*; -@SuppressWarnings("serial") public abstract class TaskButton extends AjaxButton { public TaskButton(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/taskbutton/TaskFeedbackPanel.java b/server-core/src/main/java/io/onedev/server/web/component/taskbutton/TaskFeedbackPanel.java index 5d036c1a81..2909e3b316 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/taskbutton/TaskFeedbackPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/taskbutton/TaskFeedbackPanel.java @@ -25,7 +25,6 @@ import io.onedev.server.OneDev; import io.onedev.server.buildspec.job.log.JobLogEntryEx; import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; -@SuppressWarnings("serial") abstract class TaskFeedbackPanel extends Panel { private final String title; diff --git a/server-core/src/main/java/io/onedev/server/web/component/typeselect/TypeSelectPanel.java b/server-core/src/main/java/io/onedev/server/web/component/typeselect/TypeSelectPanel.java index dbf1857616..3b5a3b9556 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/typeselect/TypeSelectPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/typeselect/TypeSelectPanel.java @@ -39,7 +39,6 @@ import static io.onedev.server.util.HtmlUtils.getText; import static io.onedev.server.web.editable.EditableUtils.getDescription; import static org.apache.commons.lang3.StringUtils.substringBefore; -@SuppressWarnings("serial") public abstract class TypeSelectPanel extends Panel { private final List> types; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/UserAvatar.java b/server-core/src/main/java/io/onedev/server/web/component/user/UserAvatar.java index 619c106798..ffce542012 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/UserAvatar.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/UserAvatar.java @@ -9,7 +9,6 @@ import io.onedev.server.OneDev; import io.onedev.server.model.User; import io.onedev.server.web.avatar.AvatarManager; -@SuppressWarnings("serial") public class UserAvatar extends WebComponent { private String url; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/UserDeleteLink.java b/server-core/src/main/java/io/onedev/server/web/component/user/UserDeleteLink.java index 459ebe8ca5..1f9312fd37 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/UserDeleteLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/UserDeleteLink.java @@ -11,7 +11,6 @@ import org.apache.wicket.RestartResponseException; import org.apache.wicket.markup.html.link.Link; import org.apache.wicket.request.flow.RedirectToUrlException; -@SuppressWarnings("serial") public abstract class UserDeleteLink extends Link { public UserDeleteLink(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenEditBean.java b/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenEditBean.java index b8c8788e3a..e68c3a53be 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenEditBean.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenEditBean.java @@ -73,6 +73,7 @@ public class AccessTokenEditBean implements Serializable { this.authorizations = authorizations; } + @SuppressWarnings("unused") private static boolean isHasOwnerPermissionsDisabled() { return !(boolean) EditContext.get().getInputValue("hasOwnerPermissions"); } diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenEditPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenEditPanel.java index 33cd52a5b8..85cc58dc22 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenEditPanel.java @@ -20,7 +20,6 @@ import org.apache.wicket.markup.html.panel.Panel; import java.util.ArrayList; -@SuppressWarnings("serial") abstract class AccessTokenEditPanel extends Panel { public AccessTokenEditPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenListPanel.java index e415bc843e..e909425215 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenListPanel.java @@ -1,9 +1,9 @@ package io.onedev.server.web.component.user.accesstoken; -import io.onedev.server.OneDev; -import io.onedev.server.entitymanager.AccessTokenManager; -import io.onedev.server.model.AccessToken; -import io.onedev.server.model.User; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; + import org.apache.wicket.Component; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.markup.html.AjaxLink; @@ -13,13 +13,12 @@ import org.apache.wicket.markup.html.list.ListView; import org.apache.wicket.markup.html.panel.Fragment; import org.apache.wicket.markup.html.panel.Panel; import org.apache.wicket.model.AbstractReadOnlyModel; -import org.checkerframework.checker.units.qual.A; -import java.util.ArrayList; -import java.util.Collections; -import java.util.List; +import io.onedev.server.OneDev; +import io.onedev.server.entitymanager.AccessTokenManager; +import io.onedev.server.model.AccessToken; +import io.onedev.server.model.User; -@SuppressWarnings("serial") public abstract class AccessTokenListPanel extends Panel { private WebMarkupContainer container; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenPanel.java index f127df8723..0b1e447b92 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AccessTokenPanel.java @@ -15,7 +15,6 @@ import org.apache.wicket.markup.html.WebMarkupContainer; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.panel.Panel; -@SuppressWarnings("serial") abstract class AccessTokenPanel extends Panel { public AccessTokenPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AuthorizationBean.java b/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AuthorizationBean.java index adf5a512ff..0dcf0a0fee 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AuthorizationBean.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/accesstoken/AuthorizationBean.java @@ -37,6 +37,7 @@ public class AuthorizationBean implements Serializable { this.projectPath = projectPath; } + @SuppressWarnings("unused") private static List getManageableProjects() { var user = WicketUtils.findInnermost(ComponentContext.get().getComponent(), UserAware.class).getUser(); var projects = new ArrayList<>(SecurityUtils.getAuthorizedProjects(user.asSubject(), new ManageProject())); diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/avataredit/AvatarEditPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/avataredit/AvatarEditPanel.java index 9ce0ae7eb1..a66158780e 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/avataredit/AvatarEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/avataredit/AvatarEditPanel.java @@ -17,7 +17,6 @@ import io.onedev.server.web.component.avatarupload.AvatarFileSelected; import io.onedev.server.web.component.avatarupload.AvatarUploadField; import io.onedev.server.web.component.user.UserAvatar; -@SuppressWarnings("serial") public class AvatarEditPanel extends GenericPanel { private String uploadedAvatarData; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/card/PersonCardPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/card/PersonCardPanel.java index 35137d868c..f0f4734e50 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/card/PersonCardPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/card/PersonCardPanel.java @@ -14,7 +14,6 @@ import io.onedev.server.model.EmailAddress; import io.onedev.server.model.User; import io.onedev.server.web.component.user.UserAvatar; -@SuppressWarnings("serial") public class PersonCardPanel extends Panel { private final PersonIdent personIdent; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/card/UserCardPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/card/UserCardPanel.java index ddd6cdbd77..6c0e14e6f6 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/card/UserCardPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/card/UserCardPanel.java @@ -13,7 +13,6 @@ import io.onedev.server.entitymanager.UserManager; import io.onedev.server.model.User; import io.onedev.server.web.component.user.UserAvatar; -@SuppressWarnings("serial") public class UserCardPanel extends GenericPanel { public UserCardPanel(String id, User user) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/choice/UserSingleChoice.java b/server-core/src/main/java/io/onedev/server/web/component/user/choice/UserSingleChoice.java index 16f132da18..8475ba9bc1 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/choice/UserSingleChoice.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/choice/UserSingleChoice.java @@ -9,7 +9,6 @@ import org.apache.wicket.model.IModel; import io.onedev.server.model.User; import io.onedev.server.web.component.select2.Select2Choice; -@SuppressWarnings("serial") public class UserSingleChoice extends Select2Choice { public UserSingleChoice(String id, IModel selectionModel, IModel> choicesModel) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/contributoravatars/ContributorAvatars.java b/server-core/src/main/java/io/onedev/server/web/component/user/contributoravatars/ContributorAvatars.java index a4be2a5aa0..f2fa7b160b 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/contributoravatars/ContributorAvatars.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/contributoravatars/ContributorAvatars.java @@ -9,7 +9,6 @@ import org.eclipse.jgit.lib.PersonIdent; import io.onedev.server.web.component.user.ident.Mode; import io.onedev.server.web.component.user.ident.PersonIdentPanel; -@SuppressWarnings("serial") public class ContributorAvatars extends Panel { private final PersonIdent author; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/emailaddresses/EmailAddressesPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/emailaddresses/EmailAddressesPanel.java index e6c81e4156..fa22ad5e7e 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/emailaddresses/EmailAddressesPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/emailaddresses/EmailAddressesPanel.java @@ -35,7 +35,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class EmailAddressesPanel extends GenericPanel { private String emailAddressValue; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/gpgkey/GpgKeyListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/gpgkey/GpgKeyListPanel.java index dd21eb4730..d10acbeba4 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/gpgkey/GpgKeyListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/gpgkey/GpgKeyListPanel.java @@ -37,7 +37,6 @@ import io.onedev.server.web.component.MultilineLabel; import io.onedev.server.web.component.datatable.DefaultDataTable; import io.onedev.server.web.util.LoadableDetachableDataProvider; -@SuppressWarnings("serial") public class GpgKeyListPanel extends GenericPanel> { private DataTable gpgKeysTable; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/gpgkey/InsertGpgKeyPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/gpgkey/InsertGpgKeyPanel.java index c8f3852d17..6d99ab44fa 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/gpgkey/InsertGpgKeyPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/gpgkey/InsertGpgKeyPanel.java @@ -23,7 +23,6 @@ import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; import io.onedev.server.web.page.my.MyPage; -@SuppressWarnings("serial") public abstract class InsertGpgKeyPanel extends Panel { public InsertGpgKeyPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/ident/PersonIdentPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/ident/PersonIdentPanel.java index 48e1f4b2ec..79b3ec91ec 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/ident/PersonIdentPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/ident/PersonIdentPanel.java @@ -17,7 +17,6 @@ import io.onedev.server.web.component.floating.AlignPlacement; import io.onedev.server.web.component.user.UserAvatar; import io.onedev.server.web.component.user.card.PersonCardPanel; -@SuppressWarnings("serial") public class PersonIdentPanel extends Panel { private final PersonIdent personIdent; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/ident/UserIdentPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/ident/UserIdentPanel.java index 92a8b809ec..f92277fe8f 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/ident/UserIdentPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/ident/UserIdentPanel.java @@ -17,7 +17,6 @@ import io.onedev.server.web.component.floating.AlignPlacement; import io.onedev.server.web.component.user.UserAvatar; import io.onedev.server.web.component.user.card.UserCardPanel; -@SuppressWarnings("serial") public class UserIdentPanel extends GenericPanel { private final Mode mode; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/list/SimpleUserListLink.java b/server-core/src/main/java/io/onedev/server/web/component/user/list/SimpleUserListLink.java index 933892dfb9..4e2d1186e0 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/list/SimpleUserListLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/list/SimpleUserListLink.java @@ -10,7 +10,6 @@ import io.onedev.server.model.User; import io.onedev.server.web.component.floating.FloatingPanel; import io.onedev.server.web.component.link.DropdownLink; -@SuppressWarnings("serial") public abstract class SimpleUserListLink extends DropdownLink { public SimpleUserListLink(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/list/SimpleUserListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/list/SimpleUserListPanel.java index f086827ba7..f3e94c3b8a 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/list/SimpleUserListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/list/SimpleUserListPanel.java @@ -10,7 +10,6 @@ import org.apache.wicket.markup.repeater.RepeatingView; import io.onedev.server.model.User; import io.onedev.server.web.component.user.UserAvatar; -@SuppressWarnings("serial") abstract class SimpleUserListPanel extends Panel { public SimpleUserListPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/passwordedit/PasswordEditPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/passwordedit/PasswordEditPanel.java index 72a03fcb1c..9705bd86f1 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/passwordedit/PasswordEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/passwordedit/PasswordEditPanel.java @@ -18,7 +18,6 @@ import org.apache.wicket.model.IModel; import java.util.HashSet; import java.util.Set; -@SuppressWarnings("serial") public class PasswordEditPanel extends GenericPanel { public PasswordEditPanel(String id, IModel model) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/preferences/PreferencesEditPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/preferences/PreferencesEditPanel.java index b4e78e34d1..10ea179a05 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/preferences/PreferencesEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/preferences/PreferencesEditPanel.java @@ -17,7 +17,6 @@ import java.io.Serializable; import static io.onedev.server.model.User.PROP_DISABLE_WATCH_NOTIFICATIONS; import static io.onedev.server.model.User.PROP_NOTIFY_OWN_EVENTS; -@SuppressWarnings("serial") public class PreferencesEditPanel extends GenericPanel { private BeanEditor editor; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/profileedit/ProfileEditPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/profileedit/ProfileEditPanel.java index 0416d34b12..2bc4265271 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/profileedit/ProfileEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/profileedit/ProfileEditPanel.java @@ -20,7 +20,6 @@ import org.apache.wicket.model.IModel; import java.io.Serializable; -@SuppressWarnings("serial") public class ProfileEditPanel extends GenericPanel { private BeanEditor editor; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/sshkey/InsertSshKeyPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/sshkey/InsertSshKeyPanel.java index e1877b4e89..4a2ae93779 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/sshkey/InsertSshKeyPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/sshkey/InsertSshKeyPanel.java @@ -19,7 +19,6 @@ import io.onedev.server.util.PathNode; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") public abstract class InsertSshKeyPanel extends Panel { public InsertSshKeyPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/sshkey/SshKeyListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/sshkey/SshKeyListPanel.java index fee679a15e..3705d9d04f 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/sshkey/SshKeyListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/sshkey/SshKeyListPanel.java @@ -30,7 +30,6 @@ import java.util.ArrayList; import java.util.Iterator; import java.util.List; -@SuppressWarnings("serial") public class SshKeyListPanel extends GenericPanel> { private DataTable sshKeysTable; diff --git a/server-core/src/main/java/io/onedev/server/web/component/user/twofactorauthentication/TwoFactorAuthenticationSetupPanel.java b/server-core/src/main/java/io/onedev/server/web/component/user/twofactorauthentication/TwoFactorAuthenticationSetupPanel.java index 8384e4e39e..edf6c47cd7 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/user/twofactorauthentication/TwoFactorAuthenticationSetupPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/user/twofactorauthentication/TwoFactorAuthenticationSetupPanel.java @@ -32,7 +32,6 @@ import java.security.SecureRandom; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public abstract class TwoFactorAuthenticationSetupPanel extends GenericPanel { private static final int QR_CODE_SIZE = 160; diff --git a/server-core/src/main/java/io/onedev/server/web/component/watchstatus/WatchStatusLink.java b/server-core/src/main/java/io/onedev/server/web/component/watchstatus/WatchStatusLink.java index 8ccebb393d..bcc338a733 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/watchstatus/WatchStatusLink.java +++ b/server-core/src/main/java/io/onedev/server/web/component/watchstatus/WatchStatusLink.java @@ -13,7 +13,6 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.LoadableDetachableModel; import org.apache.wicket.model.Model; -@SuppressWarnings("serial") public abstract class WatchStatusLink extends DropdownLink { public WatchStatusLink(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/watchstatus/WatchStatusPanel.java b/server-core/src/main/java/io/onedev/server/web/component/watchstatus/WatchStatusPanel.java index 85cd20b959..223ee41360 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/watchstatus/WatchStatusPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/watchstatus/WatchStatusPanel.java @@ -11,7 +11,6 @@ import io.onedev.server.util.watch.WatchStatus; import javax.annotation.Nullable; -@SuppressWarnings("serial") public abstract class WatchStatusPanel extends Panel { public WatchStatusPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/component/wizard/DefaultEndActionsPanel.java b/server-core/src/main/java/io/onedev/server/web/component/wizard/DefaultEndActionsPanel.java index cd5df3414a..beaafb2e5e 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/wizard/DefaultEndActionsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/wizard/DefaultEndActionsPanel.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.html.panel.Panel; import io.onedev.server.OneDev; import io.onedev.server.persistence.TransactionManager; -@SuppressWarnings("serial") public abstract class DefaultEndActionsPanel extends Panel { private final WizardPanel wizard; diff --git a/server-core/src/main/java/io/onedev/server/web/component/wizard/WizardPanel.java b/server-core/src/main/java/io/onedev/server/web/component/wizard/WizardPanel.java index 7b896873e2..832dea6ca5 100644 --- a/server-core/src/main/java/io/onedev/server/web/component/wizard/WizardPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/component/wizard/WizardPanel.java @@ -29,7 +29,6 @@ import com.google.common.base.Preconditions; import io.onedev.server.OneDev; import io.onedev.server.persistence.TransactionManager; -@SuppressWarnings("serial") public abstract class WizardPanel extends Panel { private List steps; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/ActionConditionEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/ActionConditionEditSupport.java index c33d085ff3..9bb49494dd 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/ActionConditionEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/ActionConditionEditSupport.java @@ -11,7 +11,6 @@ import io.onedev.server.web.behavior.ActionConditionBehavior; import io.onedev.server.annotation.ActionCondition; import io.onedev.server.web.editable.string.StringPropertyEditor; -@SuppressWarnings("serial") public class ActionConditionEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/BeanContext.java b/server-core/src/main/java/io/onedev/server/web/editable/BeanContext.java index 1c13f1475a..b67680e978 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/BeanContext.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/BeanContext.java @@ -15,7 +15,6 @@ import com.google.common.collect.Sets; import io.onedev.commons.utils.ClassUtils; import io.onedev.server.annotation.Editable; -@SuppressWarnings("serial") public class BeanContext implements Serializable { private final BeanDescriptor descriptor; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/BeanDescriptor.java b/server-core/src/main/java/io/onedev/server/web/editable/BeanDescriptor.java index e7b53f1145..1d69894b18 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/BeanDescriptor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/BeanDescriptor.java @@ -11,7 +11,6 @@ import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; import java.util.*; -@SuppressWarnings("serial") public class BeanDescriptor implements Serializable { private final Class beanClass; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/BeanEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/BeanEditor.java index 9180ea5521..8531d36324 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/BeanEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/BeanEditor.java @@ -30,7 +30,6 @@ import java.io.Serializable; import java.util.*; import java.util.stream.Collectors; -@SuppressWarnings("serial") public class BeanEditor extends ValueEditor { private final BeanDescriptor descriptor; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/BeanViewer.java b/server-core/src/main/java/io/onedev/server/web/editable/BeanViewer.java index 5cba63eee9..105d213a20 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/BeanViewer.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/BeanViewer.java @@ -24,7 +24,6 @@ import io.onedev.server.util.EditContext; import io.onedev.server.util.ComponentContext; import io.onedev.server.annotation.OmitName; -@SuppressWarnings("serial") public class BeanViewer extends Panel { private final BeanDescriptor descriptor; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/CodeCommentQueryEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/CodeCommentQueryEditSupport.java index 128bea1217..3cc150dc1f 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/CodeCommentQueryEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/CodeCommentQueryEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.string.StringPropertyEditor; import io.onedev.server.web.page.project.ProjectPage; import io.onedev.server.web.util.WicketUtils; -@SuppressWarnings("serial") public class CodeCommentQueryEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/CommitQueryEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/CommitQueryEditSupport.java index f138773501..4026e69c7f 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/CommitQueryEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/CommitQueryEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.string.StringPropertyEditor; import io.onedev.server.web.page.project.ProjectPage; import io.onedev.server.web.util.WicketUtils; -@SuppressWarnings("serial") public class CommitQueryEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/EditableStringTransformer.java b/server-core/src/main/java/io/onedev/server/web/editable/EditableStringTransformer.java index 347c915085..429ffe86f0 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/EditableStringTransformer.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/EditableStringTransformer.java @@ -5,13 +5,12 @@ import java.lang.reflect.Field; import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; import java.util.ArrayList; -import java.util.HashMap; import java.util.List; import java.util.function.Function; +import io.onedev.server.annotation.Editable; import io.onedev.server.util.BeanEditContext; import io.onedev.server.util.BeanUtils; -import io.onedev.server.annotation.Editable; import io.onedev.server.util.EditContext; public class EditableStringTransformer { diff --git a/server-core/src/main/java/io/onedev/server/web/editable/EmptyValueLabel.java b/server-core/src/main/java/io/onedev/server/web/editable/EmptyValueLabel.java index 27453840f0..6d5426a653 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/EmptyValueLabel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/EmptyValueLabel.java @@ -8,7 +8,6 @@ import org.unbescape.html.HtmlEscape; import io.onedev.server.util.ComponentContext; -@SuppressWarnings("serial") public abstract class EmptyValueLabel extends Label { public EmptyValueLabel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/editable/InplacePropertyEditLink.java b/server-core/src/main/java/io/onedev/server/web/editable/InplacePropertyEditLink.java index a771959b3a..805d75b48d 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/InplacePropertyEditLink.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/InplacePropertyEditLink.java @@ -14,7 +14,6 @@ import io.onedev.server.web.component.floating.AlignPlacement; import io.onedev.server.web.component.floating.FloatingPanel; import io.onedev.server.web.component.link.DropdownLink; -@SuppressWarnings("serial") public abstract class InplacePropertyEditLink extends DropdownLink { public InplacePropertyEditLink(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/editable/InplacePropertyEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/InplacePropertyEditPanel.java index 921fc9e720..9ce4177a05 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/InplacePropertyEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/InplacePropertyEditPanel.java @@ -16,7 +16,6 @@ import io.onedev.server.util.EditContext; import io.onedev.server.web.util.IssueQueryAware; import io.onedev.server.web.util.ProjectAware; -@SuppressWarnings("serial") public abstract class InplacePropertyEditPanel extends Panel implements EditContext, IssueQueryAware, ProjectAware { private final Serializable bean; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/InterpolativeEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/InterpolativeEditSupport.java index 50ea4720c7..73889811c0 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/InterpolativeEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/InterpolativeEditSupport.java @@ -21,7 +21,6 @@ import io.onedev.server.web.editable.markdown.MarkdownPropertyEditor; import io.onedev.server.web.editable.string.StringPropertyEditor; import io.onedev.server.web.editable.string.StringPropertyViewer; -@SuppressWarnings("serial") public class InterpolativeEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/InterpolativePatternsEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/InterpolativePatternsEditSupport.java index 218156a7eb..19b3ab3087 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/InterpolativePatternsEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/InterpolativePatternsEditSupport.java @@ -17,7 +17,6 @@ import io.onedev.server.annotation.Patterns; import io.onedev.server.web.editable.string.StringPropertyEditor; import io.onedev.server.web.editable.string.StringPropertyViewer; -@SuppressWarnings("serial") public class InterpolativePatternsEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/JobMatchEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/JobMatchEditSupport.java index 1e5d65ecdb..c5aaafa540 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/JobMatchEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/JobMatchEditSupport.java @@ -10,7 +10,6 @@ import org.apache.wicket.model.IModel; import java.lang.reflect.AnnotatedElement; import java.lang.reflect.Method; -@SuppressWarnings("serial") public class JobMatchEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/NotificationReceiverEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/NotificationReceiverEditSupport.java index ce197f9f55..ff6843eb63 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/NotificationReceiverEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/NotificationReceiverEditSupport.java @@ -12,7 +12,6 @@ import io.onedev.server.annotation.NotificationReceiver; import io.onedev.server.web.editable.string.StringPropertyEditor; import io.onedev.server.web.editable.string.StringPropertyViewer; -@SuppressWarnings("serial") public class NotificationReceiverEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/PackQueryEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/PackQueryEditSupport.java index 556816828b..74332f4eed 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/PackQueryEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/PackQueryEditSupport.java @@ -13,7 +13,6 @@ import org.apache.wicket.model.IModel; import java.lang.reflect.AnnotatedElement; import java.lang.reflect.Method; -@SuppressWarnings("serial") public class PackQueryEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/PatternsEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/PatternsEditSupport.java index a8b4731f87..d923ab29e5 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/PatternsEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/PatternsEditSupport.java @@ -15,7 +15,6 @@ import io.onedev.server.annotation.Patterns; import io.onedev.server.web.editable.string.StringPropertyEditor; import io.onedev.server.web.editable.string.StringPropertyViewer; -@SuppressWarnings("serial") public class PatternsEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/ProjectPathEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/ProjectPathEditSupport.java index 2c6da6bad5..2f57d5ccf4 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/ProjectPathEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/ProjectPathEditSupport.java @@ -14,7 +14,6 @@ import java.lang.reflect.Method; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class ProjectPathEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/PropertyContext.java b/server-core/src/main/java/io/onedev/server/web/editable/PropertyContext.java index 064933b693..071b580868 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/PropertyContext.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/PropertyContext.java @@ -14,7 +14,6 @@ import java.lang.reflect.Method; import java.util.List; import java.util.Map; -@SuppressWarnings("serial") public abstract class PropertyContext implements Serializable { private final PropertyDescriptor descriptor; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/PropertyDescriptor.java b/server-core/src/main/java/io/onedev/server/web/editable/PropertyDescriptor.java index ff5857345d..73f6fc2d2c 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/PropertyDescriptor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/PropertyDescriptor.java @@ -4,25 +4,22 @@ import java.io.Serializable; import java.lang.annotation.Annotation; import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; -import java.util.HashMap; import java.util.HashSet; import java.util.Map; import java.util.Set; import javax.annotation.Nullable; +import javax.validation.constraints.NotEmpty; import javax.validation.constraints.NotNull; import javax.validation.constraints.Size; -import javax.validation.constraints.NotEmpty; - -import com.google.common.base.Preconditions; import com.google.common.collect.Sets; +import io.onedev.server.annotation.ShowCondition; import io.onedev.server.annotation.SubscriptionRequired; import io.onedev.server.util.BeanUtils; import io.onedev.server.util.ComponentContext; import io.onedev.server.util.ReflectionUtils; -import io.onedev.server.annotation.ShowCondition; public class PropertyDescriptor implements Serializable { diff --git a/server-core/src/main/java/io/onedev/server/web/editable/PropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/PropertyEditor.java index 6423982bfc..524f1249de 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/PropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/PropertyEditor.java @@ -7,7 +7,6 @@ import javax.annotation.Nullable; import javax.validation.ConstraintViolation; import javax.validation.Validator; -import io.onedev.server.web.util.WicketUtils; import org.apache.wicket.AttributeModifier; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.behavior.AttributeAppender; @@ -17,16 +16,14 @@ import org.apache.wicket.markup.head.IHeaderResponse; import org.apache.wicket.markup.head.OnDomReadyHeaderItem; import org.apache.wicket.model.IModel; import org.apache.wicket.model.LoadableDetachableModel; -import org.apache.wicket.util.visit.IVisit; import org.apache.wicket.util.visit.IVisitor; import org.apache.wicket.validation.INullAcceptingValidator; -import org.apache.wicket.validation.IValidatable; import io.onedev.commons.loader.AppLoader; -import io.onedev.server.util.ComponentContext; import io.onedev.server.annotation.OmitName; +import io.onedev.server.util.ComponentContext; +import io.onedev.server.web.util.WicketUtils; -@SuppressWarnings("serial") public abstract class PropertyEditor extends ValueEditor { protected final PropertyDescriptor descriptor; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/PropertyViewer.java b/server-core/src/main/java/io/onedev/server/web/editable/PropertyViewer.java index 75d6552709..f816f332b6 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/PropertyViewer.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/PropertyViewer.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.head.IHeaderResponse; import org.apache.wicket.markup.head.JavaScriptHeaderItem; import org.apache.wicket.markup.html.panel.Panel; -@SuppressWarnings("serial") public abstract class PropertyViewer extends Panel { private final PropertyDescriptor descriptor; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/ReferenceAwareEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/ReferenceAwareEditSupport.java index 64e9e9f554..3d47af5a86 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/ReferenceAwareEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/ReferenceAwareEditSupport.java @@ -12,7 +12,6 @@ import io.onedev.server.web.behavior.ReferenceInputBehavior; import io.onedev.server.annotation.ReferenceAware; import io.onedev.server.web.editable.string.StringPropertyEditor; -@SuppressWarnings("serial") public class ReferenceAwareEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/RetryConditionEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/RetryConditionEditSupport.java index 37237d7237..e6875e56de 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/RetryConditionEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/RetryConditionEditSupport.java @@ -11,7 +11,6 @@ import io.onedev.server.web.behavior.RetryConditionBehavior; import io.onedev.server.annotation.RetryCondition; import io.onedev.server.web.editable.string.StringPropertyEditor; -@SuppressWarnings("serial") public class RetryConditionEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/ReviewRequirementEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/ReviewRequirementEditSupport.java index b317227612..48abe30789 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/ReviewRequirementEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/ReviewRequirementEditSupport.java @@ -11,7 +11,6 @@ import io.onedev.server.annotation.ReviewRequirement; import io.onedev.server.web.editable.string.StringPropertyEditor; import io.onedev.server.web.editable.string.StringPropertyViewer; -@SuppressWarnings("serial") public class ReviewRequirementEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/SuggestionEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/SuggestionEditSupport.java index fd9f6dede5..5b7a6f1bc0 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/SuggestionEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/SuggestionEditSupport.java @@ -15,7 +15,6 @@ import io.onedev.server.annotation.SuggestionProvider; import io.onedev.server.web.editable.string.StringPropertyEditor; import io.onedev.server.web.editable.string.StringPropertyViewer; -@SuppressWarnings("serial") public class SuggestionEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/UserMatchEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/UserMatchEditSupport.java index e093e66135..8d6cdeca9f 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/UserMatchEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/UserMatchEditSupport.java @@ -8,7 +8,6 @@ import org.apache.wicket.model.IModel; import java.lang.reflect.Method; -@SuppressWarnings("serial") public class UserMatchEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/ValueEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/ValueEditor.java index f7cf70271b..ecb96a94e9 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/ValueEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/ValueEditor.java @@ -8,7 +8,6 @@ import org.apache.wicket.markup.html.form.FormComponentPanel; import org.apache.wicket.model.IModel; import org.apache.wicket.util.convert.ConversionException; -@SuppressWarnings("serial") public abstract class ValueEditor extends FormComponentPanel { public ValueEditor(String id, IModel model) { diff --git a/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryEditPanel.java index 43afe852a7..f589e61248 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryEditPanel.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.page.admin.buildsetting.agent.AgentListPage; -@SuppressWarnings("serial") public class AgentQueryEditPanel extends PropertyEditor { private final boolean forExecutor; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryEditSupport.java index ad7bd9d2d0..07c8796ad7 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryEditSupport.java @@ -12,7 +12,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.AgentQuery; -@SuppressWarnings("serial") public class AgentQueryEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryViewPanel.java index fe4449c49a..4bab36763a 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/agentquery/AgentQueryViewPanel.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.html.panel.Panel; import io.onedev.server.web.page.admin.buildsetting.agent.AgentListPage; -@SuppressWarnings("serial") public class AgentQueryViewPanel extends Panel { private final String queryString; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/bean/BeanEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/bean/BeanEditSupport.java index 3b197faceb..d716ca213f 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/bean/BeanEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/bean/BeanEditSupport.java @@ -19,7 +19,6 @@ import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.Editable; import io.onedev.server.annotation.ExcludedProperties; -@SuppressWarnings("serial") public class BeanEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/bean/BeanPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/bean/BeanPropertyEditor.java index 63b2aebc9d..6a07707e8f 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/bean/BeanPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/bean/BeanPropertyEditor.java @@ -26,7 +26,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.ValueEditor; import io.onedev.server.annotation.ExcludedProperties; -@SuppressWarnings("serial") public class BeanPropertyEditor extends PropertyEditor { private final String BEAN_EDITOR_ID = "beanEditor"; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListEditSupport.java index fae80da4f9..bb391a02cd 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListEditSupport.java @@ -18,7 +18,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.Editable; -@SuppressWarnings("serial") public class BeanListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListPropertyEditor.java index afee4d9f75..05b03d7909 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListPropertyEditor.java @@ -33,7 +33,6 @@ import java.io.Serializable; import java.lang.reflect.InvocationTargetException; import java.util.*; -@SuppressWarnings("serial") public class BeanListPropertyEditor extends PropertyEditor> { private final List> propertyContexts; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListPropertyViewer.java b/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListPropertyViewer.java index 44d94de06a..4777d4e676 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListPropertyViewer.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/beanlist/BeanListPropertyViewer.java @@ -24,7 +24,6 @@ import io.onedev.server.web.editable.PropertyContext; import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.annotation.ExcludedProperties; -@SuppressWarnings("serial") public class BeanListPropertyViewer extends Panel { private final List> propertyContexts; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/blobchoice/BlobChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/blobchoice/BlobChoiceEditSupport.java index 653867b3e1..572ce0f7c6 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/blobchoice/BlobChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/blobchoice/BlobChoiceEditSupport.java @@ -15,7 +15,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.BlobChoice; -@SuppressWarnings("serial") public class BlobChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/blobchoice/BlobChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/blobchoice/BlobChoiceEditor.java index d9dd1c4d5e..3d39c49f4a 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/blobchoice/BlobChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/blobchoice/BlobChoiceEditor.java @@ -17,7 +17,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.BlobChoice; -@SuppressWarnings("serial") public class BlobChoiceEditor extends PropertyEditor { private final IModel commitModel = new LoadableDetachableModel() { diff --git a/server-core/src/main/java/io/onedev/server/web/editable/bool/BooleanEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/bool/BooleanEditSupport.java index 70ebe5152e..e9ebd8a0ea 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/bool/BooleanEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/bool/BooleanEditSupport.java @@ -15,7 +15,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.web.util.TextUtils; -@SuppressWarnings("serial") public class BooleanEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/bool/BooleanPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/bool/BooleanPropertyEditor.java index 03a7a2a984..d8d60a2d9f 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/bool/BooleanPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/bool/BooleanPropertyEditor.java @@ -9,7 +9,6 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.Model; import org.apache.wicket.util.convert.ConversionException; -@SuppressWarnings("serial") public class BooleanPropertyEditor extends PropertyEditor { private CheckBox input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/bool/NullableBooleanPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/bool/NullableBooleanPropertyEditor.java index 91a3437445..c3534b776e 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/bool/NullableBooleanPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/bool/NullableBooleanPropertyEditor.java @@ -14,7 +14,6 @@ import org.apache.wicket.util.convert.ConversionException; import java.util.LinkedHashMap; import java.util.Map; -@SuppressWarnings("serial") public class NullableBooleanPropertyEditor extends PropertyEditor { private StringSingleChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchChoiceEditSupport.java index ace7b749c4..80378dd3d1 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchChoiceEditSupport.java @@ -19,7 +19,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.BranchChoice; -@SuppressWarnings("serial") public class BranchChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchMultiChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchMultiChoiceEditor.java index aa95a94056..ad8bbe0520 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchMultiChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchMultiChoiceEditor.java @@ -22,7 +22,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.BranchChoice; -@SuppressWarnings("serial") public class BranchMultiChoiceEditor extends PropertyEditor> { private BranchMultiChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchSingleChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchSingleChoiceEditor.java index c216fb0cbe..b2ceb1b086 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchSingleChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/branchchoice/BranchSingleChoiceEditor.java @@ -19,7 +19,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.BranchChoice; -@SuppressWarnings("serial") public class BranchSingleChoiceEditor extends PropertyEditor { private BranchSingleChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/build/BuildQueryEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/build/BuildQueryEditSupport.java index 0675e94ef1..db48f1aeb9 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/build/BuildQueryEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/build/BuildQueryEditSupport.java @@ -20,7 +20,6 @@ import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.BuildQuery; import io.onedev.server.web.editable.string.StringPropertyEditor; -@SuppressWarnings("serial") public class BuildQueryEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildChoiceEditSupport.java index cd8af1b5ba..4d5bd620fc 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildChoiceEditSupport.java @@ -18,7 +18,6 @@ import java.lang.reflect.Method; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class BuildChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildMultiChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildMultiChoiceEditor.java index 679bd22b0f..027ac0ac64 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildMultiChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildMultiChoiceEditor.java @@ -7,7 +7,6 @@ import java.util.stream.Collectors; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior; -import org.apache.wicket.model.AbstractReadOnlyModel; import org.apache.wicket.model.IModel; import org.apache.wicket.model.Model; import org.apache.wicket.util.convert.ConversionException; @@ -22,7 +21,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.util.ProjectAware; -@SuppressWarnings("serial") public class BuildMultiChoiceEditor extends PropertyEditor> { private BuildMultiChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildSingleChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildSingleChoiceEditor.java index 3638387091..ee08a76359 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildSingleChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/build/choice/BuildSingleChoiceEditor.java @@ -17,7 +17,6 @@ import org.apache.wicket.util.convert.ConversionException; import javax.annotation.Nullable; -@SuppressWarnings("serial") public class BuildSingleChoiceEditor extends PropertyEditor { private BuildSingleChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListEditPanel.java index 13d33a6cd1..ed76899c3a 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListEditPanel.java @@ -28,7 +28,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyUpdating; -@SuppressWarnings("serial") class ImportListEditPanel extends PropertyEditor> { private final List imports; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListEditSupport.java index f3f20b7e79..36d93b45e5 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class ImportListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListViewPanel.java index 99f8147459..ccadac799e 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/imports/ImportListViewPanel.java @@ -12,7 +12,6 @@ import org.apache.wicket.markup.repeater.RepeatingView; import io.onedev.server.buildspec.Import; import io.onedev.server.web.editable.BeanContext; -@SuppressWarnings("serial") public class ImportListViewPanel extends Panel { private final List imports = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobChoiceEditSupport.java index 8b1ddf0c94..939ca52da6 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobChoiceEditSupport.java @@ -18,7 +18,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.JobChoice; -@SuppressWarnings("serial") public class JobChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobMultiChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobMultiChoiceEditor.java index c32b6f4e91..5a0471cd32 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobMultiChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobMultiChoiceEditor.java @@ -18,7 +18,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.JobChoice; -@SuppressWarnings("serial") public class JobMultiChoiceEditor extends PropertyEditor> { private JobMultiChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobSingleChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobSingleChoiceEditor.java index fbac6dc063..d39e2ba1b8 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobSingleChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/choice/JobSingleChoiceEditor.java @@ -15,7 +15,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.JobChoice; -@SuppressWarnings("serial") public class JobSingleChoiceEditor extends PropertyEditor { private JobSingleChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyEditPanel.java index cd4fbb2937..57867c70b4 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyEditPanel.java @@ -20,7 +20,6 @@ import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") public abstract class JobDependencyEditPanel extends Panel implements BuildSpecAware, JobAware { private final List dependencies; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListEditPanel.java index e8b8dd929a..7d6084efe3 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListEditPanel.java @@ -37,7 +37,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class JobDependencyListEditPanel extends PropertyEditor> { private final List dependencies; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListEditSupport.java index a726c88604..becbf36591 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class JobDependencyListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListViewPanel.java index f1580187e4..27527130ec 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/jobdependency/JobDependencyListViewPanel.java @@ -25,7 +25,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class JobDependencyListViewPanel extends Panel { private final List dependencies = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionEditPanel.java index 78cb7edef8..2a32c9d16d 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionEditPanel.java @@ -17,7 +17,6 @@ import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") public abstract class PostBuildActionEditPanel extends Panel implements BuildSpecAware, JobAware { private final List actions; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListEditPanel.java index fcc9aa955c..a323e7f3a6 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListEditPanel.java @@ -36,7 +36,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class PostBuildActionListEditPanel extends PropertyEditor> { private final List actions; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListEditSupport.java index 007063341c..ead0ee5b8c 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class PostBuildActionListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListViewPanel.java index 1c2ba0f32f..111272baad 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/postbuildaction/PostBuildActionListViewPanel.java @@ -30,7 +30,6 @@ import io.onedev.server.web.component.offcanvas.OffCanvasPanel; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.EditableUtils; -@SuppressWarnings("serial") class PostBuildActionListViewPanel extends Panel { private final List actions = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyEditPanel.java index c9cefe968a..fa88c3eef4 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyEditPanel.java @@ -1,11 +1,7 @@ package io.onedev.server.web.editable.buildspec.job.projectdependency; -import io.onedev.server.buildspec.BuildSpecAware; -import io.onedev.server.buildspec.job.JobAware; -import io.onedev.server.buildspec.job.projectdependency.ProjectDependency; -import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; -import io.onedev.server.web.editable.BeanContext; -import io.onedev.server.web.editable.BeanEditor; +import java.util.List; + import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.attributes.AjaxRequestAttributes; import org.apache.wicket.ajax.markup.html.AjaxLink; @@ -15,9 +11,13 @@ import org.apache.wicket.markup.html.form.Form; import org.apache.wicket.markup.html.panel.Panel; import org.apache.wicket.request.cycle.RequestCycle; -import java.util.List; +import io.onedev.server.buildspec.BuildSpecAware; +import io.onedev.server.buildspec.job.JobAware; +import io.onedev.server.buildspec.job.projectdependency.ProjectDependency; +import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; +import io.onedev.server.web.editable.BeanContext; +import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class ProjectDependencyEditPanel extends Panel implements BuildSpecAware, JobAware { private final List dependencies; @@ -108,14 +108,6 @@ abstract class ProjectDependencyEditPanel extends Panel implements BuildSpecAwar add(form); } - - private ProjectDependency getDependency(String projectName) { - for (ProjectDependency dependency: dependencies) { - if (projectName.equals(dependency.getProjectPath())) - return dependency; - } - return null; - } protected abstract void onSave(AjaxRequestTarget target); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListEditPanel.java index 2bc6228015..1a8eb0b95d 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListEditPanel.java @@ -38,7 +38,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class ProjectDependencyListEditPanel extends PropertyEditor> { private final List dependencies; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListEditSupport.java index 0205be2ed8..3e34aa9ce8 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class ProjectDependencyListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListViewPanel.java index d7162f3b66..3545b99bcc 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/projectdependency/ProjectDependencyListViewPanel.java @@ -31,7 +31,6 @@ import io.onedev.server.web.component.offcanvas.OffCanvasCardPanel; import io.onedev.server.web.component.offcanvas.OffCanvasPanel; import io.onedev.server.web.editable.BeanContext; -@SuppressWarnings("serial") class ProjectDependencyListViewPanel extends Panel { private final List dependencies = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerEditPanel.java index 4260195fa5..7321c2c05b 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerEditPanel.java @@ -15,7 +15,6 @@ import org.apache.wicket.request.cycle.RequestCycle; import java.util.List; -@SuppressWarnings("serial") public abstract class JobTriggerEditPanel extends Panel implements JobAware { private final List triggers; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListEditPanel.java index 463b4e13a4..ee09fb7118 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListEditPanel.java @@ -34,7 +34,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class JobTriggerListEditPanel extends PropertyEditor> { private final List triggers; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListEditSupport.java index d6fd02e3e1..2f8d5871c7 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class JobTriggerListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListViewPanel.java index eea59e42bc..a963b32e3a 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/job/trigger/JobTriggerListViewPanel.java @@ -25,7 +25,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class JobTriggerListViewPanel extends Panel { private final List triggers = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapEditPanel.java index 15799f74a1..8461c607c4 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapEditPanel.java @@ -38,7 +38,6 @@ import java.util.*; import static com.google.common.base.Preconditions.checkNotNull; -@SuppressWarnings("serial") class ParamMapEditPanel extends PropertyEditor> { private static final Logger logger = LoggerFactory.getLogger(ParamMapEditPanel.class); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapEditSupport.java index 8934da82bd..5504361b4e 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapEditSupport.java @@ -11,7 +11,6 @@ import org.apache.wicket.model.IModel; import java.io.Serializable; import java.util.List; -@SuppressWarnings("serial") public class ParamMapEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapViewPanel.java index 54db8070e1..217cc59057 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMapViewPanel.java @@ -11,7 +11,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class ParamMapViewPanel extends Panel { private final List params = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixEditPanel.java index a85db326a0..98782b2645 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixEditPanel.java @@ -42,7 +42,6 @@ import java.util.*; import static com.google.common.base.Preconditions.checkNotNull; -@SuppressWarnings("serial") class ParamMatrixEditPanel extends PropertyEditor> { private static final Logger logger = LoggerFactory.getLogger(ParamMatrixEditPanel.class); @@ -223,6 +222,7 @@ class ParamMatrixEditPanel extends PropertyEditor> { super.onBeforeRender(); } + @SuppressWarnings("deprecation") @Override protected void onInitialize() { super.onInitialize(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixEditSupport.java index d6ee2e8851..d49f8ba8f1 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.ParamSpecProvider; -@SuppressWarnings("serial") public class ParamMatrixEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixViewPanel.java index 7dd62b0427..8a60ef21f3 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/instance/ParamMatrixViewPanel.java @@ -17,7 +17,6 @@ import io.onedev.server.buildspec.param.instance.ScriptingValues; import io.onedev.server.buildspec.param.instance.SpecifiedValues; import io.onedev.server.web.editable.PropertyContext; -@SuppressWarnings("serial") class ParamMatrixViewPanel extends Panel { private final List params = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecEditPanel.java index 4c100c610a..7b93354688 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecEditPanel.java @@ -19,7 +19,6 @@ import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class ParamSpecEditPanel extends Panel implements InputContext { private final List paramSpecs; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListEditPanel.java index a70a66f6a6..01df0d45cf 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListEditPanel.java @@ -35,7 +35,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class ParamSpecListEditPanel extends PropertyEditor> { private final List params; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListEditSupport.java index 87dad35d75..26b99deafb 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class ParamSpecListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListViewPanel.java index d6da91991f..a6547900d9 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/param/spec/ParamSpecListViewPanel.java @@ -36,7 +36,6 @@ import io.onedev.server.web.component.offcanvas.OffCanvasPanel; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.EditableUtils; -@SuppressWarnings("serial") class ParamSpecListViewPanel extends Panel { private final List paramSpecs = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepEditContentPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepEditContentPanel.java index 352f9e1941..abbe8234e8 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepEditContentPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepEditContentPanel.java @@ -24,7 +24,6 @@ import org.apache.wicket.request.cycle.RequestCycle; import static io.onedev.server.web.component.floating.AlignPlacement.bottom; -@SuppressWarnings("serial") abstract class StepEditContentPanel extends Panel { private final Step step; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepEditModalPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepEditModalPanel.java index 62145f0012..8f4d38894b 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepEditModalPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepEditModalPanel.java @@ -10,7 +10,6 @@ import org.apache.wicket.ajax.AjaxRequestTarget; import java.lang.reflect.InvocationTargetException; -@SuppressWarnings("serial") abstract class StepEditModalPanel extends ModalPanel implements BuildSpecAware, ParamSpecAware { private Step step; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListEditPanel.java index 6781706dd7..48bf64be56 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListEditPanel.java @@ -46,7 +46,6 @@ import java.util.List; import static io.onedev.server.web.component.floating.AlignPlacement.bottom; -@SuppressWarnings("serial") class StepListEditPanel extends PropertyEditor> { private final List steps; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListEditSupport.java index ceb76b2615..5dcc9436a6 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class StepListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListViewPanel.java index f61143b3a2..b7547b9106 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/buildspec/step/StepListViewPanel.java @@ -27,7 +27,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class StepListViewPanel extends Panel { private final List steps = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/choice/ChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/choice/ChoiceEditSupport.java index c20daf7901..38f0438906 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/choice/ChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/choice/ChoiceEditSupport.java @@ -9,7 +9,6 @@ import org.apache.wicket.model.IModel; import java.lang.reflect.AnnotatedElement; import java.util.List; -@SuppressWarnings("serial") public class ChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/choice/MultiChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/choice/MultiChoiceEditor.java index 51827b670c..7f46ac5665 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/choice/MultiChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/choice/MultiChoiceEditor.java @@ -23,7 +23,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.ChoiceProvider; -@SuppressWarnings("serial") public class MultiChoiceEditor extends PropertyEditor> { private Select2MultiChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/choice/SingleChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/choice/SingleChoiceEditor.java index 679d844237..ef65b0e3a3 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/choice/SingleChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/choice/SingleChoiceEditor.java @@ -21,7 +21,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.ChoiceProvider; -@SuppressWarnings("serial") public class SingleChoiceEditor extends PropertyEditor { private FormComponent input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/code/CodeEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/code/CodeEditSupport.java index 5f6c106baf..fa45b0371e 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/code/CodeEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/code/CodeEditSupport.java @@ -18,7 +18,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class CodeEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/code/CodePropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/code/CodePropertyEditor.java index a8ec52435f..dbe301c225 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/code/CodePropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/code/CodePropertyEditor.java @@ -36,7 +36,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class CodePropertyEditor extends PropertyEditor { private TextArea input; @@ -121,6 +120,7 @@ public class CodePropertyEditor extends PropertyEditor { return Preconditions.checkNotNull(descriptor.getPropertyGetter().getAnnotation(Code.class)); } + @SuppressWarnings("unchecked") @Override protected Serializable convertInputToValue() throws ConversionException { Serializable convertedInput; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/code/CodePropertyViewer.java b/server-core/src/main/java/io/onedev/server/web/editable/code/CodePropertyViewer.java index d54c70bcb6..b4885183ec 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/code/CodePropertyViewer.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/code/CodePropertyViewer.java @@ -11,7 +11,6 @@ import org.apache.wicket.model.Model; import java.io.Serializable; import java.util.List; -@SuppressWarnings("serial") public class CodePropertyViewer extends Panel { private final Serializable code; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/color/ColorEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/color/ColorEditSupport.java index ed0fb4ec12..14c786abae 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/color/ColorEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/color/ColorEditSupport.java @@ -14,7 +14,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.Color; -@SuppressWarnings("serial") public class ColorEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/color/ColorPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/color/ColorPropertyEditor.java index bea90959e9..5167dfffbc 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/color/ColorPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/color/ColorPropertyEditor.java @@ -10,7 +10,6 @@ import io.onedev.server.web.component.colorpicker.ColorPicker; import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; -@SuppressWarnings("serial") public class ColorPropertyEditor extends PropertyEditor { private ColorPicker input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/date/DateEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/date/DateEditSupport.java index 764f1498c6..f6a60ab1e0 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/date/DateEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/date/DateEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.WithTime; -@SuppressWarnings("serial") public class DateEditSupport implements EditSupport { public static final String DATE_INPUT_FORMAT = "yyyy-MM-dd"; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/date/DatePropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/date/DatePropertyEditor.java index dfcaeb0e38..d592c82c22 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/date/DatePropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/date/DatePropertyEditor.java @@ -17,7 +17,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.OmitName; -@SuppressWarnings("serial") public class DatePropertyEditor extends PropertyEditor { private final boolean withTime; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/enumeration/EnumEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/enumeration/EnumEditSupport.java index 61117fe3dc..179da9d70a 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/enumeration/EnumEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/enumeration/EnumEditSupport.java @@ -14,7 +14,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class EnumEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/enumeration/EnumPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/enumeration/EnumPropertyEditor.java index e5829b4c8c..91b4eb0076 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/enumeration/EnumPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/enumeration/EnumPropertyEditor.java @@ -21,7 +21,7 @@ import java.util.Iterator; import java.util.LinkedHashMap; import java.util.Map; -@SuppressWarnings({ "unchecked", "rawtypes", "serial" }) +@SuppressWarnings({ "unchecked", "rawtypes"}) public class EnumPropertyEditor extends PropertyEditor> { private final Class enumClass; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/enumlist/EnumListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/enumlist/EnumListEditSupport.java index 4fd73f1df5..8268097346 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/enumlist/EnumListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/enumlist/EnumListEditSupport.java @@ -15,7 +15,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class EnumListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/enumlist/EnumListPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/enumlist/EnumListPropertyEditor.java index 081f471131..4505b59257 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/enumlist/EnumListPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/enumlist/EnumListPropertyEditor.java @@ -21,7 +21,7 @@ import io.onedev.server.web.component.stringchoice.StringMultiChoice; import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; -@SuppressWarnings({"serial", "unchecked", "rawtypes"}) +@SuppressWarnings({"unchecked", "rawtypes"}) public class EnumListPropertyEditor extends PropertyEditor>> { private final Class enumClass; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupChoiceEditSupport.java index 71c53fc83a..a53ebc5a84 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupChoiceEditSupport.java @@ -18,7 +18,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.GroupChoice; -@SuppressWarnings("serial") public class GroupChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupMultiChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupMultiChoiceEditor.java index 882661381a..916d45dcd7 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupMultiChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupMultiChoiceEditor.java @@ -23,7 +23,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.GroupChoice; -@SuppressWarnings("serial") public class GroupMultiChoiceEditor extends PropertyEditor> { private GroupMultiChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupSingleChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupSingleChoiceEditor.java index 42a827b801..0202db4bcb 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupSingleChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/groupchoice/GroupSingleChoiceEditor.java @@ -22,7 +22,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.GroupChoice; -@SuppressWarnings("serial") public class GroupSingleChoiceEditor extends PropertyEditor { private GroupSingleChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/image/ImageEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/image/ImageEditSupport.java index e7b8e9c546..52879b8182 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/image/ImageEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/image/ImageEditSupport.java @@ -8,7 +8,6 @@ import org.apache.wicket.model.IModel; import java.lang.reflect.AnnotatedElement; -@SuppressWarnings("serial") public class ImageEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/image/ImagePropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/image/ImagePropertyEditor.java index 2019578211..85449c5001 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/image/ImagePropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/image/ImagePropertyEditor.java @@ -9,7 +9,6 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.Model; import org.apache.wicket.util.convert.ConversionException; -@SuppressWarnings("serial") public class ImagePropertyEditor extends PropertyEditor { private ImageUploadField input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListEditSupport.java index b2d8fcdeb2..c5f88aff09 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListEditSupport.java @@ -1,20 +1,21 @@ package io.onedev.server.web.editable.interpolativestringlist; -import io.onedev.commons.utils.ClassUtils; -import io.onedev.server.annotation.Editable; -import io.onedev.server.annotation.Interpolative; -import io.onedev.server.util.ReflectionUtils; -import io.onedev.server.web.editable.*; -import org.apache.wicket.Component; -import org.apache.wicket.model.IModel; - -import java.io.Serializable; -import java.lang.reflect.AnnotatedElement; -import java.util.List; - import static io.onedev.server.util.ReflectionUtils.getCollectionElementClass; -@SuppressWarnings("serial") +import java.lang.reflect.AnnotatedElement; +import java.util.List; + +import org.apache.wicket.Component; +import org.apache.wicket.model.IModel; + +import io.onedev.server.annotation.Interpolative; +import io.onedev.server.web.editable.EditSupport; +import io.onedev.server.web.editable.EmptyValueLabel; +import io.onedev.server.web.editable.PropertyContext; +import io.onedev.server.web.editable.PropertyDescriptor; +import io.onedev.server.web.editable.PropertyEditor; +import io.onedev.server.web.editable.PropertyViewer; + public class InterpolativeStringListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListPropertyEditor.java index ce65c8dbe6..a2b7e4a3dc 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListPropertyEditor.java @@ -36,7 +36,6 @@ import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class InterpolativeStringListPropertyEditor extends PropertyEditor> { private RepeatingView rows; @@ -62,6 +61,7 @@ public class InterpolativeStringListPropertyEditor extends PropertyEditor form) { super.onSubmit(target, form); @@ -135,7 +134,6 @@ public class InterpolativeStringListPropertyEditor extends PropertyEditor newList = newList(); for (Component row: rows) { + @SuppressWarnings("unchecked") TextField elementEditor = (TextField) row.get("elementEditor"); newList.add(elementEditor.getConvertedInput()); } diff --git a/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListPropertyViewer.java b/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListPropertyViewer.java index 7756e1f2f4..5cd49230ac 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListPropertyViewer.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/interpolativestringlist/InterpolativeStringListPropertyViewer.java @@ -8,7 +8,6 @@ import org.apache.wicket.markup.html.panel.Panel; import java.util.List; -@SuppressWarnings("serial") public class InterpolativeStringListPropertyViewer extends Panel { private final List elements; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/issue/IssueQueryEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/issue/IssueQueryEditSupport.java index d8ed1a7cad..6c7d4b23c9 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/issue/IssueQueryEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/issue/IssueQueryEditSupport.java @@ -22,7 +22,6 @@ import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.IssueQuery; import io.onedev.server.web.editable.string.StringPropertyEditor; -@SuppressWarnings("serial") public class IssueQueryEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/issue/choice/IssueChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/issue/choice/IssueChoiceEditSupport.java index 54045aadea..ff6469047c 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/issue/choice/IssueChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/issue/choice/IssueChoiceEditSupport.java @@ -19,7 +19,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.IssueChoice; -@SuppressWarnings("serial") public class IssueChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/issue/choice/IssueChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/issue/choice/IssueChoiceEditor.java index 05124e8657..956462e0bf 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/issue/choice/IssueChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/issue/choice/IssueChoiceEditor.java @@ -18,7 +18,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.util.IssueQueryAware; import io.onedev.server.web.util.ProjectAware; -@SuppressWarnings("serial") public class IssueChoiceEditor extends PropertyEditor { private IssueChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingEditPanel.java index ce7367ea84..8131cff805 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingEditPanel.java @@ -16,7 +16,6 @@ import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class IssueCreationSettingEditPanel extends Panel { private final List settings; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingEditSupport.java index e57c57d518..34beb487ee 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingEditSupport.java @@ -13,7 +13,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class IssueCreationSettingEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingListEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingListEditPanel.java index 966d125228..da9e24f1a4 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingListEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/issue/creation/IssueCreationSettingListEditPanel.java @@ -32,7 +32,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class IssueCreationSettingListEditPanel extends PropertyEditor> { private final List settings; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListEditPanel.java index 846cae4d37..7eddbb1456 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListEditPanel.java @@ -47,7 +47,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.FieldNamesProvider; import io.onedev.server.annotation.Password; -@SuppressWarnings("serial") class FieldListEditPanel extends PropertyEditor> { private static final Logger logger = LoggerFactory.getLogger(FieldListEditPanel.class); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListEditSupport.java index 2ba43890ba..3a6124c407 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListEditSupport.java @@ -15,7 +15,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class FieldListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListViewPanel.java index 392cf06ce2..d3f1a25897 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/issue/fieldinstance/FieldListViewPanel.java @@ -16,7 +16,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class FieldListViewPanel extends Panel { private final List fields = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationChoiceEditSupport.java index b23e69ca8c..214fb49ee8 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationChoiceEditSupport.java @@ -18,7 +18,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.IterationChoice; -@SuppressWarnings("serial") public class IterationChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationMultiChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationMultiChoiceEditor.java index 1affdc88be..8786e19a63 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationMultiChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationMultiChoiceEditor.java @@ -20,7 +20,6 @@ import java.util.Collection; import java.util.List; import java.util.stream.Collectors; -@SuppressWarnings("serial") public class IterationMultiChoiceEditor extends PropertyEditor> { private IterationMultiChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationSingleChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationSingleChoiceEditor.java index 3e7a9a77a9..27ec978423 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationSingleChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/iterationchoice/IterationSingleChoiceEditor.java @@ -18,7 +18,6 @@ import org.apache.wicket.util.convert.ConversionException; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class IterationSingleChoiceEditor extends PropertyEditor { private IterationSingleChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeEditPanel.java index 04eaff185e..cf93618ab0 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeEditPanel.java @@ -16,7 +16,6 @@ import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class JobPrivilegeEditPanel extends Panel { private final List privileges; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeListEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeListEditPanel.java index e09dd9f51b..bc3f483320 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeListEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeListEditPanel.java @@ -34,7 +34,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class JobPrivilegeListEditPanel extends PropertyEditor> { private final List privileges; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeListEditSupport.java index 007dba3871..21e36a5f5a 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/jobprivilege/JobPrivilegeListEditSupport.java @@ -13,7 +13,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class JobPrivilegeListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/markdown/MarkdownEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/markdown/MarkdownEditSupport.java index f7767d7d04..3441b02175 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/markdown/MarkdownEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/markdown/MarkdownEditSupport.java @@ -12,7 +12,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.Markdown; -@SuppressWarnings("serial") public class MarkdownEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/markdown/MarkdownPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/markdown/MarkdownPropertyEditor.java index 990e339683..c8c7a55088 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/markdown/MarkdownPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/markdown/MarkdownPropertyEditor.java @@ -14,7 +14,6 @@ import io.onedev.server.web.component.markdown.MarkdownEditor; import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; -@SuppressWarnings("serial") public class MarkdownPropertyEditor extends PropertyEditor { private MarkdownEditor input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/numeric/NumericEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/numeric/NumericEditSupport.java index f4adf9f1d3..e8b7b4244b 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/numeric/NumericEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/numeric/NumericEditSupport.java @@ -18,7 +18,6 @@ import io.onedev.server.annotation.IssueChoice; import io.onedev.server.annotation.PullRequestChoice; import io.onedev.server.annotation.WorkingPeriod; -@SuppressWarnings("serial") public class NumericEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/numeric/NumericPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/numeric/NumericPropertyEditor.java index 0302cdd24b..9873fcb399 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/numeric/NumericPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/numeric/NumericPropertyEditor.java @@ -10,7 +10,6 @@ import io.onedev.server.web.behavior.OnTypingDoneBehavior; import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; -@SuppressWarnings("serial") public class NumericPropertyEditor extends PropertyEditor { private TextField input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/parentchoice/ParentChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/parentchoice/ParentChoiceEditSupport.java index a918a8a9cd..70b1d73230 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/parentchoice/ParentChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/parentchoice/ParentChoiceEditSupport.java @@ -15,7 +15,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.ParentChoice; -@SuppressWarnings("serial") public class ParentChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/parentchoice/ParentChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/parentchoice/ParentChoiceEditor.java index b38c5fab86..6d2a28b5c1 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/parentchoice/ParentChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/parentchoice/ParentChoiceEditor.java @@ -22,7 +22,6 @@ import java.util.LinkedHashMap; import java.util.List; import java.util.Map; -@SuppressWarnings("serial") public class ParentChoiceEditor extends PropertyEditor { private StringSingleChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/password/ConfirmativePasswordPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/password/ConfirmativePasswordPropertyEditor.java index 117c0bc7d7..85ddad5f05 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/password/ConfirmativePasswordPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/password/ConfirmativePasswordPropertyEditor.java @@ -13,7 +13,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.Password; -@SuppressWarnings("serial") public class ConfirmativePasswordPropertyEditor extends PropertyEditor { private PasswordTextField input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/password/PasswordEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/password/PasswordEditSupport.java index b34feb1358..8b43f1a508 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/password/PasswordEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/password/PasswordEditSupport.java @@ -8,7 +8,6 @@ import org.apache.wicket.model.IModel; import java.lang.reflect.AnnotatedElement; -@SuppressWarnings("serial") public class PasswordEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/password/PasswordPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/password/PasswordPropertyEditor.java index d46e8195c9..11cc46dfd9 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/password/PasswordPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/password/PasswordPropertyEditor.java @@ -12,7 +12,6 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.Model; import org.apache.wicket.util.convert.ConversionException; -@SuppressWarnings("serial") public class PasswordPropertyEditor extends PropertyEditor { private PasswordTextField input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicEditSuport.java b/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicEditSuport.java index 200708447e..214ad0e842 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicEditSuport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicEditSuport.java @@ -15,7 +15,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.Editable; -@SuppressWarnings("serial") public class PolymorphicEditSuport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicPropertyEditor.java index dd4a37c5e3..a66bd27991 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicPropertyEditor.java @@ -21,7 +21,6 @@ import java.util.Collections; import java.util.HashSet; import java.util.Set; -@SuppressWarnings("serial") public class PolymorphicPropertyEditor extends PropertyEditor { private final Set excludedProperties = new HashSet<>(); @@ -37,6 +36,7 @@ public class PolymorphicPropertyEditor extends PropertyEditor { Collections.addAll(excludedProperties, excludedPropertiesAnnotation.value()); } + @SuppressWarnings("unchecked") @Override protected void onInitialize() { super.onInitialize(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicPropertyViewer.java b/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicPropertyViewer.java index 53065009f6..2d7e4af728 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicPropertyViewer.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/polymorphic/PolymorphicPropertyViewer.java @@ -12,7 +12,6 @@ import java.io.Serializable; import java.util.HashSet; import java.util.Set; -@SuppressWarnings("serial") public class PolymorphicPropertyViewer extends Panel { private final Serializable propertyValue; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/polymorphiclist/PolymorphicListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/polymorphiclist/PolymorphicListEditSupport.java index bacd54e2e7..59cd5147c4 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/polymorphiclist/PolymorphicListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/polymorphiclist/PolymorphicListEditSupport.java @@ -11,7 +11,6 @@ import java.io.Serializable; import java.lang.reflect.AnnotatedElement; import java.util.List; -@SuppressWarnings("serial") public class PolymorphicListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/polymorphiclist/PolymorphicListPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/polymorphiclist/PolymorphicListPropertyEditor.java index 3c5b431204..7404aa9c54 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/polymorphiclist/PolymorphicListPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/polymorphiclist/PolymorphicListPropertyEditor.java @@ -32,7 +32,6 @@ import java.util.*; import static java.util.Arrays.asList; -@SuppressWarnings("serial") public class PolymorphicListPropertyEditor extends PropertyEditor> { private final Class baseClass; @@ -43,6 +42,7 @@ public class PolymorphicListPropertyEditor extends PropertyEditor excludedProperties = new HashSet<>(); + @SuppressWarnings("unchecked") public PolymorphicListPropertyEditor(String id, PropertyDescriptor propertyDescriptor, IModel> model) { super(id, propertyDescriptor, model); @@ -69,6 +69,7 @@ public class PolymorphicListPropertyEditor extends PropertyEditor form) { super.onSubmit(target, form); @@ -142,7 +142,6 @@ public class PolymorphicListPropertyEditor extends PropertyEditor it = rows.iterator(); @@ -257,6 +255,7 @@ public class PolymorphicListPropertyEditor extends PropertyEditor elements; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectChoiceEditSupport.java index ced139f1df..c1cdced713 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectChoiceEditSupport.java @@ -18,7 +18,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.ProjectChoice; -@SuppressWarnings("serial") public class ProjectChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectMultiChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectMultiChoiceEditor.java index 4a4211bbea..913672cab0 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectMultiChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectMultiChoiceEditor.java @@ -21,7 +21,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.ProjectChoice; -@SuppressWarnings("serial") public class ProjectMultiChoiceEditor extends PropertyEditor> { private final IModel> choicesModel = new LoadableDetachableModel>() { diff --git a/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectSingleChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectSingleChoiceEditor.java index 374b9c1a5c..67712f6e92 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectSingleChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/project/choice/ProjectSingleChoiceEditor.java @@ -20,7 +20,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.ProjectChoice; -@SuppressWarnings("serial") public class ProjectSingleChoiceEditor extends PropertyEditor { private final IModel> choicesModel = new LoadableDetachableModel>() { diff --git a/server-core/src/main/java/io/onedev/server/web/editable/project/query/ProjectQueryEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/project/query/ProjectQueryEditSupport.java index 55cf18a65c..ad43eb3116 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/project/query/ProjectQueryEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/project/query/ProjectQueryEditSupport.java @@ -15,7 +15,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.ProjectQuery; -@SuppressWarnings("serial") public class ProjectQueryEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/project/query/ProjectQueryEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/project/query/ProjectQueryEditor.java index aca6a8e37f..32379ee204 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/project/query/ProjectQueryEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/project/query/ProjectQueryEditor.java @@ -11,7 +11,6 @@ import io.onedev.server.web.behavior.ProjectQueryBehavior; import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; -@SuppressWarnings("serial") public class ProjectQueryEditor extends PropertyEditor { private TextField input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/PullRequestQueryEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/PullRequestQueryEditSupport.java index ec27df5f5d..c07837456e 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/PullRequestQueryEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/PullRequestQueryEditSupport.java @@ -19,7 +19,6 @@ import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.PullRequestQuery; import io.onedev.server.web.editable.string.StringPropertyEditor; -@SuppressWarnings("serial") public class PullRequestQueryEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/choice/PullRequestChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/choice/PullRequestChoiceEditSupport.java index 347e166069..693cbfe1e6 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/choice/PullRequestChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/choice/PullRequestChoiceEditSupport.java @@ -19,7 +19,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.PullRequestChoice; -@SuppressWarnings("serial") public class PullRequestChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/choice/PullRequestChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/choice/PullRequestChoiceEditor.java index 0e62ab5ef0..dab358f9fa 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/choice/PullRequestChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/pullrequest/choice/PullRequestChoiceEditor.java @@ -2,7 +2,6 @@ package io.onedev.server.web.editable.pullrequest.choice; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior; -import org.apache.wicket.model.AbstractReadOnlyModel; import org.apache.wicket.model.IModel; import org.apache.wicket.model.Model; import org.apache.wicket.util.convert.ConversionException; @@ -17,7 +16,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.util.ProjectAware; -@SuppressWarnings("serial") public class PullRequestChoiceEditor extends PropertyEditor { private PullRequestSingleChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/refreshtoken/RefreshTokenEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/refreshtoken/RefreshTokenEditSupport.java index 3dbbc83763..872a4dea09 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/refreshtoken/RefreshTokenEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/refreshtoken/RefreshTokenEditSupport.java @@ -14,7 +14,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.RefreshToken; -@SuppressWarnings("serial") public class RefreshTokenEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/refreshtoken/RefreshTokenPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/refreshtoken/RefreshTokenPropertyEditor.java index 2441458c5e..ce11e0bf08 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/refreshtoken/RefreshTokenPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/refreshtoken/RefreshTokenPropertyEditor.java @@ -45,7 +45,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.RefreshToken; import io.onedev.server.web.page.simple.security.OAuthCallbackPage; -@SuppressWarnings("serial") public class RefreshTokenPropertyEditor extends PropertyEditor { private PasswordTextField input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/revisionchoice/RevisionChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/revisionchoice/RevisionChoiceEditSupport.java index 47e4a306c3..d7a859489a 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/revisionchoice/RevisionChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/revisionchoice/RevisionChoiceEditSupport.java @@ -15,7 +15,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.RevisionChoice; -@SuppressWarnings("serial") public class RevisionChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/revisionchoice/RevisionChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/revisionchoice/RevisionChoiceEditor.java index 8e33c41a4f..fa3667ff91 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/revisionchoice/RevisionChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/revisionchoice/RevisionChoiceEditor.java @@ -13,7 +13,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.RevisionChoice; -@SuppressWarnings("serial") public class RevisionChoiceEditor extends PropertyEditor { private String revision; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleChoiceEditSupport.java index b7226f6246..73ca41520d 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleChoiceEditSupport.java @@ -18,7 +18,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.RoleChoice; -@SuppressWarnings("serial") public class RoleChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleMultiChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleMultiChoiceEditor.java index c97a1ffa84..36434829b3 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleMultiChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleMultiChoiceEditor.java @@ -19,7 +19,6 @@ import io.onedev.server.web.component.stringchoice.StringMultiChoice; import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; -@SuppressWarnings("serial") public class RoleMultiChoiceEditor extends PropertyEditor> { private StringMultiChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleSingleChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleSingleChoiceEditor.java index 4a04a60c0a..5fe9a856c2 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleSingleChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/rolechoice/RoleSingleChoiceEditor.java @@ -16,7 +16,6 @@ import io.onedev.server.web.component.stringchoice.StringSingleChoice; import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; -@SuppressWarnings("serial") public class RoleSingleChoiceEditor extends PropertyEditor { private StringSingleChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/scriptchoice/ScriptChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/scriptchoice/ScriptChoiceEditSupport.java index 6fc1f256a2..4e506bda96 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/scriptchoice/ScriptChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/scriptchoice/ScriptChoiceEditSupport.java @@ -14,7 +14,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.ScriptChoice; -@SuppressWarnings("serial") public class ScriptChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/scriptchoice/ScriptChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/scriptchoice/ScriptChoiceEditor.java index 58fb67ef18..37d6adceff 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/scriptchoice/ScriptChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/scriptchoice/ScriptChoiceEditor.java @@ -19,7 +19,6 @@ import io.onedev.server.web.component.stringchoice.StringSingleChoice; import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; -@SuppressWarnings("serial") public class ScriptChoiceEditor extends PropertyEditor { private FormComponent input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretEditSupport.java index cf88515b9c..c24752aba8 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretEditSupport.java @@ -7,7 +7,6 @@ import org.apache.wicket.model.IModel; import java.lang.reflect.AnnotatedElement; -@SuppressWarnings("serial") public class SecretEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretPropertyEditor.java index 881331f6b0..a20b06c9da 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretPropertyEditor.java @@ -18,7 +18,6 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.Model; import org.apache.wicket.util.convert.ConversionException; -@SuppressWarnings("serial") public class SecretPropertyEditor extends PropertyEditor { private FormComponent input2; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretPropertyViewer.java b/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretPropertyViewer.java index 921a0092db..dae6933dc5 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretPropertyViewer.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/secret/SecretPropertyViewer.java @@ -5,7 +5,6 @@ import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.panel.Panel; import org.apache.wicket.model.Model; -@SuppressWarnings("serial") public class SecretPropertyViewer extends Panel { private final String secret; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorEditPanel.java index 8b1110c84a..4ef0929c5a 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorEditPanel.java @@ -18,7 +18,6 @@ import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class ServiceLocatorEditPanel extends Panel implements BuildSpecAware, JobAware { private final List locators; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListEditPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListEditPanel.java index 0d930f8853..68a3f4b4d7 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListEditPanel.java @@ -36,7 +36,6 @@ import java.io.Serializable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") class ServiceLocatorListEditPanel extends PropertyEditor> { private final List locators; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListEditSupport.java index 6de8ab212e..2c33449ba9 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListEditSupport.java @@ -16,7 +16,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class ServiceLocatorListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListViewPanel.java b/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListViewPanel.java index e5f0fbedae..ebfc3d595a 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/servicelocator/ServiceLocatorListViewPanel.java @@ -33,7 +33,6 @@ import io.onedev.server.web.component.offcanvas.OffCanvasPanel.Placement; import io.onedev.server.web.component.svg.SpriteImage; import io.onedev.server.web.editable.BeanContext; -@SuppressWarnings("serial") class ServiceLocatorListViewPanel extends Panel { private final List locators = new ArrayList<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/string/StringEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/string/StringEditSupport.java index c66a6e3e6b..34c8f78546 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/string/StringEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/string/StringEditSupport.java @@ -8,7 +8,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class StringEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/string/StringPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/string/StringPropertyEditor.java index 3b39ad776a..c4b38857d7 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/string/StringPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/string/StringPropertyEditor.java @@ -17,7 +17,6 @@ import org.apache.wicket.util.convert.ConversionException; import java.lang.reflect.Method; -@SuppressWarnings("serial") public class StringPropertyEditor extends PropertyEditor { private FormComponent input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/string/StringPropertyViewer.java b/server-core/src/main/java/io/onedev/server/web/editable/string/StringPropertyViewer.java index b70f2e9389..6b6cdc365a 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/string/StringPropertyViewer.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/string/StringPropertyViewer.java @@ -10,7 +10,6 @@ import io.onedev.server.web.editable.EmptyValueLabel; import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyViewer; -@SuppressWarnings("serial") public class StringPropertyViewer extends PropertyViewer { private final String value; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListEditSupport.java index 580d86459e..d6f3e01d61 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListEditSupport.java @@ -9,7 +9,6 @@ import java.util.List; import static io.onedev.server.util.ReflectionUtils.getCollectionElementClass; -@SuppressWarnings("serial") public class StringListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListEditor.java index f9ce11eaab..2593472b94 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListEditor.java @@ -15,7 +15,6 @@ import java.util.Collection; import java.util.HashMap; import java.util.List; -@SuppressWarnings("serial") public class StringListEditor extends PropertyEditor> { private Select2MultiChoice input; @@ -24,7 +23,6 @@ public class StringListEditor extends PropertyEditor> { super(id, propertyDescriptor, propertyModel); } - @SuppressWarnings({"unchecked"}) @Override protected void onInitialize() { super.onInitialize(); diff --git a/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListPropertyViewer.java b/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListPropertyViewer.java index f9a586b5fe..0cbd2cb1ad 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListPropertyViewer.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/stringlist/StringListPropertyViewer.java @@ -8,7 +8,6 @@ import org.apache.wicket.markup.html.panel.Panel; import java.util.List; -@SuppressWarnings("serial") public class StringListPropertyViewer extends Panel { private final List elements; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserChoiceEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserChoiceEditSupport.java index 1a974c8103..36387c0aa0 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserChoiceEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserChoiceEditSupport.java @@ -18,7 +18,6 @@ import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.editable.PropertyViewer; import io.onedev.server.annotation.UserChoice; -@SuppressWarnings("serial") public class UserChoiceEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserMultiChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserMultiChoiceEditor.java index 2c4fc36ee6..03b65e0790 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserMultiChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserMultiChoiceEditor.java @@ -27,7 +27,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.UserChoice; -@SuppressWarnings("serial") public class UserMultiChoiceEditor extends PropertyEditor> { private UserMultiChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserSingleChoiceEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserSingleChoiceEditor.java index a8a62b4f19..f985a1bf9f 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserSingleChoiceEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/userchoice/UserSingleChoiceEditor.java @@ -27,7 +27,6 @@ import io.onedev.server.web.editable.PropertyDescriptor; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.annotation.UserChoice; -@SuppressWarnings("serial") public class UserSingleChoiceEditor extends PropertyEditor { private UserSingleChoice input; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/verticalbeanlist/VerticalBeanListEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/verticalbeanlist/VerticalBeanListEditSupport.java index 515ba2207f..cb7f91506d 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/verticalbeanlist/VerticalBeanListEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/verticalbeanlist/VerticalBeanListEditSupport.java @@ -12,7 +12,6 @@ import java.io.Serializable; import java.lang.reflect.AnnotatedElement; import java.util.List; -@SuppressWarnings("serial") public class VerticalBeanListEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/verticalbeanlist/VerticalBeanListPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/verticalbeanlist/VerticalBeanListPropertyEditor.java index 49eb2f8ea2..4f690ae42f 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/verticalbeanlist/VerticalBeanListPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/verticalbeanlist/VerticalBeanListPropertyEditor.java @@ -27,7 +27,6 @@ import java.util.*; import static java.util.Arrays.asList; -@SuppressWarnings("serial") public class VerticalBeanListPropertyEditor extends PropertyEditor> { private Class elementClass; @@ -63,6 +62,7 @@ public class VerticalBeanListPropertyEditor extends PropertyEditor form) { super.onSubmit(target, form); @@ -136,7 +135,6 @@ public class VerticalBeanListPropertyEditor extends PropertyEditor it = rows.iterator(); @@ -234,6 +231,7 @@ public class VerticalBeanListPropertyEditor extends PropertyEditor elements; diff --git a/server-core/src/main/java/io/onedev/server/web/editable/workingperiod/WorkingPeriodEditSupport.java b/server-core/src/main/java/io/onedev/server/web/editable/workingperiod/WorkingPeriodEditSupport.java index 88392b3d55..6afb2e905b 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/workingperiod/WorkingPeriodEditSupport.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/workingperiod/WorkingPeriodEditSupport.java @@ -11,7 +11,6 @@ import org.apache.wicket.model.IModel; import java.lang.reflect.AnnotatedElement; import java.lang.reflect.Method; -@SuppressWarnings("serial") public class WorkingPeriodEditSupport implements EditSupport { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/editable/workingperiod/WorkingPeriodPropertyEditor.java b/server-core/src/main/java/io/onedev/server/web/editable/workingperiod/WorkingPeriodPropertyEditor.java index 826ba14b5a..df2d4ef976 100644 --- a/server-core/src/main/java/io/onedev/server/web/editable/workingperiod/WorkingPeriodPropertyEditor.java +++ b/server-core/src/main/java/io/onedev/server/web/editable/workingperiod/WorkingPeriodPropertyEditor.java @@ -15,7 +15,6 @@ import org.apache.wicket.util.convert.ConversionException; import javax.validation.ValidationException; -@SuppressWarnings("serial") public class WorkingPeriodPropertyEditor extends PropertyEditor { private TextField input; diff --git a/server-core/src/main/java/io/onedev/server/web/page/HomePage.java b/server-core/src/main/java/io/onedev/server/web/page/HomePage.java index 85e5a906e9..c62dbfe18e 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/HomePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/HomePage.java @@ -11,7 +11,6 @@ import io.onedev.server.OneDev; import io.onedev.server.web.page.layout.LayoutPage; import io.onedev.server.web.page.layout.MainMenuCustomization; -@SuppressWarnings("serial") public class HomePage extends LayoutPage { public static final String PARAM_FAILSAFE = "failsafe"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/AdministrationPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/AdministrationPage.java index 91ee75cc38..d429ae5dcf 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/AdministrationPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/AdministrationPage.java @@ -8,7 +8,6 @@ import org.apache.wicket.markup.head.CssHeaderItem; import org.apache.wicket.markup.head.IHeaderResponse; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public abstract class AdministrationPage extends LayoutPage { public AdministrationPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/alertsettings/AlertSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/alertsettings/AlertSettingPage.java index 64b3154811..9f7dd7edd2 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/alertsettings/AlertSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/alertsettings/AlertSettingPage.java @@ -9,7 +9,6 @@ import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.form.Form; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class AlertSettingPage extends AdministrationPage { public AlertSettingPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/authenticator/AuthenticatorPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/authenticator/AuthenticatorPage.java index aad72579ea..194e0cd69b 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/authenticator/AuthenticatorPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/authenticator/AuthenticatorPage.java @@ -28,7 +28,6 @@ import org.apache.wicket.util.visit.IVisitor; import java.io.Serializable; -@SuppressWarnings("serial") public class AuthenticatorPage extends AdministrationPage { private AuthenticationToken token = new AuthenticationToken(); diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/brandingsetting/BrandSettingEditBean.java b/server-core/src/main/java/io/onedev/server/web/page/admin/brandingsetting/BrandSettingEditBean.java index e222059a67..d1b6ecb889 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/brandingsetting/BrandSettingEditBean.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/brandingsetting/BrandSettingEditBean.java @@ -30,6 +30,7 @@ public class BrandSettingEditBean implements Serializable { this.name = name; } + @SuppressWarnings("unused") private static boolean isOEM() { return BrandingSetting.isOEM((String) EditContext.get().getInputValue("name")); } diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/brandingsetting/BrandingSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/brandingsetting/BrandingSettingPage.java index f207de135d..1a3c7d4755 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/brandingsetting/BrandingSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/brandingsetting/BrandingSettingPage.java @@ -1,37 +1,30 @@ package io.onedev.server.web.page.admin.brandingsetting; +import java.io.File; +import java.io.IOException; +import java.net.URL; + +import javax.annotation.Nullable; + +import org.apache.commons.codec.binary.Base64; +import org.apache.wicket.Component; +import org.apache.wicket.Session; +import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.markup.html.form.Form; +import org.apache.wicket.markup.html.link.Link; +import org.apache.wicket.request.mapper.parameter.PageParameters; + import com.google.common.io.Resources; + import io.onedev.commons.utils.FileUtils; import io.onedev.server.OneDev; import io.onedev.server.cluster.ClusterManager; import io.onedev.server.cluster.ClusterTask; import io.onedev.server.entitymanager.SettingManager; import io.onedev.server.model.support.administration.BrandingSetting; -import io.onedev.server.web.component.brandlogo.BrandLogoPanel; -import io.onedev.server.web.component.fileupload.FileUploadField; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.img.ImageScope; import io.onedev.server.web.page.admin.AdministrationPage; -import io.onedev.server.web.util.ConfirmClickModifier; -import org.apache.commons.codec.binary.Base64; -import org.apache.wicket.Component; -import org.apache.wicket.Session; -import org.apache.wicket.ajax.AjaxRequestTarget; -import org.apache.wicket.ajax.form.AjaxFormSubmitBehavior; -import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.markup.html.form.Form; -import org.apache.wicket.markup.html.form.upload.FileUpload; -import org.apache.wicket.markup.html.link.Link; -import org.apache.wicket.markup.html.panel.Fragment; -import org.apache.wicket.model.IModel; -import org.apache.wicket.request.mapper.parameter.PageParameters; - -import javax.annotation.Nullable; -import java.io.File; -import java.io.IOException; -import java.net.URL; -import java.util.ArrayList; -import java.util.List; public class BrandingSettingPage extends AdministrationPage { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AddAgentPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AddAgentPanel.java index 83cc495a78..6972092c28 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AddAgentPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AddAgentPanel.java @@ -22,7 +22,6 @@ import io.onedev.server.web.component.tabbable.AjaxActionTab; import io.onedev.server.web.component.tabbable.Tab; import io.onedev.server.web.component.tabbable.Tabbable; -@SuppressWarnings("serial") class AddAgentPanel extends Panel { public AddAgentPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentBuildsPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentBuildsPage.java index 5b89d5643d..25c6b309a3 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentBuildsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentBuildsPage.java @@ -18,7 +18,6 @@ import io.onedev.server.search.entity.build.RanOnCriteria; import io.onedev.server.web.component.build.list.BuildListPanel; import io.onedev.server.web.util.paginghistory.PagingHistorySupport; -@SuppressWarnings("serial") public class AgentBuildsPage extends AgentDetailPage { private static final String PARAM_QUERY = "query"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentDetailPage.java index 6b250daeda..c856340f79 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentDetailPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentDetailPage.java @@ -20,7 +20,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public abstract class AgentDetailPage extends AdministrationPage { public static final String PARAM_AGENT = "agent"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentIcon.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentIcon.java index 7fb9914323..7beac18462 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentIcon.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentIcon.java @@ -6,7 +6,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import io.onedev.server.model.Agent; import io.onedev.server.web.component.svg.SpriteImage; -@SuppressWarnings("serial") public class AgentIcon extends SpriteImage { private final IModel agentModel; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentListPage.java index 99ea7e8aa6..8c3aa31b76 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentListPage.java @@ -30,7 +30,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.ArrayList; -@SuppressWarnings("serial") public class AgentListPage extends AdministrationPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentListPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentListPanel.java index 978593e831..ef63569637 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentListPanel.java @@ -59,7 +59,6 @@ import org.apache.wicket.request.cycle.RequestCycle; import javax.annotation.Nullable; import java.util.*; -@SuppressWarnings("serial") class AgentListPanel extends Panel { private final IModel queryStringModel; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentLogPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentLogPage.java index 90ffdb6a09..ca29fe3047 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentLogPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentLogPage.java @@ -15,7 +15,6 @@ import io.onedev.server.entitymanager.AgentManager; import io.onedev.server.web.resource.AgentLogResource; import io.onedev.server.web.resource.AgentLogResourceReference; -@SuppressWarnings("serial") public class AgentLogPage extends AgentDetailPage { private static final int MAX_DISPLAY_LINES = 5000; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentOverviewPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentOverviewPage.java index 0865a1232c..ea544cb41c 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentOverviewPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/AgentOverviewPage.java @@ -22,7 +22,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.*; -@SuppressWarnings("serial") public class AgentOverviewPage extends AgentDetailPage { public AgentOverviewPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/TokenListPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/TokenListPanel.java index c660bf9d2e..8764543171 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/TokenListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/agent/TokenListPanel.java @@ -29,7 +29,6 @@ import io.onedev.server.web.ajaxlistener.ConfirmClickListener; import io.onedev.server.web.component.link.copytoclipboard.CopyToClipboardLink; import io.onedev.server.web.util.LoadableDetachableDataProvider; -@SuppressWarnings("serial") public class TokenListPanel extends GenericPanel> { public TokenListPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorEditPanel.java index 63d5a8c52a..c16b554140 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorEditPanel.java @@ -32,7 +32,6 @@ import java.lang.reflect.ParameterizedType; import java.lang.reflect.Type; import java.util.List; -@SuppressWarnings("serial") abstract class JobExecutorEditPanel extends Panel { private final List executors; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorPanel.java index 0a30956550..5c3e1ee7ed 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorPanel.java @@ -16,7 +16,6 @@ import org.apache.wicket.model.Model; import java.util.List; -@SuppressWarnings("serial") abstract class JobExecutorPanel extends Panel { private final List executors; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorsPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorsPage.java index 16376696e0..1ccd0e8587 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/buildsetting/jobexecutor/JobExecutorsPage.java @@ -20,7 +20,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.List; -@SuppressWarnings("serial") public class JobExecutorsPage extends AdministrationPage { private List executors; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/databasebackup/DatabaseBackupPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/databasebackup/DatabaseBackupPage.java index 1c1ad5efb3..04a3480422 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/databasebackup/DatabaseBackupPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/databasebackup/DatabaseBackupPage.java @@ -20,7 +20,6 @@ import org.apache.wicket.request.resource.AbstractResource; import java.io.File; import java.io.IOException; -@SuppressWarnings("serial") public class DatabaseBackupPage extends AdministrationPage { public DatabaseBackupPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractNotificationTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractNotificationTemplatePage.java index 9b77cca4e8..ffc33b7f8c 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractNotificationTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractNotificationTemplatePage.java @@ -1,14 +1,12 @@ package io.onedev.server.web.page.admin.emailtemplates; +import java.util.Map; + +import org.apache.wicket.request.mapper.parameter.PageParameters; + import io.onedev.server.model.support.administration.emailtemplates.EmailTemplates; import io.onedev.server.util.CollectionUtils; -import org.apache.wicket.request.mapper.parameter.PageParameters; -import java.util.LinkedHashMap; -import java.util.List; -import java.util.Map; - -@SuppressWarnings("serial") public abstract class AbstractNotificationTemplatePage extends AbstractTemplatePage { public AbstractNotificationTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractSimpleNotificationTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractSimpleNotificationTemplatePage.java index 6857cf6271..fc233cd6b8 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractSimpleNotificationTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractSimpleNotificationTemplatePage.java @@ -6,7 +6,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.Map; -@SuppressWarnings("serial") public abstract class AbstractSimpleNotificationTemplatePage extends AbstractTemplatePage { public AbstractSimpleNotificationTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractTemplatePage.java index dbbeab9e84..fb718edf7f 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AbstractTemplatePage.java @@ -21,7 +21,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.LinkedHashMap; import java.util.Map; -@SuppressWarnings("serial") public abstract class AbstractTemplatePage extends AdministrationPage { protected final String GROOVY_TEMPLATE_LINK = "Groovy simple template"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AlertTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AlertTemplatePage.java index 2c6b54db61..0a24fab6b3 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AlertTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/AlertTemplatePage.java @@ -9,7 +9,6 @@ import java.util.Map; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.*; -@SuppressWarnings("serial") public class AlertTemplatePage extends AbstractTemplatePage { public AlertTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/BuildNotificationTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/BuildNotificationTemplatePage.java index f10b6d6da3..e9cc3d5638 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/BuildNotificationTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/BuildNotificationTemplatePage.java @@ -9,7 +9,6 @@ import java.util.Map; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.PROP_BUILD_NOTIFICATION; -@SuppressWarnings("serial") public class BuildNotificationTemplatePage extends AbstractSimpleNotificationTemplatePage { public BuildNotificationTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/CommitNotificationTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/CommitNotificationTemplatePage.java index 4752ae30d1..e574fc9829 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/CommitNotificationTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/CommitNotificationTemplatePage.java @@ -9,7 +9,6 @@ import java.util.Map; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.PROP_COMMIT_NOTIFICATION; -@SuppressWarnings("serial") public class CommitNotificationTemplatePage extends AbstractSimpleNotificationTemplatePage { public CommitNotificationTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/EmailVerificationTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/EmailVerificationTemplatePage.java index fb2fbf7fb2..cfe4522be9 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/EmailVerificationTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/EmailVerificationTemplatePage.java @@ -9,7 +9,6 @@ import java.util.Map; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.*; -@SuppressWarnings("serial") public class EmailVerificationTemplatePage extends AbstractTemplatePage { public EmailVerificationTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/IssueNotificationTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/IssueNotificationTemplatePage.java index e919845bbc..7598652142 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/IssueNotificationTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/IssueNotificationTemplatePage.java @@ -9,7 +9,6 @@ import java.util.Map; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.PROP_ISSUE_NOTIFICATION; -@SuppressWarnings("serial") public class IssueNotificationTemplatePage extends AbstractNotificationTemplatePage { public IssueNotificationTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/IssueNotificationUnsubscribedTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/IssueNotificationUnsubscribedTemplatePage.java index 10aae45058..8a5d5bb441 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/IssueNotificationUnsubscribedTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/IssueNotificationUnsubscribedTemplatePage.java @@ -1,16 +1,16 @@ package io.onedev.server.web.page.admin.emailtemplates; -import io.onedev.server.util.CollectionUtils; +import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.DEFAULT_ISSUE_NOTIFICATION_UNSUBSCRIBED; +import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.PROP_ISSUE_NOTIFICATION_UNSUBSCRIBED; + +import java.util.Map; + import org.apache.wicket.Component; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.request.mapper.parameter.PageParameters; -import java.util.List; -import java.util.Map; +import io.onedev.server.util.CollectionUtils; -import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.*; - -@SuppressWarnings("serial") public class IssueNotificationUnsubscribedTemplatePage extends AbstractTemplatePage { public IssueNotificationUnsubscribedTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PackNotificationTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PackNotificationTemplatePage.java index 29053db490..432f0c8f67 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PackNotificationTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PackNotificationTemplatePage.java @@ -9,7 +9,6 @@ import java.util.Map; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.PROP_PACK_NOTIFICATION; -@SuppressWarnings("serial") public class PackNotificationTemplatePage extends AbstractSimpleNotificationTemplatePage { public PackNotificationTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PasswordResetTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PasswordResetTemplatePage.java index bdc45e03e2..176dce8848 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PasswordResetTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PasswordResetTemplatePage.java @@ -9,7 +9,6 @@ import java.util.Map; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.*; -@SuppressWarnings("serial") public class PasswordResetTemplatePage extends AbstractTemplatePage { public PasswordResetTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PullRequestNotificationTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PullRequestNotificationTemplatePage.java index 46d4375474..89617504af 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PullRequestNotificationTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PullRequestNotificationTemplatePage.java @@ -9,7 +9,6 @@ import java.util.Map; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.PROP_PULL_REQUEST_NOTIFICATION; -@SuppressWarnings("serial") public class PullRequestNotificationTemplatePage extends AbstractNotificationTemplatePage { public PullRequestNotificationTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PullRequestNotificationUnsubscribedTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PullRequestNotificationUnsubscribedTemplatePage.java index a8ee49cafd..846103fa55 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PullRequestNotificationUnsubscribedTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/PullRequestNotificationUnsubscribedTemplatePage.java @@ -1,17 +1,16 @@ package io.onedev.server.web.page.admin.emailtemplates; -import io.onedev.server.util.CollectionUtils; -import org.apache.wicket.Component; -import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.request.mapper.parameter.PageParameters; - -import java.util.List; -import java.util.Map; - import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.DEFAULT_PULL_REQUEST_NOTIFICATION_UNSUBSCRIBED; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.PROP_PULL_REQUEST_NOTIFICATION_UNSUBSCRIBED; -@SuppressWarnings("serial") +import java.util.Map; + +import org.apache.wicket.Component; +import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.request.mapper.parameter.PageParameters; + +import io.onedev.server.util.CollectionUtils; + public class PullRequestNotificationUnsubscribedTemplatePage extends AbstractTemplatePage { public PullRequestNotificationUnsubscribedTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/ServiceDeskIssueOpenFailedTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/ServiceDeskIssueOpenFailedTemplatePage.java index 39530793f9..6ce6c2e61a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/ServiceDeskIssueOpenFailedTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/ServiceDeskIssueOpenFailedTemplatePage.java @@ -1,16 +1,16 @@ package io.onedev.server.web.page.admin.emailtemplates; -import io.onedev.server.util.CollectionUtils; +import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.DEFAULT_SERVICE_DESK_ISSUE_OPEN_FAILED; +import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.PROP_SERVICE_DESK_ISSUE_OPEN_FAILED; + +import java.util.Map; + import org.apache.wicket.Component; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.request.mapper.parameter.PageParameters; -import java.util.List; -import java.util.Map; +import io.onedev.server.util.CollectionUtils; -import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.*; - -@SuppressWarnings("serial") public class ServiceDeskIssueOpenFailedTemplatePage extends AbstractTemplatePage { public ServiceDeskIssueOpenFailedTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/ServiceDeskIssueOpenedTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/ServiceDeskIssueOpenedTemplatePage.java index fb29517c10..ac7e73ea9b 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/ServiceDeskIssueOpenedTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/ServiceDeskIssueOpenedTemplatePage.java @@ -1,17 +1,16 @@ package io.onedev.server.web.page.admin.emailtemplates; -import io.onedev.server.util.CollectionUtils; -import org.apache.wicket.Component; -import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.request.mapper.parameter.PageParameters; - -import java.util.List; -import java.util.Map; - import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.DEFAULT_SERVICE_DESK_ISSUE_OPENED; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.PROP_SERVICE_DESK_ISSUE_OPENED; -@SuppressWarnings("serial") +import java.util.Map; + +import org.apache.wicket.Component; +import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.request.mapper.parameter.PageParameters; + +import io.onedev.server.util.CollectionUtils; + public class ServiceDeskIssueOpenedTemplatePage extends AbstractTemplatePage { public ServiceDeskIssueOpenedTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/StopwatchOverdueTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/StopwatchOverdueTemplatePage.java index 3449a3612a..02932c25af 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/StopwatchOverdueTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/StopwatchOverdueTemplatePage.java @@ -9,7 +9,6 @@ import java.util.Map; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.*; -@SuppressWarnings("serial") public class StopwatchOverdueTemplatePage extends AbstractTemplatePage { public StopwatchOverdueTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/UserInvitationTemplatePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/UserInvitationTemplatePage.java index a165a83758..dfd007cc8d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/UserInvitationTemplatePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/emailtemplates/UserInvitationTemplatePage.java @@ -9,7 +9,6 @@ import java.util.Map; import static io.onedev.server.model.support.administration.emailtemplates.EmailTemplates.*; -@SuppressWarnings("serial") public class UserInvitationTemplatePage extends AbstractTemplatePage { public UserInvitationTemplatePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/gpgsigningkey/GpgSigningKeyPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/gpgsigningkey/GpgSigningKeyPage.java index 361d810e33..94df42a771 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/gpgsigningkey/GpgSigningKeyPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/gpgsigningkey/GpgSigningKeyPage.java @@ -25,7 +25,6 @@ import io.onedev.server.web.component.link.copytoclipboard.CopyToClipboardLink; import io.onedev.server.web.component.modal.confirm.ConfirmModalPanel; import io.onedev.server.web.page.admin.AdministrationPage; -@SuppressWarnings("serial") public class GpgSigningKeyPage extends AdministrationPage { public GpgSigningKeyPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/gpgtrustedkeys/GpgTrustedKeysPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/gpgtrustedkeys/GpgTrustedKeysPage.java index c5590f8787..f35e4b5b86 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/gpgtrustedkeys/GpgTrustedKeysPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/gpgtrustedkeys/GpgTrustedKeysPage.java @@ -45,7 +45,6 @@ import io.onedev.server.web.editable.BeanEditor; import io.onedev.server.web.page.admin.AdministrationPage; import io.onedev.server.web.util.LoadableDetachableDataProvider; -@SuppressWarnings("serial") public class GpgTrustedKeysPage extends AdministrationPage { public GpgTrustedKeysPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/groovyscript/GroovyScriptEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/groovyscript/GroovyScriptEditPanel.java index 377d4be915..99d82ddbdd 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/groovyscript/GroovyScriptEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/groovyscript/GroovyScriptEditPanel.java @@ -22,7 +22,6 @@ import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class GroovyScriptEditPanel extends Panel { private final int scriptIndex; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/groovyscript/GroovyScriptListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/groovyscript/GroovyScriptListPage.java index 7d607cfa59..c2b42b1188 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/groovyscript/GroovyScriptListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/groovyscript/GroovyScriptListPage.java @@ -1,5 +1,29 @@ package io.onedev.server.web.page.admin.groovyscript; +import java.util.ArrayList; +import java.util.List; + +import org.apache.wicket.Component; +import org.apache.wicket.ajax.AjaxRequestTarget; +import org.apache.wicket.ajax.attributes.AjaxRequestAttributes; +import org.apache.wicket.ajax.markup.html.AjaxLink; +import org.apache.wicket.extensions.markup.html.repeater.data.grid.ICellPopulator; +import org.apache.wicket.extensions.markup.html.repeater.data.table.AbstractColumn; +import org.apache.wicket.extensions.markup.html.repeater.data.table.DataTable; +import org.apache.wicket.extensions.markup.html.repeater.data.table.HeadersToolbar; +import org.apache.wicket.extensions.markup.html.repeater.data.table.IColumn; +import org.apache.wicket.extensions.markup.html.repeater.data.table.NoRecordsToolbar; +import org.apache.wicket.markup.ComponentTag; +import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.markup.html.list.LoopItem; +import org.apache.wicket.markup.html.panel.Fragment; +import org.apache.wicket.markup.repeater.Item; +import org.apache.wicket.markup.repeater.data.IDataProvider; +import org.apache.wicket.markup.repeater.data.ListDataProvider; +import org.apache.wicket.model.IModel; +import org.apache.wicket.model.Model; +import org.apache.wicket.request.mapper.parameter.PageParameters; + import io.onedev.server.OneDev; import io.onedev.server.entitymanager.SettingManager; import io.onedev.server.model.support.administration.GroovyScript; @@ -11,31 +35,9 @@ import io.onedev.server.web.behavior.sortable.SortPosition; import io.onedev.server.web.component.modal.ModalLink; import io.onedev.server.web.component.modal.ModalPanel; import io.onedev.server.web.component.svg.SpriteImage; -import io.onedev.server.web.editable.EmptyValueLabel; import io.onedev.server.web.page.admin.AdministrationPage; import io.onedev.server.web.util.TextUtils; -import org.apache.wicket.Component; -import org.apache.wicket.ajax.AjaxRequestTarget; -import org.apache.wicket.ajax.attributes.AjaxRequestAttributes; -import org.apache.wicket.ajax.markup.html.AjaxLink; -import org.apache.wicket.extensions.markup.html.repeater.data.grid.ICellPopulator; -import org.apache.wicket.extensions.markup.html.repeater.data.table.*; -import org.apache.wicket.markup.ComponentTag; -import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.markup.html.list.LoopItem; -import org.apache.wicket.markup.html.panel.Fragment; -import org.apache.wicket.markup.repeater.Item; -import org.apache.wicket.markup.repeater.data.IDataProvider; -import org.apache.wicket.markup.repeater.data.ListDataProvider; -import org.apache.wicket.model.IModel; -import org.apache.wicket.model.Model; -import org.apache.wicket.request.mapper.parameter.PageParameters; -import java.lang.reflect.AnnotatedElement; -import java.util.ArrayList; -import java.util.List; - -@SuppressWarnings("serial") public class GroovyScriptListPage extends AdministrationPage { private final List scripts; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/GroupListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/GroupListPage.java index 3ad084a57c..64d242666e 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/GroupListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/GroupListPage.java @@ -44,7 +44,6 @@ import java.util.ArrayList; import java.util.Iterator; import java.util.List; -@SuppressWarnings("serial") public class GroupListPage extends AdministrationPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/GroupPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/GroupPage.java index 746445df62..572a5e2031 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/GroupPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/GroupPage.java @@ -26,7 +26,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public abstract class GroupPage extends AdministrationPage { public static final String PARAM_GROUP = "group"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/authorization/GroupAuthorizationsPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/authorization/GroupAuthorizationsPage.java index 4a794ebdad..61f1fa8391 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/authorization/GroupAuthorizationsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/authorization/GroupAuthorizationsPage.java @@ -20,7 +20,6 @@ import io.onedev.server.web.page.admin.groupmanagement.GroupPage; import io.onedev.server.web.util.editbean.ProjectAuthorizationBean; import io.onedev.server.web.util.editbean.ProjectAuthorizationsBean; -@SuppressWarnings("serial") public class GroupAuthorizationsPage extends GroupPage { public GroupAuthorizationsPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/create/NewGroupPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/create/NewGroupPage.java index 058d77e6de..f06a6ce902 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/create/NewGroupPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/create/NewGroupPage.java @@ -22,7 +22,6 @@ import io.onedev.server.web.page.admin.groupmanagement.GroupCssResourceReference import io.onedev.server.web.page.admin.groupmanagement.GroupListPage; import io.onedev.server.web.page.admin.groupmanagement.membership.GroupMembershipsPage; -@SuppressWarnings("serial") public class NewGroupPage extends AdministrationPage { private Group group = new Group(); diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/membership/GroupMembershipsPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/membership/GroupMembershipsPage.java index 89014ec5f6..26bccc5503 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/membership/GroupMembershipsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/membership/GroupMembershipsPage.java @@ -62,7 +62,6 @@ import io.onedev.server.web.component.user.choice.UserChoiceResourceReference; import io.onedev.server.web.page.admin.groupmanagement.GroupPage; import io.onedev.server.web.page.admin.usermanagement.profile.UserProfilePage; -@SuppressWarnings("serial") public class GroupMembershipsPage extends GroupPage { private String query; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/profile/GroupProfilePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/profile/GroupProfilePage.java index 588d8be0be..c4d1d585f4 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/profile/GroupProfilePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/groupmanagement/profile/GroupProfilePage.java @@ -22,7 +22,6 @@ import io.onedev.server.web.page.admin.groupmanagement.GroupListPage; import io.onedev.server.web.page.admin.groupmanagement.GroupPage; import io.onedev.server.web.util.ConfirmClickModifier; -@SuppressWarnings("serial") public class GroupProfilePage extends GroupPage { private BeanEditor editor; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/IssueSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/IssueSettingPage.java index 068a9c953a..5fec9e493a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/IssueSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/IssueSettingPage.java @@ -11,7 +11,6 @@ import io.onedev.server.model.support.administration.GlobalIssueSetting; import io.onedev.server.web.component.issue.workflowreconcile.WorkflowChangeAlertPanel; import io.onedev.server.web.page.admin.AdministrationPage; -@SuppressWarnings("serial") public abstract class IssueSettingPage extends AdministrationPage { private final GlobalIssueSetting setting; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/defaultboard/DefaultBoardListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/defaultboard/DefaultBoardListPage.java index e43ec98875..0423f290b2 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/defaultboard/DefaultBoardListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/defaultboard/DefaultBoardListPage.java @@ -34,7 +34,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class DefaultBoardListPage extends IssueSettingPage { private DataTable boardsTable; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/fieldspec/FieldEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/fieldspec/FieldEditPanel.java index 1d60e73d0a..688f72c9d9 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/fieldspec/FieldEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/fieldspec/FieldEditPanel.java @@ -28,7 +28,6 @@ import io.onedev.server.web.component.issue.workflowreconcile.WorkflowChanged; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class FieldEditPanel extends Panel implements InputContext { private final int fieldIndex; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/fieldspec/IssueFieldListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/fieldspec/IssueFieldListPage.java index 1067f1aca1..4668fc4088 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/fieldspec/IssueFieldListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/fieldspec/IssueFieldListPage.java @@ -39,7 +39,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class IssueFieldListPage extends IssueSettingPage { public IssueFieldListPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/issuetemplate/IssueTemplateEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/issuetemplate/IssueTemplateEditPanel.java index d2eef4113f..4eb65385c3 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/issuetemplate/IssueTemplateEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/issuetemplate/IssueTemplateEditPanel.java @@ -17,7 +17,6 @@ import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class IssueTemplateEditPanel extends Panel { private final int templateIndex; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/issuetemplate/IssueTemplateListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/issuetemplate/IssueTemplateListPage.java index 55cfd42e83..61cbaf1530 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/issuetemplate/IssueTemplateListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/issuetemplate/IssueTemplateListPage.java @@ -36,7 +36,6 @@ import org.unbescape.html.HtmlEscape; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class IssueTemplateListPage extends IssueSettingPage { public IssueTemplateListPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/linkspec/LinkSpecEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/linkspec/LinkSpecEditPanel.java index 7b97089337..fa01fd280f 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/linkspec/LinkSpecEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/linkspec/LinkSpecEditPanel.java @@ -20,7 +20,6 @@ import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class LinkSpecEditPanel extends GenericPanel { private BeanEditor editor; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/linkspec/LinkSpecListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/linkspec/LinkSpecListPage.java index d91eb471eb..ea2025c917 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/linkspec/LinkSpecListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/linkspec/LinkSpecListPage.java @@ -32,7 +32,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class LinkSpecListPage extends IssueSettingPage { public LinkSpecListPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/statespec/IssueStateListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/statespec/IssueStateListPage.java index 65703992b3..b88e1b0c70 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/statespec/IssueStateListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/statespec/IssueStateListPage.java @@ -37,7 +37,6 @@ import org.unbescape.html.HtmlEscape; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class IssueStateListPage extends IssueSettingPage { public IssueStateListPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/statespec/StateEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/statespec/StateEditPanel.java index 8385d2e043..b709bef584 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/statespec/StateEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/statespec/StateEditPanel.java @@ -21,7 +21,6 @@ import io.onedev.server.web.component.issue.workflowreconcile.WorkflowChanged; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class StateEditPanel extends Panel { private final int stateIndex; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/transitionspec/StateTransitionListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/transitionspec/StateTransitionListPage.java index 85822038b7..e31c4f8713 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/transitionspec/StateTransitionListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/transitionspec/StateTransitionListPage.java @@ -34,7 +34,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class StateTransitionListPage extends IssueSettingPage { private DataTable transitionsTable; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/transitionspec/TransitionEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/transitionspec/TransitionEditPanel.java index 4ba20020ef..3c9082b702 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/transitionspec/TransitionEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/issuesetting/transitionspec/TransitionEditPanel.java @@ -1,15 +1,7 @@ package io.onedev.server.web.page.admin.issuesetting.transitionspec; -import io.onedev.server.OneDev; -import io.onedev.server.buildspecmodel.inputspec.InputContext; -import io.onedev.server.buildspecmodel.inputspec.InputSpec; -import io.onedev.server.entitymanager.SettingManager; -import io.onedev.server.model.support.administration.GlobalIssueSetting; -import io.onedev.server.model.support.issue.transitionspec.ManualSpec; -import io.onedev.server.model.support.issue.transitionspec.TransitionSpec; -import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; -import io.onedev.server.web.editable.BeanContext; -import io.onedev.server.web.editable.BeanEditor; +import java.util.List; + import org.apache.commons.lang3.SerializationUtils; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.attributes.AjaxRequestAttributes; @@ -19,9 +11,16 @@ import org.apache.wicket.markup.html.form.Form; import org.apache.wicket.markup.html.panel.Panel; import org.apache.wicket.request.cycle.RequestCycle; -import java.util.List; +import io.onedev.server.OneDev; +import io.onedev.server.buildspecmodel.inputspec.InputContext; +import io.onedev.server.buildspecmodel.inputspec.InputSpec; +import io.onedev.server.entitymanager.SettingManager; +import io.onedev.server.model.support.administration.GlobalIssueSetting; +import io.onedev.server.model.support.issue.transitionspec.TransitionSpec; +import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; +import io.onedev.server.web.editable.BeanContext; +import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class TransitionEditPanel extends Panel implements InputContext { private final int transitionIndex; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/labelmanagement/LabelManagementPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/labelmanagement/LabelManagementPage.java index 4c0055af65..995779c963 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/labelmanagement/LabelManagementPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/labelmanagement/LabelManagementPage.java @@ -12,7 +12,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.Comparator; -@SuppressWarnings("serial") public class LabelManagementPage extends AdministrationPage { public LabelManagementPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/mailservice/MailServicePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/mailservice/MailServicePage.java index 303c176a8d..6338490c01 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/mailservice/MailServicePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/mailservice/MailServicePage.java @@ -36,7 +36,6 @@ import java.util.concurrent.ExecutionException; import java.util.concurrent.Future; import java.util.concurrent.atomic.AtomicReference; -@SuppressWarnings("serial") public class MailServicePage extends AdministrationPage { public MailServicePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/performancesetting/PerformanceSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/performancesetting/PerformanceSettingPage.java index f01cacd0e3..4be4033997 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/performancesetting/PerformanceSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/performancesetting/PerformanceSettingPage.java @@ -11,7 +11,6 @@ import io.onedev.server.model.support.administration.PerformanceSetting; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.page.admin.AdministrationPage; -@SuppressWarnings("serial") public class PerformanceSettingPage extends AdministrationPage { public PerformanceSettingPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/pluginsettings/ContributedAdministrationSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/pluginsettings/ContributedAdministrationSettingPage.java index 034947d7d2..e1fe895124 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/pluginsettings/ContributedAdministrationSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/pluginsettings/ContributedAdministrationSettingPage.java @@ -23,7 +23,6 @@ import javax.validation.Validator; import java.io.Serializable; import java.lang.reflect.InvocationTargetException; -@SuppressWarnings("serial") public class ContributedAdministrationSettingPage extends AdministrationPage { public static final String PARAM_SETTING = "administrationSetting"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/NewRolePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/NewRolePage.java index 6e8fdb9702..c02bae6db9 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/NewRolePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/NewRolePage.java @@ -22,7 +22,6 @@ import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.editable.BeanEditor; import io.onedev.server.web.page.admin.AdministrationPage; -@SuppressWarnings("serial") public class NewRolePage extends AdministrationPage { private Role role = new Role(); diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/RoleDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/RoleDetailPage.java index b624d450fc..955c451fc8 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/RoleDetailPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/RoleDetailPage.java @@ -34,7 +34,6 @@ import io.onedev.server.web.editable.BeanEditor; import io.onedev.server.web.page.admin.AdministrationPage; import io.onedev.server.web.util.ConfirmClickModifier; -@SuppressWarnings("serial") public class RoleDetailPage extends AdministrationPage { public static final String PARAM_ROLE = "role"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/RoleListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/RoleListPage.java index c97d898447..b7953ee7e7 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/RoleListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/rolemanagement/RoleListPage.java @@ -42,7 +42,6 @@ import io.onedev.server.web.component.link.ActionablePageLink; import io.onedev.server.web.page.admin.AdministrationPage; import io.onedev.server.web.util.paginghistory.PagingHistorySupport; -@SuppressWarnings("serial") public class RoleListPage extends AdministrationPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/securitysetting/SecuritySettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/securitysetting/SecuritySettingPage.java index 39dedd31fd..b00eccb3bf 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/securitysetting/SecuritySettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/securitysetting/SecuritySettingPage.java @@ -11,7 +11,6 @@ import io.onedev.server.model.support.administration.SecuritySetting; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.page.admin.AdministrationPage; -@SuppressWarnings("serial") public class SecuritySettingPage extends AdministrationPage { public SecuritySettingPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/serverinformation/ServerInformationPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/serverinformation/ServerInformationPage.java index e1336fac28..dd7c653005 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/serverinformation/ServerInformationPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/serverinformation/ServerInformationPage.java @@ -18,7 +18,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.*; -@SuppressWarnings("serial") public class ServerInformationPage extends ServerDetailPage { private final IModel serverInformationModel = new LoadableDetachableModel<>() { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/serverlog/ServerLogPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/serverlog/ServerLogPage.java index 967127a26c..0180946911 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/serverlog/ServerLogPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/serverlog/ServerLogPage.java @@ -11,7 +11,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.List; -@SuppressWarnings("serial") public class ServerLogPage extends ServerDetailPage { private static final int MAX_DISPLAY_LINES = 5000; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/servicedesk/ServiceDeskSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/servicedesk/ServiceDeskSettingPage.java index 7f17edf93d..bca2d10e8f 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/servicedesk/ServiceDeskSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/servicedesk/ServiceDeskSettingPage.java @@ -13,7 +13,6 @@ import org.apache.wicket.markup.html.form.Form; import org.apache.wicket.markup.html.link.BookmarkablePageLink; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class ServiceDeskSettingPage extends AdministrationPage { public ServiceDeskSettingPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/sshserverkey/SshServerKeyPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/sshserverkey/SshServerKeyPage.java index 97ec0438a9..5c3cba5906 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/sshserverkey/SshServerKeyPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/sshserverkey/SshServerKeyPage.java @@ -1,18 +1,11 @@ package io.onedev.server.web.page.admin.sshserverkey; -import io.onedev.server.ssh.SshManager; -import io.onedev.server.web.util.ConfirmClickModifier; import org.apache.wicket.Component; -import org.apache.wicket.ajax.AjaxRequestTarget; -import org.apache.wicket.ajax.markup.html.AjaxLink; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.form.Button; import org.apache.wicket.markup.html.form.Form; -import org.apache.wicket.markup.html.form.TextArea; import org.apache.wicket.markup.html.link.Link; import org.apache.wicket.request.mapper.parameter.PageParameters; -import org.apache.wicket.util.visit.IVisit; -import org.apache.wicket.util.visit.IVisitor; import io.onedev.server.OneDev; import io.onedev.server.entitymanager.SettingManager; @@ -20,8 +13,8 @@ import io.onedev.server.model.support.administration.SshSetting; import io.onedev.server.ssh.SshKeyUtils; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.page.admin.AdministrationPage; +import io.onedev.server.web.util.ConfirmClickModifier; -@SuppressWarnings("serial") public class SshServerKeyPage extends AdministrationPage { public SshServerKeyPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoConnectorEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoConnectorEditPanel.java index e68a137250..5d5c6c645d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoConnectorEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoConnectorEditPanel.java @@ -21,7 +21,6 @@ import org.apache.wicket.request.cycle.RequestCycle; import javax.annotation.Nullable; import java.util.List; -@SuppressWarnings("serial") abstract class SsoConnectorEditPanel extends Panel { private final int connectorIndex; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoConnectorListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoConnectorListPage.java index 1842f555f8..5133de8918 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoConnectorListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoConnectorListPage.java @@ -1,5 +1,31 @@ package io.onedev.server.web.page.admin.ssosetting; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; + +import org.apache.wicket.Component; +import org.apache.wicket.ajax.AjaxRequestTarget; +import org.apache.wicket.ajax.attributes.AjaxRequestAttributes; +import org.apache.wicket.ajax.markup.html.AjaxLink; +import org.apache.wicket.behavior.AttributeAppender; +import org.apache.wicket.extensions.markup.html.repeater.data.grid.ICellPopulator; +import org.apache.wicket.extensions.markup.html.repeater.data.table.AbstractColumn; +import org.apache.wicket.extensions.markup.html.repeater.data.table.DataTable; +import org.apache.wicket.extensions.markup.html.repeater.data.table.HeadersToolbar; +import org.apache.wicket.extensions.markup.html.repeater.data.table.IColumn; +import org.apache.wicket.extensions.markup.html.repeater.data.table.NoRecordsToolbar; +import org.apache.wicket.markup.ComponentTag; +import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.markup.html.list.LoopItem; +import org.apache.wicket.markup.html.panel.Fragment; +import org.apache.wicket.markup.repeater.Item; +import org.apache.wicket.markup.repeater.data.IDataProvider; +import org.apache.wicket.markup.repeater.data.ListDataProvider; +import org.apache.wicket.model.IModel; +import org.apache.wicket.model.Model; +import org.apache.wicket.request.mapper.parameter.PageParameters; + import io.onedev.server.OneDev; import io.onedev.server.entitymanager.SettingManager; import io.onedev.server.model.support.administration.sso.SsoConnector; @@ -13,29 +39,7 @@ import io.onedev.server.web.component.modal.ModalLink; import io.onedev.server.web.component.modal.ModalPanel; import io.onedev.server.web.component.svg.SpriteImage; import io.onedev.server.web.page.admin.AdministrationPage; -import org.apache.wicket.Component; -import org.apache.wicket.ajax.AjaxRequestTarget; -import org.apache.wicket.ajax.attributes.AjaxRequestAttributes; -import org.apache.wicket.ajax.markup.html.AjaxLink; -import org.apache.wicket.behavior.AttributeAppender; -import org.apache.wicket.extensions.markup.html.repeater.data.grid.ICellPopulator; -import org.apache.wicket.extensions.markup.html.repeater.data.table.*; -import org.apache.wicket.markup.ComponentTag; -import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.markup.html.list.LoopItem; -import org.apache.wicket.markup.html.panel.Fragment; -import org.apache.wicket.markup.repeater.Item; -import org.apache.wicket.markup.repeater.data.IDataProvider; -import org.apache.wicket.markup.repeater.data.ListDataProvider; -import org.apache.wicket.model.IModel; -import org.apache.wicket.model.Model; -import org.apache.wicket.request.mapper.parameter.PageParameters; -import java.util.ArrayList; -import java.util.Collections; -import java.util.List; - -@SuppressWarnings("serial") public class SsoConnectorListPage extends AdministrationPage { private final List connectors; @@ -166,7 +170,7 @@ public class SsoConnectorListPage extends AdministrationPage { @Override public void onClick(AjaxRequestTarget target) { - SsoConnector connector = connectors.remove(connectorIndex); + connectors.remove(connectorIndex); OneDev.getInstance(TransactionManager.class).run(new Runnable() { @Override diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoProcessPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoProcessPage.java index 2251e6ff3c..dbe76e8d81 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoProcessPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/ssosetting/SsoProcessPage.java @@ -23,7 +23,6 @@ import io.onedev.server.web.page.HomePage; import io.onedev.server.web.page.base.BasePage; import io.onedev.server.web.page.simple.security.LoginPage; -@SuppressWarnings("serial") public class SsoProcessPage extends BasePage { public static final String MOUNT_PATH = "~sso"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/systemsetting/SystemSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/systemsetting/SystemSettingPage.java index 501cae526b..1693e6b1a4 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/systemsetting/SystemSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/systemsetting/SystemSettingPage.java @@ -19,7 +19,6 @@ import io.onedev.server.model.support.administration.SystemSetting; import io.onedev.server.web.editable.BeanContext; import io.onedev.server.web.page.admin.AdministrationPage; -@SuppressWarnings("serial") public class SystemSettingPage extends AdministrationPage { public SystemSettingPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/InvitationListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/InvitationListPage.java index 1f7a605d3f..d8b514b0d7 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/InvitationListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/InvitationListPage.java @@ -39,7 +39,6 @@ import java.util.ArrayList; import java.util.Iterator; import java.util.List; -@SuppressWarnings("serial") public class InvitationListPage extends AdministrationPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/NewInvitationPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/NewInvitationPage.java index 40ae241674..6b3792caaf 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/NewInvitationPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/NewInvitationPage.java @@ -20,7 +20,6 @@ import org.apache.wicket.markup.html.link.BookmarkablePageLink; import org.apache.wicket.markup.html.panel.Fragment; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class NewInvitationPage extends AdministrationPage { public NewInvitationPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/NewUserPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/NewUserPage.java index 41e2a0346c..1b2b466ca5 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/NewUserPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/NewUserPage.java @@ -29,7 +29,6 @@ import io.onedev.server.web.page.admin.usermanagement.profile.UserProfilePage; import static io.onedev.server.model.User.PROP_DISABLE_WATCH_NOTIFICATIONS; import static io.onedev.server.model.User.PROP_NOTIFY_OWN_EVENTS; -@SuppressWarnings("serial") public class NewUserPage extends AdministrationPage { private NewUserBean bean = new NewUserBean(); diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/UserListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/UserListPage.java index 04b56900f2..9347fa760f 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/UserListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/UserListPage.java @@ -56,7 +56,6 @@ import java.io.Serializable; import java.util.*; import java.util.stream.Collectors; -@SuppressWarnings("serial") public class UserListPage extends AdministrationPage { private static final String PARAM_PAGE = "page"; @@ -279,7 +278,7 @@ public class UserListPage extends AdministrationPage { public void onClick(AjaxRequestTarget target) { dropdown.close(); - for (Iterator it = (Iterator) dataProvider.iterator(0, usersTable.getItemCount()); it.hasNext();) { + for (@SuppressWarnings("unchecked") var it = (Iterator) dataProvider.iterator(0, usersTable.getItemCount()); it.hasNext();) { var user = it.next(); if (user.isRoot()) { Session.get().error("Can not delete root account"); @@ -295,7 +294,7 @@ public class UserListPage extends AdministrationPage { @Override protected void onConfirm(AjaxRequestTarget target) { Collection users = new ArrayList<>(); - for (Iterator it = (Iterator) dataProvider.iterator(0, usersTable.getItemCount()); it.hasNext();) + for (@SuppressWarnings("unchecked") var it = (Iterator) dataProvider.iterator(0, usersTable.getItemCount()); it.hasNext();) users.add(it.next()); getUserManager().delete(users); target.add(usersTable); diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/UserPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/UserPage.java index b8a2e7258d..1efac15eff 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/UserPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/UserPage.java @@ -1,6 +1,23 @@ package io.onedev.server.web.page.admin.usermanagement; +import java.util.ArrayList; +import java.util.List; + +import org.apache.commons.lang3.StringUtils; +import org.apache.wicket.Component; +import org.apache.wicket.RestartResponseException; +import org.apache.wicket.markup.head.CssHeaderItem; +import org.apache.wicket.markup.head.IHeaderResponse; +import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.markup.html.link.BookmarkablePageLink; +import org.apache.wicket.markup.html.panel.Fragment; +import org.apache.wicket.model.IModel; +import org.apache.wicket.model.LoadableDetachableModel; +import org.apache.wicket.model.Model; +import org.apache.wicket.request.mapper.parameter.PageParameters; + import com.google.common.base.Preconditions; + import io.onedev.server.OneDev; import io.onedev.server.ServerConfig; import io.onedev.server.entitymanager.UserManager; @@ -20,24 +37,7 @@ import io.onedev.server.web.page.admin.usermanagement.profile.UserProfilePage; import io.onedev.server.web.page.admin.usermanagement.sshkeys.UserSshKeysPage; import io.onedev.server.web.page.admin.usermanagement.twofactorauthentication.UserTwoFactorAuthenticationPage; import io.onedev.server.web.util.UserAware; -import org.apache.commons.lang3.StringUtils; -import org.apache.wicket.Component; -import org.apache.wicket.RestartResponseException; -import org.apache.wicket.markup.head.CssHeaderItem; -import org.apache.wicket.markup.head.IHeaderResponse; -import org.apache.wicket.markup.html.WebMarkupContainer; -import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.markup.html.link.BookmarkablePageLink; -import org.apache.wicket.markup.html.panel.Fragment; -import org.apache.wicket.model.IModel; -import org.apache.wicket.model.LoadableDetachableModel; -import org.apache.wicket.model.Model; -import org.apache.wicket.request.mapper.parameter.PageParameters; -import java.util.ArrayList; -import java.util.List; - -@SuppressWarnings("serial") public abstract class UserPage extends AdministrationPage implements UserAware { public static final String PARAM_USER = "user"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/accesstoken/UserAccessTokensPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/accesstoken/UserAccessTokensPage.java index 0c6da2db2b..de1148d489 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/accesstoken/UserAccessTokensPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/accesstoken/UserAccessTokensPage.java @@ -6,7 +6,6 @@ import io.onedev.server.model.User; import io.onedev.server.web.component.user.accesstoken.AccessTokenListPanel; import io.onedev.server.web.page.admin.usermanagement.UserPage; -@SuppressWarnings("serial") public class UserAccessTokensPage extends UserPage { public UserAccessTokensPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/authorization/UserAuthorizationsPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/authorization/UserAuthorizationsPage.java index 65850c9c17..aba375de9a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/authorization/UserAuthorizationsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/authorization/UserAuthorizationsPage.java @@ -20,7 +20,6 @@ import io.onedev.server.web.page.admin.usermanagement.UserPage; import io.onedev.server.web.util.editbean.ProjectAuthorizationBean; import io.onedev.server.web.util.editbean.ProjectAuthorizationsBean; -@SuppressWarnings("serial") public class UserAuthorizationsPage extends UserPage { public UserAuthorizationsPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/avatar/UserAvatarPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/avatar/UserAvatarPage.java index d683a236cc..27add11cad 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/avatar/UserAvatarPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/avatar/UserAvatarPage.java @@ -5,7 +5,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.web.component.user.avataredit.AvatarEditPanel; import io.onedev.server.web.page.admin.usermanagement.UserPage; -@SuppressWarnings("serial") public class UserAvatarPage extends UserPage { public UserAvatarPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/emailaddresses/UserEmailAddressesPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/emailaddresses/UserEmailAddressesPage.java index 9547b79442..8b34a22c78 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/emailaddresses/UserEmailAddressesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/emailaddresses/UserEmailAddressesPage.java @@ -7,7 +7,6 @@ import io.onedev.server.model.User; import io.onedev.server.web.component.user.emailaddresses.EmailAddressesPanel; import io.onedev.server.web.page.admin.usermanagement.UserPage; -@SuppressWarnings("serial") public class UserEmailAddressesPage extends UserPage { public UserEmailAddressesPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/gpgkeys/UserGpgKeysPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/gpgkeys/UserGpgKeysPage.java index a15db2d093..1674c56d5f 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/gpgkeys/UserGpgKeysPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/gpgkeys/UserGpgKeysPage.java @@ -18,7 +18,6 @@ import io.onedev.server.web.component.user.gpgkey.GpgKeyListPanel; import io.onedev.server.web.component.user.gpgkey.InsertGpgKeyPanel; import io.onedev.server.web.page.admin.usermanagement.UserPage; -@SuppressWarnings("serial") public class UserGpgKeysPage extends UserPage { private GpgKeyListPanel keyList; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/membership/UserMembershipsPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/membership/UserMembershipsPage.java index c6af8c5708..d4cc6b0077 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/membership/UserMembershipsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/membership/UserMembershipsPage.java @@ -56,7 +56,6 @@ import io.onedev.server.web.component.select2.SelectToActChoice; import io.onedev.server.web.page.admin.groupmanagement.profile.GroupProfilePage; import io.onedev.server.web.page.admin.usermanagement.UserPage; -@SuppressWarnings("serial") public class UserMembershipsPage extends UserPage { private String query; diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/password/UserPasswordPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/password/UserPasswordPage.java index 8a0b25a68a..5a0827e0a5 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/password/UserPasswordPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/password/UserPasswordPage.java @@ -5,7 +5,6 @@ import io.onedev.server.web.page.admin.usermanagement.UserPage; import org.apache.wicket.markup.html.WebMarkupContainer; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class UserPasswordPage extends UserPage { public UserPasswordPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/preferences/UserPreferencesPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/preferences/UserPreferencesPage.java index 5a44a96f0f..11382f289a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/preferences/UserPreferencesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/preferences/UserPreferencesPage.java @@ -4,7 +4,6 @@ import io.onedev.server.web.component.user.preferences.PreferencesEditPanel; import io.onedev.server.web.page.admin.usermanagement.UserPage; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class UserPreferencesPage extends UserPage { public UserPreferencesPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/profile/UserProfilePage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/profile/UserProfilePage.java index 0f863c2a9c..5978260a11 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/profile/UserProfilePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/profile/UserProfilePage.java @@ -27,7 +27,6 @@ import java.util.Arrays; import java.util.HashMap; import java.util.Map; -@SuppressWarnings("serial") public class UserProfilePage extends UserPage { public UserProfilePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/sshkeys/UserSshKeysPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/sshkeys/UserSshKeysPage.java index b306b5eebf..c2c74272e3 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/sshkeys/UserSshKeysPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/sshkeys/UserSshKeysPage.java @@ -15,7 +15,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class UserSshKeysPage extends UserPage { public UserSshKeysPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/twofactorauthentication/UserTwoFactorAuthenticationPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/twofactorauthentication/UserTwoFactorAuthenticationPage.java index 0a31fd2e74..c401896e5e 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/twofactorauthentication/UserTwoFactorAuthenticationPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/admin/usermanagement/twofactorauthentication/UserTwoFactorAuthenticationPage.java @@ -6,7 +6,6 @@ import io.onedev.server.web.component.user.twofactorauthentication.TwoFactorAuth import io.onedev.server.web.page.admin.usermanagement.UserPage; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class UserTwoFactorAuthenticationPage extends UserPage { public UserTwoFactorAuthenticationPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/base/BasePage.java b/server-core/src/main/java/io/onedev/server/web/page/base/BasePage.java index 68fe20138d..481e233951 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/base/BasePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/base/BasePage.java @@ -1,39 +1,25 @@ package io.onedev.server.web.page.base; -import com.fasterxml.jackson.core.JsonProcessingException; -import com.fasterxml.jackson.databind.ObjectMapper; -import com.google.common.base.Joiner; -import com.google.common.base.Splitter; -import com.google.common.collect.Sets; -import io.onedev.commons.bootstrap.Bootstrap; -import io.onedev.commons.loader.AppLoader; -import io.onedev.server.OneDev; -import io.onedev.server.commandhandler.Upgrade; -import io.onedev.server.entitymanager.SettingManager; -import io.onedev.server.model.User; -import io.onedev.server.security.SecurityUtils; -import io.onedev.server.util.CryptoUtils; -import io.onedev.server.web.asset.icon.IconScope; -import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; -import io.onedev.server.web.behavior.ChangeObserver; -import io.onedev.server.web.behavior.ForceOrdinaryStyleBehavior; -import io.onedev.server.web.component.svg.SpriteImage; -import io.onedev.server.web.editable.BeanEditor; -import io.onedev.server.web.page.admin.ssosetting.SsoProcessPage; -import io.onedev.server.web.page.help.IncompatibilitiesPage; -import io.onedev.server.web.page.simple.SimplePage; -import io.onedev.server.web.page.simple.security.LoginPage; -import io.onedev.server.web.page.simple.serverinit.ServerInitPage; -import io.onedev.server.web.util.WicketUtils; -import io.onedev.server.web.websocket.WebSocketManager; -import io.onedev.server.web.websocket.WebSocketMessages; +import static io.onedev.server.web.behavior.ChangeObserver.filterObservables; +import static io.onedev.server.web.page.admin.ssosetting.SsoProcessPage.MOUNT_PATH; +import static io.onedev.server.web.page.admin.ssosetting.SsoProcessPage.STAGE_INITIATE; +import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; + +import java.io.File; +import java.io.Serializable; +import java.util.Collection; +import java.util.HashSet; +import java.util.List; + +import javax.annotation.Nullable; +import javax.servlet.http.Cookie; + import org.apache.commons.codec.binary.Base64; import org.apache.commons.lang3.SerializationUtils; import org.apache.shiro.authz.UnauthorizedException; import org.apache.wicket.Component; import org.apache.wicket.MetaDataKey; import org.apache.wicket.RestartResponseAtInterceptPageException; -import org.apache.wicket.Session; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.AjaxSelfUpdatingTimerBehavior; import org.apache.wicket.ajax.attributes.AjaxRequestAttributes; @@ -65,21 +51,35 @@ import org.apache.wicket.util.visit.IVisitor; import org.eclipse.jetty.servlet.ServletContextHandler; import org.unbescape.javascript.JavaScriptEscape; -import javax.annotation.Nullable; -import javax.servlet.http.Cookie; -import java.io.File; -import java.io.Serializable; -import java.util.Collection; -import java.util.HashSet; -import java.util.List; -import java.util.Set; +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.google.common.base.Joiner; +import com.google.common.base.Splitter; +import com.google.common.collect.Sets; -import static io.onedev.server.web.behavior.ChangeObserver.filterObservables; -import static io.onedev.server.web.page.admin.ssosetting.SsoProcessPage.MOUNT_PATH; -import static io.onedev.server.web.page.admin.ssosetting.SsoProcessPage.STAGE_INITIATE; -import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; +import io.onedev.commons.bootstrap.Bootstrap; +import io.onedev.commons.loader.AppLoader; +import io.onedev.server.OneDev; +import io.onedev.server.commandhandler.Upgrade; +import io.onedev.server.entitymanager.SettingManager; +import io.onedev.server.model.User; +import io.onedev.server.security.SecurityUtils; +import io.onedev.server.util.CryptoUtils; +import io.onedev.server.web.asset.icon.IconScope; +import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; +import io.onedev.server.web.behavior.ChangeObserver; +import io.onedev.server.web.behavior.ForceOrdinaryStyleBehavior; +import io.onedev.server.web.component.svg.SpriteImage; +import io.onedev.server.web.editable.BeanEditor; +import io.onedev.server.web.page.admin.ssosetting.SsoProcessPage; +import io.onedev.server.web.page.help.IncompatibilitiesPage; +import io.onedev.server.web.page.simple.SimplePage; +import io.onedev.server.web.page.simple.security.LoginPage; +import io.onedev.server.web.page.simple.serverinit.ServerInitPage; +import io.onedev.server.web.util.WicketUtils; +import io.onedev.server.web.websocket.WebSocketManager; +import io.onedev.server.web.websocket.WebSocketMessages; -@SuppressWarnings("serial") public abstract class BasePage extends WebPage { private static final MetaDataKey> REMOVE_AUTOSAVE_KEYS = new MetaDataKey<>() { diff --git a/server-core/src/main/java/io/onedev/server/web/page/base/SessionFeedbackPanel.java b/server-core/src/main/java/io/onedev/server/web/page/base/SessionFeedbackPanel.java index 9e68112fe7..d00e53067a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/base/SessionFeedbackPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/base/SessionFeedbackPanel.java @@ -8,7 +8,6 @@ import org.apache.wicket.markup.head.OnDomReadyHeaderItem; import org.apache.wicket.markup.html.panel.FeedbackPanel; import org.apache.wicket.model.LoadableDetachableModel; -@SuppressWarnings("serial") public class SessionFeedbackPanel extends FeedbackPanel { public SessionFeedbackPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/builds/BuildListPage.java b/server-core/src/main/java/io/onedev/server/web/page/builds/BuildListPage.java index 7a27d0d870..d17fc9b734 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/builds/BuildListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/builds/BuildListPage.java @@ -36,7 +36,6 @@ import io.onedev.server.web.util.NamedBuildQueriesBean; import io.onedev.server.web.util.paginghistory.PagingHistorySupport; import io.onedev.server.web.util.QuerySaveSupport; -@SuppressWarnings("serial") public class BuildListPage extends LayoutPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/help/ApiHelpPage.java b/server-core/src/main/java/io/onedev/server/web/page/help/ApiHelpPage.java index 63bd3c1815..bced0a50fe 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/help/ApiHelpPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/help/ApiHelpPage.java @@ -18,7 +18,6 @@ import io.onedev.commons.utils.WordUtils; import io.onedev.server.rest.annotation.Api; import io.onedev.server.web.page.layout.LayoutPage; -@SuppressWarnings("serial") public abstract class ApiHelpPage extends LayoutPage { public ApiHelpPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/help/ExampleValuePanel.java b/server-core/src/main/java/io/onedev/server/web/page/help/ExampleValuePanel.java index ce90aff045..e65d89cbd2 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/help/ExampleValuePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/help/ExampleValuePanel.java @@ -50,7 +50,6 @@ import java.util.regex.Pattern; import static io.onedev.server.web.page.help.ApiHelpUtils.getJsonMembers; import static io.onedev.server.web.page.help.ValueInfo.Origin.*; -@SuppressWarnings("serial") public class ExampleValuePanel extends Panel { private static final Map, Class> resourceMap = new HashMap<>(); diff --git a/server-core/src/main/java/io/onedev/server/web/page/help/IncompatibilitiesPage.java b/server-core/src/main/java/io/onedev/server/web/page/help/IncompatibilitiesPage.java index f7d05d96a0..3a677afdb6 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/help/IncompatibilitiesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/help/IncompatibilitiesPage.java @@ -19,7 +19,6 @@ import io.onedev.server.commandhandler.Upgrade; import io.onedev.server.web.component.markdown.MarkdownViewer; import io.onedev.server.web.page.layout.LayoutPage; -@SuppressWarnings("serial") public class IncompatibilitiesPage extends LayoutPage { private final IModel incompatibilitiesSinceUpgradedVersionModel = new LoadableDetachableModel() { diff --git a/server-core/src/main/java/io/onedev/server/web/page/help/MethodDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/help/MethodDetailPage.java index f32abacfed..22ead6feaa 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/help/MethodDetailPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/help/MethodDetailPage.java @@ -45,7 +45,6 @@ import java.util.regex.Matcher; import static io.onedev.server.web.page.help.ValueInfo.Origin.CREATE_BODY; import static io.onedev.server.web.page.help.ValueInfo.Origin.UPDATE_BODY; -@SuppressWarnings("serial") public class MethodDetailPage extends ApiHelpPage { private static final String PARAM_RESOURCE = "resource"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/help/ResourceDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/help/ResourceDetailPage.java index 315e01ce4e..02eeba80ef 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/help/ResourceDetailPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/help/ResourceDetailPage.java @@ -22,7 +22,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import edu.emory.mathcs.backport.java.util.Collections; import io.onedev.server.web.component.link.ViewStateAwarePageLink; -@SuppressWarnings("serial") public class ResourceDetailPage extends ApiHelpPage { private static final String PARAM_RESOURCE = "resource"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/help/ResourceListPage.java b/server-core/src/main/java/io/onedev/server/web/page/help/ResourceListPage.java index 96ec3a9f27..2c030d7e50 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/help/ResourceListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/help/ResourceListPage.java @@ -19,7 +19,6 @@ import io.onedev.server.OneDev; import io.onedev.server.rest.annotation.Api; import io.onedev.server.web.component.link.ViewStateAwarePageLink; -@SuppressWarnings("serial") public class ResourceListPage extends ApiHelpPage { public ResourceListPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/help/ValueInfo.java b/server-core/src/main/java/io/onedev/server/web/page/help/ValueInfo.java index cd83ccbfde..d806340b5b 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/help/ValueInfo.java +++ b/server-core/src/main/java/io/onedev/server/web/page/help/ValueInfo.java @@ -1,11 +1,9 @@ package io.onedev.server.web.page.help; -import javax.annotation.Nullable; -import java.lang.reflect.AnnotatedElement; -import java.lang.reflect.Field; -import java.lang.reflect.Member; import java.lang.reflect.Type; +import javax.annotation.Nullable; + public class ValueInfo { public enum Origin {CREATE_BODY, UPDATE_BODY, READ_BODY, PATH_PLACEHOLDER, QUERY_PARAM}; diff --git a/server-core/src/main/java/io/onedev/server/web/page/issues/IssueListPage.java b/server-core/src/main/java/io/onedev/server/web/page/issues/IssueListPage.java index 6df4819276..d1ab1ae806 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/issues/IssueListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/issues/IssueListPage.java @@ -35,7 +35,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.ArrayList; -@SuppressWarnings("serial") public class IssueListPage extends LayoutPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.java b/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.java index 737b737a8a..8a8c6f49a9 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.java @@ -132,7 +132,6 @@ import java.util.*; import static io.onedev.server.model.Alert.PROP_DATE; import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; -@SuppressWarnings("serial") public abstract class LayoutPage extends BasePage { private AbstractDefaultAjaxBehavior commandPaletteBehavior; diff --git a/server-core/src/main/java/io/onedev/server/web/page/my/MyPage.java b/server-core/src/main/java/io/onedev/server/web/page/my/MyPage.java index 4d187191d6..74e5ea44c9 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/my/MyPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/my/MyPage.java @@ -9,7 +9,6 @@ import io.onedev.server.web.util.UserAware; import org.apache.wicket.RestartResponseAtInterceptPageException; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public abstract class MyPage extends LayoutPage implements UserAware { public MyPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/my/accesstoken/MyAccessTokensPage.java b/server-core/src/main/java/io/onedev/server/web/page/my/accesstoken/MyAccessTokensPage.java index 54b9bbf01c..c0267477c9 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/my/accesstoken/MyAccessTokensPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/my/accesstoken/MyAccessTokensPage.java @@ -8,7 +8,6 @@ import io.onedev.server.model.User; import io.onedev.server.web.component.user.accesstoken.AccessTokenListPanel; import io.onedev.server.web.page.my.MyPage; -@SuppressWarnings("serial") public class MyAccessTokensPage extends MyPage { public MyAccessTokensPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/my/avatar/MyAvatarPage.java b/server-core/src/main/java/io/onedev/server/web/page/my/avatar/MyAvatarPage.java index d8f1ffd280..53c8224f4d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/my/avatar/MyAvatarPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/my/avatar/MyAvatarPage.java @@ -9,7 +9,6 @@ import io.onedev.server.model.User; import io.onedev.server.web.component.user.avataredit.AvatarEditPanel; import io.onedev.server.web.page.my.MyPage; -@SuppressWarnings("serial") public class MyAvatarPage extends MyPage { public MyAvatarPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/my/emailaddresses/MyEmailAddressesPage.java b/server-core/src/main/java/io/onedev/server/web/page/my/emailaddresses/MyEmailAddressesPage.java index 1ee37d6093..ed874f9d36 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/my/emailaddresses/MyEmailAddressesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/my/emailaddresses/MyEmailAddressesPage.java @@ -9,7 +9,6 @@ import io.onedev.server.model.User; import io.onedev.server.web.component.user.emailaddresses.EmailAddressesPanel; import io.onedev.server.web.page.my.MyPage; -@SuppressWarnings("serial") public class MyEmailAddressesPage extends MyPage { public MyEmailAddressesPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/my/gpgkeys/MyGpgKeysPage.java b/server-core/src/main/java/io/onedev/server/web/page/my/gpgkeys/MyGpgKeysPage.java index b070ddca1a..afe870ad9d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/my/gpgkeys/MyGpgKeysPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/my/gpgkeys/MyGpgKeysPage.java @@ -18,7 +18,6 @@ import io.onedev.server.web.component.user.gpgkey.GpgKeyListPanel; import io.onedev.server.web.component.user.gpgkey.InsertGpgKeyPanel; import io.onedev.server.web.page.my.MyPage; -@SuppressWarnings("serial") public class MyGpgKeysPage extends MyPage { private GpgKeyListPanel keyList; diff --git a/server-core/src/main/java/io/onedev/server/web/page/my/password/MyPasswordPage.java b/server-core/src/main/java/io/onedev/server/web/page/my/password/MyPasswordPage.java index b407af1232..017f47a1d6 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/my/password/MyPasswordPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/my/password/MyPasswordPage.java @@ -9,7 +9,6 @@ import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.model.AbstractReadOnlyModel; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class MyPasswordPage extends MyPage { public MyPasswordPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/my/preferences/MyPreferencesPage.java b/server-core/src/main/java/io/onedev/server/web/page/my/preferences/MyPreferencesPage.java index 30540e8dd4..f104158fbe 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/my/preferences/MyPreferencesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/my/preferences/MyPreferencesPage.java @@ -8,7 +8,6 @@ import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.model.AbstractReadOnlyModel; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class MyPreferencesPage extends MyPage { public MyPreferencesPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/my/profile/MyProfilePage.java b/server-core/src/main/java/io/onedev/server/web/page/my/profile/MyProfilePage.java index caa054d7bd..44aa055107 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/my/profile/MyProfilePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/my/profile/MyProfilePage.java @@ -9,7 +9,6 @@ import org.apache.wicket.markup.html.panel.Fragment; import org.apache.wicket.model.AbstractReadOnlyModel; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class MyProfilePage extends MyPage { public MyProfilePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/my/sshkeys/MySshKeysPage.java b/server-core/src/main/java/io/onedev/server/web/page/my/sshkeys/MySshKeysPage.java index 5fc8c5e3f2..1fee48c94f 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/my/sshkeys/MySshKeysPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/my/sshkeys/MySshKeysPage.java @@ -16,7 +16,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class MySshKeysPage extends MyPage { private SshKeyListPanel keyList; diff --git a/server-core/src/main/java/io/onedev/server/web/page/my/twofactorauthentication/MyTwoFactorAuthenticationPage.java b/server-core/src/main/java/io/onedev/server/web/page/my/twofactorauthentication/MyTwoFactorAuthenticationPage.java index 1891ae9ccd..31aef28e4e 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/my/twofactorauthentication/MyTwoFactorAuthenticationPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/my/twofactorauthentication/MyTwoFactorAuthenticationPage.java @@ -8,7 +8,6 @@ import org.apache.wicket.Component; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class MyTwoFactorAuthenticationPage extends MyPage { public MyTwoFactorAuthenticationPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/packs/PackListPage.java b/server-core/src/main/java/io/onedev/server/web/page/packs/PackListPage.java index b032d11084..961d33a4b8 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/packs/PackListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/packs/PackListPage.java @@ -34,7 +34,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.ArrayList; -@SuppressWarnings("serial") public class PackListPage extends LayoutPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/NewProjectPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/NewProjectPage.java index 5b377b2f60..e154c24363 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/NewProjectPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/NewProjectPage.java @@ -30,7 +30,6 @@ import java.util.Collection; import static io.onedev.server.model.Project.*; -@SuppressWarnings("serial") public class NewProjectPage extends LayoutPage { private static final String PARAM_PARENT = "parent"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/NoProjectStoragePage.java b/server-core/src/main/java/io/onedev/server/web/page/project/NoProjectStoragePage.java index 94c9e5daa4..73a396fe00 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/NoProjectStoragePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/NoProjectStoragePage.java @@ -11,7 +11,6 @@ import io.onedev.server.model.Project; import io.onedev.server.web.page.project.builds.ProjectBuildsPage; import io.onedev.server.web.page.project.dashboard.ProjectDashboardPage; -@SuppressWarnings("serial") public class NoProjectStoragePage extends ProjectPage { public NoProjectStoragePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/ProjectListPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/ProjectListPage.java index 36d15004d3..266c6e277a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/ProjectListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/ProjectListPage.java @@ -34,7 +34,6 @@ import io.onedev.server.web.util.NamedProjectQueriesBean; import io.onedev.server.web.util.paginghistory.PagingHistorySupport; import io.onedev.server.web.util.QuerySaveSupport; -@SuppressWarnings("serial") public class ProjectListPage extends LayoutPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/ProjectPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/ProjectPage.java index 3bc82b42ca..a271b269f9 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/ProjectPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/ProjectPage.java @@ -98,7 +98,6 @@ import javax.persistence.EntityNotFoundException; import javax.servlet.http.HttpServletResponse; import java.util.*; -@SuppressWarnings("serial") public abstract class ProjectPage extends LayoutPage implements ProjectAware { protected final IModel projectModel; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/BlobUploadPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/BlobUploadPanel.java index 1c63adb193..64e1a85e37 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/BlobUploadPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/BlobUploadPanel.java @@ -21,7 +21,6 @@ import org.apache.wicket.model.PropertyModel; import org.apache.wicket.util.lang.Bytes; import org.eclipse.jgit.lib.ObjectId; -@SuppressWarnings("serial") public abstract class BlobUploadPanel extends Panel { private final BlobRenderContext context; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/GetCodePanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/GetCodePanel.java index 38c065835c..560a8d51d9 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/GetCodePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/GetCodePanel.java @@ -18,7 +18,6 @@ import org.apache.wicket.model.LoadableDetachableModel; import static java.net.URLEncoder.encode; import static java.nio.charset.StandardCharsets.UTF_8; -@SuppressWarnings("serial") public abstract class GetCodePanel extends Panel { private final DropdownLink dropdown; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/ProjectBlobPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/ProjectBlobPage.java index 84cdb075f2..bb6c643ac5 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/ProjectBlobPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/ProjectBlobPage.java @@ -112,7 +112,6 @@ import java.util.concurrent.atomic.AtomicBoolean; import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; -@SuppressWarnings("serial") public class ProjectBlobPage extends ProjectPage implements BlobRenderContext, EditParamsAware, JobAuthorizationContextAware { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/navigator/BlobNavigator.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/navigator/BlobNavigator.java index 662c10994c..bdcf88874d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/navigator/BlobNavigator.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/navigator/BlobNavigator.java @@ -53,7 +53,6 @@ import java.util.ArrayList; import java.util.Iterator; import java.util.List; -@SuppressWarnings("serial") public class BlobNavigator extends Panel { private final static String LAST_SEGMENT_ID = "lastSegment"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/BlobRenderContext.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/BlobRenderContext.java index 7d67532339..87d5e231c5 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/BlobRenderContext.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/BlobRenderContext.java @@ -1,7 +1,6 @@ package io.onedev.server.web.page.project.blob.render; import java.io.Serializable; -import java.util.Collection; import java.util.List; import javax.annotation.Nullable; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/commitoption/CommitMessageBean.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/commitoption/CommitMessageBean.java index daa01387e1..89a05b2ee7 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/commitoption/CommitMessageBean.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/commitoption/CommitMessageBean.java @@ -27,6 +27,7 @@ public class CommitMessageBean implements Serializable { this.commitMessage = commitMessage; } + @SuppressWarnings("unused") private static String getDefaultCommitMessage() { return ComponentContext.get().getComponent().findParent(CommitOptionPanel.class).getDefaultCommitMessage(); } diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/commitoption/CommitOptionPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/commitoption/CommitOptionPanel.java index b464474d67..19bd9c11fa 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/commitoption/CommitOptionPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/commitoption/CommitOptionPanel.java @@ -48,7 +48,6 @@ import org.eclipse.jgit.lib.ObjectId; import javax.annotation.Nullable; import java.util.*; -@SuppressWarnings("serial") public class CommitOptionPanel extends Panel { private final BlobRenderContext context; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/edit/BlobEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/edit/BlobEditPanel.java index 0dd10a9755..18903fc7b0 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/edit/BlobEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/edit/BlobEditPanel.java @@ -1,6 +1,8 @@ package io.onedev.server.web.page.project.blob.render.edit; -import io.onedev.server.web.component.svg.SpriteImage; +import java.nio.charset.StandardCharsets; +import java.util.Arrays; + import org.apache.wicket.ajax.AbstractDefaultAjaxBehavior; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.attributes.AjaxCallListener; @@ -23,6 +25,7 @@ import io.onedev.server.util.Provider; import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; import io.onedev.server.web.behavior.AbstractPostAjaxBehavior; import io.onedev.server.web.component.link.ViewStateAwareAjaxLink; +import io.onedev.server.web.component.svg.SpriteImage; import io.onedev.server.web.page.base.BasePage; import io.onedev.server.web.page.project.blob.navigator.BlobNameChanging; import io.onedev.server.web.page.project.blob.render.BlobRenderContext; @@ -30,11 +33,6 @@ import io.onedev.server.web.page.project.blob.render.BlobRenderContext.Mode; import io.onedev.server.web.page.project.blob.render.commitoption.CommitOptionPanel; import io.onedev.server.web.page.project.blob.render.edit.plain.PlainEditSupport; -import java.nio.charset.Charset; -import java.nio.charset.StandardCharsets; -import java.util.Arrays; - -@SuppressWarnings("serial") public abstract class BlobEditPanel extends Panel { public static enum Tab {EDIT, EDIT_PLAIN, SAVE}; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/edit/plain/PlainEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/edit/plain/PlainEditPanel.java index 5ce70ba687..3cb22c5303 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/edit/plain/PlainEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/edit/plain/PlainEditPanel.java @@ -11,7 +11,6 @@ import org.apache.wicket.model.Model; import io.onedev.commons.utils.StringUtils; -@SuppressWarnings("serial") public class PlainEditPanel extends FormComponentPanel { private final String fileName; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/folder/FolderViewPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/folder/FolderViewPanel.java index 81f0e53b8a..2d4f81986d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/folder/FolderViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/folder/FolderViewPanel.java @@ -52,7 +52,6 @@ import io.onedev.server.web.page.project.blob.render.BlobRenderContext; import io.onedev.server.web.page.project.blob.render.BlobRenderContext.Mode; import io.onedev.server.web.util.EditParamsAware; -@SuppressWarnings("serial") public class FolderViewPanel extends Panel { private static final String USER_CARD_ID = "userCard"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/nocommits/NoCommitsPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/nocommits/NoCommitsPanel.java index c9cab55648..f61f108482 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/nocommits/NoCommitsPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/nocommits/NoCommitsPanel.java @@ -32,7 +32,6 @@ import io.onedev.server.web.page.project.blob.BlobUploadPanel; import io.onedev.server.web.page.project.blob.render.BlobRenderContext; import io.onedev.server.web.page.project.blob.render.BlobRenderContext.Mode; -@SuppressWarnings("serial") public class NoCommitsPanel extends Panel { private final BlobRenderContext context; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameCssResourceReference.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameCssResourceReference.java index 22e3a89234..a7500f4a2f 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameCssResourceReference.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameCssResourceReference.java @@ -2,7 +2,6 @@ package io.onedev.server.web.page.project.blob.render.noname; import io.onedev.server.web.page.base.BaseDependentCssResourceReference; -@SuppressWarnings("serial") public class NoNameCssResourceReference extends BaseDependentCssResourceReference { public NoNameCssResourceReference() { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameEditPanel.java index 8ee1da5299..328a4b5424 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameEditPanel.java @@ -7,7 +7,6 @@ import org.apache.wicket.markup.html.form.FormComponentPanel; import io.onedev.server.web.page.project.blob.render.BlobRenderContext; import io.onedev.server.web.page.project.blob.render.edit.BlobEditPanel; -@SuppressWarnings("serial") public class NoNameEditPanel extends BlobEditPanel { public NoNameEditPanel(String id, BlobRenderContext context) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameFormComponent.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameFormComponent.java index 90fdbaab75..fd4ad1e8c7 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameFormComponent.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/noname/NoNameFormComponent.java @@ -2,7 +2,6 @@ package io.onedev.server.web.page.project.blob.render.noname; import org.apache.wicket.markup.html.form.FormComponentPanel; -@SuppressWarnings("serial") class NoNameFormComponent extends FormComponentPanel { public NoNameFormComponent(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobEditPanel.java index cdfa968166..7cbc2d45d1 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobEditPanel.java @@ -8,7 +8,6 @@ import io.onedev.server.web.page.project.blob.render.edit.BlobEditPanel; import io.onedev.server.web.page.project.blob.render.edit.plain.PlainEditPanel; import io.onedev.server.web.page.project.blob.render.edit.plain.PlainEditSupport; -@SuppressWarnings("serial") public class BuildSpecBlobEditPanel extends BlobEditPanel implements PlainEditSupport { public BuildSpecBlobEditPanel(String id, BlobRenderContext context) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobViewPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobViewPanel.java index 8fe820dfee..c4c1f97db1 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobViewPanel.java @@ -61,7 +61,6 @@ import java.util.Map; import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.*; -@SuppressWarnings("serial") public class BuildSpecBlobViewPanel extends BlobViewPanel { public BuildSpecBlobViewPanel(String id, BlobRenderContext context) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecEditPanel.java index e12e69bf1d..509454d959 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecEditPanel.java @@ -71,7 +71,6 @@ import java.util.List; import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getActiveElementIndex; import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getUrlSegment; -@SuppressWarnings("serial") public class BuildSpecEditPanel extends FormComponentPanel implements BuildSpecAware, EditCompleteAware { private final BlobRenderContext context; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/gitlink/GitLinkPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/gitlink/GitLinkPanel.java index c65d803c29..71aaa37652 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/gitlink/GitLinkPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/gitlink/GitLinkPanel.java @@ -20,7 +20,6 @@ import io.onedev.server.web.page.project.blob.ProjectBlobPage; import io.onedev.server.web.page.project.blob.render.BlobRenderContext; import io.onedev.server.web.page.project.blob.render.view.BlobViewPanel; -@SuppressWarnings("serial") public class GitLinkPanel extends BlobViewPanel { public GitLinkPanel(String id, BlobRenderContext context) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/image/ImageViewPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/image/ImageViewPanel.java index 70f24817e1..eaef41af16 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/image/ImageViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/image/ImageViewPanel.java @@ -9,7 +9,6 @@ import io.onedev.server.web.page.project.blob.render.view.BlobViewPanel; import io.onedev.server.web.resource.RawBlobResource; import io.onedev.server.web.resource.RawBlobResourceReference; -@SuppressWarnings("serial") public class ImageViewPanel extends BlobViewPanel { public ImageViewPanel(String id, BlobRenderContext context) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobEditPanel.java index b401365be9..aa6c4ce79d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobEditPanel.java @@ -7,7 +7,6 @@ import org.apache.wicket.markup.html.form.FormComponentPanel; import io.onedev.server.web.page.project.blob.render.BlobRenderContext; import io.onedev.server.web.page.project.blob.render.edit.BlobEditPanel; -@SuppressWarnings("serial") public class MarkdownBlobEditPanel extends BlobEditPanel { public MarkdownBlobEditPanel(String id, BlobRenderContext context) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobViewPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobViewPanel.java index 18f61c1b28..3a102a3ca3 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobViewPanel.java @@ -9,7 +9,6 @@ import io.onedev.server.web.component.markdown.MarkdownViewer; import io.onedev.server.web.page.project.blob.render.BlobRenderContext; import io.onedev.server.web.page.project.blob.render.view.BlobViewPanel; -@SuppressWarnings("serial") public class MarkdownBlobViewPanel extends BlobViewPanel { public MarkdownBlobViewPanel(String id, BlobRenderContext context) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownRenderer.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownRenderer.java index af41948a5c..161f31d3f4 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownRenderer.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownRenderer.java @@ -11,7 +11,6 @@ import io.onedev.server.web.page.project.blob.render.BlobRenderContext.Mode; import io.onedev.server.web.page.project.blob.render.source.SourceViewPanel; import io.onedev.server.web.page.project.blob.render.BlobRenderer; -@SuppressWarnings("serial") public class MarkdownRenderer implements BlobRenderer { private boolean isMarkdown(@Nullable String blobPath) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/symbollink/SymbolLinkPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/symbollink/SymbolLinkPanel.java index 3602e43769..abf5286ed4 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/symbollink/SymbolLinkPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/symbollink/SymbolLinkPanel.java @@ -19,7 +19,6 @@ import io.onedev.server.web.page.project.blob.ProjectBlobPage; import io.onedev.server.web.page.project.blob.render.BlobRenderContext; import io.onedev.server.web.page.project.blob.render.view.BlobViewPanel; -@SuppressWarnings("serial") public class SymbolLinkPanel extends BlobViewPanel { public SymbolLinkPanel(String id, BlobRenderContext context) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/video/VideoViewPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/video/VideoViewPanel.java index 602daf208d..4a21b2c549 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/video/VideoViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/video/VideoViewPanel.java @@ -11,7 +11,6 @@ import io.onedev.server.web.page.project.blob.render.view.BlobViewPanel; import io.onedev.server.web.resource.RawBlobResource; import io.onedev.server.web.resource.RawBlobResourceReference; -@SuppressWarnings("serial") public class VideoViewPanel extends BlobViewPanel { public VideoViewPanel(String id, BlobRenderContext context) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceEditPanel.java index 3959155e75..2298097325 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceEditPanel.java @@ -19,7 +19,6 @@ import io.onedev.server.web.page.project.blob.render.BlobRenderer; import io.onedev.server.web.page.project.blob.render.edit.BlobEditPanel; import io.onedev.server.web.page.project.blob.render.view.Positionable; -@SuppressWarnings("serial") public class SourceEditPanel extends BlobEditPanel implements Positionable { private SourceFormatPanel sourceFormat; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceFormComponent.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceFormComponent.java index 4584cdc60b..9a8a8e8832 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceFormComponent.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceFormComponent.java @@ -22,7 +22,6 @@ import io.onedev.server.web.page.project.blob.render.BlobRenderContext; import io.onedev.server.web.page.project.blob.render.BlobRenderContext.Mode; import io.onedev.server.web.page.project.blob.render.BlobRenderer; -@SuppressWarnings("serial") abstract class SourceFormComponent extends FormComponentPanel { private TextArea input; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceViewPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceViewPanel.java index 317bedd367..6e183f6e60 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceViewPanel.java @@ -113,7 +113,6 @@ import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; * @author robin * */ -@SuppressWarnings("serial") public class SourceViewPanel extends BlobViewPanel implements Positionable, SearchMenuContributor { private static final Logger logger = LoggerFactory.getLogger(SourceViewPanel.class); diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/view/BlobViewPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/view/BlobViewPanel.java index db63f8439b..36a0123b55 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/view/BlobViewPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/view/BlobViewPanel.java @@ -36,7 +36,6 @@ import io.onedev.server.web.resource.RawBlobResource; import io.onedev.server.web.resource.RawBlobResourceReference; import org.apache.wicket.request.resource.ContentDisposition; -@SuppressWarnings("serial") public abstract class BlobViewPanel extends Panel { protected final BlobRenderContext context; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/advanced/AdvancedSearchPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/advanced/AdvancedSearchPanel.java index 9fd60cb3d8..963b438f23 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/advanced/AdvancedSearchPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/advanced/AdvancedSearchPanel.java @@ -38,7 +38,6 @@ import java.util.HashMap; import java.util.List; import java.util.Map; -@SuppressWarnings("serial") public abstract class AdvancedSearchPanel extends Panel { private static final MetaDataKey> ACTIVE_TAB = diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/quick/QuickSearchPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/quick/QuickSearchPanel.java index ad1223e060..c9c1e65e5e 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/quick/QuickSearchPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/quick/QuickSearchPanel.java @@ -49,7 +49,6 @@ import java.util.List; import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; -@SuppressWarnings("serial") public abstract class QuickSearchPanel extends Panel { private static final int MAX_QUERY_ENTRIES = 15; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/result/SearchResultPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/result/SearchResultPanel.java index f1c2c99cfc..95d16b0e5b 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/result/SearchResultPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/search/result/SearchResultPanel.java @@ -43,7 +43,6 @@ import io.onedev.server.web.page.project.blob.ProjectBlobPage; import io.onedev.server.web.page.project.blob.render.BlobRenderContext; import io.onedev.server.web.page.project.blob.render.BlobRenderer; -@SuppressWarnings("serial") public abstract class SearchResultPanel extends Panel { private enum ExpandStatus {EXPAND_ALL, COLLAPSE_ALL}; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/branches/ProjectBranchesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/branches/ProjectBranchesPage.java index 9cdf65bc28..e8ede9b57b 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/branches/ProjectBranchesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/branches/ProjectBranchesPage.java @@ -86,7 +86,6 @@ import java.util.*; import static io.onedev.server.entityreference.ReferenceUtils.transformReferences; -@SuppressWarnings("serial") public class ProjectBranchesPage extends ProjectPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/ProjectBuildsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/ProjectBuildsPage.java index 9151d53ae6..6917e37832 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/ProjectBuildsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/ProjectBuildsPage.java @@ -37,7 +37,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.ArrayList; -@SuppressWarnings("serial") public class ProjectBuildsPage extends ProjectPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java index 48845b33ff..8e446543d2 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildDetailPage.java @@ -86,7 +86,6 @@ import java.util.Collection; import java.util.Comparator; import java.util.List; -@SuppressWarnings("serial") public abstract class BuildDetailPage extends ProjectPage implements InputContext, BuildAware, JobAuthorizationContextAware { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildTab.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildTab.java index 9d2cda2daf..598887cf53 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildTab.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/BuildTab.java @@ -9,7 +9,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.List; @ExtensionPoint -@SuppressWarnings("serial") public class BuildTab extends PageTab { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/InvalidBuildPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/InvalidBuildPage.java index 683837cf0e..af4178c829 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/InvalidBuildPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/InvalidBuildPage.java @@ -27,7 +27,6 @@ import io.onedev.server.web.page.project.builds.ProjectBuildsPage; import io.onedev.server.web.page.project.dashboard.ProjectDashboardPage; import io.onedev.server.web.util.ConfirmClickModifier; -@SuppressWarnings("serial") public class InvalidBuildPage extends ProjectPage { public static final String PARAM_BUILD = "build"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/artifacts/ArtifactUploadPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/artifacts/ArtifactUploadPanel.java index 05cd1dd4c7..a51e673228 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/artifacts/ArtifactUploadPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/artifacts/ArtifactUploadPanel.java @@ -1,19 +1,22 @@ package io.onedev.server.web.page.project.builds.detail.artifacts; -import io.onedev.commons.utils.FileUtils; -import io.onedev.commons.utils.LockUtils; -import io.onedev.k8shelper.KubernetesHelper; -import io.onedev.server.OneDev; -import io.onedev.server.StorageManager; -import io.onedev.server.cluster.ClusterManager; -import io.onedev.server.entitymanager.ProjectManager; -import io.onedev.server.entitymanager.SettingManager; -import io.onedev.server.model.Build; -import io.onedev.server.util.FilenameUtils; -import io.onedev.server.web.component.dropzonefield.DropzoneField; -import io.onedev.server.web.upload.FileUpload; -import io.onedev.server.web.upload.UploadManager; -import org.apache.commons.compress.utils.IOUtils; +import static io.onedev.server.util.IOUtils.BUFFER_SIZE; + +import java.io.BufferedOutputStream; +import java.io.File; +import java.io.FileOutputStream; +import java.io.InputStream; + +import javax.ws.rs.client.Client; +import javax.ws.rs.client.ClientBuilder; +import javax.ws.rs.client.Entity; +import javax.ws.rs.client.Invocation; +import javax.ws.rs.client.WebTarget; +import javax.ws.rs.core.HttpHeaders; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import javax.ws.rs.core.StreamingOutput; + import org.apache.commons.fileupload.FileItem; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.markup.html.AjaxLink; @@ -27,16 +30,21 @@ import org.apache.wicket.model.PropertyModel; import org.apache.wicket.util.lang.Bytes; import org.glassfish.jersey.client.ClientProperties; -import javax.ws.rs.client.*; -import javax.ws.rs.core.HttpHeaders; -import javax.ws.rs.core.MediaType; -import javax.ws.rs.core.Response; -import javax.ws.rs.core.StreamingOutput; -import java.io.*; +import io.onedev.commons.utils.FileUtils; +import io.onedev.commons.utils.LockUtils; +import io.onedev.k8shelper.KubernetesHelper; +import io.onedev.server.OneDev; +import io.onedev.server.StorageManager; +import io.onedev.server.cluster.ClusterManager; +import io.onedev.server.entitymanager.ProjectManager; +import io.onedev.server.entitymanager.SettingManager; +import io.onedev.server.model.Build; +import io.onedev.server.util.FilenameUtils; +import io.onedev.server.util.IOUtils; +import io.onedev.server.web.component.dropzonefield.DropzoneField; +import io.onedev.server.web.upload.FileUpload; +import io.onedev.server.web.upload.UploadManager; -import static io.onedev.server.util.IOUtils.BUFFER_SIZE; - -@SuppressWarnings("serial") public abstract class ArtifactUploadPanel extends Panel { private String directory; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/artifacts/BuildArtifactsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/artifacts/BuildArtifactsPage.java index f24f0f31df..429f60ac23 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/artifacts/BuildArtifactsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/artifacts/BuildArtifactsPage.java @@ -50,7 +50,6 @@ import java.util.Date; import java.util.Iterator; import java.util.List; -@SuppressWarnings("serial") public class BuildArtifactsPage extends BuildDetailPage { public BuildArtifactsPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/changes/BuildChangesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/changes/BuildChangesPage.java index 0684fee780..fca01aa573 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/changes/BuildChangesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/changes/BuildChangesPage.java @@ -24,7 +24,6 @@ import io.onedev.server.security.SecurityUtils; import io.onedev.server.web.component.commit.list.CommitListPanel; import io.onedev.server.web.page.project.builds.detail.BuildDetailPage; -@SuppressWarnings("serial") public class BuildChangesPage extends BuildDetailPage { private static final String PARAM_QUERY = "query"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/dashboard/BuildDashboardPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/dashboard/BuildDashboardPage.java index 69418c5b14..ecafce9278 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/dashboard/BuildDashboardPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/dashboard/BuildDashboardPage.java @@ -17,7 +17,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.io.File; -@SuppressWarnings("serial") public class BuildDashboardPage extends BuildDetailPage { public BuildDashboardPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/issues/FixedIssuesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/issues/FixedIssuesPage.java index 9c6bbe6d40..651ea83891 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/issues/FixedIssuesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/issues/FixedIssuesPage.java @@ -18,7 +18,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.ArrayList; -@SuppressWarnings("serial") public class FixedIssuesPage extends BuildDetailPage { private static final String PARAM_QUERY = "query"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildLogPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildLogPage.java index 3f4a9d8d1c..3c49d38916 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildLogPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/log/BuildLogPage.java @@ -11,7 +11,6 @@ import io.onedev.server.web.page.project.builds.detail.BuildDetailPage; import io.onedev.server.web.resource.BuildLogResource; import io.onedev.server.web.resource.BuildLogResourceReference; -@SuppressWarnings("serial") public class BuildLogPage extends BuildDetailPage { public BuildLogPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/pack/BuildPacksPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/pack/BuildPacksPage.java index 7d37b59427..283b1e3f8b 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/pack/BuildPacksPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/pack/BuildPacksPage.java @@ -59,6 +59,7 @@ public class BuildPacksPage extends BuildDetailPage { return null; } + @SuppressWarnings("unchecked") @Override protected PackQuery getBaseQuery() { return new PackQuery(new AndCriteria<>( diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/pipeline/BuildPipelinePage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/pipeline/BuildPipelinePage.java index 5bd0e0eaed..1f99a00d8a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/pipeline/BuildPipelinePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/pipeline/BuildPipelinePage.java @@ -13,7 +13,6 @@ import org.eclipse.jgit.lib.ObjectId; import java.util.List; -@SuppressWarnings("serial") public class BuildPipelinePage extends BuildDetailPage { public BuildPipelinePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/report/BuildReportPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/report/BuildReportPage.java index 166145bca8..8149883eb6 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/report/BuildReportPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/report/BuildReportPage.java @@ -7,7 +7,6 @@ import io.onedev.server.model.Build; import io.onedev.server.security.SecurityUtils; import io.onedev.server.web.page.project.builds.detail.BuildDetailPage; -@SuppressWarnings("serial") public abstract class BuildReportPage extends BuildDetailPage { private static final String PARAM_REPORT = "report"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/report/BuildReportTabOptionPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/report/BuildReportTabOptionPanel.java index ec711fc557..73d5875058 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/report/BuildReportTabOptionPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/builds/detail/report/BuildReportTabOptionPanel.java @@ -10,7 +10,6 @@ import io.onedev.server.search.buildmetric.BuildMetricQueryParser; import io.onedev.server.web.component.link.ViewStateAwarePageLink; import io.onedev.server.web.page.project.stats.buildmetric.BuildMetricStatsPage; -@SuppressWarnings("serial") class BuildReportTabOptionPanel extends Panel { private final Class> statsPageClass; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/children/ProjectChildrenPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/children/ProjectChildrenPage.java index ec7ded4b3f..75644893c5 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/children/ProjectChildrenPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/children/ProjectChildrenPage.java @@ -19,7 +19,6 @@ import io.onedev.server.web.component.project.list.ProjectListPanel; import io.onedev.server.web.page.project.ProjectPage; import io.onedev.server.web.util.paginghistory.PagingHistorySupport; -@SuppressWarnings("serial") public class ProjectChildrenPage extends ProjectPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/codecomments/InvalidCodeCommentPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/codecomments/InvalidCodeCommentPage.java index ede60d00c6..b6a6f36d9b 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/codecomments/InvalidCodeCommentPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/codecomments/InvalidCodeCommentPage.java @@ -1,19 +1,7 @@ package io.onedev.server.web.page.project.codecomments; -import com.google.common.base.Joiner; -import com.google.common.base.Preconditions; -import io.onedev.commons.utils.StringUtils; -import io.onedev.server.OneDev; -import io.onedev.server.entitymanager.CodeCommentManager; -import io.onedev.server.model.CodeComment; -import io.onedev.server.model.Project; -import io.onedev.server.security.SecurityUtils; -import io.onedev.server.web.WebSession; -import io.onedev.server.web.component.link.ViewStateAwarePageLink; -import io.onedev.server.web.component.markdown.MarkdownViewer; -import io.onedev.server.web.page.project.ProjectPage; -import io.onedev.server.web.page.project.dashboard.ProjectDashboardPage; -import io.onedev.server.web.util.ConfirmClickModifier; +import static java.util.stream.Collectors.toList; + import org.apache.wicket.Component; import org.apache.wicket.Session; import org.apache.wicket.markup.head.CssHeaderItem; @@ -29,11 +17,21 @@ import org.apache.wicket.request.flow.RedirectToUrlException; import org.apache.wicket.request.mapper.parameter.PageParameters; import org.eclipse.jgit.lib.ObjectId; -import java.util.stream.Collectors; +import com.google.common.base.Preconditions; -import static java.util.stream.Collectors.*; +import io.onedev.commons.utils.StringUtils; +import io.onedev.server.OneDev; +import io.onedev.server.entitymanager.CodeCommentManager; +import io.onedev.server.model.CodeComment; +import io.onedev.server.model.Project; +import io.onedev.server.security.SecurityUtils; +import io.onedev.server.web.WebSession; +import io.onedev.server.web.component.link.ViewStateAwarePageLink; +import io.onedev.server.web.component.markdown.MarkdownViewer; +import io.onedev.server.web.page.project.ProjectPage; +import io.onedev.server.web.page.project.dashboard.ProjectDashboardPage; +import io.onedev.server.web.util.ConfirmClickModifier; -@SuppressWarnings("serial") public class InvalidCodeCommentPage extends ProjectPage { public static final String PARAM_COEDE_COMMENT = "code-comment"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/codecomments/ProjectCodeCommentsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/codecomments/ProjectCodeCommentsPage.java index 468f49e512..fb34b94f1f 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/codecomments/ProjectCodeCommentsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/codecomments/ProjectCodeCommentsPage.java @@ -34,7 +34,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.ArrayList; -@SuppressWarnings("serial") public class ProjectCodeCommentsPage extends ProjectPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/commits/BranchChoiceBean.java b/server-core/src/main/java/io/onedev/server/web/page/project/commits/BranchChoiceBean.java index cb72060c1a..1be6148752 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/commits/BranchChoiceBean.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/commits/BranchChoiceBean.java @@ -26,6 +26,7 @@ public class BranchChoiceBean implements Serializable { this.branch = branch; } + @SuppressWarnings("unused") private static List getBranchChoices() { CommitDetailPage page = (CommitDetailPage) WicketUtils.getPage(); return page.getOperateBranches(); diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/commits/CommitDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/commits/CommitDetailPage.java index c234ec7c4b..7ea2554a3c 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/commits/CommitDetailPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/commits/CommitDetailPage.java @@ -86,7 +86,6 @@ import java.util.*; import static io.onedev.server.entityreference.ReferenceUtils.transformReferences; import static java.util.stream.Collectors.toList; -@SuppressWarnings("serial") public class CommitDetailPage extends ProjectPage implements RevisionAnnotationSupport, JobAuthorizationContextAware { private static final Logger logger = LoggerFactory.getLogger(CommitDetailPage.class); diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/commits/ProjectCommitsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/commits/ProjectCommitsPage.java index 46f2030152..9910488820 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/commits/ProjectCommitsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/commits/ProjectCommitsPage.java @@ -33,7 +33,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.ArrayList; -@SuppressWarnings("serial") public class ProjectCommitsPage extends ProjectPage { private static final String PARAM_COMPARE = "compare"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/compare/RevisionComparePage.java b/server-core/src/main/java/io/onedev/server/web/page/project/compare/RevisionComparePage.java index 569487fb18..211642a47e 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/compare/RevisionComparePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/compare/RevisionComparePage.java @@ -61,7 +61,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.*; -@SuppressWarnings("serial") public class RevisionComparePage extends ProjectPage implements RevisionAnnotationSupport, EditParamsAware { public enum TabPanel { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/dashboard/ProjectDashboardPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/dashboard/ProjectDashboardPage.java index c3a3d2623d..a5008d006d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/dashboard/ProjectDashboardPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/dashboard/ProjectDashboardPage.java @@ -17,7 +17,6 @@ import io.onedev.server.web.page.project.blob.ProjectBlobPage; import io.onedev.server.web.page.project.children.ProjectChildrenPage; import io.onedev.server.web.page.project.issues.list.ProjectIssueListPage; -@SuppressWarnings("serial") public class ProjectDashboardPage extends ProjectPage { public ProjectDashboardPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/imports/ProjectImportPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/imports/ProjectImportPage.java index 8552a6e11e..a7ebf809b8 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/imports/ProjectImportPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/imports/ProjectImportPage.java @@ -20,7 +20,6 @@ import org.apache.wicket.markup.html.form.Form; import org.apache.wicket.markup.html.panel.Fragment; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class ProjectImportPage extends LayoutPage { private static final String PARAM_IMPORTER = "importer"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/ProjectIssuesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/ProjectIssuesPage.java index 42e8e837a9..bd8acf6b47 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/ProjectIssuesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/ProjectIssuesPage.java @@ -8,7 +8,6 @@ import io.onedev.server.web.page.project.ProjectPage; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public abstract class ProjectIssuesPage extends ProjectPage { public ProjectIssuesPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/AbstractColumnPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/AbstractColumnPanel.java index ecbe450e2e..8cba594721 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/AbstractColumnPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/AbstractColumnPanel.java @@ -1,5 +1,18 @@ package io.onedev.server.web.page.project.issues.boards; +import javax.annotation.Nullable; + +import org.apache.wicket.Component; +import org.apache.wicket.ajax.AjaxRequestTarget; +import org.apache.wicket.ajax.markup.html.AjaxLink; +import org.apache.wicket.behavior.AttributeAppender; +import org.apache.wicket.markup.html.WebMarkupContainer; +import org.apache.wicket.markup.html.panel.Panel; +import org.apache.wicket.markup.repeater.RepeatingView; +import org.apache.wicket.model.IModel; +import org.apache.wicket.model.LoadableDetachableModel; +import org.apache.wicket.util.visit.IVisitor; + import io.onedev.commons.utils.ExplicitException; import io.onedev.server.OneDev; import io.onedev.server.entitymanager.IssueChangeManager; @@ -16,21 +29,7 @@ import io.onedev.server.util.EditContext; import io.onedev.server.util.ProjectScope; import io.onedev.server.web.component.beaneditmodal.BeanEditModalPanel; import io.onedev.server.web.page.base.BasePage; -import org.apache.wicket.Component; -import org.apache.wicket.ajax.AjaxRequestTarget; -import org.apache.wicket.ajax.markup.html.AjaxLink; -import org.apache.wicket.behavior.AttributeAppender; -import org.apache.wicket.markup.html.WebMarkupContainer; -import org.apache.wicket.markup.html.panel.Panel; -import org.apache.wicket.markup.repeater.RepeatingView; -import org.apache.wicket.model.IModel; -import org.apache.wicket.model.LoadableDetachableModel; -import org.apache.wicket.util.visit.IVisitor; -import javax.annotation.Nullable; -import java.util.HashSet; - -@SuppressWarnings("serial") abstract class AbstractColumnPanel extends Panel implements EditContext { protected final IModel countModel = new LoadableDetachableModel<>() { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/AddToIterationBean.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/AddToIterationBean.java index c4b7e5c8c7..b3ad7ea765 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/AddToIterationBean.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/AddToIterationBean.java @@ -86,12 +86,14 @@ public class AddToIterationBean implements Serializable { this.removeFromCurrentIteration = removeFromCurrentIteration; } + @SuppressWarnings("unused") private static boolean isRemoveFromCurrentIterationVisible() { var editContext = EditContext.get(); return !(Boolean)editContext.getInputValue("backlog") && editContext.getInputValue("currentIteration") != null; } + @SuppressWarnings("unused") private static List getIterationChoices() { var projectId = (Long) EditContext.get().getInputValue("projectId"); var iterationPrefix = (String) EditContext.get().getInputValue("iterationPrefix"); diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BacklogColumnPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BacklogColumnPanel.java index 5e9f5d3763..f9b16b9b2f 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BacklogColumnPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BacklogColumnPanel.java @@ -44,7 +44,6 @@ import static io.onedev.server.search.entity.issue.IssueQueryLexer.IsNot; import static io.onedev.server.security.SecurityUtils.canManageIssues; import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; -@SuppressWarnings("serial") abstract class BacklogColumnPanel extends AbstractColumnPanel { private final IModel queryModel = new LoadableDetachableModel<>() { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.java index 38930ad874..7d819865af 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardCardPanel.java @@ -50,7 +50,6 @@ import java.util.List; import static io.onedev.server.security.SecurityUtils.canManageIssues; import static io.onedev.server.security.SecurityUtils.getAuthUser; -@SuppressWarnings("serial") public abstract class BoardCardPanel extends GenericPanel { private final Long issueId; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardColumnPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardColumnPanel.java index 3a046e11b0..16677c3e34 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardColumnPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/BoardColumnPanel.java @@ -65,7 +65,6 @@ import static io.onedev.server.search.entity.issue.IssueQueryLexer.*; import static io.onedev.server.security.SecurityUtils.canManageIssues; import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; -@SuppressWarnings("serial") abstract class BoardColumnPanel extends AbstractColumnPanel { private final IModel queryModel = new LoadableDetachableModel<>() { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardDetailPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardDetailPanel.java index 2cef085731..1712c19436 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardDetailPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardDetailPanel.java @@ -49,7 +49,6 @@ import javax.annotation.Nullable; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") abstract class CardDetailPanel extends GenericPanel implements InputContext { private static final String TAB_CONTENT_ID = "tabContent"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardListPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardListPanel.java index 9846ad4a73..695a6a3490 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardListPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/CardListPanel.java @@ -31,7 +31,6 @@ import static java.lang.Long.parseLong; import static java.lang.String.format; import static org.apache.commons.lang3.StringUtils.substringAfterLast; -@SuppressWarnings("serial") abstract class CardListPanel extends Panel { private RepeatingView cardsView; @@ -130,6 +129,7 @@ abstract class CardListPanel extends Panel { private BoardCardPanel newCard(Long issueId) { return new BoardCardPanel(String.valueOf(issueId), issueId) { + @SuppressWarnings("deprecation") @Override protected Cursor getCursor() { IssueQuery query = getQuery(); @@ -218,6 +218,7 @@ abstract class CardListPanel extends Panel { void onCardDropped(AjaxRequestTarget target, Long issueId, int cardIndex, boolean accepted) { findParent(RepeatingView.class).visitChildren(CardListPanel.class, (IVisitor) (cardListPanel, visit) -> { for (int i=0; i boards; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/StateTransitionPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/StateTransitionPanel.java index 5f0418bd17..9df66347bd 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/StateTransitionPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/boards/StateTransitionPanel.java @@ -1,16 +1,10 @@ package io.onedev.server.web.page.project.issues.boards; -import io.onedev.server.OneDev; -import io.onedev.server.buildspecmodel.inputspec.InputContext; -import io.onedev.server.buildspecmodel.inputspec.InputSpec; -import io.onedev.server.entitymanager.IssueChangeManager; -import io.onedev.server.entitymanager.SettingManager; -import io.onedev.server.model.Issue; -import io.onedev.server.model.support.issue.transitionspec.TransitionSpec; -import io.onedev.server.model.support.issue.field.FieldUtils; -import io.onedev.server.model.support.issue.transitionspec.ManualSpec; -import io.onedev.server.web.editable.BeanContext; -import io.onedev.server.web.editable.BeanEditor; +import java.io.Serializable; +import java.util.Collection; +import java.util.List; +import java.util.Map; + import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.markup.html.AjaxLink; import org.apache.wicket.ajax.markup.html.form.AjaxButton; @@ -18,12 +12,17 @@ import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.form.Form; import org.apache.wicket.markup.html.panel.Panel; -import java.io.Serializable; -import java.util.Collection; -import java.util.List; -import java.util.Map; +import io.onedev.server.OneDev; +import io.onedev.server.buildspecmodel.inputspec.InputContext; +import io.onedev.server.buildspecmodel.inputspec.InputSpec; +import io.onedev.server.entitymanager.IssueChangeManager; +import io.onedev.server.entitymanager.SettingManager; +import io.onedev.server.model.Issue; +import io.onedev.server.model.support.issue.field.FieldUtils; +import io.onedev.server.model.support.issue.transitionspec.ManualSpec; +import io.onedev.server.web.editable.BeanContext; +import io.onedev.server.web.editable.BeanEditor; -@SuppressWarnings("serial") abstract class StateTransitionPanel extends Panel implements InputContext { public StateTransitionPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/create/NewIssuePage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/create/NewIssuePage.java index 780d9e5a6e..a92f28e6f6 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/create/NewIssuePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/create/NewIssuePage.java @@ -1,5 +1,19 @@ package io.onedev.server.web.page.project.issues.create; +import java.util.List; + +import javax.annotation.Nullable; + +import org.apache.wicket.Component; +import org.apache.wicket.RestartResponseAtInterceptPageException; +import org.apache.wicket.ajax.AjaxRequestTarget; +import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.markup.html.form.Form; +import org.apache.wicket.markup.html.link.BookmarkablePageLink; +import org.apache.wicket.model.IModel; +import org.apache.wicket.model.LoadableDetachableModel; +import org.apache.wicket.request.mapper.parameter.PageParameters; + import io.onedev.commons.utils.ExplicitException; import io.onedev.server.OneDev; import io.onedev.server.buildspecmodel.inputspec.InputContext; @@ -21,21 +35,7 @@ import io.onedev.server.web.page.project.dashboard.ProjectDashboardPage; import io.onedev.server.web.page.project.issues.detail.IssueActivitiesPage; import io.onedev.server.web.page.project.issues.list.ProjectIssueListPage; import io.onedev.server.web.page.simple.security.LoginPage; -import org.apache.wicket.Component; -import org.apache.wicket.RestartResponseAtInterceptPageException; -import org.apache.wicket.ajax.AjaxRequestTarget; -import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.markup.html.form.Form; -import org.apache.wicket.markup.html.link.BookmarkablePageLink; -import org.apache.wicket.model.IModel; -import org.apache.wicket.model.LoadableDetachableModel; -import org.apache.wicket.request.mapper.parameter.PageParameters; -import javax.annotation.Nullable; -import java.util.HashSet; -import java.util.List; - -@SuppressWarnings("serial") public class NewIssuePage extends ProjectPage implements InputContext { private static final String PARAM_TEMPLATE = "template"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueActivitiesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueActivitiesPage.java index bcf1f8826f..20dc73bbb1 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueActivitiesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueActivitiesPage.java @@ -6,7 +6,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.model.Issue; import io.onedev.server.web.component.issue.activities.IssueActivitiesPanel; -@SuppressWarnings("serial") public class IssueActivitiesPage extends IssueDetailPage { private IssueActivitiesPanel activities; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueAuthorizationsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueAuthorizationsPage.java index 64e56b7c7f..152a2b26cc 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueAuthorizationsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueAuthorizationsPage.java @@ -5,7 +5,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.model.Issue; import io.onedev.server.web.component.issue.authorizations.IssueAuthorizationsPanel; -@SuppressWarnings("serial") public class IssueAuthorizationsPage extends IssueDetailPage { public IssueAuthorizationsPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueBuildsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueBuildsPage.java index 1d74691cfb..25740b786c 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueBuildsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueBuildsPage.java @@ -17,7 +17,6 @@ import io.onedev.server.search.entity.build.FixedIssueCriteria; import io.onedev.server.web.component.build.list.BuildListPanel; import io.onedev.server.web.util.paginghistory.PagingHistorySupport; -@SuppressWarnings("serial") public class IssueBuildsPage extends IssueDetailPage { private static final String PARAM_QUERY = "query"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueCommitsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueCommitsPage.java index 9002c0f42e..91f1b0ab18 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueCommitsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueCommitsPage.java @@ -4,7 +4,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.web.component.issue.commits.IssueCommitsPanel; -@SuppressWarnings("serial") public class IssueCommitsPage extends IssueDetailPage { public IssueCommitsPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java index 1857f245ff..b74da89290 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssueDetailPage.java @@ -61,7 +61,6 @@ import java.util.ArrayList; import java.util.Collection; import java.util.List; -@SuppressWarnings("serial") public abstract class IssueDetailPage extends ProjectIssuesPage implements InputContext { public static final String PARAM_ISSUE = "issue"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssuePullRequestsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssuePullRequestsPage.java index 093cb1661a..99952e95d8 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssuePullRequestsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/detail/IssuePullRequestsPage.java @@ -4,7 +4,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.web.component.issue.pullrequests.IssuePullRequestsPanel; -@SuppressWarnings("serial") public class IssuePullRequestsPage extends IssueDetailPage { public IssuePullRequestsPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/imports/IssueImportPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/imports/IssueImportPage.java index 48e266416a..d99a5db7d4 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/imports/IssueImportPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/imports/IssueImportPage.java @@ -30,7 +30,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.io.Serializable; -@SuppressWarnings("serial") public class IssueImportPage extends ProjectPage { private static final String PARAM_IMPORTER = "importer"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationBurndownPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationBurndownPage.java index a25b8820f6..26c190555a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationBurndownPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationBurndownPage.java @@ -18,7 +18,6 @@ import java.util.List; import static io.onedev.server.web.component.iteration.burndown.BurndownIndicators.getChoices; import static io.onedev.server.web.component.iteration.burndown.BurndownIndicators.getDefault; -@SuppressWarnings("serial") public class IterationBurndownPage extends IterationDetailPage { private static final String PARAM_INDICATOR = "indicator"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationDetailPage.java index 534f1000af..44ae11b51e 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationDetailPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationDetailPage.java @@ -35,7 +35,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public abstract class IterationDetailPage extends ProjectPage { public static final String PARAM_ITERATION = "iteration"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationIssuesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationIssuesPage.java index d5a8aa6946..97e6d1afa3 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationIssuesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationIssuesPage.java @@ -24,7 +24,6 @@ import java.util.Map; import static io.onedev.server.search.entity.issue.IssueQueryLexer.Is; -@SuppressWarnings("serial") public class IterationIssuesPage extends IterationDetailPage { private static final String PARAM_QUERY = "query"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationListPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationListPage.java index f5dc557fb3..3fbd48872b 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/IterationListPage.java @@ -17,7 +17,6 @@ import io.onedev.server.web.page.project.ProjectPage; import io.onedev.server.web.page.project.dashboard.ProjectDashboardPage; import io.onedev.server.web.util.paginghistory.PagingHistorySupport; -@SuppressWarnings("serial") public class IterationListPage extends ProjectPage { private static final String PARAM_STATE = "state"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/NewIterationPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/NewIterationPage.java index a16ee17783..e51eb83d30 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/NewIterationPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/iteration/NewIterationPage.java @@ -18,7 +18,6 @@ import org.apache.wicket.markup.html.form.Form; import org.apache.wicket.markup.html.link.BookmarkablePageLink; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class NewIterationPage extends ProjectPage { public NewIterationPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.java index d09839027a..6d32d70b2c 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/issues/list/ProjectIssueListPage.java @@ -71,7 +71,6 @@ import java.util.ArrayList; import java.util.Collection; import java.util.List; -@SuppressWarnings("serial") public class ProjectIssueListPage extends ProjectIssuesPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/packs/ProjectPacksPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/packs/ProjectPacksPage.java index 0c5e35eec1..7379034f33 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/packs/ProjectPacksPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/packs/ProjectPacksPage.java @@ -38,7 +38,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.ArrayList; -@SuppressWarnings("serial") public class ProjectPacksPage extends ProjectPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/packs/detail/PackDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/packs/detail/PackDetailPage.java index bdac46d143..331ed255b3 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/packs/detail/PackDetailPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/packs/detail/PackDetailPage.java @@ -36,7 +36,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.List; -@SuppressWarnings("serial") public class PackDetailPage extends ProjectPage { public static final String PARAM_PACK = "pack"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/InvalidPullRequestPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/InvalidPullRequestPage.java index 7732180c54..e34ab35e5d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/InvalidPullRequestPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/InvalidPullRequestPage.java @@ -1,10 +1,10 @@ package io.onedev.server.web.page.project.pullrequests; +import static java.util.stream.Collectors.toList; +import static org.unbescape.html.HtmlEscape.escapeHtml5; + import javax.persistence.EntityNotFoundException; -import io.onedev.commons.utils.StringUtils; -import io.onedev.server.web.component.link.ViewStateAwarePageLink; -import io.onedev.server.web.component.markdown.MarkdownViewer; import org.apache.wicket.Component; import org.apache.wicket.Session; import org.apache.wicket.behavior.AttributeAppender; @@ -18,27 +18,23 @@ import org.apache.wicket.model.LoadableDetachableModel; import org.apache.wicket.model.Model; import org.apache.wicket.request.flow.RedirectToUrlException; import org.apache.wicket.request.mapper.parameter.PageParameters; +import org.eclipse.jgit.lib.ObjectId; import com.google.common.base.Preconditions; +import io.onedev.commons.utils.StringUtils; import io.onedev.server.OneDev; import io.onedev.server.entitymanager.PullRequestManager; import io.onedev.server.model.Project; import io.onedev.server.model.PullRequest; import io.onedev.server.security.SecurityUtils; import io.onedev.server.web.WebSession; +import io.onedev.server.web.component.link.ViewStateAwarePageLink; +import io.onedev.server.web.component.markdown.MarkdownViewer; import io.onedev.server.web.page.project.ProjectPage; import io.onedev.server.web.page.project.dashboard.ProjectDashboardPage; import io.onedev.server.web.util.ConfirmClickModifier; -import org.eclipse.jgit.lib.ObjectId; -import org.unbescape.html.HtmlEscape; -import java.util.stream.Collectors; - -import static java.util.stream.Collectors.toList; -import static org.unbescape.html.HtmlEscape.escapeHtml5; - -@SuppressWarnings("serial") public class InvalidPullRequestPage extends ProjectPage { public static final String PARAM_REQUEST = "request"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/create/NewPullRequestPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/create/NewPullRequestPage.java index 64fe53478b..3a73c30939 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/create/NewPullRequestPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/create/NewPullRequestPage.java @@ -88,7 +88,6 @@ import java.util.*; import java.util.concurrent.atomic.AtomicReference; import java.util.stream.Collectors; -@SuppressWarnings("serial") public class NewPullRequestPage extends ProjectPage implements RevisionAnnotationSupport { private static final String TABS_ID = "tabs"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/ConflictResolveInstructionPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/ConflictResolveInstructionPanel.java index 2b77eed845..11b9938a40 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/ConflictResolveInstructionPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/ConflictResolveInstructionPanel.java @@ -13,7 +13,6 @@ import io.onedev.server.model.PullRequest; import io.onedev.server.model.support.pullrequest.MergeStrategy; import io.onedev.server.web.component.project.gitprotocol.GitProtocolPanel; -@SuppressWarnings("serial") abstract class ConflictResolveInstructionPanel extends Panel { public ConflictResolveInstructionPanel(String id) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/PullRequestDetailPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/PullRequestDetailPage.java index a5ef45ace1..2868d64845 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/PullRequestDetailPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/PullRequestDetailPage.java @@ -1,15 +1,92 @@ package io.onedev.server.web.page.project.pullrequests.detail; +import static io.onedev.server.entityreference.ReferenceUtils.transformReferences; +import static io.onedev.server.model.support.pullrequest.MergeStrategy.CREATE_MERGE_COMMIT; +import static io.onedev.server.model.support.pullrequest.MergeStrategy.CREATE_MERGE_COMMIT_IF_NECESSARY; +import static io.onedev.server.model.support.pullrequest.MergeStrategy.REBASE_SOURCE_BRANCH_COMMITS; +import static io.onedev.server.model.support.pullrequest.MergeStrategy.SQUASH_SOURCE_BRANCH_COMMITS; +import static org.unbescape.html.HtmlEscape.escapeHtml5; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Comparator; +import java.util.Date; +import java.util.HashMap; +import java.util.List; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.stream.Collectors; + +import javax.persistence.EntityNotFoundException; +import javax.validation.ValidationException; + +import org.apache.commons.lang3.StringUtils; +import org.apache.wicket.Component; +import org.apache.wicket.RestartResponseException; +import org.apache.wicket.Session; +import org.apache.wicket.ajax.AjaxRequestTarget; +import org.apache.wicket.ajax.attributes.AjaxRequestAttributes; +import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior; +import org.apache.wicket.ajax.form.OnChangeAjaxBehavior; +import org.apache.wicket.ajax.markup.html.AjaxLink; +import org.apache.wicket.ajax.markup.html.form.AjaxButton; +import org.apache.wicket.behavior.AttributeAppender; +import org.apache.wicket.core.request.handler.IPartialPageRequestHandler; +import org.apache.wicket.markup.ComponentTag; +import org.apache.wicket.markup.head.IHeaderResponse; +import org.apache.wicket.markup.head.JavaScriptHeaderItem; +import org.apache.wicket.markup.head.OnDomReadyHeaderItem; +import org.apache.wicket.markup.html.WebMarkupContainer; +import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.markup.html.form.CheckBox; +import org.apache.wicket.markup.html.form.DropDownChoice; +import org.apache.wicket.markup.html.form.Form; +import org.apache.wicket.markup.html.form.TextField; +import org.apache.wicket.markup.html.link.BookmarkablePageLink; +import org.apache.wicket.markup.html.link.Link; +import org.apache.wicket.markup.html.list.ListItem; +import org.apache.wicket.markup.html.list.ListView; +import org.apache.wicket.markup.html.panel.Fragment; +import org.apache.wicket.model.AbstractReadOnlyModel; +import org.apache.wicket.model.IModel; +import org.apache.wicket.model.LoadableDetachableModel; +import org.apache.wicket.model.Model; +import org.apache.wicket.model.PropertyModel; +import org.apache.wicket.request.IRequestHandler; +import org.apache.wicket.request.Url; +import org.apache.wicket.request.cycle.IRequestCycleListener; +import org.apache.wicket.request.cycle.RequestCycle; +import org.apache.wicket.request.flow.RedirectToUrlException; +import org.apache.wicket.request.mapper.parameter.PageParameters; +import org.eclipse.jgit.lib.ObjectId; +import org.jetbrains.annotations.Nullable; + import com.google.common.collect.Sets; + import io.onedev.server.OneDev; -import io.onedev.server.entitymanager.*; +import io.onedev.server.entitymanager.PullRequestAssignmentManager; +import io.onedev.server.entitymanager.PullRequestChangeManager; +import io.onedev.server.entitymanager.PullRequestLabelManager; +import io.onedev.server.entitymanager.PullRequestManager; +import io.onedev.server.entitymanager.PullRequestReviewManager; +import io.onedev.server.entitymanager.PullRequestWatchManager; +import io.onedev.server.entitymanager.SettingManager; import io.onedev.server.entityreference.EntityReference; import io.onedev.server.entityreference.LinkTransformer; import io.onedev.server.git.GitUtils; import io.onedev.server.git.service.GitService; import io.onedev.server.git.service.RefFacade; -import io.onedev.server.model.*; +import io.onedev.server.model.AbstractEntity; +import io.onedev.server.model.Build; +import io.onedev.server.model.Project; +import io.onedev.server.model.PullRequest; +import io.onedev.server.model.PullRequestAssignment; +import io.onedev.server.model.PullRequestLabel; +import io.onedev.server.model.PullRequestReview; import io.onedev.server.model.PullRequestReview.Status; +import io.onedev.server.model.PullRequestWatch; +import io.onedev.server.model.User; import io.onedev.server.model.support.EntityWatch; import io.onedev.server.model.support.code.BuildRequirement; import io.onedev.server.model.support.pullrequest.AutoMerge; @@ -74,55 +151,7 @@ import io.onedev.server.web.util.PullRequestAware; import io.onedev.server.web.util.editbean.CommitMessageBean; import io.onedev.server.web.util.editbean.LabelsBean; import io.onedev.server.xodus.VisitInfoManager; -import org.apache.commons.lang3.StringUtils; -import org.apache.wicket.Component; -import org.apache.wicket.RestartResponseException; -import org.apache.wicket.Session; -import org.apache.wicket.ajax.AjaxRequestTarget; -import org.apache.wicket.ajax.attributes.AjaxRequestAttributes; -import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior; -import org.apache.wicket.ajax.form.OnChangeAjaxBehavior; -import org.apache.wicket.ajax.markup.html.AjaxLink; -import org.apache.wicket.ajax.markup.html.form.AjaxButton; -import org.apache.wicket.behavior.AttributeAppender; -import org.apache.wicket.core.request.handler.IPartialPageRequestHandler; -import org.apache.wicket.markup.ComponentTag; -import org.apache.wicket.markup.head.IHeaderResponse; -import org.apache.wicket.markup.head.JavaScriptHeaderItem; -import org.apache.wicket.markup.head.OnDomReadyHeaderItem; -import org.apache.wicket.markup.html.WebMarkupContainer; -import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.markup.html.form.CheckBox; -import org.apache.wicket.markup.html.form.DropDownChoice; -import org.apache.wicket.markup.html.form.Form; -import org.apache.wicket.markup.html.form.TextField; -import org.apache.wicket.markup.html.link.BookmarkablePageLink; -import org.apache.wicket.markup.html.link.Link; -import org.apache.wicket.markup.html.list.ListItem; -import org.apache.wicket.markup.html.list.ListView; -import org.apache.wicket.markup.html.panel.Fragment; -import org.apache.wicket.model.*; -import org.apache.wicket.request.IRequestHandler; -import org.apache.wicket.request.Url; -import org.apache.wicket.request.cycle.IRequestCycleListener; -import org.apache.wicket.request.cycle.RequestCycle; -import org.apache.wicket.request.flow.RedirectToUrlException; -import org.apache.wicket.request.mapper.parameter.PageParameters; -import org.eclipse.jgit.lib.ObjectId; -import org.jetbrains.annotations.Nullable; -import javax.persistence.EntityNotFoundException; -import javax.validation.ValidationException; -import java.io.Serializable; -import java.util.*; -import java.util.concurrent.atomic.AtomicBoolean; -import java.util.stream.Collectors; - -import static io.onedev.server.entityreference.ReferenceUtils.transformReferences; -import static io.onedev.server.model.support.pullrequest.MergeStrategy.*; -import static org.unbescape.html.HtmlEscape.escapeHtml5; - -@SuppressWarnings("serial") public abstract class PullRequestDetailPage extends ProjectPage implements PullRequestAware { public static final String PARAM_REQUEST = "request"; @@ -1562,7 +1591,6 @@ public abstract class PullRequestDetailPage extends ProjectPage implements PullR }); - var user = SecurityUtils.getAuthUser(); statusBarContainer.add(new BookmarkablePageLink( "newPullRequest", NewPullRequestPage.class, diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/PullRequestActivitiesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/PullRequestActivitiesPage.java index c88136a56c..43dbb3e921 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/PullRequestActivitiesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/PullRequestActivitiesPage.java @@ -61,7 +61,6 @@ import javax.servlet.http.Cookie; import java.util.*; import java.util.stream.Collectors; -@SuppressWarnings("serial") public class PullRequestActivitiesPage extends PullRequestDetailPage { private static final String COOKIE_SHOW_COMMENTS = "onedev.server.pullRequest.showComments"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/SinceChangesLink.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/SinceChangesLink.java index ab26c02eb1..1a8d2ab658 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/SinceChangesLink.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/SinceChangesLink.java @@ -13,7 +13,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.Collection; import java.util.Date; -@SuppressWarnings("serial") public class SinceChangesLink extends ViewStateAwarePageLink { private final IModel requestModel; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestOpenedActivity.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestOpenedActivity.java index 3da0205661..3783669288 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestOpenedActivity.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestOpenedActivity.java @@ -12,7 +12,6 @@ import io.onedev.server.model.User; import io.onedev.server.web.page.project.pullrequests.detail.activities.PullRequestActivity; import io.onedev.server.web.util.DeleteCallback; -@SuppressWarnings("serial") public class PullRequestOpenedActivity implements PullRequestActivity { private final Long requestId; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestUpdatedActivity.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestUpdatedActivity.java index 0fa8223dae..0dcd4fcde1 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestUpdatedActivity.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestUpdatedActivity.java @@ -12,7 +12,6 @@ import io.onedev.server.persistence.dao.Dao; import io.onedev.server.web.page.project.pullrequests.detail.activities.PullRequestActivity; import io.onedev.server.web.util.DeleteCallback; -@SuppressWarnings("serial") public class PullRequestUpdatedActivity implements PullRequestActivity { private final Long updateId; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestUpdatedPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestUpdatedPanel.java index d365638255..d82d5385f5 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestUpdatedPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestUpdatedPanel.java @@ -1,7 +1,23 @@ package io.onedev.server.web.page.project.pullrequests.detail.activities.activity; +import java.util.Collection; +import java.util.List; + +import org.apache.wicket.behavior.AttributeAppender; +import org.apache.wicket.markup.html.basic.Label; +import org.apache.wicket.markup.html.link.Link; +import org.apache.wicket.markup.html.list.ListItem; +import org.apache.wicket.markup.html.list.ListView; +import org.apache.wicket.markup.html.panel.GenericPanel; +import org.apache.wicket.model.IModel; +import org.apache.wicket.model.LoadableDetachableModel; +import org.apache.wicket.model.Model; +import org.apache.wicket.request.mapper.parameter.PageParameters; +import org.eclipse.jgit.revwalk.RevCommit; +import org.eclipse.jgit.revwalk.RevObject; + import com.google.common.collect.Sets; -import io.onedev.server.git.BlobIdent; + import io.onedev.server.git.GitUtils; import io.onedev.server.model.Project; import io.onedev.server.model.PullRequest; @@ -15,26 +31,8 @@ import io.onedev.server.web.component.link.ViewStateAwarePageLink; import io.onedev.server.web.component.link.copytoclipboard.CopyToClipboardLink; import io.onedev.server.web.component.user.ident.Mode; import io.onedev.server.web.component.user.ident.PersonIdentPanel; -import io.onedev.server.web.page.project.blob.ProjectBlobPage; import io.onedev.server.web.page.project.commits.CommitDetailPage; -import org.apache.wicket.behavior.AttributeAppender; -import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.markup.html.link.Link; -import org.apache.wicket.markup.html.list.ListItem; -import org.apache.wicket.markup.html.list.ListView; -import org.apache.wicket.markup.html.panel.GenericPanel; -import org.apache.wicket.model.IModel; -import org.apache.wicket.model.LoadableDetachableModel; -import org.apache.wicket.model.Model; -import org.apache.wicket.request.mapper.parameter.PageParameters; -import org.eclipse.jgit.lib.FileMode; -import org.eclipse.jgit.revwalk.RevCommit; -import org.eclipse.jgit.revwalk.RevObject; -import java.util.Collection; -import java.util.List; - -@SuppressWarnings("serial") class PullRequestUpdatedPanel extends GenericPanel { public PullRequestUpdatedPanel(String id, IModel model) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/changes/PullRequestChangesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/changes/PullRequestChangesPage.java index d417e82d58..5aa1af4304 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/changes/PullRequestChangesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/changes/PullRequestChangesPage.java @@ -60,7 +60,6 @@ import java.util.*; import static org.apache.wicket.ajax.attributes.CallbackParameter.explicit; -@SuppressWarnings("serial") public class PullRequestChangesPage extends PullRequestDetailPage implements RevisionAnnotationSupport, EditParamsAware { public static final String PARAM_OLD_COMMIT = "old-commit"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/codecomments/PullRequestCodeCommentsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/codecomments/PullRequestCodeCommentsPage.java index 8d2d2d0636..74cd51fe7a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/codecomments/PullRequestCodeCommentsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/codecomments/PullRequestCodeCommentsPage.java @@ -23,7 +23,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.Collection; -@SuppressWarnings("serial") public class PullRequestCodeCommentsPage extends PullRequestDetailPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/operationdlg/MergePullRequestOptionPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/operationdlg/MergePullRequestOptionPanel.java index 5f12e9f5d0..d1ee3862c0 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/operationdlg/MergePullRequestOptionPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/operationdlg/MergePullRequestOptionPanel.java @@ -14,7 +14,6 @@ import io.onedev.server.model.support.pullrequest.MergeStrategy; import io.onedev.server.web.component.modal.ModalPanel; import io.onedev.server.web.editable.BeanContext; -@SuppressWarnings("serial") public abstract class MergePullRequestOptionPanel extends ObsoleteUpdateAwarePanel { private CommitMessageBean bean = new CommitMessageBean(); diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/operationdlg/ObsoleteUpdateAwarePanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/operationdlg/ObsoleteUpdateAwarePanel.java index 16eb73fa9b..d05f2f0f97 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/operationdlg/ObsoleteUpdateAwarePanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/operationdlg/ObsoleteUpdateAwarePanel.java @@ -22,7 +22,6 @@ import org.unbescape.html.HtmlEscape; import javax.annotation.Nullable; -@SuppressWarnings("serial") public abstract class ObsoleteUpdateAwarePanel extends Panel { private final ModalPanel modal; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/ProjectSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/ProjectSettingPage.java index 85019fd2b3..680414b3ac 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/ProjectSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/ProjectSettingPage.java @@ -11,7 +11,6 @@ import io.onedev.server.security.SecurityUtils; import io.onedev.server.web.page.project.ProjectPage; import io.onedev.server.web.page.project.dashboard.ProjectDashboardPage; -@SuppressWarnings("serial") public abstract class ProjectSettingPage extends ProjectPage { public ProjectSettingPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/BuildPreservationsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/BuildPreservationsPage.java index d1d884361b..cdb8f38bf3 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/BuildPreservationsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/BuildPreservationsPage.java @@ -13,7 +13,6 @@ import io.onedev.server.entitymanager.ProjectManager; import io.onedev.server.web.editable.PropertyContext; import io.onedev.server.web.editable.PropertyEditor; -@SuppressWarnings("serial") public class BuildPreservationsPage extends ProjectBuildSettingPage { public BuildPreservationsPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/DefaultFixedIssueFiltersPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/DefaultFixedIssueFiltersPage.java index 215b506073..5915774e22 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/DefaultFixedIssueFiltersPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/DefaultFixedIssueFiltersPage.java @@ -13,7 +13,6 @@ import io.onedev.server.entitymanager.ProjectManager; import io.onedev.server.web.editable.PropertyContext; import io.onedev.server.web.editable.PropertyEditor; -@SuppressWarnings("serial") public class DefaultFixedIssueFiltersPage extends ProjectBuildSettingPage { public DefaultFixedIssueFiltersPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesPage.java index 5d25b3c039..a804cd77b6 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesPage.java @@ -16,7 +16,6 @@ import java.util.List; import static java.util.stream.Collectors.toList; -@SuppressWarnings("serial") public class JobPropertiesPage extends ProjectBuildSettingPage { private boolean showArchived; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java index d39aa4a645..4b00b73f5d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java @@ -16,7 +16,6 @@ import org.apache.wicket.markup.html.panel.Panel; import java.util.List; -@SuppressWarnings("serial") public abstract class JobSecretEditPanel extends Panel { private final int index; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretsPage.java index 75a0ed5daa..a56822b4d4 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretsPage.java @@ -38,7 +38,6 @@ import java.util.List; import static java.util.stream.Collectors.toList; -@SuppressWarnings("serial") public class JobSecretsPage extends ProjectBuildSettingPage { private DataTable secretsTable; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/ProjectBuildSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/ProjectBuildSettingPage.java index 55e52a821f..389f2091ae 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/ProjectBuildSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/ProjectBuildSettingPage.java @@ -4,7 +4,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.web.page.project.setting.ProjectSettingPage; -@SuppressWarnings("serial") public abstract class ProjectBuildSettingPage extends ProjectSettingPage { public ProjectBuildSettingPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/analysis/CodeAnalysisSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/analysis/CodeAnalysisSettingPage.java index 6e94337f90..52ce790a12 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/analysis/CodeAnalysisSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/analysis/CodeAnalysisSettingPage.java @@ -18,7 +18,6 @@ import io.onedev.server.web.page.project.ProjectPage; import io.onedev.server.web.page.project.dashboard.ProjectDashboardPage; import io.onedev.server.web.page.project.setting.ProjectSettingPage; -@SuppressWarnings("serial") public class CodeAnalysisSettingPage extends ProjectSettingPage { public CodeAnalysisSettingPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionEditPanel.java index 6185e5658a..9552ec62ec 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionEditPanel.java @@ -10,7 +10,6 @@ import org.apache.wicket.markup.html.panel.Panel; import io.onedev.server.model.support.code.BranchProtection; import io.onedev.server.web.editable.BeanContext; -@SuppressWarnings("serial") abstract class BranchProtectionEditPanel extends Panel { private final BranchProtection protection; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionPanel.java index 1433468d62..f189d0ce5f 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionPanel.java @@ -1,9 +1,5 @@ package io.onedev.server.web.page.project.setting.code.branchprotection; -import io.onedev.server.model.support.code.BranchProtection; -import io.onedev.server.web.ajaxlistener.ConfirmClickListener; -import io.onedev.server.web.editable.BeanContext; -import org.apache.wicket.Component; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.attributes.AjaxRequestAttributes; import org.apache.wicket.ajax.markup.html.AjaxLink; @@ -13,7 +9,10 @@ import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.panel.Panel; import org.apache.wicket.model.Model; -@SuppressWarnings("serial") +import io.onedev.server.model.support.code.BranchProtection; +import io.onedev.server.web.ajaxlistener.ConfirmClickListener; +import io.onedev.server.web.editable.BeanContext; + abstract class BranchProtectionPanel extends Panel { private final BranchProtection protection; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionsPage.java index 1b4840c527..5809f2787e 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/branchprotection/BranchProtectionsPage.java @@ -18,7 +18,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.List; -@SuppressWarnings("serial") public class BranchProtectionsPage extends ProjectSettingPage { private WebMarkupContainer container; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/git/GitPackConfigPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/git/GitPackConfigPage.java index 1fb52340aa..9a736c4b48 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/git/GitPackConfigPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/git/GitPackConfigPage.java @@ -19,7 +19,6 @@ import org.apache.wicket.markup.html.form.Form; import org.apache.wicket.markup.html.link.BookmarkablePageLink; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class GitPackConfigPage extends ProjectSettingPage { public GitPackConfigPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/pullrequest/PullRequestSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/pullrequest/PullRequestSettingPage.java index 9a8f6b86e7..6df5125437 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/pullrequest/PullRequestSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/pullrequest/PullRequestSettingPage.java @@ -17,7 +17,6 @@ import org.apache.wicket.markup.html.form.Form; import org.apache.wicket.markup.html.link.BookmarkablePageLink; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class PullRequestSettingPage extends ProjectSettingPage { public PullRequestSettingPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionEditPanel.java index 7ebe1c5b0c..c8311630a2 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionEditPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionEditPanel.java @@ -10,7 +10,6 @@ import org.apache.wicket.markup.html.panel.Panel; import io.onedev.server.model.support.code.TagProtection; import io.onedev.server.web.editable.BeanContext; -@SuppressWarnings("serial") abstract class TagProtectionEditPanel extends Panel { private final TagProtection protection; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionPanel.java index 69b57cb63c..2a9c6718e8 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionPanel.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionPanel.java @@ -1,9 +1,5 @@ package io.onedev.server.web.page.project.setting.code.tagprotection; -import io.onedev.server.model.support.code.TagProtection; -import io.onedev.server.web.ajaxlistener.ConfirmClickListener; -import io.onedev.server.web.editable.BeanContext; -import org.apache.wicket.Component; import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.attributes.AjaxRequestAttributes; import org.apache.wicket.ajax.markup.html.AjaxLink; @@ -13,7 +9,10 @@ import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.panel.Panel; import org.apache.wicket.model.Model; -@SuppressWarnings("serial") +import io.onedev.server.model.support.code.TagProtection; +import io.onedev.server.web.ajaxlistener.ConfirmClickListener; +import io.onedev.server.web.editable.BeanContext; + abstract class TagProtectionPanel extends Panel { private final TagProtection protection; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionsPage.java index 1401f83fe0..d8062e3f19 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/code/tagprotection/TagProtectionsPage.java @@ -20,7 +20,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.List; -@SuppressWarnings("serial") public class TagProtectionsPage extends ProjectSettingPage { private WebMarkupContainer container; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/general/GeneralProjectSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/general/GeneralProjectSettingPage.java index 2a0253b9aa..bb3e674ad2 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/general/GeneralProjectSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/general/GeneralProjectSettingPage.java @@ -33,7 +33,6 @@ import java.util.Collection; import static io.onedev.server.model.Project.*; -@SuppressWarnings("serial") public class GeneralProjectSettingPage extends ProjectSettingPage { private BeanEditor editor; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/pluginsettings/ContributedProjectSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/pluginsettings/ContributedProjectSettingPage.java index 4ac7d7b376..e0cd391f66 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/pluginsettings/ContributedProjectSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/pluginsettings/ContributedProjectSettingPage.java @@ -32,7 +32,6 @@ import io.onedev.server.web.page.project.setting.ContributedProjectSetting; import io.onedev.server.web.page.project.setting.ProjectSettingContribution; import io.onedev.server.web.page.project.setting.ProjectSettingPage; -@SuppressWarnings("serial") public class ContributedProjectSettingPage extends ProjectSettingPage { public static final String PARAM_SETTING = "projectSetting"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/servicedesk/ServiceDeskSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/servicedesk/ServiceDeskSettingPage.java index a39ee749bb..c1b74220c1 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/servicedesk/ServiceDeskSettingPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/servicedesk/ServiceDeskSettingPage.java @@ -24,7 +24,6 @@ import java.io.Serializable; import static io.onedev.server.model.Project.PROP_SERVICE_DESK_EMAIL_ADDRESS; -@SuppressWarnings("serial") public class ServiceDeskSettingPage extends ProjectSettingPage { private BeanEditor editor; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/webhook/WebHooksPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/webhook/WebHooksPage.java index e3e74a9f9c..ae6bcce75d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/webhook/WebHooksPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/webhook/WebHooksPage.java @@ -14,7 +14,6 @@ import io.onedev.server.web.editable.PropertyContext; import io.onedev.server.web.editable.PropertyEditor; import io.onedev.server.web.page.project.setting.ProjectSettingPage; -@SuppressWarnings("serial") public class WebHooksPage extends ProjectSettingPage { public WebHooksPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/stats/buildmetric/BuildMetricStatsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/stats/buildmetric/BuildMetricStatsPage.java index 6f890843d8..4760014f3a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/stats/buildmetric/BuildMetricStatsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/stats/buildmetric/BuildMetricStatsPage.java @@ -49,7 +49,6 @@ import java.util.stream.Collectors; import static io.onedev.server.web.util.StatsGroup.BY_DAY; import static java.util.Comparator.comparingInt; -@SuppressWarnings("serial") public abstract class BuildMetricStatsPage extends ProjectPage { private static final String PARAM_QUERY = "query"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/CodeContribsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/CodeContribsPage.java index e3e716d5dc..980b4e1bf5 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/CodeContribsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/CodeContribsPage.java @@ -23,7 +23,6 @@ import org.eclipse.jgit.lib.PersonIdent; import java.util.HashMap; import java.util.Map; -@SuppressWarnings("serial") public class CodeContribsPage extends CodeStatsPage { private static final String USER_CARD_ID = "userCard"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/CodeStatsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/CodeStatsPage.java index a258238b19..6d84b59848 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/CodeStatsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/CodeStatsPage.java @@ -1,6 +1,13 @@ package io.onedev.server.web.page.project.stats.code; -import io.onedev.server.model.AbstractEntity; +import java.util.ArrayList; + +import org.apache.wicket.markup.head.IHeaderResponse; +import org.apache.wicket.markup.head.JavaScriptHeaderItem; +import org.apache.wicket.markup.html.link.BookmarkablePageLink; +import org.apache.wicket.model.Model; +import org.apache.wicket.request.mapper.parameter.PageParameters; + import io.onedev.server.model.Project; import io.onedev.server.security.SecurityUtils; import io.onedev.server.web.component.link.ViewStateAwarePageLink; @@ -8,15 +15,8 @@ import io.onedev.server.web.component.tabbable.PageTab; import io.onedev.server.web.component.tabbable.Tabbable; import io.onedev.server.web.page.project.ProjectPage; import io.onedev.server.web.page.project.dashboard.ProjectDashboardPage; -import org.apache.wicket.markup.head.IHeaderResponse; -import org.apache.wicket.markup.head.JavaScriptHeaderItem; -import org.apache.wicket.markup.html.link.BookmarkablePageLink; -import org.apache.wicket.model.Model; -import org.apache.wicket.request.mapper.parameter.PageParameters; -import java.util.ArrayList; - -public abstract class CodeStatsPage extends ProjectPage { +public abstract class CodeStatsPage extends ProjectPage { public CodeStatsPage(PageParameters params) { super(params); diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/SourceLinesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/SourceLinesPage.java index 5fb2eae43a..4dea2355c4 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/SourceLinesPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/stats/code/SourceLinesPage.java @@ -14,7 +14,6 @@ import java.util.LinkedHashMap; import java.util.Map; import java.util.TreeSet; -@SuppressWarnings("serial") public class SourceLinesPage extends CodeStatsPage { public SourceLinesPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/tags/ProjectTagsPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/tags/ProjectTagsPage.java index 9d7bbfabd6..10af5a2076 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/project/tags/ProjectTagsPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/project/tags/ProjectTagsPage.java @@ -83,7 +83,6 @@ import java.util.*; import static io.onedev.server.entityreference.ReferenceUtils.transformReferences; -@SuppressWarnings("serial") public class ProjectTagsPage extends ProjectPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/pullrequests/PullRequestListPage.java b/server-core/src/main/java/io/onedev/server/web/page/pullrequests/PullRequestListPage.java index f0ecde1ddf..25b806e6d3 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/pullrequests/PullRequestListPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/pullrequests/PullRequestListPage.java @@ -34,7 +34,6 @@ import javax.annotation.Nullable; import java.io.Serializable; import java.util.ArrayList; -@SuppressWarnings("serial") public class PullRequestListPage extends LayoutPage { private static final String PARAM_PAGE = "page"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/SimplePage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/SimplePage.java index a70e6e98b3..04d0249f8e 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/SimplePage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/SimplePage.java @@ -13,7 +13,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.web.component.brandlogo.BrandLogoPanel; import io.onedev.server.web.page.base.BasePage; -@SuppressWarnings("serial") public abstract class SimplePage extends BasePage { public SimplePage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/error/GeneralErrorPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/error/GeneralErrorPage.java index 4520bc5bd4..84ac8d35d9 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/error/GeneralErrorPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/error/GeneralErrorPage.java @@ -30,7 +30,6 @@ import java.io.Serializable; import static javax.servlet.http.HttpServletResponse.SC_INTERNAL_SERVER_ERROR; -@SuppressWarnings("serial") public class GeneralErrorPage extends SimplePage { private static final Logger logger = LoggerFactory.getLogger(GeneralErrorPage.class); diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/error/InUseErrorPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/error/InUseErrorPage.java index f5dc329670..fc0ad13a0f 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/error/InUseErrorPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/error/InUseErrorPage.java @@ -15,7 +15,6 @@ import io.onedev.server.util.usage.InUseException; import io.onedev.server.web.component.svg.SpriteImage; import io.onedev.server.web.page.simple.SimplePage; -@SuppressWarnings("serial") public class InUseErrorPage extends SimplePage { private final InUseException exception; diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/error/PageNotFoundErrorPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/error/PageNotFoundErrorPage.java index 5f941a02a9..9df8f7303d 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/error/PageNotFoundErrorPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/error/PageNotFoundErrorPage.java @@ -10,7 +10,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.web.component.svg.SpriteImage; import io.onedev.server.web.page.simple.SimplePage; -@SuppressWarnings("serial") public class PageNotFoundErrorPage extends SimplePage { public PageNotFoundErrorPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/security/CreateUserFromInvitationPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/security/CreateUserFromInvitationPage.java index 93733eac91..5a63750d38 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/security/CreateUserFromInvitationPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/security/CreateUserFromInvitationPage.java @@ -24,7 +24,6 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.LoadableDetachableModel; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class CreateUserFromInvitationPage extends SimplePage { private final String PARAM_INVITATION_CODE = "invitationCode"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/security/EmailAddressVerificationPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/security/EmailAddressVerificationPage.java index 670dbab455..971ab34d4a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/security/EmailAddressVerificationPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/security/EmailAddressVerificationPage.java @@ -11,7 +11,6 @@ import io.onedev.server.entitymanager.EmailAddressManager; import io.onedev.server.model.EmailAddress; import io.onedev.server.web.page.simple.SimplePage; -@SuppressWarnings("serial") public class EmailAddressVerificationPage extends SimplePage { private final String PARAM_EMAIL_ADDRESS = "emailAddress"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/security/LoginPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/security/LoginPage.java index f063715d4e..1795f7ba64 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/security/LoginPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/security/LoginPage.java @@ -36,7 +36,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import static io.onedev.server.web.page.admin.ssosetting.SsoProcessPage.MOUNT_PATH; import static io.onedev.server.web.page.admin.ssosetting.SsoProcessPage.STAGE_INITIATE; -@SuppressWarnings("serial") public class LoginPage extends SimplePage { private String userName; diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/security/LogoutPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/security/LogoutPage.java index 63f99a9f32..966d2a5cd4 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/security/LogoutPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/security/LogoutPage.java @@ -5,7 +5,6 @@ import io.onedev.server.web.page.base.BasePage; import org.apache.wicket.RestartResponseException; import org.apache.wicket.request.mapper.parameter.PageParameters; -@SuppressWarnings("serial") public class LogoutPage extends BasePage { public LogoutPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/security/OAuthCallbackPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/security/OAuthCallbackPage.java index 7704dca1df..182fbe2571 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/security/OAuthCallbackPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/security/OAuthCallbackPage.java @@ -9,7 +9,6 @@ import org.unbescape.javascript.JavaScriptEscape; import io.onedev.commons.utils.ExplicitException; import io.onedev.server.web.page.simple.SimplePage; -@SuppressWarnings("serial") public class OAuthCallbackPage extends SimplePage { public static final String MOUNT_PATH = "~oauth/callback"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/security/PasswordResetPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/security/PasswordResetPage.java index f2e4f63116..c6d9a3a5fd 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/security/PasswordResetPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/security/PasswordResetPage.java @@ -34,7 +34,6 @@ import java.util.Arrays; import java.util.HashMap; import java.util.Map; -@SuppressWarnings("serial") public class PasswordResetPage extends SimplePage { private static final String PARAM_PASSWORD_RESET_CODE = "passwordResetCode"; diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/security/SignUpBean.java b/server-core/src/main/java/io/onedev/server/web/page/simple/security/SignUpBean.java index 10e7385f93..3e820a9f29 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/security/SignUpBean.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/security/SignUpBean.java @@ -29,6 +29,7 @@ public class SignUpBean extends User { this.emailAddress = emailAddress; } + @SuppressWarnings("unused") private static String getEmailAddressDescription() { var allowedSelfRegisterEmailDomain = OneDev.getInstance(SettingManager.class).getSecuritySetting().getAllowedSelfRegisterEmailDomain(); if (allowedSelfRegisterEmailDomain != null) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/security/SignUpPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/security/SignUpPage.java index 575fe0f541..e73d1e598a 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/security/SignUpPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/security/SignUpPage.java @@ -32,7 +32,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import static io.onedev.server.model.User.*; import static io.onedev.server.web.page.simple.security.SignUpBean.PROP_EMAIL_ADDRESS; -@SuppressWarnings("serial") public class SignUpPage extends SimplePage { public SignUpPage(PageParameters params) { diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/serverinit/ServerInitPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/serverinit/ServerInitPage.java index 04c92c30db..a507e5cf6b 100644 --- a/server-core/src/main/java/io/onedev/server/web/page/simple/serverinit/ServerInitPage.java +++ b/server-core/src/main/java/io/onedev/server/web/page/simple/serverinit/ServerInitPage.java @@ -22,7 +22,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class ServerInitPage extends SimplePage { private final InitStage initStage; diff --git a/server-core/src/main/java/io/onedev/server/web/resource/AgentLibResource.java b/server-core/src/main/java/io/onedev/server/web/resource/AgentLibResource.java index b04d1dc2be..dc32dfad8a 100644 --- a/server-core/src/main/java/io/onedev/server/web/resource/AgentLibResource.java +++ b/server-core/src/main/java/io/onedev/server/web/resource/AgentLibResource.java @@ -2,18 +2,17 @@ package io.onedev.server.web.resource; import java.io.File; import java.io.IOException; -import java.io.OutputStream; import java.util.Collection; import javax.servlet.http.HttpServletRequest; -import io.onedev.commons.utils.TarUtils; import org.apache.tika.mime.MimeTypes; import org.apache.wicket.request.resource.AbstractResource; import io.onedev.commons.bootstrap.Bootstrap; import io.onedev.commons.utils.ExplicitException; import io.onedev.commons.utils.FileUtils; +import io.onedev.commons.utils.TarUtils; import io.onedev.server.OneDev; import io.onedev.server.entitymanager.AgentManager; import io.onedev.server.entitymanager.AgentTokenManager; diff --git a/server-core/src/main/java/io/onedev/server/web/resource/AgentResource.java b/server-core/src/main/java/io/onedev/server/web/resource/AgentResource.java index 43ed60902b..ff88f16ed0 100644 --- a/server-core/src/main/java/io/onedev/server/web/resource/AgentResource.java +++ b/server-core/src/main/java/io/onedev/server/web/resource/AgentResource.java @@ -1,27 +1,34 @@ package io.onedev.server.web.resource; +import java.io.BufferedOutputStream; +import java.io.File; +import java.io.FileInputStream; +import java.io.FileOutputStream; +import java.io.IOException; +import java.nio.charset.StandardCharsets; +import java.util.Collection; +import java.util.Properties; + +import org.apache.commons.io.IOUtils; +import org.apache.shiro.authz.UnauthorizedException; +import org.apache.tika.mime.MimeTypes; +import org.apache.wicket.request.resource.AbstractResource; + import com.google.common.collect.Sets; + import io.onedev.agent.Agent; import io.onedev.commons.bootstrap.Bootstrap; -import io.onedev.commons.utils.*; +import io.onedev.commons.utils.ExplicitException; +import io.onedev.commons.utils.FileUtils; +import io.onedev.commons.utils.StringUtils; +import io.onedev.commons.utils.TarUtils; +import io.onedev.commons.utils.ZipUtils; import io.onedev.server.OneDev; import io.onedev.server.entitymanager.AgentManager; import io.onedev.server.entitymanager.AgentTokenManager; import io.onedev.server.entitymanager.SettingManager; import io.onedev.server.model.AgentToken; import io.onedev.server.security.SecurityUtils; -import org.apache.commons.compress.utils.IOUtils; -import org.apache.shiro.authz.UnauthorizedException; -import org.apache.tika.mime.MimeTypes; -import org.apache.wicket.request.resource.AbstractResource; - -import java.io.BufferedOutputStream; -import java.io.File; -import java.io.FileOutputStream; -import java.io.IOException; -import java.nio.charset.StandardCharsets; -import java.util.Collection; -import java.util.Properties; public class AgentResource extends AbstractResource { @@ -103,7 +110,9 @@ public class AgentResource extends AbstractResource { if (fileName.endsWith("zip")) { File packageFile = new File(tempDir, fileName); ZipUtils.zip(agentDir, packageFile, "agent/boot/wrapper-*, agent/bin/*.sh"); - IOUtils.copy(packageFile, attributes.getResponse().getOutputStream()); + try (var is = new FileInputStream(packageFile)) { + IOUtils.copy(is, attributes.getResponse().getOutputStream()); + } } else { try (var os = attributes.getResponse().getOutputStream()) { TarUtils.tar(agentDir, Sets.newHashSet("**"), Sets.newHashSet(), diff --git a/server-core/src/main/java/io/onedev/server/web/resource/SiteFileResource.java b/server-core/src/main/java/io/onedev/server/web/resource/SiteFileResource.java index d023a1dc09..b2fc652821 100644 --- a/server-core/src/main/java/io/onedev/server/web/resource/SiteFileResource.java +++ b/server-core/src/main/java/io/onedev/server/web/resource/SiteFileResource.java @@ -1,31 +1,20 @@ package io.onedev.server.web.resource; -import com.google.common.base.Joiner; -import com.google.common.base.Splitter; -import io.onedev.commons.utils.ExplicitException; -import io.onedev.k8shelper.KubernetesHelper; -import io.onedev.server.OneDev; -import io.onedev.server.cluster.ClusterManager; -import io.onedev.server.entitymanager.ProjectManager; -import io.onedev.server.git.BlobIdent; -import io.onedev.server.model.Project; -import io.onedev.server.exception.ExceptionUtils; -import io.onedev.server.util.LongRange; -import io.onedev.server.util.artifact.ArtifactInfo; -import io.onedev.server.util.artifact.DirectoryInfo; -import io.onedev.server.util.artifact.FileInfo; -import io.onedev.server.web.mapper.ProjectMapperUtils; -import io.onedev.server.web.util.WicketUtils; -import org.apache.wicket.request.flow.RedirectToUrlException; -import org.apache.wicket.request.mapper.parameter.PageParameters; -import org.apache.wicket.request.resource.AbstractResource; -import org.eclipse.jetty.io.EofException; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; +import static io.onedev.commons.utils.LockUtils.read; +import static io.onedev.server.util.IOUtils.copyRange; + +import java.io.File; +import java.io.FileInputStream; +import java.io.IOException; +import java.io.InputStream; +import java.io.UnsupportedEncodingException; +import java.net.URLEncoder; +import java.nio.charset.StandardCharsets; +import java.util.ArrayList; +import java.util.List; import javax.persistence.EntityNotFoundException; import javax.servlet.http.HttpServletResponse; -import javax.ws.rs.BadRequestException; import javax.ws.rs.client.Client; import javax.ws.rs.client.ClientBuilder; import javax.ws.rs.client.Invocation; @@ -33,14 +22,31 @@ import javax.ws.rs.client.WebTarget; import javax.ws.rs.core.HttpHeaders; import javax.ws.rs.core.MediaType; import javax.ws.rs.core.Response; -import java.io.*; -import java.net.URLEncoder; -import java.nio.charset.StandardCharsets; -import java.util.ArrayList; -import java.util.List; -import static io.onedev.commons.utils.LockUtils.read; -import static io.onedev.server.util.IOUtils.copyRange; +import org.apache.wicket.request.flow.RedirectToUrlException; +import org.apache.wicket.request.mapper.parameter.PageParameters; +import org.apache.wicket.request.resource.AbstractResource; +import org.eclipse.jetty.io.EofException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.google.common.base.Joiner; +import com.google.common.base.Splitter; + +import io.onedev.commons.utils.ExplicitException; +import io.onedev.k8shelper.KubernetesHelper; +import io.onedev.server.OneDev; +import io.onedev.server.cluster.ClusterManager; +import io.onedev.server.entitymanager.ProjectManager; +import io.onedev.server.exception.ExceptionUtils; +import io.onedev.server.git.BlobIdent; +import io.onedev.server.model.Project; +import io.onedev.server.util.LongRange; +import io.onedev.server.util.artifact.ArtifactInfo; +import io.onedev.server.util.artifact.DirectoryInfo; +import io.onedev.server.util.artifact.FileInfo; +import io.onedev.server.web.mapper.ProjectMapperUtils; +import io.onedev.server.web.util.WicketUtils; public class SiteFileResource extends AbstractResource { diff --git a/server-core/src/main/java/io/onedev/server/web/resource/SpriteResourceStream.java b/server-core/src/main/java/io/onedev/server/web/resource/SpriteResourceStream.java index af1f324d8d..11cec03b4b 100644 --- a/server-core/src/main/java/io/onedev/server/web/resource/SpriteResourceStream.java +++ b/server-core/src/main/java/io/onedev/server/web/resource/SpriteResourceStream.java @@ -16,8 +16,8 @@ import java.util.concurrent.ConcurrentHashMap; import java.util.jar.JarEntry; import java.util.jar.JarFile; -import org.apache.commons.compress.utils.IOUtils; import org.apache.commons.io.FileUtils; +import org.apache.commons.io.IOUtils; import org.apache.wicket.util.file.Files; import org.apache.wicket.util.lang.Bytes; import org.apache.wicket.util.resource.IResourceStream; @@ -98,7 +98,7 @@ public class SpriteResourceStream implements IResourceStream { if (entry.getName().startsWith(packagePath) && entry.getName().endsWith(".svg")) { String relativeEntryName = entry.getName().substring(packagePath.length()); if (!relativeEntryName.contains("/")) { - try (InputStream is = jarFile.getInputStream(entry)) { + try (var is = jarFile.getInputStream(entry)) { files.put(relativeEntryName, new String(IOUtils.toByteArray(is), StandardCharsets.UTF_8)); } } diff --git a/server-core/src/main/java/io/onedev/server/web/resourcebundle/CachedDependenciesConcatResourceBundleReference.java b/server-core/src/main/java/io/onedev/server/web/resourcebundle/CachedDependenciesConcatResourceBundleReference.java index 0e9c8fd31f..16a253f177 100644 --- a/server-core/src/main/java/io/onedev/server/web/resourcebundle/CachedDependenciesConcatResourceBundleReference.java +++ b/server-core/src/main/java/io/onedev/server/web/resourcebundle/CachedDependenciesConcatResourceBundleReference.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.head.HeaderItem; import org.apache.wicket.markup.head.IReferenceHeaderItem; import org.apache.wicket.resource.bundles.ConcatResourceBundleReference; -@SuppressWarnings("serial") public class CachedDependenciesConcatResourceBundleReference extends ConcatResourceBundleReference { diff --git a/server-core/src/main/java/io/onedev/server/web/resourcebundle/CssConcatResourceBundleReference.java b/server-core/src/main/java/io/onedev/server/web/resourcebundle/CssConcatResourceBundleReference.java index d0f8c6fd2a..a5392cfb4d 100644 --- a/server-core/src/main/java/io/onedev/server/web/resourcebundle/CssConcatResourceBundleReference.java +++ b/server-core/src/main/java/io/onedev/server/web/resourcebundle/CssConcatResourceBundleReference.java @@ -12,7 +12,6 @@ import org.apache.wicket.util.io.IOUtils; import org.apache.wicket.util.resource.IResourceStream; import org.apache.wicket.util.resource.ResourceStreamNotFoundException; -@SuppressWarnings("serial") public class CssConcatResourceBundleReference extends CachedDependenciesConcatResourceBundleReference { diff --git a/server-core/src/main/java/io/onedev/server/web/resourcebundle/JavaScriptConcatResourceBundleReference.java b/server-core/src/main/java/io/onedev/server/web/resourcebundle/JavaScriptConcatResourceBundleReference.java index 4470668140..54aadb8c42 100644 --- a/server-core/src/main/java/io/onedev/server/web/resourcebundle/JavaScriptConcatResourceBundleReference.java +++ b/server-core/src/main/java/io/onedev/server/web/resourcebundle/JavaScriptConcatResourceBundleReference.java @@ -12,7 +12,6 @@ import org.apache.wicket.util.io.IOUtils; import org.apache.wicket.util.resource.IResourceStream; import org.apache.wicket.util.resource.ResourceStreamNotFoundException; -@SuppressWarnings("serial") public class JavaScriptConcatResourceBundleReference extends CachedDependenciesConcatResourceBundleReference { diff --git a/server-core/src/main/java/io/onedev/server/web/util/ConfirmClickModifier.java b/server-core/src/main/java/io/onedev/server/web/util/ConfirmClickModifier.java index bea06c5bcc..50818e3246 100644 --- a/server-core/src/main/java/io/onedev/server/web/util/ConfirmClickModifier.java +++ b/server-core/src/main/java/io/onedev/server/web/util/ConfirmClickModifier.java @@ -3,7 +3,6 @@ package io.onedev.server.web.util; import org.apache.commons.text.StringEscapeUtils; import org.apache.wicket.AttributeModifier; -@SuppressWarnings("serial") public class ConfirmClickModifier extends AttributeModifier { public ConfirmClickModifier(String message) { diff --git a/server-core/src/main/java/io/onedev/server/web/util/LoadableDetachableDataProvider.java b/server-core/src/main/java/io/onedev/server/web/util/LoadableDetachableDataProvider.java index 412b2aaa57..c6152c8e5e 100644 --- a/server-core/src/main/java/io/onedev/server/web/util/LoadableDetachableDataProvider.java +++ b/server-core/src/main/java/io/onedev/server/web/util/LoadableDetachableDataProvider.java @@ -2,7 +2,6 @@ package io.onedev.server.web.util; import org.apache.wicket.extensions.markup.html.repeater.util.SortableDataProvider; -@SuppressWarnings("serial") public abstract class LoadableDetachableDataProvider extends SortableDataProvider { private Long size; diff --git a/server-core/src/main/java/io/onedev/server/web/util/UserAware.java b/server-core/src/main/java/io/onedev/server/web/util/UserAware.java index 7b58776a7e..f84598930a 100644 --- a/server-core/src/main/java/io/onedev/server/web/util/UserAware.java +++ b/server-core/src/main/java/io/onedev/server/web/util/UserAware.java @@ -1,6 +1,5 @@ package io.onedev.server.web.util; -import io.onedev.server.model.Project; import io.onedev.server.model.User; public interface UserAware { diff --git a/server-core/src/main/java/io/onedev/server/web/util/editbean/IssueWorkBean.java b/server-core/src/main/java/io/onedev/server/web/util/editbean/IssueWorkBean.java index eee8b99f5e..68e48c89d0 100644 --- a/server-core/src/main/java/io/onedev/server/web/util/editbean/IssueWorkBean.java +++ b/server-core/src/main/java/io/onedev/server/web/util/editbean/IssueWorkBean.java @@ -33,6 +33,7 @@ public class IssueWorkBean implements Serializable { this.spentTime = spentTime; } + @SuppressWarnings("unused") private static String getSpentTimeDescription() { var aggregationLink = OneDev.getInstance(SettingManager.class).getIssueSetting().getTimeTrackingSetting().getAggregationLink(); if (aggregationLink != null) diff --git a/server-core/src/main/java/io/onedev/server/web/util/paginghistory/AjaxPagingHistorySupport.java b/server-core/src/main/java/io/onedev/server/web/util/paginghistory/AjaxPagingHistorySupport.java index f70f7eae6b..59c45d9522 100644 --- a/server-core/src/main/java/io/onedev/server/web/util/paginghistory/AjaxPagingHistorySupport.java +++ b/server-core/src/main/java/io/onedev/server/web/util/paginghistory/AjaxPagingHistorySupport.java @@ -1,7 +1,6 @@ package io.onedev.server.web.util.paginghistory; import org.apache.wicket.ajax.AjaxRequestTarget; -import org.apache.wicket.request.mapper.parameter.PageParameters; public interface AjaxPagingHistorySupport extends PagingHistorySupport { void onPageNavigated(AjaxRequestTarget target, int currentPage); diff --git a/server-core/src/main/java/io/onedev/server/web/util/paginghistory/PagingHistorySupport.java b/server-core/src/main/java/io/onedev/server/web/util/paginghistory/PagingHistorySupport.java index 9f1004a3c9..2e0c91a9c9 100644 --- a/server-core/src/main/java/io/onedev/server/web/util/paginghistory/PagingHistorySupport.java +++ b/server-core/src/main/java/io/onedev/server/web/util/paginghistory/PagingHistorySupport.java @@ -2,8 +2,6 @@ package io.onedev.server.web.util.paginghistory; import java.io.Serializable; -import org.apache.wicket.request.mapper.parameter.PageParameters; - public interface PagingHistorySupport extends Serializable { int getCurrentPage(); diff --git a/server-core/src/main/java/io/onedev/server/xodus/DefaultCommitInfoManager.java b/server-core/src/main/java/io/onedev/server/xodus/DefaultCommitInfoManager.java index ac6d87e8de..b9097a7297 100644 --- a/server-core/src/main/java/io/onedev/server/xodus/DefaultCommitInfoManager.java +++ b/server-core/src/main/java/io/onedev/server/xodus/DefaultCommitInfoManager.java @@ -862,6 +862,7 @@ public class DefaultCommitInfoManager extends AbstractEnvironmentManager files = env.computeInReadonlyTransaction(txn -> { byte[] bytes = readBytes(store, txn, FILES_KEY); if (bytes != null) { + @SuppressWarnings("unchecked") List innerFiles = new ArrayList<>((Collection) SerializationUtils.deserialize(bytes)); Map> segmentsMap = new HashMap<>(); Splitter splitter = Splitter.on("/"); diff --git a/server-core/src/main/java/io/onedev/server/xodus/DefaultIssueInfoManager.java b/server-core/src/main/java/io/onedev/server/xodus/DefaultIssueInfoManager.java index 8e8a2a5dc0..92ffe46e43 100644 --- a/server-core/src/main/java/io/onedev/server/xodus/DefaultIssueInfoManager.java +++ b/server-core/src/main/java/io/onedev/server/xodus/DefaultIssueInfoManager.java @@ -145,6 +145,7 @@ public class DefaultIssueInfoManager extends AbstractEnvironmentManager if (state != null) { ArrayByteIterable issueKey = new LongByteIterable(issue.getId()); byte[] bytes = Preconditions.checkNotNull(readBytes(stateHistoryStore, txn, issueKey)); + @SuppressWarnings("unchecked") Map stateHistory = (Map) SerializationUtils.deserialize(bytes); stateHistory.put(toLocalDate(change.getDate()).toEpochDay(), state); stateHistoryStore.put(txn, issueKey, new ArrayByteIterable(SerializationUtils.serialize((Serializable) stateHistory))); @@ -155,6 +156,7 @@ public class DefaultIssueInfoManager extends AbstractEnvironmentManager int spentTime = changeData.getNewValue(); ArrayByteIterable issueKey = new LongByteIterable(issue.getId()); byte[] bytes = Preconditions.checkNotNull(readBytes(spentTimeHistoryStore, txn, issueKey)); + @SuppressWarnings("unchecked") Map spentTimeHistory = (Map) SerializationUtils.deserialize(bytes); spentTimeHistory.put(toLocalDate(change.getDate()).toEpochDay(), spentTime); spentTimeHistoryStore.put(txn, issueKey, new ArrayByteIterable(SerializationUtils.serialize((Serializable) spentTimeHistory))); @@ -312,6 +314,7 @@ public class DefaultIssueInfoManager extends AbstractEnvironmentManager Map dailyMetrics = new LinkedHashMap<>(); byte[] bytes = readBytes(metricHistoryStore, txn, new LongByteIterable(issueId)); if (bytes != null) { + @SuppressWarnings("unchecked") var metricHistory = (Map) SerializationUtils.deserialize(bytes); T currentMetric = null; for (var entry : metricHistory.entrySet()) { diff --git a/server-core/src/main/java/org/apache/wicket/RestartResponseAtInterceptPageException.java b/server-core/src/main/java/org/apache/wicket/RestartResponseAtInterceptPageException.java index 96f6c1e09b..0a3edfb021 100644 --- a/server-core/src/main/java/org/apache/wicket/RestartResponseAtInterceptPageException.java +++ b/server-core/src/main/java/org/apache/wicket/RestartResponseAtInterceptPageException.java @@ -23,7 +23,9 @@ import java.util.Iterator; import java.util.List; import java.util.Map; -import io.onedev.commons.utils.StringUtils; +import org.apache.wicket.core.request.handler.PageProvider; +import org.apache.wicket.core.request.handler.RenderPageRequestHandler; +import org.apache.wicket.core.request.handler.RenderPageRequestHandler.RedirectPolicy; import org.apache.wicket.request.IRequestHandler; import org.apache.wicket.request.IRequestMapper; import org.apache.wicket.request.IWritableRequestParameters; @@ -31,11 +33,7 @@ import org.apache.wicket.request.Request; import org.apache.wicket.request.Url; import org.apache.wicket.request.Url.QueryParameter; import org.apache.wicket.request.cycle.RequestCycle; -import org.apache.wicket.request.flow.RedirectToUrlException; import org.apache.wicket.request.flow.ResetResponseException; -import org.apache.wicket.core.request.handler.PageProvider; -import org.apache.wicket.core.request.handler.RenderPageRequestHandler; -import org.apache.wicket.core.request.handler.RenderPageRequestHandler.RedirectPolicy; import org.apache.wicket.request.http.WebRequest; import org.apache.wicket.request.mapper.parameter.PageParameters; import org.apache.wicket.util.string.StringValue; diff --git a/server-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java b/server-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java index 4f85e9a168..7406b7d8d6 100644 --- a/server-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java +++ b/server-core/src/main/java/org/apache/wicket/protocol/ws/api/AbstractWebSocketProcessor.java @@ -406,7 +406,6 @@ public abstract class AbstractWebSocketProcessor implements IWebSocketProcessor * A dummy page that is used to create a new WebSocketRequestHandler for * web socket connections to WebSocketResource */ - @SuppressWarnings("serial") private static class WebSocketResourcePage extends WebPage implements IMarkupResourceStreamProvider { private WebSocketResourcePage() diff --git a/server-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/SimpleWebSocketConnectionRegistry.java b/server-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/SimpleWebSocketConnectionRegistry.java index 85883610ae..c553ab0605 100644 --- a/server-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/SimpleWebSocketConnectionRegistry.java +++ b/server-core/src/main/java/org/apache/wicket/protocol/ws/api/registry/SimpleWebSocketConnectionRegistry.java @@ -35,7 +35,6 @@ import org.apache.wicket.util.lang.Generics; */ public class SimpleWebSocketConnectionRegistry implements IWebSocketConnectionRegistry { - @SuppressWarnings("serial") private static final MetaDataKey>> KEY = new MetaDataKey>>() { diff --git a/server-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java b/server-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java index fd188159bc..3c1b738db1 100644 --- a/server-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java +++ b/server-core/src/main/java/org/apache/wicket/request/cycle/RequestCycle.java @@ -70,6 +70,7 @@ public class RequestCycle implements IRequestCycle, IEventSink * Could be disabled separately than the main logger if the application developer * does not want to see this extra information. */ + @SuppressWarnings("unused") private static final Logger logExtra = LoggerFactory.getLogger("RequestCycleExtra"); /** diff --git a/server-core/src/main/java/org/eclipse/jetty/server/Response.java b/server-core/src/main/java/org/eclipse/jetty/server/Response.java index 693d2a309b..185fa1d4d2 100644 --- a/server-core/src/main/java/org/eclipse/jetty/server/Response.java +++ b/server-core/src/main/java/org/eclipse/jetty/server/Response.java @@ -68,6 +68,7 @@ import org.eclipse.jetty.util.log.Logger; */ public class Response implements HttpServletResponse { + @SuppressWarnings("unused") private static final Logger LOG = Log.getLogger(Response.class); private static final int __MIN_BUFFER_SIZE = 1; private static final HttpField __EXPIRES_01JAN1970 = new PreEncodedHttpField(HttpHeader.EXPIRES, DateGenerator.__01Jan1970); diff --git a/server-core/src/main/java/org/eclipse/jgit/revwalk/FollowFilter.java b/server-core/src/main/java/org/eclipse/jgit/revwalk/FollowFilter.java index 3b54123f0b..d179a9441f 100644 --- a/server-core/src/main/java/org/eclipse/jgit/revwalk/FollowFilter.java +++ b/server-core/src/main/java/org/eclipse/jgit/revwalk/FollowFilter.java @@ -98,7 +98,6 @@ public class FollowFilter extends TreeFilter { } /** {@inheritDoc} */ - @SuppressWarnings("nls") @Override public String toString() { return "(FOLLOW(" + path.toString() + ")" // diff --git a/server-core/src/main/java/org/eclipse/jgit/revwalk/FooterKey.java b/server-core/src/main/java/org/eclipse/jgit/revwalk/FooterKey.java index 74e4c1edb7..ed99282c5a 100644 --- a/server-core/src/main/java/org/eclipse/jgit/revwalk/FooterKey.java +++ b/server-core/src/main/java/org/eclipse/jgit/revwalk/FooterKey.java @@ -52,7 +52,6 @@ public final class FooterKey { } /** {@inheritDoc} */ - @SuppressWarnings("nls") @Override public String toString() { return "FooterKey[" + name + "]"; diff --git a/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/AndRevFilter.java b/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/AndRevFilter.java index f48bc017e5..08804e85b8 100644 --- a/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/AndRevFilter.java +++ b/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/AndRevFilter.java @@ -114,7 +114,6 @@ public abstract class AndRevFilter extends RevFilter { return new Binary(a.clone(), b.clone()); } - @SuppressWarnings("nls") @Override public String toString() { return "(" + a.toString() + " AND " + b.toString() + ")"; //$NON-NLS-1$ @@ -159,7 +158,6 @@ public abstract class AndRevFilter extends RevFilter { return new List(s); } - @SuppressWarnings("nls") @Override public String toString() { final StringBuilder r = new StringBuilder(); diff --git a/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/CommitTimeRevFilter.java b/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/CommitTimeRevFilter.java index 6ac490a345..13b7658c8e 100644 --- a/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/CommitTimeRevFilter.java +++ b/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/CommitTimeRevFilter.java @@ -122,7 +122,6 @@ public abstract class CommitTimeRevFilter extends RevFilter { return cmit.getCommitTime() <= when; } - @SuppressWarnings("nls") @Override public String toString() { return super.toString() + "(" + new Date(when * 1000L) + ")"; @@ -147,7 +146,6 @@ public abstract class CommitTimeRevFilter extends RevFilter { return true; } - @SuppressWarnings("nls") @Override public String toString() { return super.toString() + "(" + new Date(when * 1000L) + ")"; @@ -169,7 +167,6 @@ public abstract class CommitTimeRevFilter extends RevFilter { return cmit.getCommitTime() <= until && cmit.getCommitTime() >= when; } - @SuppressWarnings("nls") @Override public String toString() { return super.toString() + "(" + new Date(when * 1000L) + " - " diff --git a/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/OrRevFilter.java b/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/OrRevFilter.java index 11f35e075e..ebf48bd360 100644 --- a/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/OrRevFilter.java +++ b/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/OrRevFilter.java @@ -112,7 +112,6 @@ public abstract class OrRevFilter extends RevFilter { return new Binary(a.clone(), b.clone()); } - @SuppressWarnings("nls") @Override public String toString() { return "(" + a.toString() + " OR " + b.toString() + ")"; diff --git a/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/PatternMatchRevFilter.java b/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/PatternMatchRevFilter.java index efb5ee5e4d..bd70092faf 100644 --- a/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/PatternMatchRevFilter.java +++ b/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/PatternMatchRevFilter.java @@ -117,7 +117,6 @@ public abstract class PatternMatchRevFilter extends RevFilter { protected abstract CharSequence text(RevCommit cmit); /** {@inheritDoc} */ - @SuppressWarnings("nls") @Override public String toString() { return super.toString() + "(\"" + patternText + "\")"; diff --git a/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/SubStringRevFilter.java b/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/SubStringRevFilter.java index 7f00dfd504..5fc9b76f79 100644 --- a/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/SubStringRevFilter.java +++ b/server-core/src/main/java/org/eclipse/jgit/revwalk/filter/SubStringRevFilter.java @@ -97,7 +97,6 @@ public abstract class SubStringRevFilter extends RevFilter { } /** {@inheritDoc} */ - @SuppressWarnings("nls") @Override public String toString() { return super.toString() + "(\"" + pattern.pattern() + "\")"; diff --git a/server-core/src/main/java/org/yaml/snakeyaml/constructor/BaseConstructor.java b/server-core/src/main/java/org/yaml/snakeyaml/constructor/BaseConstructor.java index 596235ae58..484255ef82 100644 --- a/server-core/src/main/java/org/yaml/snakeyaml/constructor/BaseConstructor.java +++ b/server-core/src/main/java/org/yaml/snakeyaml/constructor/BaseConstructor.java @@ -609,6 +609,7 @@ public abstract class BaseConstructor { * different hash after initialization compared to clean just created one. And map of course does * not observe key hashCode changes. */ + @SuppressWarnings({ "rawtypes", "unchecked" }) protected void postponeMapFilling(Map mapping, Object key, Object value) { maps2fill.add(0, new RecursiveTuple(mapping, new RecursiveTuple(key, value))); } diff --git a/server-core/src/test/java/io/onedev/server/git/command/LogCommandTest.java b/server-core/src/test/java/io/onedev/server/git/command/LogCommandTest.java index 085331dc9c..ca2ec358c7 100644 --- a/server-core/src/test/java/io/onedev/server/git/command/LogCommandTest.java +++ b/server-core/src/test/java/io/onedev/server/git/command/LogCommandTest.java @@ -9,8 +9,6 @@ import java.util.List; import org.junit.Test; -import com.google.common.collect.Lists; - import io.onedev.server.git.AbstractGitTest; public class LogCommandTest extends AbstractGitTest { diff --git a/server-core/src/test/java/io/onedev/server/search/entity/issue/IssueQueryGrammarTest.java b/server-core/src/test/java/io/onedev/server/search/entity/issue/IssueQueryGrammarTest.java index 1c7053504e..a414bd28fd 100644 --- a/server-core/src/test/java/io/onedev/server/search/entity/issue/IssueQueryGrammarTest.java +++ b/server-core/src/test/java/io/onedev/server/search/entity/issue/IssueQueryGrammarTest.java @@ -1,17 +1,17 @@ package io.onedev.server.search.entity.issue; +import static org.junit.Assert.assertEquals; + +import java.util.List; + +import org.junit.Test; + import io.onedev.commons.codeassist.CodeAssist; import io.onedev.commons.codeassist.FenceAware; import io.onedev.commons.codeassist.InputStatus; import io.onedev.commons.codeassist.InputSuggestion; import io.onedev.commons.codeassist.grammar.LexerRuleRefElementSpec; import io.onedev.commons.codeassist.parser.TerminalExpect; -import org.junit.Test; - -import java.util.List; -import java.util.stream.Collectors; - -import static org.junit.Assert.assertEquals; public class IssueQueryGrammarTest { diff --git a/server-core/src/test/java/io/onedev/server/util/criteria/CriteriaTest.java b/server-core/src/test/java/io/onedev/server/util/criteria/CriteriaTest.java index ef4506c956..8601d95d4f 100644 --- a/server-core/src/test/java/io/onedev/server/util/criteria/CriteriaTest.java +++ b/server-core/src/test/java/io/onedev/server/util/criteria/CriteriaTest.java @@ -1,20 +1,20 @@ package io.onedev.server.util.criteria; -import com.google.common.collect.Lists; -import com.google.common.collect.Sets; -import io.onedev.server.util.Pair; -import org.junit.Test; +import static com.google.common.collect.Lists.newArrayList; +import static com.google.common.collect.Sets.newHashSet; +import static org.junit.Assert.assertEquals; import java.util.Collection; import java.util.HashSet; import java.util.Set; -import static com.google.common.collect.Lists.newArrayList; -import static com.google.common.collect.Sets.newHashSet; -import static org.junit.Assert.*; +import org.junit.Test; + +import io.onedev.server.util.Pair; public class CriteriaTest { + @SuppressWarnings("unchecked") @Test public void forManyValues() { var ranges = new HashSet>(); diff --git a/server-core/src/test/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanelTest.java b/server-core/src/test/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanelTest.java index d6ea89aa6a..deb4014d94 100644 --- a/server-core/src/test/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanelTest.java +++ b/server-core/src/test/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanelTest.java @@ -1,11 +1,10 @@ package io.onedev.server.web.component.diff.revision; -import com.google.common.collect.Lists; -import org.junit.Test; - import static com.google.common.collect.Lists.newArrayList; import static io.onedev.server.web.component.diff.revision.RevisionDiffPanel.getChildren; -import static org.junit.Assert.*; +import static org.junit.Assert.assertEquals; + +import org.junit.Test; public class RevisionDiffPanelTest { diff --git a/server-ee b/server-ee index 08a2f63d0a..9f14fe0782 160000 --- a/server-ee +++ b/server-ee @@ -1 +1 @@ -Subproject commit 08a2f63d0a9c6b37b4f6cc0b42701aa209aa3762 +Subproject commit 9f14fe07824649d02684b156b37ceb7e0e209df6 diff --git a/server-plugin/server-plugin-buildspec-cmake/src/main/java/io/onedev/server/plugin/buildspec/cmake/CmakeJobSuggestion.java b/server-plugin/server-plugin-buildspec-cmake/src/main/java/io/onedev/server/plugin/buildspec/cmake/CmakeJobSuggestion.java index d49ba1eb8c..3a551b66b2 100644 --- a/server-plugin/server-plugin-buildspec-cmake/src/main/java/io/onedev/server/plugin/buildspec/cmake/CmakeJobSuggestion.java +++ b/server-plugin/server-plugin-buildspec-cmake/src/main/java/io/onedev/server/plugin/buildspec/cmake/CmakeJobSuggestion.java @@ -1,6 +1,14 @@ package io.onedev.server.plugin.buildspec.cmake; +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; + +import org.eclipse.jgit.lib.FileMode; +import org.eclipse.jgit.lib.ObjectId; + import com.google.common.collect.Lists; + import io.onedev.k8shelper.ExecuteCondition; import io.onedev.server.buildspec.job.Job; import io.onedev.server.buildspec.job.JobSuggestion; @@ -15,19 +23,9 @@ import io.onedev.server.model.Project; import io.onedev.server.plugin.report.cobertura.PublishCoberturaReportStep; import io.onedev.server.plugin.report.coverage.PublishCoverageReportStep; import io.onedev.server.plugin.report.cppcheck.PublishCppcheckReportStep; -import org.eclipse.jgit.lib.FileMode; -import org.eclipse.jgit.lib.ObjectId; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -import java.util.ArrayList; -import java.util.Collection; -import java.util.List; public class CmakeJobSuggestion implements JobSuggestion { - private static final Logger logger = LoggerFactory.getLogger(CmakeJobSuggestion.class); - private GenerateChecksumStep newChecksumGenerateStep(String files) { var generateChecksum = new GenerateChecksumStep(); generateChecksum.setName("generate dependency checksum"); diff --git a/server-plugin/server-plugin-buildspec-golang/src/main/java/io/onedev/server/plugin/buildspec/golang/GolangJobSuggestion.java b/server-plugin/server-plugin-buildspec-golang/src/main/java/io/onedev/server/plugin/buildspec/golang/GolangJobSuggestion.java index 1e711ce09e..12575f282b 100644 --- a/server-plugin/server-plugin-buildspec-golang/src/main/java/io/onedev/server/plugin/buildspec/golang/GolangJobSuggestion.java +++ b/server-plugin/server-plugin-buildspec-golang/src/main/java/io/onedev/server/plugin/buildspec/golang/GolangJobSuggestion.java @@ -1,7 +1,14 @@ package io.onedev.server.plugin.buildspec.golang; +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; + +import org.eclipse.jgit.lib.FileMode; +import org.eclipse.jgit.lib.ObjectId; + import com.google.common.collect.Lists; -import io.onedev.commons.utils.TaskLogger; + import io.onedev.k8shelper.ExecuteCondition; import io.onedev.server.buildspec.job.Job; import io.onedev.server.buildspec.job.JobSuggestion; @@ -20,12 +27,6 @@ import io.onedev.server.plugin.report.cobertura.PublishCoberturaReportStep; import io.onedev.server.plugin.report.coverage.PublishCoverageReportStep; import io.onedev.server.plugin.report.junit.PublishJUnitReportStep; import io.onedev.server.util.interpolative.VariableInterpolator; -import org.eclipse.jgit.lib.FileMode; -import org.eclipse.jgit.lib.ObjectId; - -import java.util.ArrayList; -import java.util.Collection; -import java.util.List; public class GolangJobSuggestion implements JobSuggestion { diff --git a/server-plugin/server-plugin-buildspec-maven/src/main/java/io/onedev/server/plugin/buildspec/maven/MavenJobSuggestion.java b/server-plugin/server-plugin-buildspec-maven/src/main/java/io/onedev/server/plugin/buildspec/maven/MavenJobSuggestion.java index de7a0ac7b8..babb0c1b90 100644 --- a/server-plugin/server-plugin-buildspec-maven/src/main/java/io/onedev/server/plugin/buildspec/maven/MavenJobSuggestion.java +++ b/server-plugin/server-plugin-buildspec-maven/src/main/java/io/onedev/server/plugin/buildspec/maven/MavenJobSuggestion.java @@ -1,24 +1,27 @@ package io.onedev.server.plugin.buildspec.maven; +import java.util.ArrayList; +import java.util.Collection; + +import org.eclipse.jgit.lib.FileMode; +import org.eclipse.jgit.lib.ObjectId; + import com.google.common.collect.Lists; + import io.onedev.k8shelper.ExecuteCondition; import io.onedev.server.buildspec.job.Job; import io.onedev.server.buildspec.job.JobSuggestion; import io.onedev.server.buildspec.job.trigger.BranchUpdateTrigger; import io.onedev.server.buildspec.job.trigger.PullRequestUpdateTrigger; -import io.onedev.server.buildspec.step.*; -import io.onedev.server.buildspec.step.commandinterpreter.ShellInterpreter; +import io.onedev.server.buildspec.step.CheckoutStep; +import io.onedev.server.buildspec.step.CommandStep; +import io.onedev.server.buildspec.step.GenerateChecksumStep; +import io.onedev.server.buildspec.step.SetBuildVersionStep; +import io.onedev.server.buildspec.step.SetupCacheStep; import io.onedev.server.git.Blob; import io.onedev.server.git.BlobIdent; import io.onedev.server.model.Project; import io.onedev.server.plugin.report.junit.PublishJUnitReportStep; -import org.eclipse.jgit.lib.FileMode; -import org.eclipse.jgit.lib.ObjectId; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -import java.util.ArrayList; -import java.util.Collection; public class MavenJobSuggestion implements JobSuggestion { diff --git a/server-plugin/server-plugin-buildspec-rust/src/main/java/io/onedev/server/plugin/buildspec/rust/RustModule.java b/server-plugin/server-plugin-buildspec-rust/src/main/java/io/onedev/server/plugin/buildspec/rust/RustModule.java index d605fdbf24..e7a2724d8c 100644 --- a/server-plugin/server-plugin-buildspec-rust/src/main/java/io/onedev/server/plugin/buildspec/rust/RustModule.java +++ b/server-plugin/server-plugin-buildspec-rust/src/main/java/io/onedev/server/plugin/buildspec/rust/RustModule.java @@ -1,10 +1,7 @@ package io.onedev.server.plugin.buildspec.rust; -import com.google.common.collect.Lists; import io.onedev.commons.loader.AbstractPluginModule; import io.onedev.server.buildspec.job.JobSuggestion; -import io.onedev.server.model.support.administration.GroovyScript; -import io.onedev.server.util.ScriptContribution; /** * NOTE: Do not forget to rename moduleClass property defined in the pom if you've renamed this class. diff --git a/server-plugin/server-plugin-executor-kubernetes/src/main/java/io/onedev/server/plugin/executor/kubernetes/KubernetesExecutor.java b/server-plugin/server-plugin-executor-kubernetes/src/main/java/io/onedev/server/plugin/executor/kubernetes/KubernetesExecutor.java index 33c036fced..854003ff8c 100644 --- a/server-plugin/server-plugin-executor-kubernetes/src/main/java/io/onedev/server/plugin/executor/kubernetes/KubernetesExecutor.java +++ b/server-plugin/server-plugin-executor-kubernetes/src/main/java/io/onedev/server/plugin/executor/kubernetes/KubernetesExecutor.java @@ -130,6 +130,7 @@ public class KubernetesExecutor extends JobExecutor implements RegistryLoginAwar this.buildWithPV = buildWithPV; } + @SuppressWarnings("unused") private static boolean isBuildWithPVEnabled() { return (boolean) EditContext.get().getInputValue("buildWithPV"); } diff --git a/server-plugin/server-plugin-executor-serverdocker/src/main/java/io/onedev/server/plugin/executor/serverdocker/ServerDockerExecutor.java b/server-plugin/server-plugin-executor-serverdocker/src/main/java/io/onedev/server/plugin/executor/serverdocker/ServerDockerExecutor.java index 239fbab548..1c21aa4002 100644 --- a/server-plugin/server-plugin-executor-serverdocker/src/main/java/io/onedev/server/plugin/executor/serverdocker/ServerDockerExecutor.java +++ b/server-plugin/server-plugin-executor-serverdocker/src/main/java/io/onedev/server/plugin/executor/serverdocker/ServerDockerExecutor.java @@ -1,6 +1,47 @@ package io.onedev.server.plugin.executor.serverdocker; +import static io.onedev.agent.DockerExecutorUtils.buildImage; +import static io.onedev.agent.DockerExecutorUtils.callWithDockerConfig; +import static io.onedev.agent.DockerExecutorUtils.changeOwner; +import static io.onedev.agent.DockerExecutorUtils.createNetwork; +import static io.onedev.agent.DockerExecutorUtils.deleteDir; +import static io.onedev.agent.DockerExecutorUtils.deleteNetwork; +import static io.onedev.agent.DockerExecutorUtils.getEntrypoint; +import static io.onedev.agent.DockerExecutorUtils.getOwner; +import static io.onedev.agent.DockerExecutorUtils.isUseProcessIsolation; +import static io.onedev.agent.DockerExecutorUtils.newDockerKiller; +import static io.onedev.agent.DockerExecutorUtils.pruneBuilderCache; +import static io.onedev.agent.DockerExecutorUtils.runImagetools; +import static io.onedev.agent.DockerExecutorUtils.startService; +import static io.onedev.agent.DockerExecutorUtils.useDockerSock; +import static io.onedev.agent.ExecutorUtils.newErrorLogger; +import static io.onedev.agent.ExecutorUtils.newInfoLogger; +import static io.onedev.k8shelper.KubernetesHelper.cloneRepository; +import static io.onedev.k8shelper.KubernetesHelper.installGitCert; +import static io.onedev.k8shelper.KubernetesHelper.stringifyStepPosition; +import static io.onedev.k8shelper.RegistryLoginFacade.merge; +import static java.util.stream.Collectors.toList; + +import java.io.File; +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import java.util.concurrent.atomic.AtomicBoolean; + +import javax.annotation.Nullable; +import javax.validation.ConstraintValidatorContext; +import javax.validation.constraints.NotEmpty; + +import org.apache.commons.lang3.SystemUtils; + import com.google.common.base.Preconditions; + import io.onedev.agent.DockerExecutorUtils; import io.onedev.agent.ExecutorUtils; import io.onedev.commons.bootstrap.Bootstrap; @@ -11,14 +52,36 @@ import io.onedev.commons.utils.StringUtils; import io.onedev.commons.utils.TaskLogger; import io.onedev.commons.utils.command.Commandline; import io.onedev.commons.utils.command.LineConsumer; -import io.onedev.k8shelper.*; +import io.onedev.k8shelper.BuildImageFacade; +import io.onedev.k8shelper.CheckoutFacade; +import io.onedev.k8shelper.CloneInfo; +import io.onedev.k8shelper.CommandFacade; +import io.onedev.k8shelper.CompositeFacade; +import io.onedev.k8shelper.KubernetesHelper; +import io.onedev.k8shelper.LeafFacade; +import io.onedev.k8shelper.LeafHandler; +import io.onedev.k8shelper.OsInfo; +import io.onedev.k8shelper.PruneBuilderCacheFacade; +import io.onedev.k8shelper.RegistryLoginFacade; +import io.onedev.k8shelper.RunContainerFacade; +import io.onedev.k8shelper.RunImagetoolsFacade; +import io.onedev.k8shelper.ServerSideFacade; +import io.onedev.k8shelper.ServerStepResult; +import io.onedev.k8shelper.SetupCacheFacade; import io.onedev.server.OneDev; -import io.onedev.server.annotation.*; +import io.onedev.server.annotation.ClassValidating; +import io.onedev.server.annotation.Editable; +import io.onedev.server.annotation.Numeric; +import io.onedev.server.annotation.OmitName; +import io.onedev.server.annotation.ReservedOptions; import io.onedev.server.cluster.ClusterManager; import io.onedev.server.cluster.ClusterTask; -import io.onedev.server.entitymanager.SettingManager; import io.onedev.server.git.location.GitLocation; -import io.onedev.server.job.*; +import io.onedev.server.job.JobContext; +import io.onedev.server.job.JobManager; +import io.onedev.server.job.JobRunnable; +import io.onedev.server.job.ResourceAllocator; +import io.onedev.server.job.ServerCacheHelper; import io.onedev.server.model.support.administration.jobexecutor.JobExecutor; import io.onedev.server.model.support.administration.jobexecutor.RegistryLogin; import io.onedev.server.model.support.administration.jobexecutor.RegistryLoginAware; @@ -28,21 +91,6 @@ import io.onedev.server.terminal.Shell; import io.onedev.server.terminal.Terminal; import io.onedev.server.validation.Validatable; import io.onedev.server.web.util.Testable; -import org.apache.commons.lang3.SystemUtils; - -import javax.annotation.Nullable; -import javax.validation.ConstraintValidatorContext; -import javax.validation.constraints.NotEmpty; -import java.io.File; -import java.io.Serializable; -import java.util.*; -import java.util.concurrent.atomic.AtomicBoolean; - -import static io.onedev.agent.DockerExecutorUtils.changeOwner; -import static io.onedev.agent.DockerExecutorUtils.*; -import static io.onedev.k8shelper.KubernetesHelper.*; -import static io.onedev.k8shelper.RegistryLoginFacade.merge; -import static java.util.stream.Collectors.toList; @Editable(order=ServerDockerExecutor.ORDER, name="Server Docker Executor", description="This executor runs build jobs as docker containers on OneDev server") @@ -226,11 +274,7 @@ public class ServerDockerExecutor extends JobExecutor implements RegistryLoginAw private ClusterManager getClusterManager() { return OneDev.getInstance(ClusterManager.class); } - - private SettingManager getSettingManager() { - return OneDev.getInstance(SettingManager.class); - } - + private JobManager getJobManager() { return OneDev.getInstance(JobManager.class); } diff --git a/server-plugin/server-plugin-import-bitbucketcloud/src/main/java/io/onedev/server/plugin/imports/bitbucketcloud/ImportRepositories.java b/server-plugin/server-plugin-import-bitbucketcloud/src/main/java/io/onedev/server/plugin/imports/bitbucketcloud/ImportRepositories.java index 29b9f7f553..0eee26246c 100644 --- a/server-plugin/server-plugin-import-bitbucketcloud/src/main/java/io/onedev/server/plugin/imports/bitbucketcloud/ImportRepositories.java +++ b/server-plugin/server-plugin-import-bitbucketcloud/src/main/java/io/onedev/server/plugin/imports/bitbucketcloud/ImportRepositories.java @@ -42,6 +42,7 @@ public class ImportRepositories extends ImportWorkspace implements Validatable { this.parentOneDevProject = parentOneDevProject; } + @SuppressWarnings("unused") private static List getParentOneDevProjectChoices() { return SecurityUtils.getAuthorizedProjects(new CreateChildren()).stream() .map(it->it.getPath()).sorted().collect(Collectors.toList()); @@ -60,6 +61,7 @@ public class ImportRepositories extends ImportWorkspace implements Validatable { return (Boolean)EditContext.get().getInputValue("all"); } + @SuppressWarnings("unused") private static boolean isAllDisabled() { return !isAllEnabled(); } @@ -86,6 +88,7 @@ public class ImportRepositories extends ImportWorkspace implements Validatable { this.bitbucketRepositories = bitbucketRepositories; } + @SuppressWarnings("unused") private static List getBitbucketRepositoryChoices() { BeanEditor editor = ComponentContext.get().getComponent().findParent(BeanEditor.class); ImportRepositories repositories = (ImportRepositories) editor.getModelObject(); diff --git a/server-plugin/server-plugin-import-gitea/src/main/java/io/onedev/server/plugin/imports/gitea/GiteaIssueImporter.java b/server-plugin/server-plugin-import-gitea/src/main/java/io/onedev/server/plugin/imports/gitea/GiteaIssueImporter.java index b6c68d06c7..da679c4708 100644 --- a/server-plugin/server-plugin-import-gitea/src/main/java/io/onedev/server/plugin/imports/gitea/GiteaIssueImporter.java +++ b/server-plugin/server-plugin-import-gitea/src/main/java/io/onedev/server/plugin/imports/gitea/GiteaIssueImporter.java @@ -1,23 +1,22 @@ package io.onedev.server.plugin.imports.gitea; -import com.google.common.collect.Lists; -import io.onedev.commons.utils.TaskLogger; -import io.onedev.server.OneDev; -import io.onedev.server.entitymanager.ProjectManager; -import io.onedev.server.imports.IssueImporter; -import io.onedev.server.model.Project; -import io.onedev.server.model.User; -import io.onedev.server.persistence.TransactionManager; -import io.onedev.server.web.component.taskbutton.TaskResult; -import io.onedev.server.web.component.taskbutton.TaskResult.HtmlMessgae; -import io.onedev.server.web.util.ImportStep; - import java.io.Serializable; import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.Optional; +import com.google.common.collect.Lists; + +import io.onedev.commons.utils.TaskLogger; +import io.onedev.server.OneDev; +import io.onedev.server.entitymanager.ProjectManager; +import io.onedev.server.imports.IssueImporter; +import io.onedev.server.persistence.TransactionManager; +import io.onedev.server.web.component.taskbutton.TaskResult; +import io.onedev.server.web.component.taskbutton.TaskResult.HtmlMessgae; +import io.onedev.server.web.util.ImportStep; + public class GiteaIssueImporter implements IssueImporter { private static final long serialVersionUID = 1L; diff --git a/server-plugin/server-plugin-import-gitea/src/main/java/io/onedev/server/plugin/imports/gitea/ImportRepositories.java b/server-plugin/server-plugin-import-gitea/src/main/java/io/onedev/server/plugin/imports/gitea/ImportRepositories.java index 4309e5256b..4637f46456 100644 --- a/server-plugin/server-plugin-import-gitea/src/main/java/io/onedev/server/plugin/imports/gitea/ImportRepositories.java +++ b/server-plugin/server-plugin-import-gitea/src/main/java/io/onedev/server/plugin/imports/gitea/ImportRepositories.java @@ -44,6 +44,7 @@ public class ImportRepositories extends ImportOrganization implements Validatabl this.parentOneDevProject = parentOneDevProject; } + @SuppressWarnings("unused") private static List getParentOneDevProjectChoices() { ProjectManager projectManager = OneDev.getInstance(ProjectManager.class); return SecurityUtils.getAuthorizedProjects(new CreateChildren()).stream() @@ -63,6 +64,7 @@ public class ImportRepositories extends ImportOrganization implements Validatabl return (Boolean)EditContext.get().getInputValue("all"); } + @SuppressWarnings("unused") private static boolean isAllDisabled() { return !isAllEnabled(); } @@ -89,6 +91,7 @@ public class ImportRepositories extends ImportOrganization implements Validatabl this.giteaRepositories = giteaRepositories; } + @SuppressWarnings("unused") private static List getGiteaRepositoryChoices() { BeanEditor editor = ComponentContext.get().getComponent().findParent(BeanEditor.class); ImportRepositories repositories = (ImportRepositories) editor.getModelObject(); diff --git a/server-plugin/server-plugin-import-github/src/main/java/io/onedev/server/plugin/imports/github/GitHubIssueImporter.java b/server-plugin/server-plugin-import-github/src/main/java/io/onedev/server/plugin/imports/github/GitHubIssueImporter.java index 2c3adf586f..7d36582164 100644 --- a/server-plugin/server-plugin-import-github/src/main/java/io/onedev/server/plugin/imports/github/GitHubIssueImporter.java +++ b/server-plugin/server-plugin-import-github/src/main/java/io/onedev/server/plugin/imports/github/GitHubIssueImporter.java @@ -1,23 +1,22 @@ package io.onedev.server.plugin.imports.github; -import com.google.common.collect.Lists; -import io.onedev.commons.utils.TaskLogger; -import io.onedev.server.OneDev; -import io.onedev.server.entitymanager.ProjectManager; -import io.onedev.server.imports.IssueImporter; -import io.onedev.server.model.Project; -import io.onedev.server.model.User; -import io.onedev.server.persistence.TransactionManager; -import io.onedev.server.web.component.taskbutton.TaskResult; -import io.onedev.server.web.component.taskbutton.TaskResult.HtmlMessgae; -import io.onedev.server.web.util.ImportStep; - import java.io.Serializable; import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.Optional; +import com.google.common.collect.Lists; + +import io.onedev.commons.utils.TaskLogger; +import io.onedev.server.OneDev; +import io.onedev.server.entitymanager.ProjectManager; +import io.onedev.server.imports.IssueImporter; +import io.onedev.server.persistence.TransactionManager; +import io.onedev.server.web.component.taskbutton.TaskResult; +import io.onedev.server.web.component.taskbutton.TaskResult.HtmlMessgae; +import io.onedev.server.web.util.ImportStep; + public class GitHubIssueImporter implements IssueImporter { private static final long serialVersionUID = 1L; diff --git a/server-plugin/server-plugin-import-github/src/main/java/io/onedev/server/plugin/imports/github/ImportRepositories.java b/server-plugin/server-plugin-import-github/src/main/java/io/onedev/server/plugin/imports/github/ImportRepositories.java index 2eaacd2518..ea33b4eb37 100644 --- a/server-plugin/server-plugin-import-github/src/main/java/io/onedev/server/plugin/imports/github/ImportRepositories.java +++ b/server-plugin/server-plugin-import-github/src/main/java/io/onedev/server/plugin/imports/github/ImportRepositories.java @@ -42,6 +42,7 @@ public class ImportRepositories extends ImportOrganization implements Validatabl this.parentOneDevProject = parentOneDevProject; } + @SuppressWarnings("unused") private static List getParentOneDevProjectChoices() { return SecurityUtils.getAuthorizedProjects(new CreateChildren()).stream() .map(it->it.getPath()).sorted().collect(Collectors.toList()); @@ -60,6 +61,7 @@ public class ImportRepositories extends ImportOrganization implements Validatabl return (Boolean)EditContext.get().getInputValue("all"); } + @SuppressWarnings("unused") private static boolean isAllDisabled() { return !isAllEnabled(); } @@ -86,6 +88,7 @@ public class ImportRepositories extends ImportOrganization implements Validatabl this.gitHubRepositories = gitHubRepositories; } + @SuppressWarnings("unused") private static List getGitHubRepositoryChoices() { BeanEditor editor = ComponentContext.get().getComponent().findParent(BeanEditor.class); ImportRepositories repositories = (ImportRepositories) editor.getModelObject(); diff --git a/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/GitLabIssueImporter.java b/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/GitLabIssueImporter.java index d3e87b5fc0..763e4d1160 100644 --- a/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/GitLabIssueImporter.java +++ b/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/GitLabIssueImporter.java @@ -1,23 +1,22 @@ package io.onedev.server.plugin.imports.gitlab; -import com.google.common.collect.Lists; -import io.onedev.commons.utils.TaskLogger; -import io.onedev.server.OneDev; -import io.onedev.server.entitymanager.ProjectManager; -import io.onedev.server.imports.IssueImporter; -import io.onedev.server.model.Project; -import io.onedev.server.model.User; -import io.onedev.server.persistence.TransactionManager; -import io.onedev.server.web.component.taskbutton.TaskResult; -import io.onedev.server.web.component.taskbutton.TaskResult.HtmlMessgae; -import io.onedev.server.web.util.ImportStep; - import java.io.Serializable; import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.Optional; +import com.google.common.collect.Lists; + +import io.onedev.commons.utils.TaskLogger; +import io.onedev.server.OneDev; +import io.onedev.server.entitymanager.ProjectManager; +import io.onedev.server.imports.IssueImporter; +import io.onedev.server.persistence.TransactionManager; +import io.onedev.server.web.component.taskbutton.TaskResult; +import io.onedev.server.web.component.taskbutton.TaskResult.HtmlMessgae; +import io.onedev.server.web.util.ImportStep; + public class GitLabIssueImporter implements IssueImporter { private static final long serialVersionUID = 1L; diff --git a/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/ImportGroup.java b/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/ImportGroup.java index af3f0d5525..83a6becd88 100644 --- a/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/ImportGroup.java +++ b/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/ImportGroup.java @@ -1,13 +1,13 @@ package io.onedev.server.plugin.imports.gitlab; +import java.io.Serializable; +import java.util.Map; + import io.onedev.server.annotation.ChoiceProvider; import io.onedev.server.annotation.Editable; import io.onedev.server.util.ComponentContext; import io.onedev.server.web.editable.BeanEditor; -import java.io.Serializable; -import java.util.Map; - @Editable public class ImportGroup implements Serializable { @@ -16,9 +16,7 @@ public class ImportGroup implements Serializable { ImportServer server; private String groupId; - - private boolean includeForks; - + @Editable(order=100, name="GitLab Group", description="Specify group to import from. " + "Leave empty to import from projects under current account") @ChoiceProvider("getGroupChoices") diff --git a/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/ImportProjects.java b/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/ImportProjects.java index 6f5c77997c..59e6e56f22 100644 --- a/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/ImportProjects.java +++ b/server-plugin/server-plugin-import-gitlab/src/main/java/io/onedev/server/plugin/imports/gitlab/ImportProjects.java @@ -49,6 +49,7 @@ public class ImportProjects extends ImportGroup { return (Boolean)EditContext.get().getInputValue("all"); } + @SuppressWarnings("unused") private static boolean isAllDisabled() { return !isAllEnabled(); } @@ -75,6 +76,7 @@ public class ImportProjects extends ImportGroup { this.gitLabProjects = gitLabProjects; } + @SuppressWarnings("unused") private static List getGitLabProjectChoices() { BeanEditor editor = ComponentContext.get().getComponent().findParent(BeanEditor.class); ImportProjects projects = (ImportProjects) editor.getModelObject(); diff --git a/server-plugin/server-plugin-import-jiracloud/src/main/java/io/onedev/server/plugin/imports/jiracloud/ImportProjects.java b/server-plugin/server-plugin-import-jiracloud/src/main/java/io/onedev/server/plugin/imports/jiracloud/ImportProjects.java index a8bba6a8d5..32f690681c 100644 --- a/server-plugin/server-plugin-import-jiracloud/src/main/java/io/onedev/server/plugin/imports/jiracloud/ImportProjects.java +++ b/server-plugin/server-plugin-import-jiracloud/src/main/java/io/onedev/server/plugin/imports/jiracloud/ImportProjects.java @@ -43,6 +43,7 @@ public class ImportProjects implements Serializable, Validatable { this.parentOneDevProject = parentOneDevProject; } + @SuppressWarnings("unused") private static List getParentOneDevProjectChoices() { return SecurityUtils.getAuthorizedProjects(new CreateChildren()).stream() .map(it->it.getPath()).sorted().collect(Collectors.toList()); @@ -57,6 +58,7 @@ public class ImportProjects implements Serializable, Validatable { this.all = all; } + @SuppressWarnings("unused") private static boolean isAllDisabled() { return !(Boolean) EditContext.get().getInputValue("all"); } @@ -73,6 +75,7 @@ public class ImportProjects implements Serializable, Validatable { this.jiraProjects = jiraProjects; } + @SuppressWarnings("unused") private static List getJiraProjectChoices() { BeanEditor editor = ComponentContext.get().getComponent().findParent(BeanEditor.class); ImportProjects projects = (ImportProjects) editor.getModelObject(); diff --git a/server-plugin/server-plugin-import-youtrack/src/main/java/io/onedev/server/plugin/imports/youtrack/ImportProjects.java b/server-plugin/server-plugin-import-youtrack/src/main/java/io/onedev/server/plugin/imports/youtrack/ImportProjects.java index d009328f94..9c0c7d744e 100644 --- a/server-plugin/server-plugin-import-youtrack/src/main/java/io/onedev/server/plugin/imports/youtrack/ImportProjects.java +++ b/server-plugin/server-plugin-import-youtrack/src/main/java/io/onedev/server/plugin/imports/youtrack/ImportProjects.java @@ -1,11 +1,17 @@ package io.onedev.server.plugin.imports.youtrack; -import io.onedev.server.OneDev; +import java.io.Serializable; +import java.util.Collection; +import java.util.List; +import java.util.stream.Collectors; + +import javax.validation.ConstraintValidatorContext; +import javax.validation.constraints.Size; + import io.onedev.server.annotation.ChoiceProvider; import io.onedev.server.annotation.ClassValidating; import io.onedev.server.annotation.Editable; import io.onedev.server.annotation.ShowCondition; -import io.onedev.server.entitymanager.ProjectManager; import io.onedev.server.security.SecurityUtils; import io.onedev.server.security.permission.CreateChildren; import io.onedev.server.util.ComponentContext; @@ -13,13 +19,6 @@ import io.onedev.server.util.EditContext; import io.onedev.server.validation.Validatable; import io.onedev.server.web.editable.BeanEditor; -import javax.validation.ConstraintValidatorContext; -import javax.validation.constraints.Size; -import java.io.Serializable; -import java.util.Collection; -import java.util.List; -import java.util.stream.Collectors; - @Editable @ClassValidating public class ImportProjects implements Serializable, Validatable { @@ -47,6 +46,7 @@ public class ImportProjects implements Serializable, Validatable { this.parentOneDevProject = parentOneDevProject; } + @SuppressWarnings("unused") private static List getParentOneDevProjectChoices() { return SecurityUtils.getAuthorizedProjects(new CreateChildren()).stream() .map(it->it.getPath()).sorted().collect(Collectors.toList()); @@ -61,6 +61,7 @@ public class ImportProjects implements Serializable, Validatable { this.all = all; } + @SuppressWarnings("unused") private static boolean isAllDisabled() { return !(Boolean) EditContext.get().getInputValue("all"); } @@ -77,6 +78,7 @@ public class ImportProjects implements Serializable, Validatable { this.youTrackProjects = youTrackProjects; } + @SuppressWarnings("unused") private static List getYouTrackProjectChoices() { BeanEditor editor = ComponentContext.get().getComponent().findParent(BeanEditor.class); ImportProjects projects = (ImportProjects) editor.getModelObject(); diff --git a/server-plugin/server-plugin-import-youtrack/src/main/java/io/onedev/server/plugin/imports/youtrack/ImportResult.java b/server-plugin/server-plugin-import-youtrack/src/main/java/io/onedev/server/plugin/imports/youtrack/ImportResult.java index 3c37b53548..c9d0d38ce6 100644 --- a/server-plugin/server-plugin-import-youtrack/src/main/java/io/onedev/server/plugin/imports/youtrack/ImportResult.java +++ b/server-plugin/server-plugin-import-youtrack/src/main/java/io/onedev/server/plugin/imports/youtrack/ImportResult.java @@ -1,11 +1,17 @@ package io.onedev.server.plugin.imports.youtrack; -import io.onedev.server.model.Issue; -import io.onedev.server.model.LinkSpec; -import io.onedev.server.util.Pair; +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashMap; +import java.util.LinkedHashMap; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; + import org.unbescape.html.HtmlEscape; -import java.util.*; +import io.onedev.server.util.Pair; public class ImportResult { diff --git a/server-plugin/server-plugin-mailservice-office365/src/main/java/io/onedev/server/plugin/mailservice/office365/Office365MailService.java b/server-plugin/server-plugin-mailservice-office365/src/main/java/io/onedev/server/plugin/mailservice/office365/Office365MailService.java index 42060e5ac3..351ebbaeea 100644 --- a/server-plugin/server-plugin-mailservice-office365/src/main/java/io/onedev/server/plugin/mailservice/office365/Office365MailService.java +++ b/server-plugin/server-plugin-mailservice-office365/src/main/java/io/onedev/server/plugin/mailservice/office365/Office365MailService.java @@ -143,6 +143,7 @@ public class Office365MailService implements MailService { return String.format("https://login.microsoftonline.com/%s/oauth2/v2.0/token", tenantId); } + @SuppressWarnings("unused") private static RefreshToken.Callback getRefreshTokenCallback() { String tenantId = (String) EditContext.get().getInputValue("tenantId"); if (tenantId == null) diff --git a/server-plugin/server-plugin-pack-container/src/main/java/io/onedev/server/plugin/pack/container/ContainerModule.java b/server-plugin/server-plugin-pack-container/src/main/java/io/onedev/server/plugin/pack/container/ContainerModule.java index fd62daae20..dde4a658e7 100644 --- a/server-plugin/server-plugin-pack-container/src/main/java/io/onedev/server/plugin/pack/container/ContainerModule.java +++ b/server-plugin/server-plugin-pack-container/src/main/java/io/onedev/server/plugin/pack/container/ContainerModule.java @@ -1,17 +1,12 @@ package io.onedev.server.plugin.pack.container; -import java.util.Collection; - -import com.google.common.collect.Sets; +import org.eclipse.jetty.servlet.ServletHolder; import io.onedev.commons.loader.AbstractPluginModule; -import io.onedev.commons.loader.ImplementationProvider; import io.onedev.server.OneDev; -import io.onedev.server.buildspec.step.PublishReportStep; import io.onedev.server.jetty.ServletConfigurator; import io.onedev.server.pack.PackSupport; import io.onedev.server.security.FilterChainConfigurator; -import org.eclipse.jetty.servlet.ServletHolder; /** * NOTE: Do not forget to rename moduleClass property defined in the pom if you've renamed this class. diff --git a/server-plugin/server-plugin-pack-gem/src/main/java/io/onedev/server/plugin/pack/gem/GemHelpPanel.java b/server-plugin/server-plugin-pack-gem/src/main/java/io/onedev/server/plugin/pack/gem/GemHelpPanel.java index 4e2d5bb10b..95e436c4d0 100644 --- a/server-plugin/server-plugin-pack-gem/src/main/java/io/onedev/server/plugin/pack/gem/GemHelpPanel.java +++ b/server-plugin/server-plugin-pack-gem/src/main/java/io/onedev/server/plugin/pack/gem/GemHelpPanel.java @@ -1,13 +1,13 @@ package io.onedev.server.plugin.pack.gem; +import static io.onedev.server.plugin.pack.gem.GemPackService.SERVICE_ID; + +import org.apache.wicket.markup.html.panel.Panel; +import org.apache.wicket.model.Model; + import io.onedev.server.OneDev; import io.onedev.server.entitymanager.SettingManager; import io.onedev.server.web.component.codesnippet.CodeSnippetPanel; -import org.apache.wicket.markup.html.basic.Label; -import org.apache.wicket.markup.html.panel.Panel; -import org.apache.wicket.model.Model; - -import static io.onedev.server.plugin.pack.gem.GemPackService.SERVICE_ID; public class GemHelpPanel extends Panel { diff --git a/server-plugin/server-plugin-pack-gem/src/main/java/io/onedev/server/plugin/pack/gem/GemPackService.java b/server-plugin/server-plugin-pack-gem/src/main/java/io/onedev/server/plugin/pack/gem/GemPackService.java index 0f0976281d..cca2b6f8ab 100644 --- a/server-plugin/server-plugin-pack-gem/src/main/java/io/onedev/server/plugin/pack/gem/GemPackService.java +++ b/server-plugin/server-plugin-pack-gem/src/main/java/io/onedev/server/plugin/pack/gem/GemPackService.java @@ -96,6 +96,7 @@ public class GemPackService implements PackService { return "update-pack:" + projectId + ":" + TYPE + ":" + name; } + @SuppressWarnings("deprecation") @Override public void service(HttpServletRequest request, HttpServletResponse response, Long projectId, Long buildId, List pathSegments) { diff --git a/server-plugin/server-plugin-pack-nuget/src/main/java/io/onedev/server/plugin/pack/nuget/NugetPackService.java b/server-plugin/server-plugin-pack-nuget/src/main/java/io/onedev/server/plugin/pack/nuget/NugetPackService.java index 016bdf8f81..2adb5e63c9 100644 --- a/server-plugin/server-plugin-pack-nuget/src/main/java/io/onedev/server/plugin/pack/nuget/NugetPackService.java +++ b/server-plugin/server-plugin-pack-nuget/src/main/java/io/onedev/server/plugin/pack/nuget/NugetPackService.java @@ -1,7 +1,62 @@ package io.onedev.server.plugin.pack.nuget; +import static com.google.common.collect.Lists.newArrayList; +import static io.onedev.server.plugin.pack.nuget.NugetPackSupport.TYPE; +import static io.onedev.server.util.IOUtils.BUFFER_SIZE; +import static io.onedev.server.util.IOUtils.copyWithMaxSize; +import static io.onedev.server.util.UrlUtils.decodePath; +import static io.onedev.server.util.UrlUtils.decodeQuery; +import static io.onedev.server.util.UrlUtils.encodePath; +import static java.time.format.DateTimeFormatter.ISO_OFFSET_DATE_TIME; +import static java.util.stream.Collectors.toList; +import static javax.servlet.http.HttpServletResponse.SC_BAD_REQUEST; +import static javax.servlet.http.HttpServletResponse.SC_CONFLICT; +import static javax.servlet.http.HttpServletResponse.SC_CREATED; +import static javax.servlet.http.HttpServletResponse.SC_METHOD_NOT_ALLOWED; +import static javax.servlet.http.HttpServletResponse.SC_NOT_ACCEPTABLE; +import static javax.servlet.http.HttpServletResponse.SC_NOT_FOUND; +import static javax.servlet.http.HttpServletResponse.SC_NO_CONTENT; +import static javax.servlet.http.HttpServletResponse.SC_OK; +import static javax.servlet.http.HttpServletResponse.SC_REQUEST_ENTITY_TOO_LARGE; + +import java.io.BufferedInputStream; +import java.io.BufferedOutputStream; +import java.io.ByteArrayInputStream; +import java.io.ByteArrayOutputStream; +import java.io.FileInputStream; +import java.io.FileOutputStream; +import java.io.IOException; +import java.text.ParseException; +import java.time.ZoneId; +import java.util.ArrayList; +import java.util.Comparator; +import java.util.Date; +import java.util.HashMap; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import java.util.zip.ZipEntry; +import java.util.zip.ZipInputStream; + +import javax.inject.Inject; +import javax.inject.Singleton; +import javax.servlet.http.HttpServletRequest; +import javax.servlet.http.HttpServletResponse; + +import org.apache.commons.fileupload.FileUploadException; +import org.apache.commons.fileupload.servlet.ServletFileUpload; +import org.apache.commons.io.IOUtils; +import org.apache.shiro.authz.UnauthorizedException; +import org.dom4j.Document; +import org.dom4j.DocumentException; +import org.dom4j.Element; +import org.dom4j.io.SAXReader; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import com.fasterxml.jackson.databind.ObjectMapper; import com.google.common.collect.Lists; + import io.onedev.commons.utils.ExplicitException; import io.onedev.commons.utils.FileUtils; import io.onedev.commons.utils.LockUtils; @@ -21,36 +76,6 @@ import io.onedev.server.security.SecurityUtils; import io.onedev.server.util.SemanticVersion; import io.onedev.server.util.XmlUtils; import io.onedev.server.web.UrlManager; -import org.apache.commons.compress.utils.IOUtils; -import org.apache.commons.fileupload.FileUploadException; -import org.apache.commons.fileupload.servlet.ServletFileUpload; -import org.apache.shiro.authz.UnauthorizedException; -import org.dom4j.Document; -import org.dom4j.DocumentException; -import org.dom4j.Element; -import org.dom4j.io.SAXReader; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -import javax.inject.Inject; -import javax.inject.Singleton; -import javax.servlet.http.HttpServletRequest; -import javax.servlet.http.HttpServletResponse; -import java.io.*; -import java.text.ParseException; -import java.time.ZoneId; -import java.util.*; -import java.util.zip.ZipEntry; -import java.util.zip.ZipInputStream; - -import static com.google.common.collect.Lists.newArrayList; -import static io.onedev.server.plugin.pack.nuget.NugetPackSupport.TYPE; -import static io.onedev.server.util.IOUtils.BUFFER_SIZE; -import static io.onedev.server.util.IOUtils.copyWithMaxSize; -import static io.onedev.server.util.UrlUtils.*; -import static java.time.format.DateTimeFormatter.ISO_OFFSET_DATE_TIME; -import static java.util.stream.Collectors.toList; -import static javax.servlet.http.HttpServletResponse.*; @Singleton public class NugetPackService implements PackService { diff --git a/server-plugin/server-plugin-pack-nuget/src/main/java/io/onedev/server/plugin/pack/nuget/NugetPackSupport.java b/server-plugin/server-plugin-pack-nuget/src/main/java/io/onedev/server/plugin/pack/nuget/NugetPackSupport.java index 9edc5dc691..73889894d3 100644 --- a/server-plugin/server-plugin-pack-nuget/src/main/java/io/onedev/server/plugin/pack/nuget/NugetPackSupport.java +++ b/server-plugin/server-plugin-pack-nuget/src/main/java/io/onedev/server/plugin/pack/nuget/NugetPackSupport.java @@ -1,14 +1,13 @@ package io.onedev.server.plugin.pack.nuget; +import org.apache.wicket.Component; +import org.apache.wicket.model.LoadableDetachableModel; + import io.onedev.server.OneDev; import io.onedev.server.entitymanager.PackManager; import io.onedev.server.model.Pack; import io.onedev.server.model.Project; import io.onedev.server.pack.PackSupport; -import org.apache.wicket.Component; -import org.apache.wicket.model.LoadableDetachableModel; - -import javax.servlet.http.HttpServletRequest; public class NugetPackSupport implements PackSupport { diff --git a/server-plugin/server-plugin-pack-pypi/src/main/java/io/onedev/server/plugin/pack/pypi/PypiData.java b/server-plugin/server-plugin-pack-pypi/src/main/java/io/onedev/server/plugin/pack/pypi/PypiData.java index 94748376f6..5d35abaf20 100644 --- a/server-plugin/server-plugin-pack-pypi/src/main/java/io/onedev/server/plugin/pack/pypi/PypiData.java +++ b/server-plugin/server-plugin-pack-pypi/src/main/java/io/onedev/server/plugin/pack/pypi/PypiData.java @@ -1,7 +1,6 @@ package io.onedev.server.plugin.pack.pypi; import java.io.Serializable; -import java.util.LinkedHashMap; import java.util.List; import java.util.Map; diff --git a/server-plugin/server-plugin-report-cobertura/src/test/java/io/onedev/server/plugin/report/cobertura/PublishCoberturaReportStepTest.java b/server-plugin/server-plugin-report-cobertura/src/test/java/io/onedev/server/plugin/report/cobertura/PublishCoberturaReportStepTest.java index 340c301188..ffd415e3a2 100644 --- a/server-plugin/server-plugin-report-cobertura/src/test/java/io/onedev/server/plugin/report/cobertura/PublishCoberturaReportStepTest.java +++ b/server-plugin/server-plugin-report-cobertura/src/test/java/io/onedev/server/plugin/report/cobertura/PublishCoberturaReportStepTest.java @@ -6,7 +6,7 @@ import io.onedev.commons.utils.TaskLogger; import io.onedev.server.codequality.CoverageStatus; import io.onedev.server.model.Build; import io.onedev.server.plugin.report.coverage.FileCoverage; -import org.apache.commons.compress.utils.IOUtils; +import org.apache.commons.io.IOUtils; import org.jetbrains.annotations.Nullable; import org.junit.Test; diff --git a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageModule.java b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageModule.java index 9b18b1f78f..ca0beec0cd 100644 --- a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageModule.java +++ b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageModule.java @@ -1,5 +1,29 @@ package io.onedev.server.plugin.report.coverage; +import static io.onedev.commons.utils.LockUtils.read; +import static io.onedev.server.model.Build.getProjectRelativeDirPath; +import static io.onedev.server.plugin.report.coverage.CoverageStats.CATEGORY; +import static io.onedev.server.plugin.report.coverage.CoverageStats.getReportLockName; +import static io.onedev.server.util.DirectoryVersionUtils.isVersionFile; + +import java.io.BufferedInputStream; +import java.io.File; +import java.io.FileInputStream; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +import javax.annotation.Nullable; + +import org.apache.commons.lang.SerializationException; +import org.apache.commons.lang.SerializationUtils; +import org.apache.wicket.request.mapper.parameter.PageParameters; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import io.onedev.commons.loader.AbstractPluginModule; import io.onedev.server.OneDev; import io.onedev.server.cluster.ClusterTask; @@ -20,25 +44,6 @@ import io.onedev.server.web.page.project.StatisticsMenuContribution; import io.onedev.server.web.page.project.builds.detail.BuildTab; import io.onedev.server.web.page.project.builds.detail.BuildTabContribution; import io.onedev.server.web.page.project.builds.detail.report.BuildReportTab; -import org.apache.commons.lang.SerializationException; -import org.apache.commons.lang.SerializationUtils; -import org.apache.wicket.request.mapper.parameter.PageParameters; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -import javax.annotation.Nullable; -import java.io.BufferedInputStream; -import java.io.File; -import java.io.FileInputStream; -import java.io.InputStream; -import java.util.*; -import java.util.stream.Collectors; - -import static io.onedev.commons.utils.LockUtils.read; -import static io.onedev.server.model.Build.getProjectRelativeDirPath; -import static io.onedev.server.plugin.report.coverage.CoverageStats.CATEGORY; -import static io.onedev.server.plugin.report.coverage.CoverageStats.getReportLockName; -import static io.onedev.server.util.DirectoryVersionUtils.isVersionFile; /** * NOTE: Do not forget to rename moduleClass property defined in the pom if you've renamed this class. @@ -175,6 +180,7 @@ public class CoverageModule extends AbstractPluginModule { this.reportName = reportName; } + @SuppressWarnings("unchecked") @Override public Map> call() { return read(getReportLockName(projectId, buildNumber), () -> { diff --git a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoveragePanel.java b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoveragePanel.java index fccd8e88eb..f21072ba88 100644 --- a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoveragePanel.java +++ b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoveragePanel.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.html.panel.GenericPanel; import org.apache.wicket.model.AbstractReadOnlyModel; import org.apache.wicket.model.IModel; -@SuppressWarnings("serial") class CoveragePanel extends GenericPanel { public CoveragePanel(String id, IModel model) { diff --git a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageReportPage.java b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageReportPage.java index 407465ba31..4b09865b84 100644 --- a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageReportPage.java +++ b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageReportPage.java @@ -61,7 +61,6 @@ import java.util.concurrent.Callable; import static java.util.stream.Collectors.toList; -@SuppressWarnings("serial") public class CoverageReportPage extends BuildReportPage { private static final String PARAM_GROUP = "group"; diff --git a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageStats.java b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageStats.java index f18a3e52dd..c640014644 100644 --- a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageStats.java +++ b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageStats.java @@ -1,5 +1,7 @@ package io.onedev.server.plugin.report.coverage; +import static io.onedev.server.util.IOUtils.BUFFER_SIZE; + import java.io.BufferedInputStream; import java.io.BufferedOutputStream; import java.io.File; @@ -7,14 +9,12 @@ import java.io.FileInputStream; import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; -import java.io.OutputStream; import java.io.Serializable; import java.util.List; -import io.onedev.server.model.Build; import org.apache.commons.lang3.SerializationUtils; -import static io.onedev.server.util.IOUtils.BUFFER_SIZE; +import io.onedev.server.model.Build; public class CoverageStats implements Serializable { diff --git a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageStatsPage.java b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageStatsPage.java index e8ecf52326..c8f16ddd72 100644 --- a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageStatsPage.java +++ b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/CoverageStatsPage.java @@ -7,7 +7,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.model.CoverageMetric; import io.onedev.server.web.page.project.stats.buildmetric.BuildMetricStatsPage; -@SuppressWarnings("serial") public class CoverageStatsPage extends BuildMetricStatsPage { public CoverageStatsPage(PageParameters params) { diff --git a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/PercentageBar.java b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/PercentageBar.java index 5f0f7cf4d7..5ad95d4532 100644 --- a/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/PercentageBar.java +++ b/server-plugin/server-plugin-report-coverage/src/main/java/io/onedev/server/plugin/report/coverage/PercentageBar.java @@ -6,7 +6,6 @@ import org.apache.wicket.markup.html.panel.GenericPanel; import org.apache.wicket.model.IModel; import org.apache.wicket.model.LoadableDetachableModel; -@SuppressWarnings("serial") public class PercentageBar extends GenericPanel { public PercentageBar(String id, IModel model) { diff --git a/server-plugin/server-plugin-report-cppcheck/src/main/java/io/onedev/server/plugin/report/cppcheck/PublishCppcheckReportStep.java b/server-plugin/server-plugin-report-cppcheck/src/main/java/io/onedev/server/plugin/report/cppcheck/PublishCppcheckReportStep.java index 22fc09921d..5b007f87f3 100644 --- a/server-plugin/server-plugin-report-cppcheck/src/main/java/io/onedev/server/plugin/report/cppcheck/PublishCppcheckReportStep.java +++ b/server-plugin/server-plugin-report-cppcheck/src/main/java/io/onedev/server/plugin/report/cppcheck/PublishCppcheckReportStep.java @@ -1,12 +1,22 @@ package io.onedev.server.plugin.report.cppcheck; -import com.fasterxml.jackson.databind.ObjectMapper; +import java.io.File; +import java.io.StringReader; +import java.nio.charset.StandardCharsets; +import java.util.ArrayList; +import java.util.List; + +import javax.validation.constraints.NotEmpty; + +import org.dom4j.Document; +import org.dom4j.io.SAXReader; + import com.google.common.collect.Lists; + import io.onedev.commons.codeassist.InputSuggestion; import io.onedev.commons.utils.ExceptionUtils; import io.onedev.commons.utils.FileUtils; import io.onedev.commons.utils.TaskLogger; -import io.onedev.server.OneDev; import io.onedev.server.annotation.Editable; import io.onedev.server.annotation.Interpolative; import io.onedev.server.annotation.Patterns; @@ -16,15 +26,6 @@ import io.onedev.server.codequality.CodeProblem; import io.onedev.server.model.Build; import io.onedev.server.plugin.report.problem.PublishProblemReportStep; import io.onedev.server.util.XmlUtils; -import org.dom4j.Document; -import org.dom4j.io.SAXReader; - -import javax.validation.constraints.NotEmpty; -import java.io.File; -import java.io.StringReader; -import java.nio.charset.StandardCharsets; -import java.util.ArrayList; -import java.util.List; @Editable(order=10000, group=StepGroup.PUBLISH, name="Cppcheck Report") public class PublishCppcheckReportStep extends PublishProblemReportStep { diff --git a/server-plugin/server-plugin-report-gtest/src/main/java/io/onedev/server/plugin/report/gtest/GTestReportParser.java b/server-plugin/server-plugin-report-gtest/src/main/java/io/onedev/server/plugin/report/gtest/GTestReportParser.java index a4ddb27e6c..c24e494086 100644 --- a/server-plugin/server-plugin-report-gtest/src/main/java/io/onedev/server/plugin/report/gtest/GTestReportParser.java +++ b/server-plugin/server-plugin-report-gtest/src/main/java/io/onedev/server/plugin/report/gtest/GTestReportParser.java @@ -1,14 +1,8 @@ package io.onedev.server.plugin.report.gtest; -import io.onedev.commons.utils.PlanarRange; -import io.onedev.commons.utils.StringUtils; -import io.onedev.server.git.BlobIdent; -import io.onedev.server.model.Build; -import io.onedev.server.plugin.report.unittest.UnitTestReport.Status; -import io.onedev.server.plugin.report.unittest.UnitTestReport.TestCase; -import io.onedev.server.plugin.report.unittest.UnitTestReport.TestSuite; -import io.onedev.server.web.page.project.blob.ProjectBlobPage; -import io.onedev.server.web.page.project.blob.render.BlobRenderer; +import java.util.ArrayList; +import java.util.List; + import org.apache.commons.lang3.math.NumberUtils; import org.apache.commons.lang3.tuple.ImmutablePair; import org.apache.commons.lang3.tuple.Pair; @@ -20,10 +14,15 @@ import org.dom4j.Document; import org.dom4j.Element; import org.jetbrains.annotations.Nullable; -import java.util.ArrayList; -import java.util.List; - -import static org.unbescape.html.HtmlEscape.escapeHtml5; +import io.onedev.commons.utils.PlanarRange; +import io.onedev.commons.utils.StringUtils; +import io.onedev.server.git.BlobIdent; +import io.onedev.server.model.Build; +import io.onedev.server.plugin.report.unittest.UnitTestReport.Status; +import io.onedev.server.plugin.report.unittest.UnitTestReport.TestCase; +import io.onedev.server.plugin.report.unittest.UnitTestReport.TestSuite; +import io.onedev.server.web.page.project.blob.ProjectBlobPage; +import io.onedev.server.web.page.project.blob.render.BlobRenderer; public class GTestReportParser { diff --git a/server-plugin/server-plugin-report-jest/src/test/java/io/onedev/server/plugin/report/jest/JestReportParserTest.java b/server-plugin/server-plugin-report-jest/src/test/java/io/onedev/server/plugin/report/jest/JestReportParserTest.java index 8b112d8a9a..b808e57809 100644 --- a/server-plugin/server-plugin-report-jest/src/test/java/io/onedev/server/plugin/report/jest/JestReportParserTest.java +++ b/server-plugin/server-plugin-report-jest/src/test/java/io/onedev/server/plugin/report/jest/JestReportParserTest.java @@ -6,7 +6,6 @@ import java.io.IOException; import java.io.InputStream; import java.util.HashSet; -import org.jetbrains.annotations.Nullable; import org.junit.Test; import com.fasterxml.jackson.databind.JsonNode; diff --git a/server-plugin/server-plugin-report-markdown/src/main/java/io/onedev/server/plugin/report/markdown/MarkdownReportPage.java b/server-plugin/server-plugin-report-markdown/src/main/java/io/onedev/server/plugin/report/markdown/MarkdownReportPage.java index 6890ab8121..f6e357ad21 100644 --- a/server-plugin/server-plugin-report-markdown/src/main/java/io/onedev/server/plugin/report/markdown/MarkdownReportPage.java +++ b/server-plugin/server-plugin-report-markdown/src/main/java/io/onedev/server/plugin/report/markdown/MarkdownReportPage.java @@ -25,7 +25,6 @@ import java.nio.charset.StandardCharsets; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public class MarkdownReportPage extends BuildDetailPage { private static final String PARAM_REPORT = "report"; diff --git a/server-plugin/server-plugin-report-markdown/src/main/java/io/onedev/server/plugin/report/markdown/MarkdownReportTab.java b/server-plugin/server-plugin-report-markdown/src/main/java/io/onedev/server/plugin/report/markdown/MarkdownReportTab.java index 35c7c37edd..2166a10380 100644 --- a/server-plugin/server-plugin-report-markdown/src/main/java/io/onedev/server/plugin/report/markdown/MarkdownReportTab.java +++ b/server-plugin/server-plugin-report-markdown/src/main/java/io/onedev/server/plugin/report/markdown/MarkdownReportTab.java @@ -21,7 +21,6 @@ import java.io.File; import java.nio.charset.StandardCharsets; import java.util.concurrent.Callable; -@SuppressWarnings("serial") public class MarkdownReportTab extends BuildTab { public MarkdownReportTab(String reportName) { diff --git a/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemModule.java b/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemModule.java index 89347b754d..686f6a0bf4 100644 --- a/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemModule.java +++ b/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemModule.java @@ -143,6 +143,7 @@ public class ProblemModule extends AbstractPluginModule { this.reportName = reportName; } + @SuppressWarnings("unchecked") @Override public Map> call() { return read(getReportLockName(projectId, buildNumber), () -> { diff --git a/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemReportPage.java b/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemReportPage.java index e981a286b4..2f8a8f4c9e 100644 --- a/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemReportPage.java +++ b/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemReportPage.java @@ -67,7 +67,6 @@ import java.util.concurrent.Callable; import static java.util.stream.Collectors.toList; -@SuppressWarnings("serial") public class ProblemReportPage extends BuildReportPage { private static final String PARAM_NAME = "name"; diff --git a/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemStatsPage.java b/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemStatsPage.java index 4272ac6931..faae108996 100644 --- a/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemStatsPage.java +++ b/server-plugin/server-plugin-report-problem/src/main/java/io/onedev/server/plugin/report/problem/ProblemStatsPage.java @@ -7,7 +7,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.model.ProblemMetric; import io.onedev.server.web.page.project.stats.buildmetric.BuildMetricStatsPage; -@SuppressWarnings("serial") public class ProblemStatsPage extends BuildMetricStatsPage { public ProblemStatsPage(PageParameters params) { diff --git a/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/TestStatusBadge.java b/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/TestStatusBadge.java index 6bf17e1d8c..1939686f17 100644 --- a/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/TestStatusBadge.java +++ b/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/TestStatusBadge.java @@ -6,7 +6,6 @@ import org.apache.wicket.model.AbstractReadOnlyModel; import io.onedev.server.plugin.report.unittest.UnitTestReport.Status; -@SuppressWarnings("serial") class TestStatusBadge extends Label { private final Status status; diff --git a/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestCasesPage.java b/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestCasesPage.java index e49179fd11..8af9fa0332 100644 --- a/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestCasesPage.java +++ b/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestCasesPage.java @@ -1,26 +1,20 @@ package io.onedev.server.plugin.report.unittest; -import com.google.common.base.Optional; -import com.google.common.collect.Lists; -import com.google.common.collect.Sets; -import io.onedev.commons.codeassist.InputSuggestion; -import io.onedev.commons.codeassist.parser.TerminalExpect; -import io.onedev.server.git.BlobIdent; -import io.onedev.server.model.Build; -import io.onedev.server.plugin.report.unittest.UnitTestReport.Status; -import io.onedev.server.plugin.report.unittest.UnitTestReport.TestCase; -import io.onedev.server.security.SecurityUtils; -import io.onedev.server.util.patternset.PatternSet; -import io.onedev.server.web.WebConstants; -import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; -import io.onedev.server.web.behavior.PatternSetAssistBehavior; -import io.onedev.server.web.component.NoRecordsPlaceholder; -import io.onedev.server.web.component.chart.pie.PieChartPanel; -import io.onedev.server.web.component.chart.pie.PieSlice; -import io.onedev.server.web.component.pagenavigator.OnePagingNavigator; -import io.onedev.server.web.page.project.blob.ProjectBlobPage; -import io.onedev.server.web.page.project.blob.render.BlobRenderer; -import io.onedev.server.web.util.SuggestionUtils; +import static java.util.Comparator.comparingInt; +import static java.util.List.of; +import static java.util.stream.Collectors.toSet; +import static org.unbescape.html.HtmlEscape.escapeHtml5; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.HashSet; +import java.util.List; +import java.util.stream.Collectors; + +import javax.annotation.Nullable; + import org.apache.commons.lang3.time.DurationFormatUtils; import org.apache.wicket.Component; import org.apache.wicket.ajax.AjaxRequestTarget; @@ -41,17 +35,25 @@ import org.apache.wicket.model.LoadableDetachableModel; import org.apache.wicket.request.mapper.parameter.PageParameters; import org.apache.wicket.util.string.StringValue; -import javax.annotation.Nullable; -import java.io.Serializable; -import java.util.*; -import java.util.stream.Collectors; +import com.google.common.base.Optional; +import com.google.common.collect.Lists; +import com.google.common.collect.Sets; -import static java.util.Comparator.comparingInt; -import static java.util.List.of; -import static java.util.stream.Collectors.toSet; -import static org.unbescape.html.HtmlEscape.escapeHtml5; +import io.onedev.commons.codeassist.InputSuggestion; +import io.onedev.commons.codeassist.parser.TerminalExpect; +import io.onedev.server.model.Build; +import io.onedev.server.plugin.report.unittest.UnitTestReport.Status; +import io.onedev.server.plugin.report.unittest.UnitTestReport.TestCase; +import io.onedev.server.util.patternset.PatternSet; +import io.onedev.server.web.WebConstants; +import io.onedev.server.web.ajaxlistener.ConfirmLeaveListener; +import io.onedev.server.web.behavior.PatternSetAssistBehavior; +import io.onedev.server.web.component.NoRecordsPlaceholder; +import io.onedev.server.web.component.chart.pie.PieChartPanel; +import io.onedev.server.web.component.chart.pie.PieSlice; +import io.onedev.server.web.component.pagenavigator.OnePagingNavigator; +import io.onedev.server.web.util.SuggestionUtils; -@SuppressWarnings("serial") public class UnitTestCasesPage extends UnitTestReportPage { private static final String PARAM_TEST_SUITE = "test-suite"; diff --git a/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestReportPage.java b/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestReportPage.java index ec7e9d00de..96a5e7fc27 100644 --- a/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestReportPage.java +++ b/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestReportPage.java @@ -29,7 +29,6 @@ import java.io.File; import java.util.ArrayList; import java.util.List; -@SuppressWarnings("serial") public abstract class UnitTestReportPage extends BuildReportPage { private final IModel reportModel = new LoadableDetachableModel<>() { diff --git a/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestStatsPage.java b/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestStatsPage.java index c0e989a209..8bf1ab4293 100644 --- a/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestStatsPage.java +++ b/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestStatsPage.java @@ -7,7 +7,6 @@ import org.apache.wicket.request.mapper.parameter.PageParameters; import io.onedev.server.model.UnitTestMetric; import io.onedev.server.web.page.project.stats.buildmetric.BuildMetricStatsPage; -@SuppressWarnings("serial") public class UnitTestStatsPage extends BuildMetricStatsPage { public UnitTestStatsPage(PageParameters params) { diff --git a/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestSuitesPage.java b/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestSuitesPage.java index 30fdb56eb5..ed13c681ce 100644 --- a/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestSuitesPage.java +++ b/server-plugin/server-plugin-report-unittest/src/main/java/io/onedev/server/plugin/report/unittest/UnitTestSuitesPage.java @@ -48,7 +48,6 @@ import static java.util.Comparator.comparingInt; import static java.util.List.of; import static java.util.stream.Collectors.toSet; -@SuppressWarnings("serial") public class UnitTestSuitesPage extends UnitTestReportPage { private static final String PARAM_NAME = "name"; diff --git a/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/CallbackUrlPanel.java b/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/CallbackUrlPanel.java index b2848bb55a..86ff7cbcbc 100644 --- a/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/CallbackUrlPanel.java +++ b/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/CallbackUrlPanel.java @@ -6,7 +6,6 @@ import org.apache.wicket.model.Model; import io.onedev.server.web.component.link.copytoclipboard.CopyToClipboardLink; -@SuppressWarnings("serial") public class CallbackUrlPanel extends Panel { private final String callbackUrl; diff --git a/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/EntraIdConnector.java b/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/EntraIdConnector.java index 03bc5c7695..2a90af43f0 100644 --- a/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/EntraIdConnector.java +++ b/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/EntraIdConnector.java @@ -115,7 +115,7 @@ public class EntraIdConnector extends OpenIdConnector { var httpResponse = httpRequest.send(); if (httpResponse.getStatusCode() == HTTPResponse.SC_OK) { var groupNames = new HashMap(); - JSONObject json = httpResponse.getContentAsJSONObject(); + JSONObject json = httpResponse.getBodyAsJSONObject(); var jsonArray = (JSONArray) json.get("value"); for (var jsonArrayElement: jsonArray) { var groupInfo = (JSONObject) jsonArrayElement; diff --git a/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/GitHubConnector.java b/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/GitHubConnector.java index ba6e7c45eb..d91544b98d 100644 --- a/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/GitHubConnector.java +++ b/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/GitHubConnector.java @@ -70,7 +70,7 @@ public class GitHubConnector extends OpenIdConnector { HTTPResponse httpResponse = userInfoRequest.toHTTPRequest().send(); if (httpResponse.getStatusCode() == HTTPResponse.SC_OK) { - var jsonObject = httpResponse.getContentAsJSONObject(); + var jsonObject = httpResponse.getBodyAsJSONObject(); var userName = jsonObject.getAsString("login"); var fullName = jsonObject.getAsString("name"); var email = jsonObject.getAsString("email"); @@ -79,7 +79,7 @@ public class GitHubConnector extends OpenIdConnector { new URI("https://api.github.com/user/emails"), accessToken); httpResponse = userInfoRequest.toHTTPRequest().send(); if (httpResponse.getStatusCode() == HTTPResponse.SC_OK) { - for (var element: httpResponse.getContentAsJSONArray()) { + for (var element: httpResponse.getBodyAsJSONArray()) { JSONObject emailObject = (JSONObject) element; if (emailObject.getAsString("verified").equals("true") && emailObject.getAsString("primary").equals("true")) { diff --git a/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/OpenIdConnector.java b/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/OpenIdConnector.java index c76dd0b719..8e934bc976 100644 --- a/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/OpenIdConnector.java +++ b/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/OpenIdConnector.java @@ -236,7 +236,7 @@ public class OpenIdConnector extends SsoConnector { var httpResponse = httpRequest.send(); if (httpResponse.getStatusCode() == HTTPResponse.SC_OK) { - JSONObject json = httpResponse.getContentAsJSONObject(); + JSONObject json = httpResponse.getBodyAsJSONObject(); if (!subject.equals(json.get("sub"))) throw new AuthenticationException("OIDC error: Inconsistent sub in ID token and userinfo"); diff --git a/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/TwitchConnector.java b/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/TwitchConnector.java index 022287791d..79827f5c95 100644 --- a/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/TwitchConnector.java +++ b/server-plugin/server-plugin-sso-openid/src/main/java/io/onedev/server/plugin/sso/openid/TwitchConnector.java @@ -59,7 +59,7 @@ public class TwitchConnector extends OpenIdConnector { @Override protected TokenResponse parseOIDCTokenResponse(HTTPResponse response) throws ParseException { - JSONObject responseJson = response.getContentAsJSONObject(); + JSONObject responseJson = response.getBodyAsJSONObject(); if (response.getStatusCode() == HTTPResponse.SC_OK) { Object scopeValue = responseJson.remove("scope"); Scope scope;