From f6f9483e1006588ba5ce18fde14c9ff57e79e489 Mon Sep 17 00:00:00 2001 From: Javier Abadia Date: Tue, 4 Feb 2014 00:13:25 +0100 Subject: [PATCH] problem found --- lib/edit/ISSUES.md | 1 + lib/edit/offlineFeaturesManager.js | 3 +++ 2 files changed, 4 insertions(+) diff --git a/lib/edit/ISSUES.md b/lib/edit/ISSUES.md index 5ad136b..c182d9e 100644 --- a/lib/edit/ISSUES.md +++ b/lib/edit/ISSUES.md @@ -12,6 +12,7 @@ - 'loader.gif' when replaying edits to server, OK - unit tests, OK +- going online fails if all edits cancel themselves (for instance one add + one delete) - unit tests for failure cases - explicit feedback to user when QuotaError happens - goOnline()/goOffline() automatically diff --git a/lib/edit/offlineFeaturesManager.js b/lib/edit/offlineFeaturesManager.js index ef96aa7..1b2e62a 100644 --- a/lib/edit/offlineFeaturesManager.js +++ b/lib/edit/offlineFeaturesManager.js @@ -165,7 +165,10 @@ define([ break; case editsStore.DELETE: if(objectId < 0) + { delete layerEdits[ objectId ]; + optimizedCount -= 1; + } else layerEdits[objectId].operation = editsStore.DELETE; break;