Alex Anderson 91de4b9453
Cursor: avoid closing connection twice if error received after destroy() (#2836)
* Cursor: avoid closing connection twice if error received after destroy()

Includes test case from @nathanjcochran

* Resolve lint violations

* revert fix to check tests fail without it

* Re-introdce fix

This reverts commit 5f5d42a071e40f8851035dba182642937dd35664.

---------

Co-authored-by: alxndrsn <alxndrsn>
2024-03-15 12:26:25 -05:00

174 lines
5.4 KiB
TypeScript

import assert from 'assert'
import helper from './helper'
import QueryStream from '../src'
import { Pool, Client } from 'pg'
helper('error', function (client) {
it('receives error on stream', function (done) {
const stream = new QueryStream('SELECT * FROM asdf num', [])
const query = client.query(stream)
query
.on('error', function (err) {
assert(err)
assert.equal(err.code, '42P01')
done()
})
.on('data', function () {
// noop to kick of reading
})
})
it('continues to function after stream', function (done) {
client.query('SELECT NOW()', done)
})
})
describe('error recovery', () => {
// created from https://github.com/chrisdickinson/pg-test-case
it('recovers from a streaming error in a transaction', async () => {
const pool = new Pool()
const client = await pool.connect()
await client.query(`CREATE TEMP TABLE frobnicators (
id serial primary key,
updated timestamp
)`)
await client.query(`BEGIN;`)
const query = new QueryStream(`INSERT INTO frobnicators ("updated") VALUES ($1) RETURNING "id"`, [Date.now()])
let error: Error | undefined = undefined
query.on('data', console.log).on('error', (e) => {
error = e
})
client.query(query) // useless callback necessitated by an older version of honeycomb-beeline
await client.query(`ROLLBACK`)
assert(error, 'Error should not be undefined')
const { rows } = await client.query('SELECT NOW()')
assert.strictEqual(rows.length, 1)
client.release()
const client2 = await pool.connect()
await client2.query(`BEGIN`)
client2.release()
pool.end()
})
// created from https://github.com/brianc/node-postgres/pull/2333
it('handles an error on a stream after a plain text non-stream error', async () => {
const client = new Client()
const stmt = 'SELECT * FROM goose;'
await client.connect()
return new Promise((resolve, reject) => {
client.query(stmt).catch((e) => {
assert(e, 'Query should have rejected with an error')
const stream = new QueryStream('SELECT * FROM duck')
client.query(stream)
stream.on('data', () => {})
stream.on('error', () => {
client.end((err) => {
err ? reject(err) : resolve()
})
})
})
})
})
it('does not crash when closing a connection with a queued stream', async () => {
const client = new Client()
const stmt = 'SELECT * FROM goose;'
await client.connect()
return new Promise(async (resolve) => {
let queryError: Error | undefined
client.query(stmt).catch((e) => {
queryError = e
})
const stream = client.query(new QueryStream(stmt))
stream.on('data', () => {})
stream.on('error', () => {
assert(queryError, 'query should have errored due to client ending')
resolve()
})
await client.end()
})
})
it('should work if used after timeout error', async () => {
const pool = new Pool({ max: 1, connectionTimeoutMillis: 400, statement_timeout: 400 })
const res1 = await pool.query('SELECT 1 AS a')
assert.deepStrictEqual(res1.rows, [{ a: 1 }])
const query = new QueryStream('SELECT 2 AS b')
const client = await pool.connect()
const stream = await client.query(query)
await assert.rejects(() => pool.query('SELECT TRUE'), { message: 'timeout exceeded when trying to connect' })
await stream.destroy()
await client.release()
const res2 = await pool.query('SELECT 4 AS d')
assert.deepStrictEqual(res2.rows, [{ d: 4 }])
await pool.end()
})
it('should work if used after syntax error', async () => {
const pool = new Pool({ max: 1, statement_timeout: 100 }) // statement_timeout is required here, so maybe this is just another timeout error?
const res1 = await pool.query('SELECT 1 AS a')
assert.deepStrictEqual(res1.rows, [{ a: 1 }])
const query = new QueryStream('SELECT 2 AS b')
const client = await pool.connect()
const stream = await client.query(query)
await new Promise((resolve) => setTimeout(resolve, 10))
await stream.destroy()
await client.release()
const res2 = await pool.query('SELECT 4 AS d')
assert.deepStrictEqual(res2.rows, [{ d: 4 }])
await pool.end()
})
it('should work after cancelling query', async () => {
const pool = new Pool()
const conn = await pool.connect()
// Get connection PID for sake of pg_cancel_backend() call
const result = await conn.query('SELECT pg_backend_pid() AS pid;')
const { pid } = result.rows[0]
const stream = conn.query(new QueryStream('SELECT pg_sleep(10);'))
stream.on('data', (chunk) => {
// Switches stream into readableFlowing === true mode
})
stream.on('error', (err) => {
// Errors are expected due to pg_cancel_backend() call
})
// Create a promise that is resolved when the stream is closed
const closed = new Promise((res) => {
stream.on('close', res)
})
// Wait 100ms before cancelling the query
await new Promise((res) => setTimeout(res, 100))
// Cancel pg_sleep(10) query
await pool.query('SELECT pg_cancel_backend($1);', [pid])
// Destroy stream and wait for it to be closed
stream.destroy()
await closed
// Subsequent query on same connection should succeed
const res = await conn.query('SELECT 1 AS a;')
assert.deepStrictEqual(res.rows, [{ a: 1 }])
conn.release()
await pool.end()
})
})