31 Commits

Author SHA1 Message Date
Brian M. Carlson
507c7eaca4 Merge branch 'master' into bmc/add-test-and-deprecate-method 2019-10-30 12:47:14 -05:00
Brian M. Carlson
389d5d8c14 Fix named portal being left open
When code was added to use a random named portal instead of the empty portal to support redshift we didn't update the close messages approprately.  This could result in postgres keeping locks on tables for modification if streaming and table modification was both done within a transaction.  This update fixes the issue by always issuing a close command on the named portal when query is finished.

fixes #56
2019-10-30 11:33:52 -05:00
Brian M. Carlson
d3aee3dfc8 Add additional pool test & deprecate .end
There are no tests covering cursor.end().  It's also a weird method to have on the cursor as it terminates the connection to postgres internally.  I don't recall why I added this method in the first place but its not correct to close a connection to postgres by calling .end on a cursor...seems like a pretty big footgun.  If you have a pooled client and you call `cursor.end` it'll close the client internally and likely confuse the pool.  Plus it's just weird to be able to close a connection by calling .end on a query or cursor.  So...I'm deprecating that method.
2019-10-28 11:45:20 -05:00
Brian M. Carlson
be0321299b Update lint, fix for pg@7.x 2019-10-25 18:11:53 -05:00
Brian M. Carlson
4164686c4b meh 2019-10-25 18:03:07 -05:00
Brian M. Carlson
414fac6a05 Apply prettier to code, change lint rules 2019-10-25 12:14:27 -05:00
Brian M. Carlson
71dde045ea Merge branch 'master' of github.com:brianc/node-pg-cursor 2019-01-08 08:52:25 -06:00
Brian C
67b880a4bd
Merge pull request #35 from jakobrun/master
return rowCount on insert
2019-01-08 08:52:20 -06:00
Brian M. Carlson
1200da5c74 Fix test 2019-01-08 08:52:05 -06:00
Brian C
0a1052516f
Merge pull request #44 from jafl/redshift-requires-portal-name
fix: AWS Redshift requires a portal name to honor fetchSize
2019-01-08 08:28:39 -06:00
Mikkel Hoegh
6fc07b4a63
fix: remove support for deprecated pg.js package
BREAKING CHANGE: pg.js is long dead and no longer supported.

Use [pg](https://www.npmjs.com/package/pg) instead.
2018-12-05 00:06:10 +01:00
John Lindal
37997fed76 fix formatting issues 2018-10-23 09:59:50 -07:00
John Lindal
19c68c753e fix: AWS Redshift requires a portal name to honor fetchSize 2018-10-17 14:30:56 -07:00
jakob
2398e992a8 return rowCount on insert 2018-01-01 18:43:18 +00:00
Brian M. Carlson
4ff97f54bf Add support for rowMode & custom types 2017-08-05 18:22:54 -05:00
Brian M. Carlson
2ced8f1f2b Integrate eslint 2017-08-05 17:24:49 -05:00
Brian M. Carlson
3675d2b041 Fix to support node@4 LTS 2017-08-05 17:17:24 -05:00
Brian Carlson
a720dc774b Some cleanup 2017-08-05 16:59:20 -05:00
Brian M. Carlson
620ddc0ded Do not send close after readyForQuery
Close is used to release a named portal (which isn't used by pg-cursor) or when you're early-terminating a cursor on the unnamed portal. Sending 'close' on an connection which has already sent 'readyForQuery' results in the connection responding with a _second_ 'readyForQuery' which causes a lot of issues within node-postgres as 'readyForQuery' is the signal to indicate the client has gone back into the idle state.
2017-08-04 17:40:52 -05:00
Sam Beran
2f480217cb fix: only dispatch error events if we have a listener 2017-05-09 10:13:57 -05:00
Sam Beran
acae15de53 Emit Query Events
This change adds events to the `Cursor` object
as per the [Query API](https://github.com/brianc/node-postgres/wiki/Query).
2017-05-09 10:13:57 -05:00
Sam Beran
557e5f879d Return result accumulator in callback
fixes issue: https://github.com/brianc/node-pg-cursor/issues/22
2017-04-27 14:26:11 -05:00
Rick Bergfalk
74b6891b20 handle empty query 2016-06-28 16:47:50 -05:00
Brian M. Carlson
19a2d26fc1 Add client#close
Closes #6
2014-09-24 23:42:51 -04:00
Stephen Sugden
8283fd9b22 add support for queries that don't return a row description 2014-05-21 22:44:51 +02:00
Stephen Sugden
f7b6572399 fix typo 2014-05-21 21:54:27 +02:00
Brian M. Carlson
1a9fd7ff76 Do not callback with final empty array until readyForQuery is received
Closes https://github.com/brianc/node-pg-query-stream/issues/3
2014-03-21 11:44:46 -05:00
Brian M. Carlson
f1dbe7884c Normalize parameter values 2014-02-26 09:30:00 -06:00
Brian M. Carlson
9af987fa63 Pass all tests 2013-11-20 22:30:52 -06:00
Brian M. Carlson
31b2b1da6f All tests passing in isolation
Still have weird race conditions & shutdown/error/resume conditions to tackle
2013-11-11 23:20:04 -06:00
Brian Carlson
5d27cf24e2 Initial commit 2013-10-07 11:52:36 -05:00