archive-gh-me/node-postgres
1
0
Fork 0
mirror of https://github.com/brianc/node-postgres.git synced 2025-12-08 20:16:25 +00:00
Code Issues Projects Releases Wiki Activity

Add callback interface to pool#query (#11)

Browse Source 
* Add callback interface to pool#query

* Fix linting errors
This commit is contained in:
Brian C 2016-06-24 11:35:16 -05:00 committed by GitHub
parent 8b45ea1e7d
commit ce59164ba1
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
index.js
View File

@ -83,13 +83,16 @@ Pool.prototype.connect = function (cb) {
Pool.prototype.take = Pool.prototype.connect
Pool.prototype.query = function (text, values) {
Pool.prototype.query = function (text, values, cb) {
return new this.Promise(function (resolve, reject) {
this.connect(function (err, client, done) {
if (err) return reject(err)
client.query(text, values, function (err, res) {
done(err)
err ? reject(err) : resolve(res)
if (cb) {
cb(err, res)
}
})
})
}.bind(this))

10
test/index.js
View File

@ -32,6 +32,16 @@ describe('pool', function () {
})
})
it('can run a query with a callback', function (done) {
const pool = new Pool()
pool.query('SELECT $1::text as name', ['brianc'], function (err, res) {
expect(res.rows[0]).to.eql({ name: 'brianc' })
pool.end(function () {
done(err)
})
})
})
it('removes client if it errors in background', function (done) {
const pool = new Pool()
pool.connect(function (err, client, release) {