archive-gh-me/node-postgres
1
0
Fork 0
mirror of https://github.com/brianc/node-postgres.git synced 2026-01-18 15:55:05 +00:00
Code Issues Projects Releases Wiki Activity

fix writing empty string to buffer. closes gh-39

Browse Source
This commit is contained in:
brianc 2011-07-20 15:32:47 -05:00
parent 621857746d
commit c317606b0a
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/writer.js
View File

@ -37,7 +37,12 @@ p.addInt16 = function(num) {
}
p.addCString = function(string) {
var string = string || "";
//just write a 0 for empty or null strings
if(!string) {
this._ensure(1);
this.buffer[this.offset++] = 0;
return this;
}
var len = Buffer.byteLength(string) + 1;
this._ensure(len);
this.buffer.write(string, this.offset);

7
test/unit/writer-tests.js
View File

@ -66,6 +66,13 @@ test('cString', function() {
var result = subject.addCString().join();
assert.equalBuffers(result, [0])
})
test('writes two empty cstrings', function() {
var subject = new Writer();
var result = subject.addCString("").addCString("").join();
assert.equalBuffers(result, [0, 0])
})
test('writes non-empty cstring', function() {
var subject = new Writer();