archive-gh-me/node-postgres
1
0
Fork 0
mirror of https://github.com/brianc/node-postgres.git synced 2026-01-18 15:55:05 +00:00
Code Issues Projects Releases Wiki Activity

Remove unreachable branch in parseE (#2020)

Browse Source 
The message is created with a fixed name.

56b7c4168d5aa084b2821279ee88d437a2b7636d, released in pg 2.4.0, was when this became applicable and the type of a `notice` event’s argument changed to an Error.
This commit is contained in:
Charmander 2019-12-12 08:15:53 -08:00 committed by Brian C
parent b03a3bd76d
commit c1f954b7a6
1 changed files with 8 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/connection.js
View File

@ -594,27 +594,19 @@ Connection.prototype._readValue = function (buffer) {
// parses error
Connection.prototype.parseE = function (buffer, length) {
var fields = {}
var msg, item
var input = new Message('error', length)
var fieldType = this.readString(buffer, 1)
while (fieldType !== '\0') {
fields[fieldType] = this.parseCString(buffer)
fieldType = this.readString(buffer, 1)
}
if (input.name === 'error') {
// the msg is an Error instance
msg = new Error(fields.M)
for (item in input) {
// copy input properties to the error
if (Object.prototype.hasOwnProperty.call(input, item)) {
msg[item] = input[item]
}
}
} else {
// the msg is an object literal
msg = input
msg.message = fields.M
}
// the msg is an Error instance
var msg = new Error(fields.M)
// for compatibility with Message
msg.name = 'error'
msg.length = length
msg.severity = fields.S
msg.code = fields.C
msg.detail = fields.D