archive-gh-me/node-postgres
1
0
Fork 0
mirror of https://github.com/brianc/node-postgres.git synced 2025-12-08 20:16:25 +00:00
Code Issues Projects Releases Wiki Activity

When connection fail, emit the error. (#28)

Browse Source 
* When connection fail, emit the error.

If client connect failed, emit the connection error  rather than swallowing it.

* Add test for connection error.
This commit is contained in:
Yanlong Wang 2016-09-14 10:26:03 +08:00 committed by Brian C
parent cf28f9357f
commit 6a7edabc22
2 changed files with 25 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
index.js
View File

@ -43,6 +43,7 @@ Pool.prototype._create = function (cb) {
if (err) {
this.log('client connection error:', err)
cb(err)
this.emit('error', err)
} else {
this.log('client connected')
this.emit('connect', client)

26
test/events.js
View File

@ -22,7 +22,7 @@ describe('events', function () {
})
})
it('emits "connect" only with a successful connection', function (done) {
it('emits "error" with a failed connection', function (done) {
var pool = new Pool({
// This client will always fail to connect
Client: mockClient({
@ -34,7 +34,29 @@ describe('events', function () {
pool.on('connect', function () {
throw new Error('should never get here')
})
pool._create(function (err) {
pool.on('error', function (err) {
if (err) done()
else done(new Error('expected failure'))
})
pool.connect()
})
it('callback err with a failed connection', function (done) {
var pool = new Pool({
// This client will always fail to connect
Client: mockClient({
connect: function (cb) {
process.nextTick(function () { cb(new Error('bad news')) })
}
})
})
pool.on('connect', function () {
throw new Error('should never get here')
})
pool.on('error', function (err) {
if (!err) done(new Error('expected failure'))
})
pool.connect(function (err) {
if (err) done()
else done(new Error('expected failure'))
})