archive-gh-me/node-postgres
1
0
Fork 0
mirror of https://github.com/brianc/node-postgres.git synced 2025-12-08 20:16:25 +00:00
Code Issues Projects Releases Wiki Activity

fix: Prevent closing the portal twice (#2609)

Browse Source 
Fixes brianc/node-postgres#2119
This commit is contained in:
Matthieu 2022-01-28 19:59:45 +01:00 committed by GitHub
parent 998f573244
commit 5508c0ee6b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/pg-cursor/index.js
View File

@ -86,6 +86,8 @@ class Cursor extends EventEmitter {
}
_closePortal() {
if (this.state === 'done') return
// because we opened a named portal to stream results
// we need to close the same named portal. Leaving a named portal
// open can lock tables for modification if inside a transaction.
@ -97,6 +99,8 @@ class Cursor extends EventEmitter {
if (this.state !== 'error') {
this.connection.sync()
}
this.state = 'done'
}
handleRowDescription(msg) {
@ -213,7 +217,6 @@ class Cursor extends EventEmitter {
}
this._closePortal()
this.state = 'done'
this.connection.once('readyForQuery', function () {
cb()
})

12
packages/pg-query-stream/test/async-iterator.ts
View File

@ -117,5 +117,17 @@ if (!process.version.startsWith('v8')) {
client.release()
await pool.end()
})
it('supports breaking with low watermark', async function () {
const pool = new pg.Pool({ max: 1 })
const client = await pool.connect()
for await (const _ of client.query(new QueryStream('select TRUE', [], { highWaterMark: 1 }))) break
for await (const _ of client.query(new QueryStream('select TRUE', [], { highWaterMark: 1 }))) break
for await (const _ of client.query(new QueryStream('select TRUE', [], { highWaterMark: 1 }))) break
client.release()
await pool.end()
})
})
}