Add use strict to every file

lib/client.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

lib/connection-parameters.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

lib/connection.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

lib/defaults.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

lib/index.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

lib/native/client.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

lib/native/index.js

@@ -1 +1,2 @@
+"use strict";
 module.exports = require('./client')

lib/native/query.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

lib/native/result.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

lib/query.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

lib/result.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

lib/type-overrides.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

lib/utils.js

@@ -1,3 +1,4 @@
+"use strict";
 /**
  * Copyright (c) 2010-2017 Brian Carlson (brian.m.carlson@gmail.com)
  * All rights reserved.

script/create-test-tables.js

@@ -1,3 +1,4 @@
+"use strict";
 var args = require(__dirname + '/../test/cli');
 var pg = require(__dirname + '/../lib');
 

script/dump-db-types.js

@@ -1,3 +1,4 @@
+"use strict";
 var pg = require(__dirname + '/../lib');
 var args = require(__dirname + '/../test/cli');
 

script/list-db-types.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + "/../test/integration/test-helper");
 var pg = helper.pg;
 pg.connect(helper.config, assert.success(function(client) {

test/buffer-list.js

@@ -1,4 +1,5 @@
-BufferList = function() {
+"use strict";
+global.BufferList = function() {
   this.buffers = [];
 };
 var p = BufferList.prototype;

test/cli.js

@@ -1,3 +1,4 @@
+"use strict";
 var ConnectionParameters = require(__dirname + '/../lib/connection-parameters');
 var config = new ConnectionParameters(process.argv[2]);
 

test/integration/client/api-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + "/../test-helper");
 var pg = helper.pg;
 

test/integration/client/appname-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 var Client = helper.Client;
 

test/integration/client/array-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + "/test-helper");
 var pg = helper.pg;
 

test/integration/client/big-simple-query-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require("./test-helper");
 var Query = helper.pg.Query
 

test/integration/client/configuration-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 var pg = helper.pg;
 

test/integration/client/custom-types-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 const helper = require('./test-helper');
 const Client = helper.pg.Client;
 const suite = new helper.Suite()

test/integration/client/empty-query-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 const suite = new helper.Suite()
 

test/integration/client/error-handling-tests.js

@@ -1,4 +1,5 @@
 "use strict";
+"use strict";
 
 var helper = require('./test-helper');
 var util = require('util');

test/integration/client/huge-numeric-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 const pool = new helper.pg.Pool()
 

test/integration/client/json-type-parsing-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 var assert = require('assert');
 

test/integration/client/network-partition-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var buffers = require('../../test-buffers')
 var helper = require('./test-helper')
 var suite = new helper.Suite()

test/integration/client/no-data-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 const suite = new helper.Suite()
 

test/integration/client/no-row-result-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require("./test-helper");
 var pg = helper.pg;
 const suite = new helper.Suite();

test/integration/client/notice-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 const suite = new helper.Suite()
 

test/integration/client/parse-int-8-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 
 var helper = require('../test-helper');
 var pg = helper.pg;

test/integration/client/prepared-statement-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 var Query = helper.pg.Query;
 

test/integration/client/promise-api-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 'use strict';
 
 const helper = require('./test-helper')

test/integration/client/query-as-promise-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/../test-helper');
 var pg = helper.pg;
 

test/integration/client/query-column-names-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/../test-helper');
 var pg = helper.pg;
 

test/integration/client/query-error-handling-prepared-statement-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 var Query = helper.pg.Query;
 var util = require('util');

test/integration/client/query-error-handling-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 var util = require('util');
 var Query = helper.pg.Query;

test/integration/client/quick-disconnect-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 //test for issue #320
 //
 var helper = require('./test-helper');

test/integration/client/result-metadata-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require("./test-helper");
 var pg = helper.pg;
 

test/integration/client/results-as-array-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var util = require('util');
 var helper = require('./test-helper');
 

test/integration/client/row-description-on-results-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 
 var Client = helper.Client;

test/integration/client/simple-query-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require("./test-helper");
 var Query = helper.pg.Query;
 
@@ -18,7 +19,7 @@ test("simple query interface", function() {
   query.once('row', function(row) {
     test('Can iterate through columns', function () {
       var columnCount = 0;
-      for (column in row) {
+      for (var column in row) {
         columnCount++;
       }
       if ('length' in row) {

test/integration/client/ssl-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var pg = require(__dirname + '/../../../lib');
 var config = require(__dirname + '/test-helper').config;
 test('can connect with ssl', function() {

test/integration/client/test-helper.js

@@ -1,3 +1,4 @@
-var helper = require(__dirname+'/../test-helper');
+"use strict";
+var helper = require('./../test-helper');
 
 module.exports = helper;

test/integration/client/timezone-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./../test-helper');
 var exec = require('child_process').exec;
 

test/integration/client/transaction-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 const suite = new helper.Suite()
 const pg = helper.pg

test/integration/client/type-coercion-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/test-helper');
 var pg = helper.pg;
 var sink;

test/integration/client/type-parser-override-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 
 function testTypeParser(client, expectedResult, done) {

test/integration/connection-pool/connection-pool-size-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require("./test-helper")
 
 helper.testPoolSize(1);

test/integration/connection-pool/error-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require("./test-helper");
 const pg = helper.pg
 

test/integration/connection-pool/idle-timeout-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 
 

test/integration/connection-pool/native-instance-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require("./../test-helper")
 var pg = helper.pg
 var native = helper.args.native

test/integration/connection-pool/test-helper.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require("./../test-helper");
 
 const suite = new helper.Suite()

test/integration/connection-pool/yield-support-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper')
 var co = require('co')
 

test/integration/connection/bound-command-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/test-helper');
 //http://developer.postgresql.org/pgdocs/postgres/protocol-flow.html#PROTOCOL-FLOW-EXT-QUERY
 

test/integration/connection/copy-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname+"/test-helper");
 var assert = require('assert');
 

test/integration/connection/notification-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/test-helper');
 //http://www.postgresql.org/docs/8.3/static/libpq-notify.html
 test('recieves notification from same connection with no payload', function() {

test/integration/connection/query-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname+"/test-helper");
 var assert = require('assert');
 

test/integration/connection/test-helper.js

@@ -1,3 +1,4 @@
+"use strict";
 var net = require('net');
 var helper = require(__dirname+'/../test-helper');
 var Connection = require(__dirname + '/../../../lib/connection');

test/integration/domain-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var async = require('async')
 
 var helper = require('./test-helper')

test/integration/gh-issues/130-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/../test-helper');
 var exec = require('child_process').exec;
 

test/integration/gh-issues/131-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('../test-helper');
 var pg = helper.pg;
 

test/integration/gh-issues/199-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('../test-helper');
 var client = helper.client();
 

test/integration/gh-issues/507-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + "/../test-helper");
 var pg = helper.pg;
 

test/integration/gh-issues/600-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var async = require('async');
 var helper = require('../test-helper');
 const suite = new helper.Suite()

test/integration/gh-issues/675-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('../test-helper');
 var assert = require('assert');
 

test/integration/gh-issues/699-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('../test-helper');
 var assert = require('assert');
 var copyFrom = require('pg-copy-streams').from;

test/integration/gh-issues/787-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('../test-helper');
 const pool = new helper.pg.Pool()
 

test/integration/gh-issues/882-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 //client should not hang on an empty query
 var helper = require('../test-helper');
 var client = helper.client();

test/integration/gh-issues/981-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./../test-helper');
 
 //native bindings are only installed for native tests

test/integration/test-helper.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/../test-helper');
 
 if(helper.args.native) {

test/native/callback-api-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var domain = require('domain');
 var helper = require("./../test-helper");
 var Client = require("./../../lib/native");

test/native/error-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + "/../test-helper");
 var Client = require(__dirname + "/../../lib/native");
 

test/native/evented-api-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require("../test-helper");
 var Client = require("../../lib/native");
 var Query = Client.Query;

test/native/missing-native.js

@@ -1,3 +1,4 @@
+"use strict";
 //this test assumes it has been run from the Makefile
 //and that node_modules/pg-native has been deleted
 

test/native/native-vs-js-error-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var assert = require('assert')
 var Client = require('../../lib/client');
 var NativeClient = require('../../lib/native');

test/native/stress-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + "/../test-helper");
 var Client = require(__dirname + "/../../lib/native");
 var Query = Client.Query;

test/suite.js

@@ -1,3 +1,4 @@
+"use strict";
 'use strict';
 
 const async = require('async')

test/test-buffers.js

@@ -1,3 +1,4 @@
+"use strict";
 require(__dirname+'/test-helper');
 //http://developer.postgresql.org/pgdocs/postgres/protocol-message-formats.html
 

test/test-helper.js

@@ -1,5 +1,6 @@
+"use strict";
 //make assert a global...
-assert = require('assert');
+global.assert = require('assert');
 var EventEmitter = require('events').EventEmitter;
 var sys = require('util');
 
@@ -9,7 +10,7 @@ const args = require('./cli');
 
 var Connection = require('./../lib/connection');
 
-Client = require('./../lib').Client;
+global.Client = require('./../lib').Client;
 
 process.on('uncaughtException', function(d) {
   if ('stack' in d && 'message' in d) {
@@ -172,7 +173,7 @@ const getMode = () => {
   return ''
 }
 
-test = function(name, action) {
+global.test = function(name, action) {
   test.testCount ++;
   test[name] = action;
   var result = test[name]();

test/unit/client/cleartext-password-tests.js

@@ -1,4 +1,6 @@
-require(__dirname+'/test-helper');
+"use strict";
+
+const createClient = require('./test-helper').createClient;
 
 /*
  * TODO: Add _some_ comments to explain what it is we're testing, and how the

test/unit/client/configuration-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 require(__dirname+'/test-helper');
 
 var pguser = process.env['PGUSER'] || process.env.USER;

test/unit/client/early-disconnect-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/test-helper');
 var net = require('net');
 var pg = require('../../..//lib/index.js');

test/unit/client/escape-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/test-helper');
 
 function createClient(callback) {

test/unit/client/md5-password-tests.js

@@ -1,8 +1,9 @@
-require('./test-helper');
+"use strict";
+var helper = require('./test-helper');
 var utils = require('../../../lib/utils')
 
 test('md5 authentication', function() {
-  var client = createClient();
+  var client = helper.createClient();
   client.password = "!";
   var salt = Buffer.from([1, 2, 3, 4]);
   client.connection.emit('authenticationMD5Password', {salt: salt});

test/unit/client/notification-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + "/test-helper");
 
 test('passes connection notification', function() {

test/unit/client/prepared-statement-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('./test-helper');
 var Query = require('../../../lib/query')
 

test/unit/client/query-queue-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/test-helper');
 var Connection = require(__dirname + '/../../../lib/connection');
 

test/unit/client/result-metadata-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + "/test-helper")
 
 var testForTag = function(tagText, callback) {

test/unit/client/simple-query-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + "/test-helper");
 var Query = require('../../../lib/query')
 

test/unit/client/stream-and-query-error-interaction-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/test-helper');
 var Connection = require(__dirname + '/../../../lib/connection');
 var Client = require(__dirname + '/../../../lib/client');

test/unit/client/test-helper.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require('../test-helper');
 var Connection = require('../../../lib/connection');
 

test/unit/client/throw-in-type-parser-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require("./test-helper");
 var Query = require("../../../lib/query");
 var types = require("pg-types");

test/unit/connection-parameters/creation-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/../test-helper');
 var assert = require('assert');
 var ConnectionParameters = require(__dirname + '/../../../lib/connection-parameters');
@@ -67,12 +68,12 @@ test('ConnectionParameters initializing from config', function() {
 });
 
 test('escape spaces if present', function() {
-  subject = new ConnectionParameters('postgres://localhost/post gres');
+  var subject = new ConnectionParameters('postgres://localhost/post gres');
   assert.equal(subject.database, 'post gres');
 });
 
 test('do not double escape spaces', function() {
-  subject = new ConnectionParameters('postgres://localhost/post%20gres');
+  var subject = new ConnectionParameters('postgres://localhost/post%20gres');
   assert.equal(subject.database, 'post gres');
 });
 

test/unit/connection-parameters/environment-variable-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/../test-helper');
 var assert = require('assert');
 var ConnectionParameters = require(__dirname + '/../../../lib/connection-parameters');

test/unit/connection/error-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 var helper = require(__dirname + '/test-helper');
 var Connection = require(__dirname + '/../../../lib/connection');
 test("connection emits stream errors", function() {

test/unit/connection/inbound-parser-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 require(__dirname+'/test-helper');
 var Connection = require(__dirname + '/../../../lib/connection');
 var buffers = require(__dirname + '/../../test-buffers');

test/unit/connection/outbound-sending-tests.js

@@ -1,3 +1,4 @@
+"use strict";
 require(__dirname + "/test-helper");
 var Connection = require(__dirname + '/../../../lib/connection');
 var stream = new MemoryStream();