archive-gh-me/node-postgres
1
0
Fork 0
mirror of https://github.com/brianc/node-postgres.git synced 2025-12-08 20:16:25 +00:00
Code Issues Projects Releases Wiki Activity

Fix compare (#1923)

Browse Source 
* Fix deepEqual compare

In node 12 assert.deepEqual against a buffer & array no longer passes if the values are the same.  This makes sense.  Updated the test to not use deepEqual in this case.
This commit is contained in:
Brian C 2019-07-16 18:41:54 -05:00 committed by GitHub
parent d8a0e1e950
commit 0acaf9d8ff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/native/client.js
View File

@ -7,7 +7,7 @@
* README.md file in the root directory of this source tree.
*/
// eslint-disable-next-line node/no-missing-require
// eslint-disable-next-line
var Native = require('pg-native')
var TypeOverrides = require('../type-overrides')
var semver = require('semver')

35
test/unit/utils-tests.js
View File

@ -29,22 +29,22 @@ test('EventEmitter.once', function (t) {
test('normalizing query configs', function () {
var config
var callback = function () {}
var callback = function () { }
config = utils.normalizeQueryConfig({text: 'TEXT'})
assert.same(config, {text: 'TEXT'})
config = utils.normalizeQueryConfig({ text: 'TEXT' })
assert.same(config, { text: 'TEXT' })
config = utils.normalizeQueryConfig({text: 'TEXT'}, [10])
assert.deepEqual(config, {text: 'TEXT', values: [10]})
config = utils.normalizeQueryConfig({ text: 'TEXT' }, [10])
assert.deepEqual(config, { text: 'TEXT', values: [10] })
config = utils.normalizeQueryConfig({text: 'TEXT', values: [10]})
assert.deepEqual(config, {text: 'TEXT', values: [10]})
config = utils.normalizeQueryConfig({ text: 'TEXT', values: [10] })
assert.deepEqual(config, { text: 'TEXT', values: [10] })
config = utils.normalizeQueryConfig('TEXT', [10], callback)
assert.deepEqual(config, {text: 'TEXT', values: [10], callback: callback})
assert.deepEqual(config, { text: 'TEXT', values: [10], callback: callback })
config = utils.normalizeQueryConfig({text: 'TEXT', values: [10]}, callback)
assert.deepEqual(config, {text: 'TEXT', values: [10], callback: callback})
config = utils.normalizeQueryConfig({ text: 'TEXT', values: [10] }, callback)
assert.deepEqual(config, { text: 'TEXT', values: [10], callback: callback })
})
test('prepareValues: buffer prepared properly', function () {
@ -57,7 +57,8 @@ test('prepareValues: Uint8Array prepared properly', function () {
var buf = new Uint8Array([1, 2, 3]).subarray(1, 2)
var out = utils.prepareValue(buf)
assert.ok(Buffer.isBuffer(out))
assert.deepEqual(out, [2])
assert.equal(out.length, 1)
assert.deepEqual(out[0], 2)
})
test('prepareValues: date prepared properly', function () {
@ -167,12 +168,12 @@ test('prepareValue: objects with simple toPostgres prepared properly', function
assert.strictEqual(out, 'zomgcustom!')
})
test('prepareValue: buffer array prepared properly', function() {
var buffer1 = Buffer.from('dead', 'hex')
var buffer2 = Buffer.from('beef', 'hex')
var out = utils.prepareValue([buffer1, buffer2])
assert.strictEqual(out, '{\\\\xdead,\\\\xbeef}')
})
test('prepareValue: buffer array prepared properly', function () {
var buffer1 = Buffer.from('dead', 'hex')
var buffer2 = Buffer.from('beef', 'hex')
var out = utils.prepareValue([buffer1, buffer2])
assert.strictEqual(out, '{\\\\xdead,\\\\xbeef}')
})
test('prepareValue: objects with complex toPostgres prepared properly', function () {
var buf = Buffer.from('zomgcustom!')