archive-gh-me/node-postgres
1
0
Fork 0
mirror of https://github.com/brianc/node-postgres.git synced 2025-12-08 20:16:25 +00:00
Code Issues Projects Releases Wiki Activity

fix #3508 - recheck min client count during idle callback (#3509)

Browse Source
This commit is contained in:
Barry Hagan 2025-07-10 14:30:48 -05:00 committed by GitHub
parent 43b8692019
commit 01fadd93d7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/pg-pool/index.js
View File

@ -372,8 +372,10 @@ class Pool extends EventEmitter {
let tid
if (this.options.idleTimeoutMillis && this._isAboveMin()) {
tid = setTimeout(() => {
this.log('remove idle client')
this._remove(client, this._pulseQueue.bind(this))
if (this._isAboveMin()) {
this.log('remove idle client')
this._remove(client, this._pulseQueue.bind(this))
}
}, this.options.idleTimeoutMillis)
if (this.options.allowExitOnIdle) {

16
packages/pg-pool/test/sizing.js
View File

@ -124,3 +124,19 @@ describe('pool size of 2', () => {
})
)
})
describe('pool min size', () => {
it(
'does not drop below min when clients released at same time',
co.wrap(function* () {
const pool = new Pool({ max: 2, min: 1, idleTimeoutMillis: 10 })
const client = yield pool.connect()
const client2 = yield pool.connect()
client.release()
client2.release()
yield new Promise((resolve) => setTimeout(resolve, 20))
expect(pool.idleCount).to.equal(1)
return yield pool.end()
})
)
})