From 0748ccabd392bfed271deb2444a5ab68d6a45256 Mon Sep 17 00:00:00 2001 From: Peter Braden Date: Wed, 20 Mar 2019 09:57:06 +0000 Subject: [PATCH] Remove coverage for now (was broken) --- Makefile | 34 ---------------------------------- README.md | 9 --------- package.json | 1 - 3 files changed, 44 deletions(-) diff --git a/Makefile b/Makefile index ba8436c..c4b9132 100644 --- a/Makefile +++ b/Makefile @@ -15,17 +15,6 @@ travis-build: docker build -t peterbraden/node-opencv-ubuntu-14-04 -f test/Dockerfile-ubuntu-14-04 . .PHONY: travis-build - -# Below build, coverage and clean tasks were partly lifted from https://github.com/geo-data/node-mapserv/blob/e99b23a44d910d444f5a45d144859758f820e1d1/Makefile -# @author danschultzer - -# The location of the `istanbul` JS code coverage framework. Try and get a -# globally installed version, falling back to a local install. -ISTANBUL := $(shell which istanbul) -ifeq ($(ISTANBUL),) - ISTANBUL = ./node_modules/.bin/istanbul/lib/cli.js -endif - # The location of the `node-pre-gyp` module builder. Try and get a globally # installed version, falling back to a local install. NODE_PRE_GYP = $(shell which node-pre-gyp) @@ -43,32 +32,9 @@ build: build/Debug/opencv.node build/Debug/opencv.node: $(NODE_PRE_GYP) --verbose --debug rebuild -# Perform the code coverage -cover: coverage/index.html -coverage/index.html: coverage/node-opencv.info - genhtml --output-directory coverage coverage/node-opencv.info - @echo "\033[0;32mPoint your browser at \`coverage/index.html\`\033[m\017" -coverage/node-opencv.info: coverage/bindings.info - lcov --test-name node-opencv \ - --add-tracefile coverage/lcov.info \ - --add-tracefile coverage/bindings.info \ - --output-file coverage/node-opencv.info -coverage/bindings.info: coverage/addon.info - lcov --extract coverage/addon.info '*opencv/src/*' --output-file coverage/bindings.info -coverage/addon.info: coverage/lcov.info - lcov --capture --base-directory build/ --directory . --output-file coverage/addon.info -# This generates the JS lcov info as well as gcov `*.gcda` files: -coverage/lcov.info: $(test_deps) $(ISTANBUL) - NODE_OPENCV_DEBUG=true $(NODE) --nouse_idle_notification --expose-gc \ - $(ISTANBUL) cover --report lcovonly -- test/unit.js - $(NODE_PRE_GYP): npm install node-pre-gyp -$(ISTANBUL): package.json - npm install istanbul - @touch $(ISTANBUL) - # Clean up any generated files clean: $(NODE_PRE_GYP) $(NODE_PRE_GYP) clean diff --git a/README.md b/README.md index 1173b03..f612d2b 100755 --- a/README.md +++ b/README.md @@ -1,7 +1,6 @@ # node-opencv [![Build Status](https://secure.travis-ci.org/peterbraden/node-opencv.svg)](http://travis-ci.org/peterbraden/node-opencv) -[![Coverage](http://codecov.io/github/peterbraden/node-opencv/coverage.svg?branch=master)](https://codecov.io/gh/peterbraden/node-opencv) [OpenCV](http://opencv.org) bindings for Node.js. OpenCV is the defacto computer vision library - by interfacing with it natively in node, @@ -299,14 +298,6 @@ Using [tape](https://github.com/substack/tape). Run with command: `npm test`. -## Code coverage - -Using [istanbul](http://gotwarlost.github.io/istanbul/) and [lcov](http://ltp.sourceforge.net/coverage/lcov.php). Run with command: - -`make cover` - -Build version of `opencv.node` will be generated, and coverage files will be put in `coverage/` directory. These files can be remvoved automatically by running `make clean`. - ## MIT License The library is distributed under the MIT License - if for some reason that doesn't work for you please get in touch. diff --git a/package.json b/package.json index 6b384a5..67b421a 100644 --- a/package.json +++ b/package.json @@ -9,7 +9,6 @@ }, "devDependencies": { "tape": "^3.0.0", - "istanbul": "0.4.5", "glob": "^5.0.3", "request": "^2.44.0" },