From d98d9516ea1b7c8f54390b3bfaee4e3c5dfb7098 Mon Sep 17 00:00:00 2001 From: Jarrett Cruger Date: Tue, 2 Dec 2014 09:57:49 -0700 Subject: [PATCH] [fix] simple fixes #748 #744 #746 --- lib/http-proxy/common.js | 2 +- test/lib-http-proxy-common-test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/http-proxy/common.js b/lib/http-proxy/common.js index a4ce19d..6aee0bd 100644 --- a/lib/http-proxy/common.js +++ b/lib/http-proxy/common.js @@ -157,7 +157,7 @@ common.urlJoin = function() { // on every request // Handle case where there could be multiple ? in the URL. - retSegs.concat(lastSegs); + retSegs.push.apply(retSegs, lastSegs); return retSegs.join('?') }; diff --git a/test/lib-http-proxy-common-test.js b/test/lib-http-proxy-common-test.js index ef202ce..342c028 100644 --- a/test/lib-http-proxy-common-test.js +++ b/test/lib-http-proxy-common-test.js @@ -203,7 +203,7 @@ describe('lib/http-proxy/common.js', function () { expect(outgoing.path).to.eql('/forward/static/path'); }) - it.only('should not modify the query string', function () { + it('should not modify the query string', function () { var outgoing = {}; common.setupOutgoing(outgoing, { target: { path: '/forward' },