archive-gh-me/node-http-proxy
1
0
Fork 0
mirror of https://github.com/http-party/node-http-proxy.git synced 2025-12-08 20:59:18 +00:00
Code Issues Projects Releases Wiki Activity

[fix minor] Prevent crashes from attempting to remove listeners more than once when proxying websocket requests.

Browse Source
This commit is contained in:
indexzero 2013-03-09 00:40:00 -05:00
parent 2055d0c8ec
commit a681493371
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/node-http-proxy/http-proxy.js
View File

@ -472,6 +472,8 @@ HttpProxy.prototype.proxyWebSocketRequest = function (req, socket, head, buffer)
// the appropriate events. // the appropriate events.
// //
function onUpgrade (reverseProxy, proxySocket) { function onUpgrade (reverseProxy, proxySocket) {
var detached;
if (!reverseProxy) { if (!reverseProxy) {
proxySocket.end(); proxySocket.end();
socket.end(); socket.end();
@ -543,6 +545,8 @@ HttpProxy.prototype.proxyWebSocketRequest = function (req, socket, head, buffer)
// from `reverseProxy` and `proxySocket`. // from `reverseProxy` and `proxySocket`.
// //
function detach() { function detach() {
if (!detached) {
detached = true;
proxySocket.destroySoon(); proxySocket.destroySoon();
proxySocket.removeListener('end', listeners.onIncomingClose); proxySocket.removeListener('end', listeners.onIncomingClose);
proxySocket.removeListener('data', listeners.onIncoming); proxySocket.removeListener('data', listeners.onIncoming);
@ -550,6 +554,7 @@ HttpProxy.prototype.proxyWebSocketRequest = function (req, socket, head, buffer)
reverseProxy.incoming.socket.removeListener('end', listeners.onOutgoingClose); reverseProxy.incoming.socket.removeListener('end', listeners.onOutgoingClose);
reverseProxy.incoming.socket.removeListener('data', listeners.onOutgoing); reverseProxy.incoming.socket.removeListener('data', listeners.onOutgoing);
} }
}
// //
// If the incoming `proxySocket` socket closes, then // If the incoming `proxySocket` socket closes, then