archive-gh-me/node-http-proxy
1
0
Fork 0
mirror of https://github.com/http-party/node-http-proxy.git synced 2025-12-08 20:59:18 +00:00
Code Issues Projects Releases Wiki Activity

[fix] pass more useful information to the error that we dont already have access to

Browse Source
This commit is contained in:
Jarrett Cruger 2016-02-09 19:11:25 -05:00
parent 9d9fa940cf
commit 8a60ca43fb
2 changed files with 5 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/http-proxy/passes/web-incoming.js
View File

@ -127,17 +127,14 @@ web_o = Object.keys(web_o).map(function(pass) {
proxyReq.abort();
});
// Handle errors on incoming request as well as it makes sense to
req.on('error', proxyError);
// Error Handler
proxyReq.on('error', proxyError);
function proxyError (err){
if (clb) {
clb(err, req, res, options.target);
clb(err, proxyReq, options.target);
} else {
server.emit('error', err, req, res, options.target);
server.emit('error', err, proxyReq, options.target);
}
}

12
test/lib-http-proxy-passes-web-incoming-test.js
View File

@ -144,11 +144,9 @@ describe('#createProxyServer.web() using own http server', function () {
var proxyServer = http.createServer(requestHandler);
function requestHandler(req, res) {
proxy.once('error', function (err, errReq, errRes) {
proxy.once('error', function (err) {
proxyServer.close();
expect(err).to.be.an(Error);
expect(errReq).to.be.equal(req);
expect(errRes).to.be.equal(res);
expect(err.code).to.be('ECONNREFUSED');
done();
});
@ -177,11 +175,9 @@ describe('#createProxyServer.web() using own http server', function () {
var started = new Date().getTime();
function requestHandler(req, res) {
proxy.once('error', function (err, errReq, errRes) {
proxy.once('error', function (err) {
proxyServer.close();
expect(err).to.be.an(Error);
expect(errReq).to.be.equal(req);
expect(errRes).to.be.equal(res);
expect(new Date().getTime() - started).to.be.greaterThan(99);
expect(err.code).to.be('ECONNRESET');
done();
@ -217,11 +213,9 @@ describe('#createProxyServer.web() using own http server', function () {
var started = new Date().getTime();
function requestHandler(req, res) {
proxy.once('error', function (err, errReq, errRes) {
proxy.once('error', function (err) {
proxyServer.close();
expect(err).to.be.an(Error);
expect(errReq).to.be.equal(req);
expect(errRes).to.be.equal(res);
expect(err.code).to.be('ECONNRESET');
doneOne();
});