archive-gh-me/node-http-proxy
1
0
Fork 0
mirror of https://github.com/http-party/node-http-proxy.git synced 2025-12-08 20:59:18 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #934 from Torthu/master

Browse Source 
Fix for #839 (Ignore path and the trailing slash)
This commit is contained in:
Jarrett Cruger 2016-01-26 15:56:58 -05:00
commit 58c0fdc761
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -330,7 +330,7 @@ proxyServer.listen(8015);
* **secure**: true/false, if you want to verify the SSL Certs
* **toProxy**: passes the absolute URL as the `path` (useful for proxying to proxies)
* **prependPath**: true/false, Default: true - specify whether you want to prepend the target's path to the proxy path
* **ignorePath**: true/false, Default: false - specify whether you want to ignore the proxy path of the incoming request
* **ignorePath**: true/false, Default: false - specify whether you want to ignore the proxy path of the incoming request (note: you will have to append / manually if required).
* **localAddress**: Local interface string to bind for outgoing connections
* **changeOrigin**: true/false, Default: false - changes the origin of the host header to the target URL
* **auth**: Basic authentication i.e. 'user:password' to compute an Authorization header.

2
lib/http-proxy/common.js
View File

@ -88,7 +88,7 @@ common.setupOutgoing = function(outgoing, options, req, forward) {
// path is. This can be labeled as FOOT-GUN material if you do not know what
// you are doing and are using conflicting options.
//
outgoingPath = !options.ignorePath ? outgoingPath : '/';
outgoingPath = !options.ignorePath ? outgoingPath : '';
outgoing.path = common.urlJoin(targetPath, outgoingPath);

4
test/lib-http-proxy-common-test.js
View File

@ -250,7 +250,7 @@ describe('lib/http-proxy/common.js', function () {
ignorePath: true
}, { url: '/more/crazy/pathness' });
expect(outgoing.path).to.eql('/some/crazy/path/whoooo/');
expect(outgoing.path).to.eql('/some/crazy/path/whoooo');
});
it('and prependPath: false, it should ignore path of target and incoming request', function () {
@ -262,7 +262,7 @@ describe('lib/http-proxy/common.js', function () {
prependPath: false
}, { url: '/more/crazy/pathness' });
expect(outgoing.path).to.eql('/');
expect(outgoing.path).to.eql('');
});
});