archive-gh-me/node-http-proxy
1
0
Fork 0
mirror of https://github.com/http-party/node-http-proxy.git synced 2025-12-08 20:59:18 +00:00
Code Issues Projects Releases Wiki Activity

[fix] properly include port in host header with changeOrigin in all cases fixes #750

Browse Source
This commit is contained in:
Jarrett Cruger 2014-12-08 16:14:16 -05:00
parent 81874f795b
commit 501e8c2a9b
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/http-proxy/common.js
View File

@ -1,6 +1,7 @@
var common = exports, var common = exports,
url = require('url'), url = require('url'),
extend = require('util')._extend; extend = require('util')._extend,
required = require('requires-port');
var upgradeHeader = /(^|,)\s*upgrade\s*($|,)/i; var upgradeHeader = /(^|,)\s*upgrade\s*($|,)/i;
/** /**
@ -74,9 +75,11 @@ common.setupOutgoing = function(outgoing, options, req, forward) {
outgoing.path = common.urlJoin(targetPath, outgoingPath); outgoing.path = common.urlJoin(targetPath, outgoingPath);
if (options.changeOrigin) { if (options.changeOrigin) {
outgoing.headers.host = outgoing.host; outgoing.headers.host =
required(outgoing.port, options[forward || 'target'].protocol) && !hasPort(outgoing.host)
? outgoing.host + ':' + outgoing.port
: outgoing.host;
} }
return outgoing; return outgoing;
}; };
@ -161,3 +164,14 @@ common.urlJoin = function() {
return retSegs.join('?') return retSegs.join('?')
}; };
/**
* Check the host and see if it potentially has a port in it (keep it simple)
*
* @returns {Boolean} Whether we have one or not
*
* @api private
*/
function hasPort(host) {
return !!~host.indexOf(':');
};