archive-gh-me/node-http-proxy
1
0
Fork 0
mirror of https://github.com/http-party/node-http-proxy.git synced 2025-12-08 20:59:18 +00:00
Code Issues Projects Releases Wiki Activity

[fix] Make options immutable in RoutingProxy. Fixes #248.

Browse Source
This commit is contained in:
indexzero 2013-03-09 02:21:31 -05:00
parent b1c4bd61e8
commit 4c1a2c1416
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/node-http-proxy/http-proxy.js
View File

@ -101,7 +101,7 @@ var HttpProxy = exports.HttpProxy = function (options) {
// be provided or the operation will fail with an `origin mismatch` // be provided or the operation will fail with an `origin mismatch`
// by definition. // by definition.
// //
this.source = options.source || { host: 'localhost', port: 8000 }; this.source = options.source || { host: 'localhost', port: 80 };
this.source.https = this.source.https || options.https; this.source.https = this.source.https || options.https;
this.changeOrigin = options.changeOrigin || false; this.changeOrigin = options.changeOrigin || false;
}; };

8
lib/node-http-proxy/routing-proxy.js
View File

@ -7,7 +7,7 @@
*/ */
var events = require('events'), var events = require('events'),
util = require('util'), utile = require('utile'),
HttpProxy = require('./http-proxy').HttpProxy, HttpProxy = require('./http-proxy').HttpProxy,
ProxyTable = require('./proxy-table').ProxyTable; ProxyTable = require('./proxy-table').ProxyTable;
@ -70,7 +70,7 @@ var RoutingProxy = exports.RoutingProxy = function (options) {
// //
// Inherit from `events.EventEmitter`. // Inherit from `events.EventEmitter`.
// //
util.inherits(RoutingProxy, events.EventEmitter); utile.inherits(RoutingProxy, events.EventEmitter);
// //
// ### function add (options) // ### function add (options)
@ -227,7 +227,7 @@ RoutingProxy.prototype.proxyRequest = function (req, res, options) {
} }
if (!this.proxies[key]) { if (!this.proxies[key]) {
this.add(options); this.add(utile.clone(options));
} }
proxy = this.proxies[key]; proxy = this.proxies[key];
@ -267,7 +267,7 @@ RoutingProxy.prototype.proxyWebSocketRequest = function (req, socket, head, opti
key = this._getKey(options); key = this._getKey(options);
if (!this.proxies[key]) { if (!this.proxies[key]) {
this.add(options); this.add(utile.clone(options));
} }
proxy = this.proxies[key]; proxy = this.proxies[key];

3
package.json
View File

@ -19,7 +19,8 @@
"dependencies": { "dependencies": {
"colors": "0.x.x", "colors": "0.x.x",
"optimist": "0.3.x", "optimist": "0.3.x",
"pkginfo": "0.2.x" "pkginfo": "0.2.x",
"utile": "~0.1.7"
}, },
"devDependencies": { "devDependencies": {
"request": "1.9.x", "request": "1.9.x",