From 34cba38c297d6dcb845e95b9e1ce0271da1631d2 Mon Sep 17 00:00:00 2001 From: indexzero Date: Tue, 7 Dec 2010 19:27:41 -0500 Subject: [PATCH] [fix] Fixed cli parsing issue when --argument=value is not used --- bin/node-http-proxy | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/bin/node-http-proxy b/bin/node-http-proxy index efe36a8..29e5c34 100755 --- a/bin/node-http-proxy +++ b/bin/node-http-proxy @@ -17,10 +17,10 @@ var help = [ " --config OUTFILE Location of the configuration file for the proxy server", " --silent Silence the log output from the proxy server", " -h, --help You're staring at it" -]; +].join('\n'); if (argv.h || argv.help || Object.keys(argv).length === 2) { - util.puts(help.join('\n')); + util.puts(help); process.exit(0); } @@ -49,7 +49,7 @@ config.silent = typeof argv.silent !== 'undefined' ? argv.silent : config.silent // // If we were passed a target, parse the url string // -if (target) location = target.split(':'); +if (typeof target === 'string') location = target.split(':'); // // Create the server with the specified options @@ -59,9 +59,12 @@ if (location) { var targetPort = location.length === 1 ? 80 : location[1]; server = httpProxy.createServer(targetPort, location[0], config); } -else { +else if (config.router) { server = httpProxy.createServer(config); } +else { + return util.puts(help); +} // // Start the server