Merge pull request #539 from nodejitsu/fix-before-after

[fix] add `type` to before and after to grab correct `passes`, fixes #537
This commit is contained in:
yawnt 2013-12-29 14:20:46 -08:00
commit 2c8edc170d

View File

@ -117,23 +117,33 @@ ProxyServer.prototype.listen = function(port) {
return this;
};
ProxyServer.prototype.before = function(passName, callback) {
var i = false;
this.passes.forEach(function(v, idx) {
ProxyServer.prototype.before = function(type, passName, callback) {
if (type !== 'ws' || type !== 'web') {
throw new Error('type must be `web` or `ws`');
}
var passes = (type === 'ws') ? this.wsPasses : this.webPasses,
i = false;
passes.forEach(function(v, idx) {
if(v.name === passName) i = idx;
})
if(!i) throw new Error('No such pass');
this.passes.splice(i, 0, callback);
passes.splice(i, 0, callback);
};
ProxyServer.prototype.after = function(passName, callback) {
var i = false;
this.passes.forEach(function(v, idx) {
ProxyServer.prototype.after = function(type, passName, callback) {
if (type !== 'ws' || type !== 'web') {
throw new Error('type must be `web` or `ws`');
}
var passes = (type === 'ws') ? this.wsPasses : this.webPasses,
i = false;
passes.forEach(function(v, idx) {
if(v.name === passName) i = idx;
})
if(!i) throw new Error('No such pass');
this.passes.splice(i++, 0, callback);
passes.splice(i++, 0, callback);
};