archive-gh-me/node-fs-extra
1
0
Fork 0
mirror of https://github.com/jprichardson/node-fs-extra.git synced 2026-01-25 16:42:57 +00:00
Code Issues Projects Releases Wiki Activity

This fixes (what I think) is a bug in copySync

Browse Source 
The issue is that copySync applies the filter **only** at the root level of a recursive
copy.  This adds a test (that failed with the original code) that checks to make sure that
the filter is applied recursively.  The patch to lib/copy.js then addresses this issue
with a simple fix and the tests pass again with the patch.
This commit is contained in:
Michael Tiller 2014-02-26 16:09:57 -05:00
parent 47b87c1b78
commit 4eaf19874c
2 changed files with 37 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/copy.js
View File

@ -73,7 +73,7 @@ function copySync(src, dest, filter) {
if (!destExists) mkdir.mkdirsSync(dest);
var contents = fs.readdirSync(src);
contents.forEach(function (content) {
copySync(src + "/" + content, dest + "/" + content);
copySync(src + "/" + content, dest + "/" + content, filter);
});
}
}

36
test/copy.test.js
View File

@ -248,6 +248,42 @@ describe('fs-extra', function() {
done()
});
it("should should apply filter recursively", function(done) {
var FILES = 2,
src = path.join(DIR, 'src'),
dest = path.join(DIR, 'dest'),
filter = /0$/i,
i, j;
mkdir.sync(src);
for (i = 0; i < FILES; ++i)
testutil.createFileWithData(path.join(src, i.toString()), SIZE);
var subdir = path.join(src, 'subdir');
mkdir.sync(subdir);
for (i = 0; i < FILES; ++i)
testutil.createFileWithData(path.join(subdir, i.toString()), SIZE);
fs.copySync(src, dest, filter);
T(fs.existsSync(dest));
T(FILES>1);
for (i = 0; i < FILES; ++i) {
if (i==0) {
T(fs.existsSync(path.join(dest, i.toString())))
} else {
T(!fs.existsSync(path.join(dest, i.toString())))
}
};
var destSub = path.join(dest, 'subdir');
for (j = 0; j < FILES; ++j) {
if (j==0) {
T(fs.existsSync(path.join(destSub, j.toString())));
} else {
T(!fs.existsSync(path.join(destSub, j.toString())));
}
}
done()
});
describe("> when the destination dir does not exist", function() {
it("should create the destination directory and copy the file", function(done) {
var src = path.join(DIR, 'data/');