From 72472d07561df032fbf6c54bd2da91a748bcfe40 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9e=20Kooi?= Date: Wed, 12 Dec 2018 09:52:35 +0100 Subject: [PATCH] Fix infinite spinner on --collect-only (#101) In --collect-only, the CLI wasn't stopping the spinner after it completed. The spinner uses `setInterval` so it would just keep going indefinitely, preventing the process from exiting. Now it's correctly stopped. --- bin.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bin.js b/bin.js index 60ecab5..15ffef3 100755 --- a/bin.js +++ b/bin.js @@ -355,6 +355,10 @@ function runTool (args, Tool, version, uiOptions) { process.once('SIGINT', onsigint) tool.collect(args['--'], function (err, filename) { if (err) throw err + if (spinner.isEnabled) { + spinner.stop() + spinner.stream.write(`${spinner.text}\n`) + } console.log(`Output file is ${filename}`) }) } else if (args['visualize-only']) {