diff --git a/.changeset/short-ravens-stare.md b/.changeset/short-ravens-stare.md new file mode 100644 index 000000000..3de09d86d --- /dev/null +++ b/.changeset/short-ravens-stare.md @@ -0,0 +1,5 @@ +--- +"@heroui/number-input": patch +--- + +ignore name prop in getNumberInputProps (#5594) diff --git a/packages/components/number-input/__tests__/number-input.test.tsx b/packages/components/number-input/__tests__/number-input.test.tsx index fb111f6e9..86cdfd0af 100644 --- a/packages/components/number-input/__tests__/number-input.test.tsx +++ b/packages/components/number-input/__tests__/number-input.test.tsx @@ -1,7 +1,7 @@ import type {UserEvent} from "@testing-library/user-event"; import * as React from "react"; -import {render, renderHook, fireEvent, act} from "@testing-library/react"; +import {render, fireEvent, act} from "@testing-library/react"; import userEvent from "@testing-library/user-event"; import {useForm} from "react-hook-form"; import {Form} from "@heroui/form"; @@ -330,59 +330,85 @@ describe("NumberInput", () => { }); describe("NumberInput with React Hook Form", () => { - let input1: HTMLInputElement; - let input2: HTMLInputElement; - let input3: HTMLInputElement; + let hiddenInput1: HTMLInputElement; + let hiddenInput2: HTMLInputElement; + let hiddenInput3: HTMLInputElement; + let visibleInput3: HTMLInputElement; let submitButton: HTMLButtonElement; let onSubmit: () => void; beforeEach(() => { - const {result} = renderHook(() => - useForm({ - defaultValues: { - withDefaultValue: 1234, - withoutDefaultValue: undefined, - requiredField: undefined, - }, - }), - ); - - const { - handleSubmit, - register, - formState: {errors}, - } = result.current; - onSubmit = jest.fn(); - render( -
, - ); + function TestForm() { + const { + handleSubmit, + setValue, + watch, + register, + formState: {errors}, + } = useForm<{ + withDefaultValue: number; + withoutDefaultValue?: number; + requiredField?: number; + }>(); - input1 = document.querySelector("input[name=withDefaultValue]")!; - input2 = document.querySelector("input[name=withoutDefaultValue]")!; - input3 = document.querySelector("input[name=requiredField]")!; + React.useEffect(() => { + register("withDefaultValue"); + register("withoutDefaultValue"); + register("requiredField", {required: true}); + }, [register]); + + const requiredFieldValue = watch("requiredField"); + + return ( + + ); + } + + const {getByTestId} = render(