archive-gh-me/nextui
1
0
Fork 0
mirror of https://github.com/nextui-org/nextui.git synced 2025-12-08 19:26:11 +00:00
Code Issues Projects Releases Wiki Activity

components/tooltip replace "useLayoutEffect" with "useSafeLayoutEffect" (#2021)

Browse Source
This commit is contained in:
Friedemann Sommer 2023-12-23 16:40:19 +01:00 committed by GitHub
parent 95ffa64d41
commit bea1e1fde8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/selfish-ties-enjoy.md Normal file
View File

@ -0,0 +1,5 @@
---
"@nextui-org/tooltip": patch
---
replaced "useLayoutEffect" with "useSafeLayoutEffect" in "useTooltip" hook to prevent unnecessary React warnings

1
packages/components/tooltip/package.json
View File

@ -45,6 +45,7 @@
"@nextui-org/react-utils": "workspace:*",
"@nextui-org/aria-utils": "workspace:*",
"@nextui-org/framer-transitions": "workspace:*",
"@nextui-org/use-safe-layout-effect": "workspace:*",
"@react-aria/overlays": "^3.18.1",
"@react-aria/tooltip": "^3.6.4",
"@react-stately/tooltip": "^3.4.5",

5
packages/components/tooltip/src/use-tooltip.ts
View File

@ -4,7 +4,7 @@ import type {OverlayTriggerProps} from "@react-types/overlays";
import type {HTMLMotionProps} from "framer-motion";
import type {OverlayOptions} from "@nextui-org/aria-utils";
import {ReactNode, Ref, useId, useImperativeHandle, useLayoutEffect} from "react";
import {ReactNode, Ref, useId, useImperativeHandle} from "react";
import {useTooltipTriggerState} from "@react-stately/tooltip";
import {mergeProps} from "@react-aria/utils";
import {useTooltip as useReactAriaTooltip, useTooltipTrigger} from "@react-aria/tooltip";
@ -16,6 +16,7 @@ import {ReactRef, mergeRefs} from "@nextui-org/react-utils";
import {createDOMRef} from "@nextui-org/react-utils";
import {useMemo, useRef, useCallback} from "react";
import {toReactAriaPlacement, getArrowPlacement} from "@nextui-org/aria-utils";
import {useSafeLayoutEffect} from "@nextui-org/use-safe-layout-effect";
interface Props extends Omit<HTMLNextUIProps, "content"> {
/**
@ -180,7 +181,7 @@ export function useTooltip(originalProps: UseTooltipProps) {
containerPadding,
});
useLayoutEffect(() => {
useSafeLayoutEffect(() => {
if (!updatePositionDeps.length) return;
// force update position when deps change
updatePosition();

3
pnpm-lock.yaml generated
View File

@ -2493,6 +2493,9 @@ importers:
'@nextui-org/shared-utils':
specifier: workspace:*
version: link:../../utilities/shared-utils
'@nextui-org/use-safe-layout-effect':
specifier: workspace:*
version: link:../../hooks/use-safe-layout-effect
'@react-aria/interactions':
specifier: ^3.19.1
version: 3.19.1(react@18.2.0)