From 5b9d85e09898101385a581a1f32875253d89ba2f Mon Sep 17 00:00:00 2001 From: camcam <67684008+camcam2605@users.noreply.github.com> Date: Thu, 25 May 2023 09:58:11 +0700 Subject: [PATCH] Chore(Link): Remove code redundancies (#1111) --- packages/components/link/src/use-link.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/components/link/src/use-link.ts b/packages/components/link/src/use-link.ts index 228861ffe..9e2ecb0b3 100644 --- a/packages/components/link/src/use-link.ts +++ b/packages/components/link/src/use-link.ts @@ -64,9 +64,13 @@ export function useLink(originalProps: UseLinkProps) { otherProps.target = otherProps.target ?? "_blank"; } - if (as !== "a") { - otherProps.role = "link"; - } + /** + * if (as !== "a") { + * otherProps.role = "link"; + * } + * This logic handled by @react-aria/link. + * See: https://github.com/adobe/react-spectrum/blob/5a3315f560071087cacf846bd2a86d8f47692446/packages/%40react-aria/link/src/useLink.ts#L55 + */ const classNames = useMemo( () => @@ -87,7 +91,7 @@ export function useLink(originalProps: UseLinkProps) { }; }; - return {Component, children, anchorIcon, linkProps, showAnchorIcon, getLinkProps}; + return {Component, children, anchorIcon, showAnchorIcon, getLinkProps}; } export type UseLinkReturn = ReturnType;