archive-gh-me/nextui
1
0
Fork 0
mirror of https://github.com/nextui-org/nextui.git synced 2025-12-08 19:26:11 +00:00
Code Issues Projects Releases Wiki Activity

fix(radio): remove required attribute for Radio with validationBehavior="aria" (#3110)

Browse Source
This commit is contained in:
Ryo Matsukawa 2024-05-29 04:43:46 +09:00 committed by GitHub
parent 9a2cf47a60
commit 41d2eeb20b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.changeset/sour-starfishes-lick.md Normal file
View File

@ -0,0 +1,5 @@
---
"@nextui-org/radio": patch
---
Remove required attribute for Radio with validationBehavior="aria"

19
packages/components/radio/__tests__/radio.test.tsx
View File

@ -144,7 +144,7 @@ describe("Radio", () => {
expect(onFocus).toBeCalled();
});
it('should work correctly with "isRequired" prop', () => {
it("should have required attribute when isRequired with native validationBehavior", () => {
const {getByRole, getAllByRole} = render(
<RadioGroup isRequired label="Options" validationBehavior="native">
<Radio value="1">Option 1</Radio>
@ -161,6 +161,23 @@ describe("Radio", () => {
expect(radios[0]).toHaveAttribute("required");
});
it("should not have required attribute when isRequired with aria validationBehavior", () => {
const {getByRole, getAllByRole} = render(
<RadioGroup isRequired label="Options" validationBehavior="aria">
<Radio value="1">Option 1</Radio>
<Radio value="2">Option 2</Radio>
</RadioGroup>,
);
const group = getByRole("radiogroup");
expect(group).toHaveAttribute("aria-required", "true");
const radios = getAllByRole("radio");
expect(radios[0]).not.toHaveAttribute("required");
});
it("should work correctly with controlled value", () => {
const onValueChange = jest.fn();

4
packages/components/radio/src/use-radio.ts
View File

@ -219,11 +219,11 @@ export function useRadio(props: UseRadioProps) {
(props = {}) => {
return {
ref: inputRef,
...mergeProps(props, inputProps, focusProps, {required: isRequired}),
...mergeProps(props, inputProps, focusProps),
onChange: chain(inputProps.onChange, onChange),
};
},
[inputProps, focusProps, isRequired, onChange],
[inputProps, focusProps, onChange],
);
const getLabelProps: PropGetter = useCallback(