archive-gh-me/napi-rs
1
0
Fork 0
mirror of https://github.com/napi-rs/napi-rs.git synced 2025-12-08 19:56:07 +00:00
Code Issues Projects Releases Wiki Activity

fix(napi): avoid allocate empty Box if closures is empty (#2712)

Browse Source 
Ref: https://github.com/napi-rs/napi-rs/pull/2711
This commit is contained in:
LongYinan 2025-06-12 04:19:38 +08:00 committed by GitHub
parent 97ed022e46
commit fcfac5083a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
crates/napi/src/bindgen_runtime/js_values/object.rs
View File

@ -324,21 +324,23 @@ pub trait JsObjectValue<'env>: JsValue<'env> {
.map(|p| p.data)
.filter(|data| !data.is_null())
.collect::<Vec<*mut std::ffi::c_void>>();
let len = Box::into_raw(Box::new(closures.len()));
check_status!(
unsafe {
sys::napi_add_finalizer(
env,
self.value().value,
closures.as_mut_ptr().cast(),
Some(finalize_closures),
len.cast(),
ptr::null_mut(),
)
},
"Failed to add finalizer"
)?;
std::mem::forget(closures);
if !closures.is_empty() {
let len = Box::into_raw(Box::new(closures.len()));
check_status!(
unsafe {
sys::napi_add_finalizer(
env,
self.value().value,
closures.as_mut_ptr().cast(),
Some(finalize_closures),
len.cast(),
ptr::null_mut(),
)
},
"Failed to add finalizer"
)?;
std::mem::forget(closures);
}
}
}
check_status!(unsafe {