From 2599e8983f2c001a6ff7520cd962f5ce41780b1b Mon Sep 17 00:00:00 2001 From: Suren Atoyan Date: Fri, 21 Jun 2019 21:50:04 +0400 Subject: [PATCH 1/3] fix url --- demo/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/demo/README.md b/demo/README.md index 4210844..6ca8aa6 100644 --- a/demo/README.md +++ b/demo/README.md @@ -1,4 +1,4 @@ ### Monaco-React Demo This is the demo of [@monaco-editor/react](../) package. -It's hosted [here](monaco-react.surenatoyan.com) +It's hosted [here](https://monaco-react.surenatoyan.com) From d89610101938e65db4294fae60380bb5419ea5d1 Mon Sep 17 00:00:00 2001 From: Suren Atoyan Date: Fri, 21 Jun 2019 21:59:00 +0400 Subject: [PATCH 2/3] fix spelling errors --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 5f97bca..a6f73db 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ There is a well-known web technology based code editor called [Monaco Editor](ht There also exist solutions for integration with React; e.g [this one](https://github.com/react-monaco-editor/react-monaco-editor) and [this one](https://wangchujiang.com/react-monacoeditor/). But they need some custom webpack configuration to make Monaco fully work, which is not the "best" solution for such kind of things like create-react-app - [CRA](https://facebook.github.io/create-react-app/). -With this solution, you don't need any kind of webpack configuration files and it works great both with React apps created by CRA or created by something else. +With this solution, you don't need any kind of webpack configuration files and it works great with React apps created by CRA or created by something else. ## Installation @@ -66,7 +66,7 @@ export default App; #### MonacoEditor instance -The second argument of `editorDidMount` is the instance of the editor. So, you can use it to get the full control of the editor if you need it. +The second argument of `editorDidMount` is the instance of the editor. So, you can use it to get the full control on the editor if you need it. ## Props From cc93b6ec2784241b3a6ef10bf6e77356cfa4ed44 Mon Sep 17 00:00:00 2001 From: Suren Atoyan Date: Fri, 21 Jun 2019 22:30:42 +0400 Subject: [PATCH 3/3] Fix url --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a6f73db..7ecbfa4 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ Monaco editor wrapper for painless integration with React applications without n ## Motivation There is a well-known web technology based code editor called [Monaco Editor](https://microsoft.github.io/monaco-editor/) that powers [VS Code](https://code.visualstudio.com/). [There are also many ways to integrate](https://github.com/Microsoft/monaco-editor-samples/) it provided by monaco creators. But there were tons of problems with integration of monaco with modern technologies; e.g React. -There also exist solutions for integration with React; e.g [this one](https://github.com/react-monaco-editor/react-monaco-editor) and [this one](https://wangchujiang.com/react-monacoeditor/). But they need some custom webpack configuration to make Monaco fully work, which is not the "best" solution for such kind of things like create-react-app - [CRA](https://facebook.github.io/create-react-app/). +There also exist solutions for integration with React; e.g [this one](https://github.com/react-monaco-editor/react-monaco-editor) and [this one](https://github.com/jaywcjlove/react-monacoeditor). But they need some custom webpack configuration to make Monaco fully work, which is not the "best" solution for such kind of things like create-react-app - [CRA](https://facebook.github.io/create-react-app/). With this solution, you don't need any kind of webpack configuration files and it works great with React apps created by CRA or created by something else.