From b7c4b4748101d044fb4c18cc82142f936c7b27c4 Mon Sep 17 00:00:00 2001 From: Rin Date: Sat, 23 Feb 2019 20:45:11 +0700 Subject: [PATCH 1/3] Updates README.md to added react-router-ext (#320) Updates README.md to added react-router-ext Built with Microbundle --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 2ddb7f1..fa6db4d 100644 --- a/README.md +++ b/README.md @@ -117,6 +117,7 @@ Here's what's coming up for Microbundle: - [brazilian-utils](https://github.com/brazilian-utils/brazilian-utils) Utils library for specific Brazilian businesses. - [react-hooks-lib](https://github.com/beizhedenglong/react-hooks-lib) A set of reusable react hooks. - [mdx-deck-live-code](https://github.com/JReinhold/mdx-deck-live-code) A library for [mdx-deck](https://github.com/jxnblk/mdx-deck) to do live React and JS coding directly in slides. +- [react-router-ext](https://github.com/ri7nz/react-router-ext) An Extended [react-router-dom](https://github.com/ReactTraining/react-router/tree/master/packages/react-router-dom) with simple usage. ## 🥂 License From 65730af20fbe0b4d57d13907d51d681ecb91855d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C3=ADas=20Olivera=20=E2=9A=A1?= Date: Sat, 23 Feb 2019 14:16:10 -0300 Subject: [PATCH 2/3] Refactor | Test refactoring (#290) thx @MatiasOlivera --- test/index.test.js | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/test/index.test.js b/test/index.test.js index a772ca1..a073fe7 100644 --- a/test/index.test.js +++ b/test/index.test.js @@ -14,26 +14,34 @@ const rimraf = promisify(_rimraf); const FIXTURES_DIR = `${__dirname}/fixtures`; const DEFAULT_SCRIPT = 'microbundle'; -const times = (n, fn) => Array.from({ length: n }).map(i => fn(i)); const join = (arr, delimiter = '') => arr.join(delimiter); -const constant = konst => () => konst; const printTree = (nodes, indentLevel = 0) => { - const indent = join(times(indentLevel, constant(' '))); + const indent = ' '.repeat(indentLevel); return join( nodes .filter(node => node.name[0] !== '.') - .map( - node => - `${indent}${node.name}\n${ - node.type === 'directory' - ? printTree(node.children, indentLevel + 1) - : '' - }`, - ), + .map(node => { + const isDir = node.type === 'directory'; + return `${indent}${node.name}\n${ + isDir ? printTree(node.children, indentLevel + 1) : '' + }`; + }), ); }; +const getBuildScript = async (fixturePath, defaultScript) => { + let pkg = {}; + try { + pkg = JSON.parse( + await readFile(resolve(fixturePath, 'package.json'), 'utf8'), + ); + } catch (err) { + if (err.code !== 'ENOENT') throw err; + } + return (pkg && pkg.scripts && pkg.scripts.build) || defaultScript; +}; + const parseScript = (() => { let parsed; const prog = createProg(_parsed => (parsed = _parsed)); @@ -65,13 +73,7 @@ describe('fixtures', () => { await rimraf(resolve(`${fixturePath}/.rts2_cache_es`)); await rimraf(resolve(`${fixturePath}/.rts2_cache_umd`)); - let script; - try { - ({ scripts: { build: script } = {} } = JSON.parse( - await readFile(resolve(fixturePath, 'package.json'), 'utf8'), - )); - } catch (err) {} - script = script || DEFAULT_SCRIPT; + const script = await getBuildScript(fixturePath, DEFAULT_SCRIPT); const prevDir = process.cwd(); process.chdir(resolve(fixturePath)); From b1f16b3376371e6a41d027963adde314d9ce3120 Mon Sep 17 00:00:00 2001 From: Joachim Viide Date: Sat, 23 Feb 2019 19:33:06 +0200 Subject: [PATCH 3/3] Fix rollup options - 'treeshake' should be a part of inputOptions --- src/index.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/index.js b/src/index.js index 84549fb..13bc4af 100644 --- a/src/index.js +++ b/src/index.js @@ -418,6 +418,9 @@ function createConfig(options, entry, format, writeMeta) { } return externalTest(id); }, + treeshake: { + propertyReadSideEffects: false, + }, plugins: [] .concat( postcss({ @@ -592,9 +595,6 @@ function createConfig(options, entry, format, writeMeta) { freeze: false, esModule: false, sourcemap: options.sourcemap, - treeshake: { - propertyReadSideEffects: false, - }, format, name: options.name, file: resolve(