From 928079d1812394b4dbe62e369a4a4790c0bb6a1d Mon Sep 17 00:00:00 2001 From: Mitchell Gates Date: Wed, 13 Dec 2017 10:18:46 -0500 Subject: [PATCH 1/2] Change default name from snake_case to PascalCase --- package.json | 1 + src/index.js | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index a8b6df0..305fce7 100644 --- a/package.json +++ b/package.json @@ -53,6 +53,7 @@ "rollup-plugin-preserve-shebang": "^0.1.3", "rollup-plugin-sizes": "^0.4.2", "rollup-plugin-uglify": "^2.0.1", + "uppercamelcase": "^3.0.0", "yargs": "^10.0.3" }, "devDependencies": { diff --git a/src/index.js b/src/index.js index df7d2af..b678e51 100644 --- a/src/index.js +++ b/src/index.js @@ -16,12 +16,13 @@ import gzipSize from 'gzip-size'; import prettyBytes from 'pretty-bytes'; import shebangPlugin from 'rollup-plugin-preserve-shebang'; import flow from 'rollup-plugin-flow'; +import pascalCase from 'uppercamelcase'; const readFile = promisify(fs.readFile); const stat = promisify(fs.stat); const isDir = name => stat(name).then( stats => stats.isDirectory() ).catch( () => false ); const isFile = name => stat(name).then( stats => stats.isFile() ).catch( () => false ); -const safeVariableName = name => name.replace(/(?:^[^a-z$_]|([^a-z0-9_$]+))/g, '_'); +const safeVariableName = name => pascalCase(name.toLowerCase().replace(/((^[^a-zA-Z]+)|[^\w.-])|([^a-zA-Z0-9]+$)/g, '')); const FORMATS = ['es', 'cjs', 'umd']; From c2256a8cb08c3cb7516f59d0cc72b5e015e6f2d5 Mon Sep 17 00:00:00 2001 From: Mitchell Gates Date: Fri, 15 Dec 2017 13:16:35 -0500 Subject: [PATCH 2/2] Use camelCase over PascalCase --- package.json | 2 +- src/index.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 305fce7..6fbb7cb 100644 --- a/package.json +++ b/package.json @@ -35,6 +35,7 @@ "acorn-jsx": "4.1.0", "asyncro": "^2.0.1", "babel-polyfill": "^6.26.0", + "camelcase": "^4.1.0", "chalk": "^2.3.0", "es6-promisify": "^5.0.0", "glob": "^7.1.2", @@ -53,7 +54,6 @@ "rollup-plugin-preserve-shebang": "^0.1.3", "rollup-plugin-sizes": "^0.4.2", "rollup-plugin-uglify": "^2.0.1", - "uppercamelcase": "^3.0.0", "yargs": "^10.0.3" }, "devDependencies": { diff --git a/src/index.js b/src/index.js index b678e51..a48e467 100644 --- a/src/index.js +++ b/src/index.js @@ -16,13 +16,13 @@ import gzipSize from 'gzip-size'; import prettyBytes from 'pretty-bytes'; import shebangPlugin from 'rollup-plugin-preserve-shebang'; import flow from 'rollup-plugin-flow'; -import pascalCase from 'uppercamelcase'; +import camelCase from 'camelcase'; const readFile = promisify(fs.readFile); const stat = promisify(fs.stat); const isDir = name => stat(name).then( stats => stats.isDirectory() ).catch( () => false ); const isFile = name => stat(name).then( stats => stats.isFile() ).catch( () => false ); -const safeVariableName = name => pascalCase(name.toLowerCase().replace(/((^[^a-zA-Z]+)|[^\w.-])|([^a-zA-Z0-9]+$)/g, '')); +const safeVariableName = name => camelCase(name.toLowerCase().replace(/((^[^a-zA-Z]+)|[^\w.-])|([^a-zA-Z0-9]+$)/g, '')); const FORMATS = ['es', 'cjs', 'umd'];