* feat(FunctionNode): allow function parameters to be called
This change is implemented by checking if a function symbol is in
the arg list, and if so delaying its analysis until evaluation time,
at which point it is extracted from the arguments and called as
appropriate depending on its rawArgs property.
Also adds a few tests, documents the new facility, and documents the
handling of free variables in a function definition, which was previously
left undescribed.
Resolves#2441.
Resolves#2442.
* chore: correct lint violations (sorry)
Co-authored-by: Jos de Jong <wjosdejong@gmail.com>
* feat(simplify): Allow context option
If the options argument has a key 'context', it value is interpreted
as a context specifying various (non-default) properties of operators.
This context is propagated to all rules and all matching.
Adds some initial tests that the context option affects the behavior
of simplify appropriately. Not all can be activated until in a future
commit we add the ability for the application of a rule to be contingent
on aspects of the context.
Note that the enhanced rule matching necessary to support rules
constrained by non-default operator properties led to a couple of
changes to the output of rationalize() as well. Since the new output
seemed to better match what a person would typical write for the
rationalized form, this commit changed the test rather than attempted
to preserve the exact prior order of terms.
* feat(simplifyCore): strip all parentheses
Prior to this commit, simplifyCore stripped internal parentheses, but
would leave top-level ones. But top-level parentheses don't carry any
semantics, and no tests other than the ones that explicitly checked for
the retention of top-level parentheses were affected by this change.
Not making a special case for the top level also notably streamlined the
code in simplifyCore.
Adds tests for the new parenthesis-stripping behavior, as well as for
other node types that were added earlier but which did not yet have
simplifyCore tests.
* refactor(simplifyCore): Strip any node marked as trivial in context
This replaces special-case tests for unary + and parentheses, and
paves the way for example for 'abs' being marked trivial in a
putative positiveContext
* refactor(simplify): Rename 'context' parameter to rules and document it.
The new name is 'imposeContext' -- the motivation for the change is to
distinguish the parameter for 'assuming', which will be added as a new
parameter to control rule application based on context.
* feat(simplify): Allow context-based conditions on rule application.
Adds a new property of rules specified as objects: `assuming`. Its
value should be a context, and every property specified in that context
must match the incoming context, or else the rule will not be applied.
Updates the constant floating rules to require their operators be commutative,
as a test of the feature, and adds a unit test for this.
* feat(simplify): annotate rules with underlying assumptions
Also activates a number of tests of simplifications that should
or should not occur in various contexts.
To get all tests to pass, I could no longer find a rule ordering
that worked in all cases, without the ability to mark an individual
rule as applying repeatedly until just that rule stabilized. So this
commit also adds that ability, and uses it to eliminate the tricky rule
of expanding n1 + (n2 + n3)*(-1) to n1 + n2*(-1) + n3*(-1) late in the
rule ordering, in favor of the more intuitive (complete) expansion of
(n1 + n2)*(-1) to n1*(-1) + n2*(-1) early in the rule ordering, before
constant folding and gathering of like terms.
* feat(simplify): Add contexts for specific domains
In particular, adds a `simplify.realContext` and a `simplify.positiveContext`
which (attempt to) guarantee that no simplifications that change the value
of the expression, on any real number or any positive real number,
respectively, will occur.
Adds multiple tests for these contexts, including verification that the
simplification in either context does not change some example values of
any of the expressions in any simplify test.
This testing uncovered that it is unaryPlus that must be marked as trivial
for simplifyCore to work properly, so that marking is added as well.
* chore: Alter value consistency tests for browsers/older Node
The problem was NaN != NaN in some JavaScripts but not others,
so test for "both values NaN" explicitly before using deepEqual.
* fix: Implement requested changes from review
Added documentation about scope and context in top-level algebra functions
page; made variable name less abbreviated; performed suggested refactoring.
Co-authored-by: Jos de Jong <wjosdejong@gmail.com>
It says:
An object is enclosed by **square** brackets `{`, `}`,
But they are not square`[`,`]`, they are **curly** `{`, `}`.
The proposal is:
An object is enclosed by curly brackets `{`, `}`,
* Support for Percentage Operation
* Fixed Style issue
* Added Test case to check for modulo followed by pi
* Support for % addition and % subtraction
* Fixed Documentation comment
* Support - Should not calculate mod for negative divisor
* Updated Docs
Co-authored-by: Jos de Jong <wjosdejong@gmail.com>
* Add support for scopes with get and set methods
* Fix build for node v12
* Fixup cli and parser tests
* Add tests for simplify and evaluate
* Add example for a custom scope object
* Function calls need child scopes
* Transitionary step: Separate Safe and Scope Property calls
* Renamed identifiers in FunctionNode
* Evaluate with ObjectScopeWrapper
* Simplify tests passing
* Assume all scopes are map-like. Except parser
* Remove isMapLike check in customs.*SafeProperty() methods
* Change MapLike to Map
* Move keywords from an Object to a Set
* Move ScopeProperty functions in to scope.js
* Removed deprecation warning
* Rename scope.js to map.js
* Rename ScopeProperty to MapProperty
* Add tests and docs for map.js
* Put back the micro-optimization of function calls
* Use Map in the parser
* Called scope methods directly in cli.js
* Coercing of scope into a Map is done in Node, not evaluate
* Move createSubScope to its own file
* Fixup following self-review
* Add scope docs
* Final self-review changes
* Address reviewer comments
* Remove MapProperty witness marks
* Converted broken benchmark possibly lost in a rebase
* Use bare map as scope in benchmark
Co-authored-by: Jos de Jong <wjosdejong@gmail.com>
* Basic untested support for parsing non decimal numbers with radix point.
* Added some documentation for function parseNonDecimalWithRadix.
* Renamed variable in BigNumber constructor.
Not related to current feature branch but is a good change.
* Improved some variable and function names in number.js and fixed an error when parsing octal numbers with radix point.
* Added some tests and fixed linter issues.
* Added some documentation on new syntax.
* Added more tests.
* Added more tests for edge cases.
* added support for word size suffix in getToken
* start modifying number(string) to support word size suffix for signed integers
* word size suffixes for Number
* initial support for BigNumber
* fix linter issues
* remove unused variable
* start extending bitwise operators for Number for values greater than 32 bits
* Revert "start extending bitwise operators for Number for values greater than 32 bits"
This reverts commit 6fac1a7b10665a221ab5de521c08fa9fcf959eb1.
* add a test for 53 bit literal
* added an optional second argument to bin, oct, and hex to allow formatting signed numbers with custom word size
* removed size checks
* Attempted to extend bin, oct, hex format functions to work with BigNumber, but not working fully.
Apparently Decimal.js toString method doesn't take a base parameter like js number does. I guess I have to do the formatting myself.
* Added n2base function to do formatting for BigNumber.
* Added check for zero in n2base.
* Removed old failing tests.
* Added some tests (failing).
* Extended 'format' function with 'base' and 'wordSize' options and changed 'bin', 'oct', and 'hex' to use 'format' function.
* Fixed lint issues.
* Fixed issues related to the merge.
* Corrected a test.
* Fixed bignumber formatter.
* Added tests for math.format with 'base' and 'wordSize' options.
* Fixed lint issue.
* Changed 'base' option to 'bin', 'oct', and 'hex' values for 'notation' option of 'format' function.
* Added word size suffix to the output of format, bin, oct, and hex.
* Updated documentation.
* allow binary, octal, and hex literals as in JS (0b, 0o, 0x)
* add tests
* fix lint issues
* add notation for binary, octal, and hex in formatNumber
* remove the extra format notations
* add bin, oct, and hex functions for formatting
* move bin, oct, and hex from base.js to their own files, fixed built test error about documentation
* parse and format treat values as 32 bit signed 2s complement integers
* add section in syntax documentation
* typo
Co-authored-by: Jos de Jong <wjosdejong@gmail.com>
* initial implementation of multidimensional std and var
* consolidated std function into var, cleaned up the interface for var, fixed bias correction
* added documentation of variable axis for std and var
* updated documentation for std and var
* changed the order of normalization and dimension for a three parameter input in the functions
* updated documentation for var and std
* add transform expressions for std and var with variable axis
* added test coverage for std and var with a variable axis
* update to documentation
* change n dim std to use apply function
* fixed tests, removed unnecessary code, updated docs
* fixed typo in docs
* update docs to remove a type
* changed location of apply function
* updated tests to use deepStrictEqual to pass linter
* adding test coverage for var.transform and std.transform
