archive-gh-me/mathjs
1
0
Fork 0
mirror of https://github.com/josdejong/mathjs.git synced 2026-01-25 15:07:57 +00:00
Code Issues Projects Releases Wiki Activity

Improve debugging support

Browse Source 
When this error is encountered in the field, I see it via honeybadger, but I have none of the context about what unit it was called in, and what unit it was being converted to. Help the debugging by adding some info to the exception. I'm not entirely sure that 'toString' is what I want here - perhaps others in the community can help make that the right expression?
This commit is contained in:
gap 2018-06-15 09:10:07 -04:00
parent f0e5ed5774
commit d15498715d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/type/unit/Unit.js
View File

@ -801,7 +801,7 @@ function factory (type, config, load, typed, math) {
// other = new Unit(null, valuelessUnit)
other = Unit.parse(valuelessUnit)
if (!this.equalBase(other)) {
throw new Error('Units do not match')
throw new Error(`Units do not match ('${other.toString()}' != '${this.toString()}')`)
}
if (other.value !== null) {
throw new Error('Cannot convert to a unit with a value')
@ -813,7 +813,7 @@ function factory (type, config, load, typed, math) {
return other
} else if (type.isUnit(valuelessUnit)) {
if (!this.equalBase(valuelessUnit)) {
throw new Error('Units do not match')
throw new Error(`Units do not match ('${valuelessUnit.toString()}' != '${this.toString()}')`)
}
if (valuelessUnit.value !== null) {
throw new Error('Cannot convert to a unit with a value')