From 1dd67cd59110edf5ef0fc20becad7937310ef9e1 Mon Sep 17 00:00:00 2001 From: Thomas Brierley Date: Tue, 4 Jul 2017 19:56:54 +0100 Subject: [PATCH] Fix undefined isSafeProperty test + comment --- test/utils/customs.test.js | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/test/utils/customs.test.js b/test/utils/customs.test.js index 78e9acf5c..6a1602c68 100644 --- a/test/utils/customs.test.js +++ b/test/utils/customs.test.js @@ -91,17 +91,25 @@ describe ('customs', function () { describe ('isSafeProperty', function () { it ('plain objects', function () { - var object = { - foo: true - }; + var object = {}; + + /* From Object.prototype: + Object.getOwnPropertyNames(Object.prototype).forEach( + key => typeof ({})[key] !== 'function' && console.log(key)) + */ assert.equal(customs.isSafeProperty(object, '__proto__'), false); + + /* From Function.prototype: + Object.getOwnPropertyNames(Function.prototype).forEach( + key => typeof (function () {})[key] !== 'function' && console.log(key)) + */ assert.equal(customs.isSafeProperty(object, 'length'), true); assert.equal(customs.isSafeProperty(object, 'name'), false); assert.equal(customs.isSafeProperty(object, 'arguments'), false); assert.equal(customs.isSafeProperty(object, 'caller'), false); // non existing property - assert.equal(customs.isSafeProperty(object, 'foo'), true); + assert.equal(customs.isSafeProperty(object, 'bar'), true); // custom inherited property var object = {};