32 Commits

Author SHA1 Message Date
Dylan Piercey
eaa7024720
Improve for loop auto keying (#1346) 2019-06-05 11:29:29 -07:00
Michael Rawlings
4a73060bc6 Cleanup tests (#1341)
Cleanup tests and add assertions that all deprecated tests log warnings, and all non deprecated tests don't.
2019-05-28 10:54:31 -07:00
Dylan Piercey
e065c140ff
Namespace fixes (#1333)
* Calculate namespace on actualize
2019-05-20 13:13:51 -07:00
Dylan Piercey
a714074dd1
Fix regression with unary expression printing (#1323)
* Fix regression with unary expression printing
2019-04-30 11:48:23 -07:00
Michael Rawlings
e6408c2c14
fix components runtime path after refactor (#1322) 2019-04-22 14:20:15 -07:00
Michael Rawlings
101c5c6bb8
refactor to better separate compiler/taglib/core-tags/runtime (#1319)
* refactor out taglib loader/finder/lookup

* add comments for taglib apis that we need to deprecate

* move components into runtime/core-tags
2019-04-16 13:34:26 -07:00
Dylan Piercey
2f54313613
Fix regression for no-update on dynamic tag html attributes (#1292)
* Fix regression for no-update on dynamic tag html attributes
2019-03-15 13:00:47 -07:00
Dylan Piercey
95c515e66f
Fix function as event handler when server side rendering (#1262) 2019-02-15 15:49:08 -08:00
Dylan Piercey
bfe194d8c9 Implement modern arguments support for dynamic tags (#1259) 2019-02-14 15:12:09 -08:00
Dylan Piercey
9e1577fff4
Migrate legacy macro syntax to tag params 2019-02-07 11:54:00 -08:00
Dylan Piercey
24753a7674
Upgrade <await> tag to use tag parameters and attribute tags. Add migration from old syntax. (#1244) 2019-02-07 11:50:49 -08:00
Dylan Piercey
465ebee841
Treat importing tags the same as using the tag within the template. (#1245) 2019-01-29 13:56:18 -08:00
Michael Rawlings
d808906bd3 importing a marko template adds it to tags meta (#1226)
* importing a marko template adds it to tags meta
2019-01-10 13:12:41 -08:00
Dylan Piercey
ff31597a56
Fix migrator regressions and misc refactoring (#1212)
* Fixes control flow attributes on var tag.
* Fixes w-body to ensure that value exists.
* Ensures w-body and include properly enclose typeof expressions.
2018-12-28 10:14:33 -07:00
Dylan Piercey
db5559cde1
Add migrator for include, layout-use and layout-placeholder tags (#1204)
Add migrator for include tag/directive
Add migrator for layout-placeholder tag
Add migrator for layout-use tag
2018-12-27 13:37:08 -07:00
Bhavin Patel
b26d2608c7 Migrate w-body attr in favor of using dynamic tags (#1199)
Add migrator for w-body.
2018-12-26 08:13:54 -07:00
Bhavin Patel
e7bfb039d8 Added migrators for w-* attrs & code restructure (#1190)
* Added migrator for w-id, w-for, w-preserve, w-preserve-attrs and widget-elId
2018-12-14 12:28:47 -08:00
Michael Rawlings
5ea9eaa657
Legacy compat updates (#1189)
* legacy: add _isWidget property from marko-widgets@6

* add back legacy method that was not deprecated in marko-widgets

* add data-widget property back to legacy widgets

* fix defineRenderer (legacy) to work with non-widgets as well

* assign id attribute to legacy dom nodes

* allow accessing the parent widget from a legacy child template

* getWidget/s only gets legacy widgets, keep init

* remove call to non-existant api

* don't kick off registration as this causes an issue with circular dependencies in legacy widgets

* add component names in debug mode

* fix keys and this.el in legacy widgets

* ensure widgetconfig object exists for legacy init

* ensure this.el exists before attaching __widget to it

* add back private __document to legacy widgets

* add deprecation warnings
2018-12-10 17:01:55 -08:00
Dylan Piercey
3338fd4e0a
Fix regression in parse javascript not aborting on unrecognized nodes (#1184)
* Fix regression in parse javascript not aborting on unrecognized nodes
2018-12-06 12:40:54 -08:00
Cameron Braid
ca859cfdd5 added failing test case for #1181 (#1182) 2018-12-06 11:15:42 -08:00
Michael Rawlings
df79fcc5f0
Diffing/Keying fixes (#1094)
* Updates the diffing algorithm to use an HTMLFragment node as an abstraction rather than keeping track of startNode and endNode all throughout the diffing algorithm.

* Uses the HTMLFragment for the <${dynamic}> tag and <include> tags to preserve server-rendered content for which the renderBody is not available in the browser.

* Component ids are based on the resulting parent tree (not the owner tree). This means we cannot rely on the ids in the global lookup, so component key/refs are now also stored on the component instance.

* Static node trees are now only auto assigned a key for the top-level node (instead of all nodes).

* Server comment starting markers now have the component's key serialized so the component can be attached to its owner

* Server comment markers no longer have the id on the closing marker, it is stack based.

* Normalize differences between hydration and client-rendering, so post mount the DOM looks the same regardless of whether a component was server or client rendered.

* fix matching up fragments when hydrating by taking components and normalized text nodes into account

* remove wrapping divs in test, should no longer be needed.  address hydration issue with alternate fragment matching approach.

* add fragment to dom if there's a parentNode even if no startNode

* add test for mismatched hydration

* don't detach components before moving

* use fragments to preserve renderBody content

* use ___finishFragment as the incomplete fragment marker

* ensure fragments get destroyed properly and dom node key sequences don't continue from previous renders

* use parent/owner terminology in more places, component ids are now parent scoped, key/ref components are attached to their owner for both client + server render, server comment boundaries include the owner and the key in addition to the fully scoped component id, autokeyed dom nodes are attached to their parent, hydration now uses a stack: ids in ending comment nodes not needed, hydration checks to see if a component has been initialized and will attach keys directly to the owner if so

* add mutation guards for text/comment nodes, add mutation guard for input value

* make component-pages test better represent streaming hydration, fix html/head/body hydration in a better/more generic way

* add test for async rendered keyrefs

* add test for repeated mult-level transclusion

* Autokeyed elements are now stored on the parent rather than the owner. User assigned key/refs are still stored on the owner component. Because of this, user assigned keys are now prefixed (with @) to differentiate them from autokeys. This also has the benefit that assigning numeric keys can no longer conflict with the autokeys.

* add re-rendering the intermediate container to one of the new tests
2018-08-27 11:46:47 -07:00
Michael Rawlings
b749da95ed
Use capture for event delegation (#1104)
use delegation for all events
2018-08-06 15:50:55 -07:00
Dylan Piercey
e4a01a9558 Remove extra parenthesis from compiled javascript. (#1099) 2018-07-26 10:38:21 -07:00
Dylan Piercey
6d9c11d072 No longer set scoped attributes as default keys. (#1069)
* No longer set scoped attributes as default keys.
* Remove now unnecessary variable from compiled output
2018-06-28 12:19:31 -07:00
Michael Rawlings
a5b93ebb25
fix for loop autokeys (#1067) 2018-06-25 21:35:39 -07:00
Michael Rawlings
92c448f639 Autotest refactor (#1023)
* update autotest api and first few test suites

* refactor components-browser to use the new autotest api

* minor changes to update adjustIndent and components-pages to new autotest api

* refactor and combine async-render, deprecated-async-fragments, and render suites

* migrate compiler tests to new autotest runner

* migrate components-compilation tests to use new autotest api

* migrate most remaining test runners to new autotest api

* update adjustIndent

* migrate express tests to new autotest api

* switch from compare to snapshot

* move versions into directory

* remove snapshot sequences, prefix to name, suffix to ext

* refactor autotest

* keep node 4 happy: don't use destructured parameters

* use strict

* update contributing document to reflect new autotest api

* better snapshot errors with clickable path

* remove old vdomSkip property, fix some normalization in the render test runner, skip only tests that need to be skipped

* for generated vdom expectations use expected.html instead of rerendering the html template, update expected files that had editor added newlines at the end

* remove half-finished test that was intended to replace another test (render/fixtures/preserveWhitespace-load-option) - we'll keep the original
2018-03-23 11:27:52 -07:00
Michael Rawlings
0f5e639775 Format + lint (#1016)
* add prettierignore

* switch to eslint:recommended + eslint-config-prettier

* fix eslint violations

* remove more .jshintrc files

* better conditional structure

* add prettier and update prettier ignore

* add precommit hook to run prettier

* add lint check to precommit and format check to ci

* format all the things

* add generated files

* let npm do it's thing with package.json
2018-03-09 10:02:11 -08:00
Michael Rawlings
bd4855271d Hydrate fixes (#1010)
* enable legacy hydrate tests, update test harness to support legacy widgets

* enable autokey for tests, update expectations, add better html diff output

* update test harness to register statically discovered components

* return to using a single mount function for legacy and modern components

* remove lasso from test package dependencies

* add all renders to the renderedCache, track instances separately

* temporarily skip failing hydrate test for widget types

* update widget lifecycle tracker to work with hydrate test as well

* update tests/expectations to use serialize globals: onCreate should be called when hydrating stateful components

* preserve included renderbodies

* update legacy renderbodies to use the new method of preservations

* mount components in preserved renderbodies

* stateful components should rerender when mounting, not all legacy components are split components

* ensure elements with events in split components have thier keys serialized

* call onCreate and onInput when mounting root rerender components

* fix code supporting once-* causing all events (on-* included) for hydrated split components to be handled only once

* change the way input is removed from legacy components
2018-03-02 16:09:14 -08:00
Scott Davis
f76bfff323 Add once-[event] directive Fixes #985 (#990)
* Add `once-[event]` directive.
* Improve docs for attaching events.
2018-02-20 10:33:43 -08:00
Dylan Piercey
a7f529debd Testing Improvements. (#989)
* * Setup utility to run jsdom tests in the same process without bundling.
* Cleanup require hooks in test suite.
* Test organization and cleanup.
* Remove redundant autotest utilities.

* Switch to require for browser.json loading

* Cache browser.json remaps. Fix components-browser rehydration setup

* Improve inline docs, remove some unneeded init code for testing modules.

* Remove unneeded promise polyfill
2018-02-20 10:26:48 -08:00
Dylan Piercey
d00ea44d46 Test perf and organization (#981)
* Switch to in memory lasso builds and other optimizations.

* Condense components-compilation tests.

* Update lasso-fs-writer

* Condense components-compilation and compiler tests

* Increase mocha test timeout

* Allow lasso to be gc'd for tests

* Improve test cache clearing

* Fix lasso memory leak in tests

* Cache instanbul intrumenting.

* Hide complain logs.
2018-02-06 18:53:55 -08:00
Dylan Piercey
1496a0f26c Organize tests (#934) 2017-11-22 16:46:18 -08:00