archive-gh-me/marko
1
0
Fork 0
mirror of https://github.com/marko-js/marko.git synced 2025-12-08 19:26:05 +00:00
Code Issues Projects Releases Wiki Activity

Fixes #705 - Throw error when the root HTML element has a dynamic id attribute.

Browse Source
This commit is contained in:
Austin Kelleher 2017-05-31 13:15:15 -04:00
parent fe60da9c11
commit f73c2364d5
3 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/components/taglib/TransformHelper/handleRootNodes.js
View File

@ -199,9 +199,16 @@ module.exports = function handleRootNodes() {
hasLegacyExplicitBind = true;
} else {
if (node.hasAttribute('id')) {
let id = node.getAttributeValue('id');
if (id && id.name) {
context.addError('Root HTML element should not have a dynamic `id` attribute');
return;
}
hasIdCount++;
nodeWithAssignedId = node;
assignedId = node.getAttributeValue('id');
assignedId = id;
}
if (tagName === 'style') {

3
test/autotests/render/error-variable-id-root-node/template.marko Normal file
View File

@ -0,0 +1,3 @@
$ var id = 'abc123';
<div id=id/>

6
test/autotests/render/error-variable-id-root-node/test.js Normal file
View File

@ -0,0 +1,6 @@
var expect = require('chai').expect;
exports.checkError = function(e) {
var message = e.toString();
expect(message).to.contain('Root HTML element should not have a dynamic `id` attribute');
};